devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Allow devices to be marked as noncoherent
@ 2025-03-03  6:56 Inochi Amaoto
  2025-03-03 16:31 ` Conor Dooley
  2025-03-10 21:06 ` Vinod Koul
  0 siblings, 2 replies; 3+ messages in thread
From: Inochi Amaoto @ 2025-03-03  6:56 UTC (permalink / raw)
  To: Eugeniy Paltsev, Vinod Koul, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: Inochi Amaoto, dmaengine, devicetree, linux-kernel, Yixun Lan,
	Longbin Li

A RISC-V platform can have both DMA coherent/noncoherent devices.
Since the RISC-V architecture is marked coherent, devices should
be marked as noncoherent when coherent devices exist.

Add dma-noncoherent property for snps,dw-axi-dmac device. It will
be used on SG2044, and it has other coherent devices.

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
Related discussion for this property.

https://lore.kernel.org/all/20250221013758.370936-1-inochiama@gmail.com/
---
 Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
index 525f5f3932f5..935735a59afd 100644
--- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
+++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
@@ -59,6 +59,8 @@ properties:
     minimum: 1
     maximum: 8

+  dma-noncoherent: true
+
   resets:
     minItems: 1
     maxItems: 2
--
2.48.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Allow devices to be marked as noncoherent
  2025-03-03  6:56 [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Allow devices to be marked as noncoherent Inochi Amaoto
@ 2025-03-03 16:31 ` Conor Dooley
  2025-03-10 21:06 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2025-03-03 16:31 UTC (permalink / raw)
  To: Inochi Amaoto
  Cc: Eugeniy Paltsev, Vinod Koul, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, dmaengine, devicetree, linux-kernel, Yixun Lan,
	Longbin Li

[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]

On Mon, Mar 03, 2025 at 02:56:48PM +0800, Inochi Amaoto wrote:
> A RISC-V platform can have both DMA coherent/noncoherent devices.
> Since the RISC-V architecture is marked coherent, devices should
> be marked as noncoherent when coherent devices exist.
> 
> Add dma-noncoherent property for snps,dw-axi-dmac device. It will
> be used on SG2044, and it has other coherent devices.
> 
> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> ---
> Related discussion for this property.
> 
> https://lore.kernel.org/all/20250221013758.370936-1-inochiama@gmail.com/
> ---
>  Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> index 525f5f3932f5..935735a59afd 100644
> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> @@ -59,6 +59,8 @@ properties:
>      minimum: 1
>      maximum: 8
> 
> +  dma-noncoherent: true

I'd probably also add mutual exclusion, but I think that's something for
dt-schema and not for individual bindings.

Acked-by: Conor Dooley <conor.dooley@microchip.com>

> +
>    resets:
>      minItems: 1
>      maxItems: 2
> --
> 2.48.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Allow devices to be marked as noncoherent
  2025-03-03  6:56 [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Allow devices to be marked as noncoherent Inochi Amaoto
  2025-03-03 16:31 ` Conor Dooley
@ 2025-03-10 21:06 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2025-03-10 21:06 UTC (permalink / raw)
  To: Eugeniy Paltsev, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Inochi Amaoto
  Cc: dmaengine, devicetree, linux-kernel, Yixun Lan, Longbin Li


On Mon, 03 Mar 2025 14:56:48 +0800, Inochi Amaoto wrote:
> A RISC-V platform can have both DMA coherent/noncoherent devices.
> Since the RISC-V architecture is marked coherent, devices should
> be marked as noncoherent when coherent devices exist.
> 
> Add dma-noncoherent property for snps,dw-axi-dmac device. It will
> be used on SG2044, and it has other coherent devices.
> 
> [...]

Applied, thanks!

[1/1] dt-bindings: dma: snps,dw-axi-dmac: Allow devices to be marked as noncoherent
      commit: 6ec29d4086ed8b951fa794ac6c0e7cd7ae3762d9

Best regards,
-- 
~Vinod



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-03-10 21:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-03  6:56 [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Allow devices to be marked as noncoherent Inochi Amaoto
2025-03-03 16:31 ` Conor Dooley
2025-03-10 21:06 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).