From: Conor Dooley <conor@kernel.org>
To: Inochi Amaoto <inochiama@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chen Wang <unicorn_wang@outlook.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
sophgo@lists.linux.dev, Yixun Lan <dlan@gentoo.org>,
Longbin Li <looong.bin@gmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: interrupt-controller: Add Sophgo SG2044 MSI controller
Date: Mon, 3 Mar 2025 16:29:53 +0000 [thread overview]
Message-ID: <20250303-woozy-pluck-c04b13342401@spud> (raw)
In-Reply-To: <20250303111648.1337543-2-inochiama@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]
On Mon, Mar 03, 2025 at 07:16:46PM +0800, Inochi Amaoto wrote:
> Like SG2042, SG2044 uses a similar msi controller to provide MSI
> interrupt for PCIe controllers.
In the future, could you mention the way in which they differ?
"similar" could mean 99% the same but incompatible, or 90% the same but
capable of using a fallback?
Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
> Add support for the SG2044 msi controller
>
> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> ---
> .../bindings/interrupt-controller/sophgo,sg2042-msi.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/sophgo,sg2042-msi.yaml b/Documentation/devicetree/bindings/interrupt-controller/sophgo,sg2042-msi.yaml
> index e1ffd55fa7bf..f6b8b1d92f79 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/sophgo,sg2042-msi.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/sophgo,sg2042-msi.yaml
> @@ -18,7 +18,9 @@ allOf:
>
> properties:
> compatible:
> - const: sophgo,sg2042-msi
> + enum:
> + - sophgo,sg2042-msi
> + - sophgo,sg2044-msi
>
> reg:
> items:
> --
> 2.48.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-03-03 16:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250303111648.1337543-1-inochiama@gmail.com>
2025-03-03 11:16 ` [PATCH 1/2] dt-bindings: interrupt-controller: Add Sophgo SG2044 MSI controller Inochi Amaoto
2025-03-03 16:29 ` Conor Dooley [this message]
2025-03-04 1:00 ` Inochi Amaoto
2025-03-03 11:16 ` [PATCH 2/2] irqchip/sg2042-msi: Add the Sophgo SG2044 MSI interrupt controller Inochi Amaoto
2025-03-03 19:31 ` Thomas Gleixner
2025-03-04 0:41 ` Inochi Amaoto
2025-03-04 2:16 ` Chen Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250303-woozy-pluck-c04b13342401@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=inochiama@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=looong.bin@gmail.com \
--cc=robh@kernel.org \
--cc=sophgo@lists.linux.dev \
--cc=tglx@linutronix.de \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox