From: "Krzysztof Wilczyński" <kw@linux.com>
To: Thippeswamy Havalige <thippeswamy.havalige@amd.com>
Cc: bhelgaas@google.com, lpieralisi@kernel.org,
manivannan.sadhasivam@linaro.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, michal.simek@amd.com,
bharat.kumar.gogada@amd.com, jingoohan1@gmail.com
Subject: Re: [PATCH v15 3/3] PCI: amd-mdb: Add AMD MDB Root Port driver
Date: Mon, 3 Mar 2025 18:58:00 +0900 [thread overview]
Message-ID: <20250303095800.GC1065658@rocinante> (raw)
In-Reply-To: <20250228093351.923615-4-thippeswamy.havalige@amd.com>
Hello,
[...]
> + err = devm_request_irq(dev, irq, amd_mdb_pcie_intr_handler,
> + IRQF_NO_THREAD, intr_cause[i].sym, pcie);
> + if (err) {
> + dev_err(dev, "Failed to request IRQ %d\n", irq);
> + return err;
> + }
> + }
Out of curiosity: would exposing error values be of any benefit to the
users of the driver? So, perhaps:
if (err) {
dev_err(dev, "Failed to request IRQ %d, err=%d\n", irq, err);
return err;
}
Thoughts?
Krzysztof
next prev parent reply other threads:[~2025-03-03 9:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 9:33 [PATCH v15 0/3] Add support for AMD MDB IP as Root Port Thippeswamy Havalige
2025-02-28 9:33 ` [PATCH v15 1/3] dt-bindings: PCI: dwc: Add AMD Versal2 mdb slcr support Thippeswamy Havalige
2025-02-28 9:33 ` [PATCH v15 2/3] dt-bindings: PCI: amd-mdb: Add AMD Versal2 MDB PCIe Root Port Bridge Thippeswamy Havalige
2025-02-28 9:33 ` [PATCH v15 3/3] PCI: amd-mdb: Add AMD MDB Root Port driver Thippeswamy Havalige
2025-02-28 16:37 ` Bjorn Helgaas
2025-03-02 18:35 ` Krzysztof Wilczyński
2025-03-03 9:58 ` Krzysztof Wilczyński [this message]
2025-03-03 11:03 ` Havalige, Thippeswamy
2025-03-04 13:23 ` Manivannan Sadhasivam
2025-03-18 10:21 ` Geert Uytterhoeven
2025-03-02 18:33 ` [PATCH v15 0/3] Add support for AMD MDB IP as Root Port Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250303095800.GC1065658@rocinante \
--to=kw@linux.com \
--cc=bharat.kumar.gogada@amd.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jingoohan1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=michal.simek@amd.com \
--cc=robh@kernel.org \
--cc=thippeswamy.havalige@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox