From: Artur Weber <aweber.kernel@gmail.com>
To: Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>
Cc: Stanislav Jakubek <stano.jakubek@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
~postmarketos/upstreaming@lists.sr.ht,
Artur Weber <aweber.kernel@gmail.com>
Subject: [PATCH v6 07/10] regulator: bcm590xx: Use dev_err_probe for regulator register error
Date: Tue, 04 Mar 2025 07:20:38 +0100 [thread overview]
Message-ID: <20250304-bcm59054-v6-7-ae8302358443@gmail.com> (raw)
In-Reply-To: <20250304-bcm59054-v6-0-ae8302358443@gmail.com>
Instead of calling dev_err() and returning PTR_ERR(...) separately, use
a single "return dev_err_probe" statement.
Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
---
Changes in v4:
- Added this commit
---
drivers/regulator/bcm590xx-regulator.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/regulator/bcm590xx-regulator.c b/drivers/regulator/bcm590xx-regulator.c
index 9f0cda46b01506080ae5fa709104a8df4d174a8d..a17311fa30e4d48c0a4925778d7bed486ac7a982 100644
--- a/drivers/regulator/bcm590xx-regulator.c
+++ b/drivers/regulator/bcm590xx-regulator.c
@@ -340,12 +340,10 @@ static int bcm590xx_probe(struct platform_device *pdev)
rdev = devm_regulator_register(&pdev->dev, &pmu->desc[i],
&config);
- if (IS_ERR(rdev)) {
- dev_err(bcm590xx->dev,
- "failed to register %s regulator\n",
- pdev->name);
- return PTR_ERR(rdev);
- }
+ if (IS_ERR(rdev))
+ return dev_err_probe(bcm590xx->dev, PTR_ERR(rdev),
+ "failed to register %s regulator\n",
+ pdev->name);
}
return 0;
--
2.48.1
next prev parent reply other threads:[~2025-03-04 6:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 6:20 [PATCH v6 00/10] mfd: bcm590xx: Add support for BCM59054 Artur Weber
2025-03-04 6:20 ` [PATCH v6 01/10] dt-bindings: mfd: brcm,bcm59056: Convert to YAML Artur Weber
2025-03-04 14:16 ` Rob Herring (Arm)
2025-03-04 6:20 ` [PATCH v6 02/10] dt-bindings: mfd: brcm,bcm59056: Add compatible for BCM59054 Artur Weber
2025-03-04 14:19 ` Rob Herring
2025-03-05 16:52 ` Artur Weber
2025-03-05 17:02 ` Rob Herring
2025-03-04 6:20 ` [PATCH v6 03/10] ARM: dts: Drop DTS for BCM59056 PMU Artur Weber
2025-03-17 13:29 ` Florian Fainelli
2025-03-04 6:20 ` [PATCH v6 04/10] mfd: bcm590xx: Drop unused "id" member of bcm590xx MFD struct Artur Weber
2025-03-04 6:20 ` [PATCH v6 05/10] mfd: bcm590xx: Add support for multiple device types + BCM59054 compatible Artur Weber
2025-03-04 6:20 ` [PATCH v6 06/10] mfd: bcm590xx: Add PMU ID/revision parsing function Artur Weber
2025-03-13 13:20 ` Lee Jones
2025-03-13 13:25 ` Mark Brown
2025-03-13 20:39 ` Artur Weber
2025-03-14 8:00 ` Lee Jones
2025-03-14 8:42 ` Lee Jones
2025-03-04 6:20 ` Artur Weber [this message]
2025-03-04 6:20 ` [PATCH v6 08/10] regulator: bcm590xx: Store regulator descriptions in table Artur Weber
2025-03-04 6:20 ` [PATCH v6 09/10] regulator: bcm590xx: Rename BCM59056-specific data as such Artur Weber
2025-03-04 6:20 ` [PATCH v6 10/10] regulator: bcm590xx: Add support for BCM59054 regulators Artur Weber
2025-03-13 13:21 ` [PATCH v6 00/10] mfd: bcm590xx: Add support for BCM59054 Lee Jones
2025-03-13 20:49 ` Artur Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250304-bcm59054-v6-7-ae8302358443@gmail.com \
--to=aweber.kernel@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=stano.jakubek@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).