From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABFE8AD24; Tue, 4 Mar 2025 07:35:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741073720; cv=none; b=VJSAMazTtQDaJ38Kk5X0+sx06Vfr2CLPP2S2wMpFORjgCfselz4iRjtDdZQ1X6HuwgBedQnARMIW00s1Fz9fkYU8kVV3G4C/Nh1kzSB6UP6yvk0PZ4Uik1B5D5W2XPxN4mdz/xp5umv/hG7JkJSJY+6nkkaMxhFzit7GGrTMcDc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741073720; c=relaxed/simple; bh=BKl3YpxP921qg6Y9Mt0kJy44103dFeFyCIdjzDwM11s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KaKH4YKSIwj0eMRpcjgMdGHRBJoEzYUjf+zqowfUaTSthTUUPehsRwZ9lcs2yL3UQhiJzxr+UYLTGgx37JD3JhdsqfobjvDnYiMIUgKH7A5S1ZF9aqNXb0crsiAiaXtOsLvOHVl2Nn7nztrrtpPb9ds8mw3c6iOnDkl3xB7l8oc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DNaHQylf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DNaHQylf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32DCFC4CEE5; Tue, 4 Mar 2025 07:35:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741073720; bh=BKl3YpxP921qg6Y9Mt0kJy44103dFeFyCIdjzDwM11s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DNaHQylfVrNjgjfpQYhM9j/+K0ka8a+tNMEms/EW5ovxQ6etN1pULMMQ2teBYIMQH o5LN+8AqCm4zLo51UDh0nGEMvE+W6RcDBT0yITvUjYDC4qfFRkFa4v6H/QW7onq2j1 zwIpgfF+j+NM0r7gj4CziF4RVthdIFSQ5gWsHvpPNPaYE8Vl6CaRZt1pviY7vdtr8V KzHQqG86iS8vq8+Ap8u1ddREOBQ6SngrEc+wc20e+mv73jMXmY1ROja0w2qbxgM4Pe pqyfktB0kzxZSROBSXfOQcuEKeDtIs0Ih4cuCxeC5JaWfknwXdMsr1dSy+t3XqOekP lnSrg4H8wroUw== Date: Tue, 4 Mar 2025 08:35:16 +0100 From: Krzysztof Kozlowski To: Artur Weber Cc: Michael Turquette , Stephen Boyd , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alex Elder , Stanislav Jakubek , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH v2 2/7] dt-bindings: clock: brcm,kona-ccu: Add BCM281xx bus clocks Message-ID: <20250304-fat-nebulous-meerkat-008f04@krzk-bin> References: <20250303-kona-bus-clock-v2-0-a363c6a6b798@gmail.com> <20250303-kona-bus-clock-v2-2-a363c6a6b798@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250303-kona-bus-clock-v2-2-a363c6a6b798@gmail.com> On Mon, Mar 03, 2025 at 09:27:50PM +0100, Artur Weber wrote: > - if: > properties: > compatible: > diff --git a/include/dt-bindings/clock/bcm281xx.h b/include/dt-bindings/clock/bcm281xx.h > index d74ca42112e79746c513f6861a89628ee03f0f79..15449f998eb7a5a191fd847b689cfbe60b27c541 100644 > --- a/include/dt-bindings/clock/bcm281xx.h > +++ b/include/dt-bindings/clock/bcm281xx.h > @@ -34,7 +34,9 @@ > #define BCM281XX_AON_CCU_HUB_TIMER 0 > #define BCM281XX_AON_CCU_PMU_BSC 1 > #define BCM281XX_AON_CCU_PMU_BSC_VAR 2 > -#define BCM281XX_AON_CCU_CLOCK_COUNT 3 You cannot change defines, it is an ABI. Unless it is not an ABI... so just drop all these counts in separate patch, just like we were doing for other platforms. Best regards, Krzysztof