Re: [PATCH v3 17/20] ASoC: dt-bindings: tas2770: add flags for SDOUT pulldown and zero-fill

[Rob Herring <robh@kernel.org>]

On Thu, Feb 27, 2025 at 10:07:44PM +1000, James Calligeros wrote:
> TAS2770 can pull down and zero-fill SDOUT when not actively transmitting
> TDM slot data. Zero-fill is useful when there are no other amps on the
> bus. Pulldown is useful when the chip is attached to a shared bus.
> 
> Signed-off-by: James Calligeros <jcalligeros99@gmail.com>
> ---
>  .../bindings/sound/ti,tas2770.yaml       | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/ti,tas2770.yaml b/Documentation/devicetree/bindings/sound/ti,tas2770.yaml
> index 8eab98a0f7a25a9c87d2c56fd0635ff8ecee17d0..3eba9bb34a581526f68b6bf2e8437e1f1e03d26f 100644
> --- a/Documentation/devicetree/bindings/sound/ti,tas2770.yaml
> +++ b/Documentation/devicetree/bindings/sound/ti,tas2770.yaml
> @@ -57,6 +57,18 @@ properties:
>        - 0 # Rising edge
>        - 1 # Falling edge
>  
> +  ti,sdout-pull-down:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      If present, SDOUT will be pulled low when not
> +      transmitting.
> +
> +  ti,sdout-zero-fill:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      If present, SDOUT will be zero-filled when not
> +      transmitting.

Can't you align this with the other property you added? Or extend the 
existing TDM properties we have.

Rob