From: Krzysztof Kozlowski <krzk@kernel.org>
To: Maxime Ripard <mripard@kernel.org>
Cc: Liu Ying <victor.liu@nxp.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
andrzej.hajda@intel.com, neil.armstrong@linaro.org,
rfoss@kernel.org, Laurent.pinchart@ideasonboard.com,
jonas@kwiboo.se, jernej.skrabec@gmail.com,
maarten.lankhorst@linux.intel.com, tzimmermann@suse.de,
airlied@gmail.com, simona@ffwll.ch
Subject: Re: [PATCH 1/5] dt-bindings: display: Document DPI color codings
Date: Wed, 5 Mar 2025 08:51:35 +0100 [thread overview]
Message-ID: <20250305-important-quizzical-chamois-ff48af@krzk-bin> (raw)
In-Reply-To: <20250304-deer-of-striking-pride-ff6e86@houat>
On Tue, Mar 04, 2025 at 11:33:44AM +0100, Maxime Ripard wrote:
> > +properties:
> > + dpi-color-coding:
> > + enum:
> > + - 16bit-configuration1
> > + - 16bit-configuration2
> > + - 16bit-configuration3
> > + - 18bit-configuration1
> > + - 18bit-configuration2
> > + - 24bit
>
> Do we really needs strings there? It would be much better to use an int
> plus a header
So DTS would sill have a name, just being a define? Then what is the
benefit comparing to strings above in DTS readability?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-05 7:51 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 10:15 [PATCH 0/5] drm/bridge: simple-bridge: Add DPI color encoder support Liu Ying
2025-03-04 10:15 ` [PATCH 1/5] dt-bindings: display: Document DPI color codings Liu Ying
2025-03-04 10:33 ` Maxime Ripard
2025-03-05 7:51 ` Krzysztof Kozlowski [this message]
2025-03-05 8:26 ` Maxime Ripard
2025-03-05 12:16 ` Krzysztof Kozlowski
2025-03-06 7:13 ` Liu Ying
2025-03-04 10:15 ` [PATCH 2/5] drm/of: Add drm_of_dpi_get_color_coding() Liu Ying
2025-03-04 10:15 ` [PATCH 3/5] dt-bindings: display: simple-bridge: Document DPI color encoder Liu Ying
2025-03-04 10:38 ` Maxime Ripard
2025-03-06 5:49 ` Liu Ying
2025-03-04 11:27 ` Rob Herring (Arm)
2025-03-04 15:23 ` Rob Herring
2025-03-05 9:35 ` Alexander Stein
2025-03-05 16:38 ` Rob Herring
2025-03-06 7:02 ` Liu Ying
2025-03-06 11:35 ` Maxime Ripard
2025-03-06 20:34 ` Rob Herring
2025-03-07 3:25 ` Liu Ying
2025-03-10 9:53 ` Maxime Ripard
2025-03-11 2:29 ` Liu Ying
2025-03-11 7:44 ` Maxime Ripard
2025-03-07 3:10 ` Liu Ying
2025-03-10 9:44 ` Maxime Ripard
2025-03-11 2:38 ` Liu Ying
2025-03-11 7:52 ` Maxime Ripard
2025-03-04 10:15 ` [PATCH 4/5] drm/bridge: simple-bridge: Add DPI color encoder support Liu Ying
2025-03-04 10:40 ` Maxime Ripard
2025-03-06 5:57 ` Liu Ying
2025-03-04 10:15 ` [PATCH 5/5] drm/bridge: simple-bridge: Add next panel support Liu Ying
2025-03-04 10:41 ` Maxime Ripard
2025-03-06 6:17 ` Liu Ying
2025-03-04 15:00 ` [PATCH 0/5] drm/bridge: simple-bridge: Add DPI color encoder support Alexander Stein
2026-01-12 9:31 ` Francesco Dolcini
2026-01-12 9:44 ` Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250305-important-quizzical-chamois-ff48af@krzk-bin \
--to=krzk@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=victor.liu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox