devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dimitri Fedrau <dima.fedrau@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: dimitri.fedrau@liebherr.com,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/3] net: phy: dp83822: Add support for changing the MAC series termination
Date: Fri, 7 Mar 2025 20:23:05 +0100	[thread overview]
Message-ID: <20250307192305.GA8328@debian> (raw)
In-Reply-To: <d57aff5b-7d1d-43bf-95a1-ee90689f5ac0@lunn.ch>

Am Fri, Mar 07, 2025 at 04:34:59PM +0100 schrieb Andrew Lunn:
> > Should I add the proper description in the bindings ? Description of the
> > properties are somehow short. However will expand the description.
> 
> Yes, please expand the description. For well known concepts, we can
> keep the binding description short. But i would not consider this a
> well known concept, so we need to spell out in detail what it is.
>
Ok.

> My knowledge of transmission lines and termination is not so good....
> 
> So this configures the resistor on the PHY outputs. Do PHY inputs also
> need termination resistors? Could there be PHYs which also allow such
> resistors to be configured? Are there use cases where you need
> asymmetric termination resistors?
>
I think they are also needed for the PHY inputs, but termination
resistors should be placed near the driver. In case the MAC doesn't have
them integrated they should be placed near the MAC outputs. From PHY
perspective we just care about the PHY outputs.

https://resources.pcb.cadence.com/blog/termination-resistors-in-pcb-design

I don't know if there is a general rule that states wether to use series
termination or not. I think it depends on the PCB design and if there are
issues with signal quality. Maybe this one helps, there is a small
chapter regarding series termination:

https://resources.altium.com/p/gigabit-ethernet-101-basics-implementation

Found it reading this:

https://community.nxp.com/t5/i-MX-Processors/Why-doesn-t-NXP-use-termination-resistors-for-MII-data-lines/td-p/1360873

> My questions are trying to lead to an answer to your question:
> 
> > Should I rename then "mac-series-termination-ohms" to
> > "output-mac-series-termination-ohms" or similar ?
> 
> We should think about this from the general case, not one specific
> PHY, and ideally from thinking about the physics of termination.
> 
> https://electronics.stackexchange.com/questions/524620/impedance-termination-of-marvell-phy
> 
> This seems to suggest RGMII only has termination resistors at the
> outputs. So "mac-series-termination-ohms" would be O.K.
>
Ok.

Best regards,
Dimitri Fedrau

      reply	other threads:[~2025-03-07 19:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07 10:30 [PATCH net-next 0/3] net: phy: dp83822: Add support for changing the MAC series termination Dimitri Fedrau via B4 Relay
2025-03-07 10:30 ` [PATCH net-next 1/3] dt-bindings: net: ethernet-phy: add property mac-series-termination-ohms Dimitri Fedrau via B4 Relay
2025-03-11 17:33   ` Rob Herring
2025-03-11 18:06     ` Andrew Lunn
2025-03-07 10:30 ` [PATCH net-next 2/3] net: phy: Add helper for getting MAC series termination resistance Dimitri Fedrau via B4 Relay
2025-03-07 10:30 ` [PATCH net-next 3/3] net: phy: dp83822: Add support for changing the MAC series termination Dimitri Fedrau via B4 Relay
2025-03-07 13:39 ` [PATCH net-next 0/3] " Andrew Lunn
2025-03-07 14:22   ` Dimitri Fedrau
2025-03-07 15:34     ` Andrew Lunn
2025-03-07 19:23       ` Dimitri Fedrau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250307192305.GA8328@debian \
    --to=dima.fedrau@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dimitri.fedrau@liebherr.com \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).