From: Roman Kisel <romank@linux.microsoft.com>
To: arnd@arndb.de, bhelgaas@google.com, bp@alien8.de,
catalin.marinas@arm.com, conor+dt@kernel.org,
dave.hansen@linux.intel.com, decui@microsoft.com,
haiyangz@microsoft.com, hpa@zytor.com, joey.gouly@arm.com,
krzk+dt@kernel.org, kw@linux.com, kys@microsoft.com,
lenb@kernel.org, lpieralisi@kernel.org,
manivannan.sadhasivam@linaro.org, mark.rutland@arm.com,
maz@kernel.org, mingo@redhat.com, oliver.upton@linux.dev,
rafael@kernel.org, robh@kernel.org, ssengar@linux.microsoft.com,
sudeep.holla@arm.com, suzuki.poulose@arm.com, tglx@linutronix.de,
wei.liu@kernel.org, will@kernel.org, yuzenghui@huawei.com,
devicetree@vger.kernel.org, kvmarm@lists.linux.dev,
linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, x86@kernel.org
Cc: apais@microsoft.com, benhill@microsoft.com,
bperkins@microsoft.com, sunilmut@microsoft.com
Subject: [PATCH hyperv-next v5 02/11] arm64: hyperv: Use SMCCC to detect hypervisor presence
Date: Fri, 7 Mar 2025 14:02:54 -0800 [thread overview]
Message-ID: <20250307220304.247725-3-romank@linux.microsoft.com> (raw)
In-Reply-To: <20250307220304.247725-1-romank@linux.microsoft.com>
The arm64 Hyper-V startup path relies on ACPI to detect
running under a Hyper-V compatible hypervisor. That
doesn't work on non-ACPI systems.
Hoist the ACPI detection logic into a separate function. Then
use the vendor-specific hypervisor service call (implemented
recently in Hyper-V) via SMCCC in the non-ACPI case.
Signed-off-by: Roman Kisel <romank@linux.microsoft.com>
---
arch/arm64/hyperv/mshyperv.c | 43 +++++++++++++++++++++++++++++++-----
1 file changed, 38 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/hyperv/mshyperv.c b/arch/arm64/hyperv/mshyperv.c
index 29fcfd595f48..c647db56fd6b 100644
--- a/arch/arm64/hyperv/mshyperv.c
+++ b/arch/arm64/hyperv/mshyperv.c
@@ -27,6 +27,41 @@ int hv_get_hypervisor_version(union hv_hypervisor_version_info *info)
return 0;
}
+static bool __init hyperv_detect_via_acpi(void)
+{
+ if (acpi_disabled)
+ return false;
+#if IS_ENABLED(CONFIG_ACPI)
+ /*
+ * Hypervisor ID is only available in ACPI v6+, and the
+ * structure layout was extended in v6 to accommodate that
+ * new field.
+ *
+ * At the very minimum, this check makes sure not to read
+ * past the FADT structure.
+ *
+ * It is also needed to catch running in some unknown
+ * non-Hyper-V environment that has ACPI 5.x or less.
+ * In such a case, it can't be Hyper-V.
+ */
+ if (acpi_gbl_FADT.header.revision < 6)
+ return false;
+ return strncmp((char *)&acpi_gbl_FADT.hypervisor_id, "MsHyperV", 8) == 0;
+#else
+ return false;
+#endif
+}
+
+static bool __init hyperv_detect_via_smccc(void)
+{
+ uuid_t hyperv_uuid = UUID_INIT(
+ 0x4d32ba58, 0x4764, 0xcd24,
+ 0x75, 0x6c, 0xef, 0x8e,
+ 0x24, 0x70, 0x59, 0x16);
+
+ return arm_smccc_hyp_present(&hyperv_uuid);
+}
+
static int __init hyperv_init(void)
{
struct hv_get_vp_registers_output result;
@@ -35,13 +70,11 @@ static int __init hyperv_init(void)
/*
* Allow for a kernel built with CONFIG_HYPERV to be running in
- * a non-Hyper-V environment, including on DT instead of ACPI.
+ * a non-Hyper-V environment.
+ *
* In such cases, do nothing and return success.
*/
- if (acpi_disabled)
- return 0;
-
- if (strncmp((char *)&acpi_gbl_FADT.hypervisor_id, "MsHyperV", 8))
+ if (!hyperv_detect_via_acpi() && !hyperv_detect_via_smccc())
return 0;
/* Setup the guest ID */
--
2.43.0
next prev parent reply other threads:[~2025-03-07 22:03 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 22:02 [PATCH hyperv-next v5 00/11] arm64: hyperv: Support Virtual Trust Level Boot Roman Kisel
2025-03-07 22:02 ` [PATCH hyperv-next v5 01/11] arm64: kvm, smccc: Introduce and use API for detectting hypervisor presence Roman Kisel
2025-03-08 21:08 ` Arnd Bergmann
2025-03-10 21:16 ` Michael Kelley
2025-03-10 21:54 ` Roman Kisel
2025-03-12 14:07 ` kernel test robot
2025-03-12 21:18 ` kernel test robot
2025-03-07 22:02 ` Roman Kisel [this message]
2025-03-10 21:17 ` [PATCH hyperv-next v5 02/11] arm64: hyperv: Use SMCCC to detect " Michael Kelley
2025-03-07 22:02 ` [PATCH hyperv-next v5 03/11] Drivers: hv: Enable VTL mode for arm64 Roman Kisel
2025-03-08 21:05 ` Arnd Bergmann
2025-03-10 17:35 ` Roman Kisel
2025-03-10 21:01 ` Michael Kelley
2025-03-10 21:20 ` Arnd Bergmann
2025-03-10 22:18 ` Michael Kelley
2025-03-12 18:33 ` Roman Kisel
2025-03-12 20:25 ` Arnd Bergmann
2025-03-12 21:21 ` Roman Kisel
2025-03-13 5:10 ` Michael Kelley
2025-03-12 20:31 ` Wei Liu
2025-03-12 21:30 ` Roman Kisel
2025-03-07 22:02 ` [PATCH hyperv-next v5 04/11] Drivers: hv: Provide arch-neutral implementation of get_vtl() Roman Kisel
2025-03-10 13:44 ` Tianyu Lan
2025-03-07 22:02 ` [PATCH hyperv-next v5 05/11] arm64: hyperv: Initialize the Virtual Trust Level field Roman Kisel
2025-03-10 23:07 ` Michael Kelley
2025-03-07 22:02 ` [PATCH hyperv-next v5 06/11] arm64, x86: hyperv: Report the VTL the system boots in Roman Kisel
2025-03-10 0:31 ` Wei Liu
2025-03-10 16:42 ` Roman Kisel
2025-03-10 16:53 ` Wei Liu
2025-03-10 17:20 ` Roman Kisel
2025-03-07 22:02 ` [PATCH hyperv-next v5 07/11] dt-bindings: microsoft,vmbus: Add interrupts and DMA coherence Roman Kisel
2025-03-10 9:28 ` Krzysztof Kozlowski
2025-03-10 17:05 ` Roman Kisel
2025-03-10 17:40 ` Krzysztof Kozlowski
2025-03-10 18:07 ` Roman Kisel
2025-03-10 21:17 ` Krzysztof Kozlowski
2025-03-10 21:51 ` Roman Kisel
2025-03-07 22:03 ` [PATCH hyperv-next v5 08/11] Drivers: hv: vmbus: Get the IRQ number from DeviceTree Roman Kisel
2025-03-08 21:11 ` Arnd Bergmann
2025-03-10 17:36 ` Roman Kisel
2025-03-10 23:09 ` Michael Kelley
2025-03-13 18:31 ` Dan Carpenter
2025-03-13 18:35 ` Roman Kisel
2025-03-13 18:44 ` Rob Herring
2025-03-13 18:46 ` Roman Kisel
2025-03-07 22:03 ` [PATCH hyperv-next v5 09/11] Drivers: hv: vmbus: Introduce hv_get_vmbus_root_device() Roman Kisel
2025-03-10 13:41 ` Tianyu Lan
2025-03-10 17:09 ` Roman Kisel
2025-03-10 23:12 ` Michael Kelley
2025-03-07 22:03 ` [PATCH hyperv-next v5 10/11] ACPI: irq: Introduce acpi_get_gsi_dispatcher() Roman Kisel
2025-03-10 23:26 ` Michael Kelley
2025-03-07 22:03 ` [PATCH hyperv-next v5 11/11] PCI: hv: Get vPCI MSI IRQ domain from DeviceTree Roman Kisel
2025-03-10 16:41 ` Bjorn Helgaas
2025-03-10 17:15 ` Roman Kisel
2025-03-10 23:42 ` Michael Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250307220304.247725-3-romank@linux.microsoft.com \
--to=romank@linux.microsoft.com \
--cc=apais@microsoft.com \
--cc=arnd@arndb.de \
--cc=benhill@microsoft.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=bperkins@microsoft.com \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=devicetree@vger.kernel.org \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=joey.gouly@arm.com \
--cc=krzk+dt@kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=kw@linux.com \
--cc=kys@microsoft.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=oliver.upton@linux.dev \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=ssengar@linux.microsoft.com \
--cc=sudeep.holla@arm.com \
--cc=sunilmut@microsoft.com \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).