From: Leo Yan <leo.yan@arm.com>
To: Yuanfang Zhang <quic_yuanfang@quicinc.com>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
kernel@quicinc.com, linux-kernel@vger.kernel.org,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
kernel@oss.qualcomm.com, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/5] coresight: add coresight Trace NOC driver
Date: Mon, 10 Mar 2025 11:02:51 +0000 [thread overview]
Message-ID: <20250310110251.GC9682@e132581.arm.com> (raw)
In-Reply-To: <c0848f24-26c4-4282-9813-1842c2a50c1e@quicinc.com>
On Thu, Mar 06, 2025 at 04:22:20PM +0800, Yuanfang Zhang wrote:
[...]
> >> +static int trace_noc_init_default_data(struct trace_noc_drvdata *drvdata)
> >> +{
> >> + int atid;
> >> +
> >> + atid = coresight_trace_id_get_system_id();
> >> + if (atid < 0)
> >> + return atid;
> >> +
> >> + drvdata->atid = atid;
> >> +
> >> + drvdata->freq_type = FREQ_TS;
> >
> > I don't see anywhere uses FREQ. Please remove the unused definitions
> > and related code.
>
> it is used in trace_noc_enable_hw().
I understood some macros and definitions are used by seqential patches.
A good practice is code should be added only when they are used. This
can allow every patch in neat way and easier for review.
Thanks,
Leo
> >
> >> + drvdata->flag_type = FLAG;
> >
> > FLAG_TS is not used in the driver as well. Remove it.
> it is used in trace_noc_enable_hw().
next prev parent reply other threads:[~2025-03-10 11:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 11:05 [PATCH v2 0/5] coresight: Add Coresight Trace NOC driver Yuanfang Zhang
2025-02-26 11:05 ` [PATCH v2 1/5] dt-bindings: arm: Add Coresight device Trace NOC definition Yuanfang Zhang
2025-02-26 11:09 ` Krzysztof Kozlowski
2025-02-26 11:16 ` Yuanfang Zhang
2025-02-26 11:20 ` Krzysztof Kozlowski
2025-02-26 11:05 ` [PATCH v2 2/5] coresight: add coresight Trace NOC driver Yuanfang Zhang
2025-02-27 11:39 ` Leo Yan
2025-03-06 8:22 ` Yuanfang Zhang
2025-03-10 11:02 ` Leo Yan [this message]
2025-04-03 7:40 ` Yuanfang Zhang
2025-04-07 15:47 ` Mike Leach
2025-04-08 11:35 ` Yuanfang Zhang
2025-02-26 11:05 ` [PATCH v2 3/5] coresight-tnoc: add nodes to configure flush Yuanfang Zhang
2025-02-27 16:23 ` Leo Yan
2025-03-06 8:39 ` Yuanfang Zhang
2025-03-10 11:46 ` Leo Yan
2025-02-26 11:05 ` [PATCH v2 4/5] coresight-tnoc: add node to configure flag type Yuanfang Zhang
2025-02-26 11:05 ` [PATCH v2 5/5] coresight-tnoc: add nodes to configure freq packet Yuanfang Zhang
2025-02-26 11:12 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250310110251.GC9682@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@linaro.org \
--cc=kernel@oss.qualcomm.com \
--cc=kernel@quicinc.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=quic_yuanfang@quicinc.com \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).