From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5474221ABBF; Mon, 10 Mar 2025 12:32:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741609931; cv=none; b=i8yAzn0j6ziePYXmg4wlu7iWgKNMgFFukkU8K3P/yzM5O2hPxueefU+HRszPMlfeAhyML/K2dNxgiBnQMASEpzshWFWncD98NK3ud+dsNnZDdUEUQDHK+hKopVeGZA5rysBijpBt1rTgqRebi47hVJoQwX7WTKoLu3bUNPp+300= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741609931; c=relaxed/simple; bh=+yJXW3oB2sKwOAYNjS/cyatF0So7vPbPll756fs5Nps=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ggZmqlPbK/JcjidgVpBspCJ2S1AbydLu8/Ma/6MURXwHBDJJcAS0lzi0qrE7vlTTyEZaKeADoHpTJLiZ1I5vwMzeQ9rsssy25nmNZw5ZG0bovXgK7/jSntRRDFlKC/6/v6c/Ll7aC81UnSBZSbhMlsqkfkIXJ1xOKX6pHJi3QgA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XY0FhGNz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XY0FhGNz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D320C4CEEA; Mon, 10 Mar 2025 12:32:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741609929; bh=+yJXW3oB2sKwOAYNjS/cyatF0So7vPbPll756fs5Nps=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XY0FhGNz/+TRaq1rubNK8SAY4CBRiH1RDdjwpGzDXcryn/LGrKkpSiJXxMN05qTto GktCOuoFSdnUrIfGHOgrQo1OZFKBgcTJnyRqazDKuhi69HD8z3SJjX6rQDCAQ86oI9 H6KWiijonJVFQ+kGlJ3Qwx8/N7RZlUiYRaT3zAB/eLpnodG4uneirLn775Umqp9GvP FTw5LBehq9qDwlE/arO5Xh9TtJW5betOcs0PF/moAReVhf2hEvMQuStoZ2EhVYtjtC XbxYxvPMHJNgDlOusvJQWYu1/xgKTNZQCi+z0HAHBB5dn0RwjotXYCFZXjm6SVxsxT lBwykbgDebHfQ== Date: Mon, 10 Mar 2025 07:32:07 -0500 From: Rob Herring To: Cosmin Tanislav Cc: Tomi Valkeinen , Niklas =?iso-8859-1?Q?S=F6derlund?= , Cosmin Tanislav , Mauro Carvalho Chehab , Krzysztof Kozlowski , Conor Dooley , Julien Massot , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , Bjorn Andersson , Geert Uytterhoeven , Dmitry Baryshkov , Heiko Stuebner , Biju Das , Taniya Das , =?iso-8859-1?Q?N=EDcolas_F_=2E_R_=2E_A_=2E?= Prado , Eric Biggers , Javier Carrasco , Ross Burton , Sakari Ailus , Hans Verkuil , Laurent Pinchart , Umang Jain , Zhi Mao , Kieran Bingham , Dongcheng Yan , AngeloGioacchino Del Regno , Benjamin Mugnier , Tommaso Merciai , Dan Carpenter , Ricardo Ribalda , Ihor Matushchak , Laurentiu Palcu , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-gpio@vger.kernel.org Subject: Re: [RFC PATCH 09/24] dt-bindings: media: i2c: max96714: make i2c-gate conditional on compatible Message-ID: <20250310123207.GA3853920-robh@kernel.org> References: <20250308183410.3013996-1-demonsingur@gmail.com> <20250308183410.3013996-10-demonsingur@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250308183410.3013996-10-demonsingur@gmail.com> On Sat, Mar 08, 2025 at 08:33:38PM +0200, Cosmin Tanislav wrote: > Devices to be added in following patches don't use I2C gate. > > Make this property conditional on the compatible strings. > > Signed-off-by: Cosmin Tanislav > --- > .../bindings/media/i2c/maxim,max96714.yaml | 21 ++++++++++++------- > 1 file changed, 13 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max96714.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max96714.yaml > index 2f453189338f..d0a2aaf7df9c 100644 > --- a/Documentation/devicetree/bindings/media/i2c/maxim,max96714.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max96714.yaml > @@ -84,14 +84,6 @@ properties: > required: > - port@1 > > - i2c-gate: > - $ref: /schemas/i2c/i2c-gate.yaml > - unevaluatedProperties: false > - description: > - The MAX96714 will pass through and forward the I2C requests from the > - incoming I2C bus over the GMSL2 link. Therefore it supports an i2c-gate > - subnode to configure a serializer. > - > port0-poc-supply: > description: Regulator providing Power over Coax for the GMSL port > > @@ -101,6 +93,19 @@ required: > - ports > > additionalProperties: false > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - maxim,max96714 > + - maxim,max96714f > + then: > + properties: > + i2c-gate: Leave the original definition, invert the 'if', and here you just need: i2c-gate: false > + $ref: /schemas/i2c/i2c-gate.yaml > + unevaluatedProperties: false > > examples: > - | > -- > 2.48.1 >