[PATCH 1/2] dt-bindings: PCI: fsl,layerscape-pcie-ep: Drop deprecated windows

[PATCH 1/2] dt-bindings: PCI: fsl,layerscape-pcie-ep: Drop deprecated windows

[Krzysztof Kozlowski]

The example DTS uses 'num-ib-windows' and 'num-ob-windows' properties
but these are not defined in the binding.  Binding also does not
reference snps,dw-pcie-common.yaml, probably because it is quite
different even though the device is based on Synopsys controller.

The properties are actually deprecated, so simply drop them from the
example.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml         | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
index 399efa7364c9..1fdc899e7292 100644
--- a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
+++ b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
@@ -94,8 +94,6 @@ examples:
         reg-names = "regs", "addr_space";
         interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>; /* PME interrupt */
         interrupt-names = "pme";
-        num-ib-windows = <6>;
-        num-ob-windows = <8>;
         status = "disabled";
       };
     };
-- 
2.43.0

[PATCH 2/2] dt-bindings: PCI: fsl,layerscape-pcie-ep: Drop unnecessary status from example

[Krzysztof Kozlowski]

Device nodes in the examples are supposed to be enabled, so the schema
will be validated against them.  Keeping them disabled hides potential
errors.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml          | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
index 1fdc899e7292..d78a6d1f7198 100644
--- a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
+++ b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
@@ -94,7 +94,6 @@ examples:
         reg-names = "regs", "addr_space";
         interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>; /* PME interrupt */
         interrupt-names = "pme";
-        status = "disabled";
       };
     };
 ...
-- 
2.43.0

Re: [PATCH 2/2] dt-bindings: PCI: fsl,layerscape-pcie-ep: Drop unnecessary status from example

[Frank Li]

On Fri, Mar 07, 2025 at 09:13:27AM +0100, Krzysztof Kozlowski wrote:
> Device nodes in the examples are supposed to be enabled, so the schema
> will be validated against them.  Keeping them disabled hides potential
> errors.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> ---
>  .../devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml          | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
> index 1fdc899e7292..d78a6d1f7198 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
> @@ -94,7 +94,6 @@ examples:
>          reg-names = "regs", "addr_space";
>          interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>; /* PME interrupt */
>          interrupt-names = "pme";
> -        status = "disabled";
>        };
>      };
>  ...
> --
> 2.43.0
>

Re: [PATCH 1/2] dt-bindings: PCI: fsl,layerscape-pcie-ep: Drop deprecated windows

[Frank Li]

On Fri, Mar 07, 2025 at 09:13:26AM +0100, Krzysztof Kozlowski wrote:
> The example DTS uses 'num-ib-windows' and 'num-ob-windows' properties
> but these are not defined in the binding.  Binding also does not
> reference snps,dw-pcie-common.yaml, probably because it is quite
> different even though the device is based on Synopsys controller.

The reg-names is difference with defined in snps,dw-pcie-common.yaml.
Driver and dts's upstream is quite early and change driver and dts's
reg-names will cause back compatible problem.

>
> The properties are actually deprecated, so simply drop them from the
> example.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  .../devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml         | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
> index 399efa7364c9..1fdc899e7292 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
> @@ -94,8 +94,6 @@ examples:
>          reg-names = "regs", "addr_space";
>          interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>; /* PME interrupt */
>          interrupt-names = "pme";
> -        num-ib-windows = <6>;
> -        num-ob-windows = <8>;
>          status = "disabled";
>        };
>      };
> --
> 2.43.0
>

Re: [PATCH 1/2] dt-bindings: PCI: fsl,layerscape-pcie-ep: Drop deprecated windows

[Krzysztof Wilczyński]

Hello,

> The example DTS uses 'num-ib-windows' and 'num-ob-windows' properties
> but these are not defined in the binding.  Binding also does not
> reference snps,dw-pcie-common.yaml, probably because it is quite
> different even though the device is based on Synopsys controller.
> 
> The properties are actually deprecated, so simply drop them from the
> example.

Applied to dt-bindings, thank you!

	Krzysztof

Re: [PATCH 1/2] dt-bindings: PCI: fsl,layerscape-pcie-ep: Drop deprecated windows

[Rob Herring]

On Fri, Mar 07, 2025 at 09:13:26AM +0100, Krzysztof Kozlowski wrote:
> The example DTS uses 'num-ib-windows' and 'num-ob-windows' properties
> but these are not defined in the binding.  Binding also does not
> reference snps,dw-pcie-common.yaml, probably because it is quite
> different even though the device is based on Synopsys controller.
> 
> The properties are actually deprecated, so simply drop them from the
> example.

How are we not getting warnings for them? That would be the bigger 
issue. "status" shouldn't matter.

> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml         | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
> index 399efa7364c9..1fdc899e7292 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
> @@ -94,8 +94,6 @@ examples:
>          reg-names = "regs", "addr_space";
>          interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>; /* PME interrupt */
>          interrupt-names = "pme";
> -        num-ib-windows = <6>;
> -        num-ob-windows = <8>;
>          status = "disabled";
>        };
>      };
> -- 
> 2.43.0
> 

Re: [PATCH 1/2] dt-bindings: PCI: fsl,layerscape-pcie-ep: Drop deprecated windows

[Krzysztof Kozlowski]

On 10/03/2025 13:53, Rob Herring wrote:
> On Fri, Mar 07, 2025 at 09:13:26AM +0100, Krzysztof Kozlowski wrote:
>> The example DTS uses 'num-ib-windows' and 'num-ob-windows' properties
>> but these are not defined in the binding.  Binding also does not
>> reference snps,dw-pcie-common.yaml, probably because it is quite
>> different even though the device is based on Synopsys controller.
>>
>> The properties are actually deprecated, so simply drop them from the
>> example.
> 
> How are we not getting warnings for them? That would be the bigger 
> issue. "status" shouldn't matter.
If I drop the status, then I see warnings, so the status seems to matter.

Best regards,
Krzysztof