From: Rob Herring <robh@kernel.org>
To: Pankit Garg <pankit.garg@nxp.com>
Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, conor+dt@kernel.org,
alexandre.belloni@bootlin.com, vikash.bansal@nxp.com,
priyanka.jain@nxp.com, daniel.aguirre@nxp.com,
shashank.rebbapragada@nxp.com, aman.kumarpandey@nxp.com
Subject: Re: [PATCH 1/2] dt-bindings: rtc: Add pcf85053a support
Date: Mon, 10 Mar 2025 08:00:44 -0500 [thread overview]
Message-ID: <20250310130044.GA3891357-robh@kernel.org> (raw)
In-Reply-To: <20250310063846.1867615-1-pankit.garg@nxp.com>
On Mon, Mar 10, 2025 at 12:08:45PM +0530, Pankit Garg wrote:
> Add device tree bindings for NXP PCF85053a RTC chip.
Looks fine, but this can be handled by trivial-rtc.yaml.
>
> Signed-off-by: Pankit Garg <pankit.garg@nxp.com>
> ---
> .../bindings/rtc/nxp,pcf85053a.yaml | 44 +++++++++++++++++++
> MAINTAINERS | 6 +++
> 2 files changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf85053a.yaml
>
> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf85053a.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf85053a.yaml
> new file mode 100644
> index 000000000000..177afbe128d4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf85053a.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright 2025 NXP
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/nxp,pcf85053a.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP PCF85053A Real Time Clock
> +
> +allOf:
> + - $ref: rtc.yaml#
> +
> +maintainers:
> + - Pankit Garg <pankit.garg@nxp.com>
> +
> +properties:
> + compatible:
> + enum:
> + - nxp,pcf85053a
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + rtc@6f {
> + compatible = "nxp,pcf85053a";
> + reg = <0x6f>;
> + };
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8e0736dc2ee0..21a05e169564 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -17158,6 +17158,12 @@ S: Maintained
> F: Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
> F: sound/soc/codecs/tfa989x.c
>
> +NXP RTC PCF85053A DRIVER
> +M: Pankit Garg<pankit.garg@nxp.com>
> +L: linux-kernel@vger.kernel.org
> +S: Maintained
> +F: Documentation/devicetree/bindings/rtc/nxp,pcf85053a.yaml
> +
> NZXT-KRAKEN2 HARDWARE MONITORING DRIVER
> M: Jonas Malaco <jonas@protocubo.io>
> L: linux-hwmon@vger.kernel.org
> --
> 2.25.1
>
next prev parent reply other threads:[~2025-03-10 13:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 6:38 [PATCH 1/2] dt-bindings: rtc: Add pcf85053a support Pankit Garg
2025-03-10 6:38 ` [PATCH 2/2] rtc: Add NXP PCF85053A driver support Pankit Garg
2025-03-10 13:00 ` Rob Herring [this message]
2025-04-16 6:57 ` [EXT] Re: [PATCH 1/2] dt-bindings: rtc: Add pcf85053a support Pankit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250310130044.GA3891357-robh@kernel.org \
--to=robh@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=aman.kumarpandey@nxp.com \
--cc=conor+dt@kernel.org \
--cc=daniel.aguirre@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=pankit.garg@nxp.com \
--cc=priyanka.jain@nxp.com \
--cc=shashank.rebbapragada@nxp.com \
--cc=vikash.bansal@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).