Re: [PATCH 2/4] dt-bindings: iio: adc: Add adi,ad4052

Jorge Marques
2025-03-09T20:26:07Z

> > +description: |
> > + Analog Devices AD4052 Single Channel Precision SAR ADC family
> > +
> > + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4050.pdf
> > + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4052.pdf
> It's this data sheet that I opened. Seems it describes things a bit
> different that you have here.
The power supplies were wrong, the correct ones are vdd, vio and vref
(optional).

> People have a nasty habit of wiring just one. So use
> interrupt-names and let them come in any order. The driver can require
> both or a specific one if it likes, but in future we may need to make it
> more flexible and the dt-binding should allow that.
Agreed.

> They seem to be GP0 and GP1 on datasheet and don't have fixed roles
> like this implies.

GP0 and GP1 can output data ready, chop (not implemented), device enabled,
interrupt (threshold) or a constant logic state.
In the driver implementation, one takes the role of threshold interrupt and the
other of data ready.

>
> > +
> > + cnv-gpios:
>
> Not the most self explanatory of names. I'd suggest a bit of help
> text for this one.
Noted.

> > + vdd-supply: true
> > + vdd_1_8-supply: true
> As per other thread, supplies like this normally required and this
> one at least doesn't seem to exist in the datasheet I randomly picked.
Fixed.