Re: [PATCH 4/4] iio: adc: add support for ad4052

Christophe JAILLET
2025-03-08T16:21:39Z

Le 06/03/2025 à 15:03, Jorge Marques a écrit :
> The AD4052/AD4058/AD4050/AD4056 are versatile, 16-bit/12-bit,
> successive approximation register (SAR) analog-to-digital converter (ADC)
> that enables low-power, high-density data acquisition solutions without
> sacrificing precision.
...

> +#define AD4052_CHAN(bits, grade) { \
> + .type = IIO_VOLTAGE, \
> + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_RAW) | \
> + BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO), \
> + .info_mask_shared_by_type_available = BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO), \

Nitpick: Unneeded extra space before BIT

> + .indexed = 1, \
> + .channel = 0, \
> + .event_spec = ad4052_events, \
> + .num_event_specs = ARRAY_SIZE(ad4052_events), \
> + .has_ext_scan_type = 1, \
> + .ext_scan_type = ad4052_scan_type_##bits##_s, \
> + .num_ext_scan_type = ARRAY_SIZE(ad4052_scan_type_##bits##_s), \
> + .ext_info = grade##_ext_info, \
> +}
> +
> +#define AD4052_OFFLOAD_CHAN(bits, grade) { \
> + .type = IIO_VOLTAGE, \
> + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_RAW) | \
> + BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO) | \
> + BIT(IIO_CHAN_INFO_SAMP_FREQ), \
> + .info_mask_shared_by_type_available = BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO), \

Nitpick: Unneeded extra space before BIT

> + .indexed = 1, \
> + .channel = 0, \
> + .event_spec = ad4052_events, \
> + .num_event_specs = ARRAY_SIZE(ad4052_events), \
> + .has_ext_scan_type = 1, \
> + .ext_scan_type = ad4052_scan_type_##bits##_s, \
> + .num_ext_scan_type = ARRAY_SIZE(ad4052_scan_type_##bits##_s), \
> + .ext_info = grade##_ext_info, \
> +}

...

> +static int ad4052_probe(struct spi_device *spi)
> +{
> + const struct ad4052_chip_info *chip;
> + struct device *dev = &spi->dev;
> + struct iio_dev *indio_dev;
> + struct ad4052_state *st;
> + int ret;
> + u8 buf;
> +
> + chip = spi_get_device_match_data(spi);
> + if (!chip)
> + return dev_err_probe(dev, -ENODEV,
> + "Could not find chip info data\n");
> +
> + indio_dev = devm_iio_device_alloc(dev, sizeof(*st));
> + if (!indio_dev)
> + return -ENOMEM;
> +
> + st = iio_priv(indio_dev);
> + st->spi = spi;
> + spi_set_drvdata(spi, st);
> + init_completion(&st->completion);
> +
> + st->regmap = devm_regmap_init_spi(spi, &ad4052_regmap_config);
> + if (IS_ERR(st->regmap))
> + return dev_err_probe(&spi->dev, PTR_ERR(st->regmap),

Nitpick: Unneeded extra space before PTR_ERR

> + "Failed to initialize regmap\n");
> +
> + st->mode = AD4052_SAMPLE_MODE;
> + st->wait_event = false;
> + st->chip = chip;

...

CJ