Re: [PATCH 2/4] dt-bindings: iio: adc: Add adi,ad4052

Jonathan Cameron
2025-03-08T15:06:05Z

> > + vdd-supply: true
> > + vdd_1_8-supply: true
>
> You're allowed to use . in property names, and the _s should be -s.
> That said, vdd and vdd 1.8? Shouldn't both have the voltage in them in
> that case?
I got curious and opened datasheet. Only seeing two supplies (vdd and vio)

So checked driver and that doesn't enable any of them.
>
> > + vio-supply: true
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > +
Supplies that are not actually optional (i.e. device can run without them)
should be in required list even though the regulator core will provide
stubs if they aren't in your dts. The aim is to reflect what should
be provided, not what Linux does with it.

Jonathan