Re: [PATCH] PCI: xilinx-cpm: Fix incorrect version check in init_port

Krzysztof Wilczyński
2025-03-11T07:27:38Z

Hello,

> Fix an incorrect conditional check in xilinx_cpm_pcie_init_port().
>
> The previous condition mistakenly skipped initialization for all
> versions except CPM5NC_HOST. This is now corrected to ensure that only
> the CPM5NC_HOST is skipped while other versions proceed with
> initialization.

[...]
> {
> const struct xilinx_cpm_variant *variant = port->variant;
>
> - if (variant->version != CPM5NC_HOST)
> + if (variant->version == CPM5NC_HOST)
> return;
>
> if (cpm_pcie_link_up(port))

Ouch! Nice catch.

I will pull and squash this against the existing code directly on the branch.

Thank you!

Krzysztof