From: Lee Jones <lee@kernel.org>
To: "Lu Tang (汤璐)" <Lu.Tang@mediatek.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Sean Wang" <sean.wang@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Stephen Boyd" <sboyd@kernel.org>,
"Chen Zhong (钟辰)" <Chen.Zhong@mediatek.com>,
"Sen Chu (储森)" <Sen.Chu@mediatek.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: 回复: [PATCH 3/5] pmic: mediatek: Add spmi pmic mfd driver
Date: Fri, 14 Mar 2025 09:47:31 +0000 [thread overview]
Message-ID: <20250314094731.GA3890718@google.com> (raw)
In-Reply-To: <SEZPR03MB6891D404A7AA2BC5244A992A80D22@SEZPR03MB6891.apcprd03.prod.outlook.com>
On Fri, 14 Mar 2025, Lu Tang (汤璐) wrote:
> Update email address
What is this?
Please refrain from top-posting.
> -----邮件原件-----
> 发件人: Lu.Tang <Lu.Tang@mediatek.com>
> 发送时间: 2025年3月14日 15:32
> 收件人: Jonathan Cameron <jic23@kernel.org>; Lars-Peter Clausen <lars@metafoo.de>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Dmitry Torokhov <dmitry.torokhov@gmail.com>; Lee Jones <lee@kernel.org>; Matthias Brugger <matthias.bgg@gmail.com>; AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>; Sean Wang <sean.wang@kernel.org>; Linus Walleij <linus.walleij@linaro.org>; Liam Girdwood <lgirdwood@gmail.com>; Mark Brown <broonie@kernel.org>; Stephen Boyd <sboyd@kernel.org>; Chen Zhong (钟辰) <Chen.Zhong@mediatek.com>; Sen Chu <shen.chu@mediatek.com>
> 抄送: linux-iio@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-input@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-mediatek@lists.infradead.org; linux-gpio@vger.kernel.org; Project_Global_Chrome_Upstream_Group <Project_Global_Chrome_Upstream_Group@mediatek.com>; Lu Tang (汤璐) <Lu.Tang@mediatek.com>
> 主题: [PATCH 3/5] pmic: mediatek: Add spmi pmic mfd driver
Fix your mailer. Headers have no place in the body of an email.
> From: "Lu.Tang" <lu.tang@mediatek.com>
>
> Add spmi pmic mfd driver for mt8196
7 words for a 900 line change is not going to fly.
What is this device? What does it provide? What are its dependencies?
Etc.
> Signed-off-by: Lu Tang <lu.tang@mediatek.com>
> ---
> drivers/mfd/Kconfig | 26 ++
> drivers/mfd/Makefile | 2 +
> drivers/mfd/mt6685-core.c | 83 +++++
> drivers/mfd/mtk-spmi-pmic.c | 518 +++++++++++++++++++++++++++
> include/linux/mfd/mt6363/core.h | 134 +++++++
> include/linux/mfd/mt6363/registers.h | 168 +++++++++
> include/linux/mfd/mt6373/core.h | 94 +++++
> include/linux/mfd/mt6373/registers.h | 53 +++
> 8 files changed, 1078 insertions(+)
> create mode 100644 drivers/mfd/mt6685-core.c create mode 100644 drivers/mfd/mtk-spmi-pmic.c create mode 100644 include/linux/mfd/mt6363/core.h create mode 100644 include/linux/mfd/mt6363/registers.h
> create mode 100644 include/linux/mfd/mt6373/core.h create mode 100644 include/linux/mfd/mt6373/registers.h
Please try again.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2025-03-14 9:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 7:32 [PATCH 0/5] Add PMIC and SPMI driver for mt8196 Lu.Tang
2025-03-14 7:32 ` [PATCH 1/5] pmic: mediatek: Add pmic auxadc driver Lu.Tang
2025-03-14 8:53 ` AngeloGioacchino Del Regno
2025-03-14 9:21 ` 回复: " Lu Tang (汤璐)
2025-03-14 12:15 ` Krzysztof Kozlowski
2025-03-14 9:04 ` Lu Tang (汤璐)
2025-03-15 12:50 ` Jonathan Cameron
2025-03-14 7:32 ` [PATCH 2/5] pmic: mediatek: Add pmic regulator driver Lu.Tang
2025-03-14 8:26 ` Chen-Yu Tsai
2025-03-14 9:02 ` 回复: " Lu Tang (汤璐)
2025-03-14 7:32 ` [PATCH 3/5] pmic: mediatek: Add spmi pmic mfd driver Lu.Tang
2025-03-14 9:01 ` 回复: " Lu Tang (汤璐)
2025-03-14 9:47 ` Lee Jones [this message]
2025-03-14 7:32 ` [PATCH 4/5] spmi: mediatek: modify spmi dirver for mt8196 Lu.Tang
2025-03-14 9:01 ` 回复: " Lu Tang (汤璐)
2025-03-14 7:32 ` [PATCH 5/5] dt-bindings: pmic: mediatek: Add pmic documents Lu.Tang
2025-03-14 8:25 ` Rob Herring (Arm)
2025-03-14 8:34 ` Chen-Yu Tsai
2025-03-14 9:01 ` 回复: " Lu Tang (汤璐)
2025-03-17 10:49 ` Krzysztof Kozlowski
2025-03-14 10:32 ` Krzysztof Kozlowski
2025-03-14 10:35 ` AngeloGioacchino Del Regno
2025-03-14 8:27 ` [PATCH 0/5] Add PMIC and SPMI driver for mt8196 Chen-Yu Tsai
2025-03-14 9:06 ` 回复: " Lu Tang (汤璐)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250314094731.GA3890718@google.com \
--to=lee@kernel.org \
--cc=Chen.Zhong@mediatek.com \
--cc=Lu.Tang@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Sen.Chu@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sean.wang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).