* [PATCH v2] dt-bindings: timer: Add SiFive CLINT2
@ 2025-03-14 8:12 Nick Hu
2025-03-14 23:25 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Nick Hu @ 2025-03-14 8:12 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Paul Walmsley, Samuel Holland, Palmer Dabbelt,
Anup Patel
Cc: Nick Hu, linux-kernel, devicetree, linux-riscv
Add compatible string and property for the SiFive CLINT v2.
Signed-off-by: Nick Hu <nick.hu@sifive.com>
Reviewed-by: Samuel Holland <samuel.holland@sifive.com>
---
- v2 changes:
- Don't allow sifive,clint2 by itself. Add '-{}' to the first entry
- Mark the sifive,fine-ctr-bits as the required property when
the compatible includes the sifive,clint2
.../bindings/timer/sifive,clint.yaml | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
index 76d83aea4e2b..4b9dad11c1e9 100644
--- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml
+++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
@@ -36,6 +36,10 @@ properties:
- starfive,jh7110-clint # StarFive JH7110
- starfive,jh8100-clint # StarFive JH8100
- const: sifive,clint0 # SiFive CLINT v0 IP block
+ - items:
+ - {}
+ - const: sifive,clint2 # SiFive CLINT v2 IP block
+ description: SiFive CLINT v2 is the HRT that supports the Zicntr
- items:
- enum:
- allwinner,sun20i-d1-clint
@@ -62,6 +66,22 @@ properties:
minItems: 1
maxItems: 4095
+ sifive,fine-ctr-bits:
+ maximum: 15
+ description: The width in bits of the fine counter.
+
+if:
+ properties:
+ compatible:
+ contains:
+ const: sifive,clint2
+then:
+ required:
+ - sifive,fine-ctr-bits
+else:
+ properties:
+ sifive,fine-ctr-bits: false
+
additionalProperties: false
required:
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: timer: Add SiFive CLINT2
2025-03-14 8:12 [PATCH v2] dt-bindings: timer: Add SiFive CLINT2 Nick Hu
@ 2025-03-14 23:25 ` Rob Herring
2025-03-17 2:36 ` Nick Hu
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2025-03-14 23:25 UTC (permalink / raw)
To: Nick Hu
Cc: Daniel Lezcano, Thomas Gleixner, Krzysztof Kozlowski,
Conor Dooley, Paul Walmsley, Samuel Holland, Palmer Dabbelt,
Anup Patel, linux-kernel, devicetree, linux-riscv
On Fri, Mar 14, 2025 at 04:12:54PM +0800, Nick Hu wrote:
> Add compatible string and property for the SiFive CLINT v2.
Conor asked about being backwards compatible with v1. Please say why it
isn't here.
>
> Signed-off-by: Nick Hu <nick.hu@sifive.com>
> Reviewed-by: Samuel Holland <samuel.holland@sifive.com>
> ---
> - v2 changes:
> - Don't allow sifive,clint2 by itself. Add '-{}' to the first entry
> - Mark the sifive,fine-ctr-bits as the required property when
> the compatible includes the sifive,clint2
>
> .../bindings/timer/sifive,clint.yaml | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> index 76d83aea4e2b..4b9dad11c1e9 100644
> --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> @@ -36,6 +36,10 @@ properties:
> - starfive,jh7110-clint # StarFive JH7110
> - starfive,jh8100-clint # StarFive JH8100
> - const: sifive,clint0 # SiFive CLINT v0 IP block
> + - items:
> + - {}
> + - const: sifive,clint2 # SiFive CLINT v2 IP block
> + description: SiFive CLINT v2 is the HRT that supports the Zicntr
> - items:
> - enum:
> - allwinner,sun20i-d1-clint
> @@ -62,6 +66,22 @@ properties:
> minItems: 1
> maxItems: 4095
>
> + sifive,fine-ctr-bits:
> + maximum: 15
> + description: The width in bits of the fine counter.
> +
> +if:
> + properties:
> + compatible:
> + contains:
> + const: sifive,clint2
> +then:
> + required:
> + - sifive,fine-ctr-bits
> +else:
> + properties:
> + sifive,fine-ctr-bits: false
> +
> additionalProperties: false
>
> required:
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: timer: Add SiFive CLINT2
2025-03-14 23:25 ` Rob Herring
@ 2025-03-17 2:36 ` Nick Hu
2025-03-18 16:07 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Nick Hu @ 2025-03-17 2:36 UTC (permalink / raw)
To: Rob Herring
Cc: Daniel Lezcano, Thomas Gleixner, Krzysztof Kozlowski,
Conor Dooley, Paul Walmsley, Samuel Holland, Palmer Dabbelt,
Anup Patel, linux-kernel, devicetree, linux-riscv
Hi Rob
Sorry, I thought I had replied to the mailing list, but it looks like
I only sent it to Conor.
The control of sifive,clint2 differs from that of sifive,clint0,
making them incompatible.
On Sat, Mar 15, 2025 at 7:25 AM Rob Herring <robh@kernel.org> wrote:
>
> On Fri, Mar 14, 2025 at 04:12:54PM +0800, Nick Hu wrote:
> > Add compatible string and property for the SiFive CLINT v2.
>
> Conor asked about being backwards compatible with v1. Please say why it
> isn't here.
>
> >
> > Signed-off-by: Nick Hu <nick.hu@sifive.com>
> > Reviewed-by: Samuel Holland <samuel.holland@sifive.com>
> > ---
> > - v2 changes:
> > - Don't allow sifive,clint2 by itself. Add '-{}' to the first entry
> > - Mark the sifive,fine-ctr-bits as the required property when
> > the compatible includes the sifive,clint2
> >
> > .../bindings/timer/sifive,clint.yaml | 20 +++++++++++++++++++
> > 1 file changed, 20 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> > index 76d83aea4e2b..4b9dad11c1e9 100644
> > --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> > +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> > @@ -36,6 +36,10 @@ properties:
> > - starfive,jh7110-clint # StarFive JH7110
> > - starfive,jh8100-clint # StarFive JH8100
> > - const: sifive,clint0 # SiFive CLINT v0 IP block
> > + - items:
> > + - {}
> > + - const: sifive,clint2 # SiFive CLINT v2 IP block
> > + description: SiFive CLINT v2 is the HRT that supports the Zicntr
> > - items:
> > - enum:
> > - allwinner,sun20i-d1-clint
> > @@ -62,6 +66,22 @@ properties:
> > minItems: 1
> > maxItems: 4095
> >
> > + sifive,fine-ctr-bits:
> > + maximum: 15
> > + description: The width in bits of the fine counter.
> > +
> > +if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: sifive,clint2
> > +then:
> > + required:
> > + - sifive,fine-ctr-bits
> > +else:
> > + properties:
> > + sifive,fine-ctr-bits: false
> > +
> > additionalProperties: false
> >
> > required:
> > --
> > 2.17.1
> >
Best Regards,
Nick
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: timer: Add SiFive CLINT2
2025-03-17 2:36 ` Nick Hu
@ 2025-03-18 16:07 ` Rob Herring
2025-03-19 1:47 ` Nick Hu
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2025-03-18 16:07 UTC (permalink / raw)
To: Nick Hu
Cc: Daniel Lezcano, Thomas Gleixner, Krzysztof Kozlowski,
Conor Dooley, Paul Walmsley, Samuel Holland, Palmer Dabbelt,
Anup Patel, linux-kernel, devicetree, linux-riscv
On Sun, Mar 16, 2025 at 9:36 PM Nick Hu <nick.hu@sifive.com> wrote:
>
> Hi Rob
Please don't top post.
> Sorry, I thought I had replied to the mailing list, but it looks like
> I only sent it to Conor.
>
> The control of sifive,clint2 differs from that of sifive,clint0,
> making them incompatible.
The answer belongs in the patch, not just in a reply. Assume we've
forgotten everything said in the prior version because we likely have,
so you don't want to get the same questions again.
>
> On Sat, Mar 15, 2025 at 7:25 AM Rob Herring <robh@kernel.org> wrote:
> >
> > On Fri, Mar 14, 2025 at 04:12:54PM +0800, Nick Hu wrote:
> > > Add compatible string and property for the SiFive CLINT v2.
> >
> > Conor asked about being backwards compatible with v1. Please say why it
> > isn't here.
> >
> > >
> > > Signed-off-by: Nick Hu <nick.hu@sifive.com>
> > > Reviewed-by: Samuel Holland <samuel.holland@sifive.com>
> > > ---
> > > - v2 changes:
> > > - Don't allow sifive,clint2 by itself. Add '-{}' to the first entry
> > > - Mark the sifive,fine-ctr-bits as the required property when
> > > the compatible includes the sifive,clint2
> > >
> > > .../bindings/timer/sifive,clint.yaml | 20 +++++++++++++++++++
> > > 1 file changed, 20 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> > > index 76d83aea4e2b..4b9dad11c1e9 100644
> > > --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> > > +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> > > @@ -36,6 +36,10 @@ properties:
> > > - starfive,jh7110-clint # StarFive JH7110
> > > - starfive,jh8100-clint # StarFive JH8100
> > > - const: sifive,clint0 # SiFive CLINT v0 IP block
> > > + - items:
> > > + - {}
> > > + - const: sifive,clint2 # SiFive CLINT v2 IP block
> > > + description: SiFive CLINT v2 is the HRT that supports the Zicntr
> > > - items:
> > > - enum:
> > > - allwinner,sun20i-d1-clint
> > > @@ -62,6 +66,22 @@ properties:
> > > minItems: 1
> > > maxItems: 4095
> > >
> > > + sifive,fine-ctr-bits:
> > > + maximum: 15
> > > + description: The width in bits of the fine counter.
> > > +
> > > +if:
> > > + properties:
> > > + compatible:
> > > + contains:
> > > + const: sifive,clint2
> > > +then:
> > > + required:
> > > + - sifive,fine-ctr-bits
> > > +else:
> > > + properties:
> > > + sifive,fine-ctr-bits: false
> > > +
> > > additionalProperties: false
> > >
> > > required:
> > > --
> > > 2.17.1
> > >
>
> Best Regards,
> Nick
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: timer: Add SiFive CLINT2
2025-03-18 16:07 ` Rob Herring
@ 2025-03-19 1:47 ` Nick Hu
0 siblings, 0 replies; 5+ messages in thread
From: Nick Hu @ 2025-03-19 1:47 UTC (permalink / raw)
To: Rob Herring
Cc: Daniel Lezcano, Thomas Gleixner, Krzysztof Kozlowski,
Conor Dooley, Paul Walmsley, Samuel Holland, Palmer Dabbelt,
Anup Patel, linux-kernel, devicetree, linux-riscv
Hi Rob
On Wed, Mar 19, 2025 at 12:07 AM Rob Herring <robh@kernel.org> wrote:
>
> On Sun, Mar 16, 2025 at 9:36 PM Nick Hu <nick.hu@sifive.com> wrote:
> >
> > Hi Rob
>
> Please don't top post.
>
> > Sorry, I thought I had replied to the mailing list, but it looks like
> > I only sent it to Conor.
> >
> > The control of sifive,clint2 differs from that of sifive,clint0,
> > making them incompatible.
>
> The answer belongs in the patch, not just in a reply. Assume we've
> forgotten everything said in the prior version because we likely have,
> so you don't want to get the same questions again.
>
Sure, I can include a description in the patch. I'll make the update
in the next version.
> >
> > On Sat, Mar 15, 2025 at 7:25 AM Rob Herring <robh@kernel.org> wrote:
> > >
> > > On Fri, Mar 14, 2025 at 04:12:54PM +0800, Nick Hu wrote:
> > > > Add compatible string and property for the SiFive CLINT v2.
> > >
> > > Conor asked about being backwards compatible with v1. Please say why it
> > > isn't here.
> > >
> > > >
> > > > Signed-off-by: Nick Hu <nick.hu@sifive.com>
> > > > Reviewed-by: Samuel Holland <samuel.holland@sifive.com>
> > > > ---
> > > > - v2 changes:
> > > > - Don't allow sifive,clint2 by itself. Add '-{}' to the first entry
> > > > - Mark the sifive,fine-ctr-bits as the required property when
> > > > the compatible includes the sifive,clint2
> > > >
> > > > .../bindings/timer/sifive,clint.yaml | 20 +++++++++++++++++++
> > > > 1 file changed, 20 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> > > > index 76d83aea4e2b..4b9dad11c1e9 100644
> > > > --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> > > > +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> > > > @@ -36,6 +36,10 @@ properties:
> > > > - starfive,jh7110-clint # StarFive JH7110
> > > > - starfive,jh8100-clint # StarFive JH8100
> > > > - const: sifive,clint0 # SiFive CLINT v0 IP block
> > > > + - items:
> > > > + - {}
> > > > + - const: sifive,clint2 # SiFive CLINT v2 IP block
> > > > + description: SiFive CLINT v2 is the HRT that supports the Zicntr
> > > > - items:
> > > > - enum:
> > > > - allwinner,sun20i-d1-clint
> > > > @@ -62,6 +66,22 @@ properties:
> > > > minItems: 1
> > > > maxItems: 4095
> > > >
> > > > + sifive,fine-ctr-bits:
> > > > + maximum: 15
> > > > + description: The width in bits of the fine counter.
> > > > +
> > > > +if:
> > > > + properties:
> > > > + compatible:
> > > > + contains:
> > > > + const: sifive,clint2
> > > > +then:
> > > > + required:
> > > > + - sifive,fine-ctr-bits
> > > > +else:
> > > > + properties:
> > > > + sifive,fine-ctr-bits: false
> > > > +
> > > > additionalProperties: false
> > > >
> > > > required:
> > > > --
> > > > 2.17.1
> > > >
> >
> > Best Regards,
> > Nick
> >
Best Regards,
Nick
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-03-19 1:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-14 8:12 [PATCH v2] dt-bindings: timer: Add SiFive CLINT2 Nick Hu
2025-03-14 23:25 ` Rob Herring
2025-03-17 2:36 ` Nick Hu
2025-03-18 16:07 ` Rob Herring
2025-03-19 1:47 ` Nick Hu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).