[PATCH] dt-bindings: rtc: pcf2127: Reference spi-peripheral-props.yaml

[PATCH] dt-bindings: rtc: pcf2127: Reference spi-peripheral-props.yaml

[Fabio Estevam]

From: Fabio Estevam <festevam@denx.de>

Currently, when the 'spi-max-frequency' property is passed, the following
dt-schema warning is seen:

'spi-max-frequency' does not match any of the regexes: 'pinctrl-[0-9]+'

Fix it by adding a reference to spi-peripheral-props.yaml and change
it to use 'unevaluatedProperties: false'.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
index 2d9fe5a75b06..11fcf0ca1ae0 100644
--- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
+++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
@@ -8,6 +8,7 @@ title: NXP PCF2127 Real Time Clock
 
 allOf:
   - $ref: rtc.yaml#
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
 
 maintainers:
   - Alexandre Belloni <alexandre.belloni@bootlin.com>
@@ -34,7 +35,7 @@ required:
   - compatible
   - reg
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
-- 
2.34.1

Re: [PATCH] dt-bindings: rtc: pcf2127: Reference spi-peripheral-props.yaml

[Krzysztof Kozlowski]

On Sat, Mar 15, 2025 at 09:41:50AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Currently, when the 'spi-max-frequency' property is passed, the following
> dt-schema warning is seen:
> 
> 'spi-max-frequency' does not match any of the regexes: 'pinctrl-[0-9]+'

Is this real or imaginary error? If imaginary, then do not include it
because it just confuses.

Otherwise: which Makefile target in upstream has this error?

> 
> Fix it by adding a reference to spi-peripheral-props.yaml and change
> it to use 'unevaluatedProperties: false'.

You wrote 7 lines for something as simple as saying this is a SPI
device thus its binding should reference SPI device properties. Please
write concise and accurate commit msgs.

Best regards,
Krzysztof