Re: [PATCH v2 0/3] iio:light: add driver for veml6046x00 RGBIR color sensor

Jonathan Cameron
2025-03-17T12:01:05Z

On Sun, 16 Mar 2025 17:48:10 +0100
Andreas Klinger <ak@it-klinger.de> wrote:

> This patchset adds an IIO driver for Vishay veml6046x00 RGBIR color sensor
>
Ah. As a general rule don't send a v2 out that fast - leave
it at least a few days even if there is an 'obvious fix'.
A rush can make sense if we are trying to sneak it in very late
in a kernel cycle, but right now we are right at the start of the next
one so lots of time.

Anyhow, comments on v1 probably still apply ;)

Jonathan

> Changes in v2:
> - fix missing include for example in vishay,veml6046x00.yaml
>
> Andreas Klinger (3):
> dt-bindings: iio: light: veml6046x00: add color sensor
> iio: light: add support for veml6046x00 RGBIR color sensor
> MAINTAINER: add maintainer for veml6046x00
>
> .../iio/light/vishay,veml6046x00.yaml | 51 +
> MAINTAINERS | 6 +
> drivers/iio/light/Kconfig | 13 +
> drivers/iio/light/Makefile | 1 +
> drivers/iio/light/veml6046x00.c | 890 ++++++++++++++++++
> 5 files changed, 961 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/light/vishay,veml6046x00.yaml
> create mode 100644 drivers/iio/light/veml6046x00.c
>