* [PATCH] ARM: dts: qcom-msm8960: add missing clocks to the timer node
@ 2025-03-19 5:10 Rudraksha Gupta
2025-03-19 10:03 ` Dmitry Baryshkov
2025-05-14 21:03 ` Bjorn Andersson
0 siblings, 2 replies; 4+ messages in thread
From: Rudraksha Gupta @ 2025-03-19 5:10 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Rudraksha Gupta
In order to fix DT schema warning and describe hardware properly, add
missing sleep clock to the timer node.
Solved by Dmitry Baryshkov on the APQ8064 SoC
Link: https://lore.kernel.org/all/20250318-fix-nexus-4-v2-6-bcedd1406790@oss.qualcomm.com/
Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
---
Running the following no longer returns any errors:
make ARCH=arm CHECK_DTBS=y qcom/qcom-msm8960-cdp.dtb
make ARCH=arm CHECK_DTBS=y qcom/qcom-msm8960-samsung-expressatt.dtb
---
arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
index 865fe7cc3951..06b3fa5e1acf 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
@@ -112,6 +112,8 @@ timer@200a000 {
<GIC_PPI 3 0x301>;
reg = <0x0200a000 0x100>;
clock-frequency = <27000000>;
+ clocks = <&sleep_clk>;
+ clock-names = "sleep";
cpu-offset = <0x80000>;
};
---
base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04
change-id: 20250318-expressatt-solve-dts-errors-359f9d91c86c
Best regards,
--
Rudraksha Gupta <guptarud@gmail.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: qcom-msm8960: add missing clocks to the timer node
2025-03-19 5:10 [PATCH] ARM: dts: qcom-msm8960: add missing clocks to the timer node Rudraksha Gupta
@ 2025-03-19 10:03 ` Dmitry Baryshkov
2025-05-14 21:03 ` Bjorn Andersson
1 sibling, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-03-19 10:03 UTC (permalink / raw)
To: Rudraksha Gupta
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
On Tue, Mar 18, 2025 at 10:10:47PM -0700, Rudraksha Gupta wrote:
> In order to fix DT schema warning and describe hardware properly, add
> missing sleep clock to the timer node.
>
> Solved by Dmitry Baryshkov on the APQ8064 SoC
> Link: https://lore.kernel.org/all/20250318-fix-nexus-4-v2-6-bcedd1406790@oss.qualcomm.com/
>
> Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
> ---
> Running the following no longer returns any errors:
> make ARCH=arm CHECK_DTBS=y qcom/qcom-msm8960-cdp.dtb
> make ARCH=arm CHECK_DTBS=y qcom/qcom-msm8960-samsung-expressatt.dtb
> ---
> arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: qcom-msm8960: add missing clocks to the timer node
[not found] <20250318-expressatt-solve-dts-errors-v1-1-f103da6476ba@gmail.com>
@ 2025-03-20 2:27 ` Rudraksha Gupta
0 siblings, 0 replies; 4+ messages in thread
From: Rudraksha Gupta @ 2025-03-20 2:27 UTC (permalink / raw)
To: Rob Herring
Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio,
Bjorn Andersson, Krzysztof Kozlowski, Conor Dooley
> ---
> Running the following no longer returns any errors:
> make ARCH=arm CHECK_DTBS=y qcom/qcom-msm8960-cdp.dtb
> make ARCH=arm CHECK_DTBS=y qcom/qcom-msm8960-samsung-expressatt.dtb
> ---
Hello Rob,
Why does running the above two commands always returns 0, even if there
is an error within the dt? Is there a historical reason, or has it just
not been implemented?
Now that these no longer return errors, I would like to use it within my
development process.
Thanks,
Rudraksha
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: qcom-msm8960: add missing clocks to the timer node
2025-03-19 5:10 [PATCH] ARM: dts: qcom-msm8960: add missing clocks to the timer node Rudraksha Gupta
2025-03-19 10:03 ` Dmitry Baryshkov
@ 2025-05-14 21:03 ` Bjorn Andersson
1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2025-05-14 21:03 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Rudraksha Gupta
Cc: linux-arm-msm, devicetree, linux-kernel
On Tue, 18 Mar 2025 22:10:47 -0700, Rudraksha Gupta wrote:
> In order to fix DT schema warning and describe hardware properly, add
> missing sleep clock to the timer node.
>
> Solved by Dmitry Baryshkov on the APQ8064 SoC
> Link: https://lore.kernel.org/all/20250318-fix-nexus-4-v2-6-bcedd1406790@oss.qualcomm.com/
>
>
> [...]
Applied, thanks!
[1/1] ARM: dts: qcom-msm8960: add missing clocks to the timer node
commit: b81dcdad43daf10f79ae149826fff9e467b95e8b
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-14 21:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-19 5:10 [PATCH] ARM: dts: qcom-msm8960: add missing clocks to the timer node Rudraksha Gupta
2025-03-19 10:03 ` Dmitry Baryshkov
2025-05-14 21:03 ` Bjorn Andersson
[not found] <20250318-expressatt-solve-dts-errors-v1-1-f103da6476ba@gmail.com>
2025-03-20 2:27 ` Rudraksha Gupta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox