From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Ziyue Zhang <quic_ziyuzhan@quicinc.com>
Cc: bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
vkoul@kernel.org, kishon@kernel.org, andersson@kernel.org,
konradybcio@kernel.org, dmitry.baryshkov@linaro.org,
neil.armstrong@linaro.org, abel.vesa@linaro.org,
quic_qianyu@quicinc.com, quic_krichai@quicinc.com,
johan+linaro@kernel.org, linux-arm-msm@vger.kernel.org,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org
Subject: Re: [PATCH v4 4/8] PCI: qcom: Add QCS8300 PCIe support
Date: Tue, 18 Mar 2025 11:08:36 +0530 [thread overview]
Message-ID: <20250318053836.tievnd5ohzl7bmox@thinkpad> (raw)
In-Reply-To: <20250310063103.3924525-5-quic_ziyuzhan@quicinc.com>
On Mon, Mar 10, 2025 at 02:30:59PM +0800, Ziyue Zhang wrote:
> Add support for QCS8300 SoC that uses controller version 5.90 so reusing
> the 1.34.0 config.
This is not a valid argument. You should mention that the controller is of
version <Qcom IP version>, but compatible with version 1.34.0 controllers and
hence reusing that ops.
5.90 is the synopsys IP version, not Qcom one. You should mention both.
>
Please add more info about the controller like link speed, max lane count,
etc...
Moreover, cfg_1_34_0 has the 'override_no_snoop' bit set to override read/write
no snoop attributes. Are they applicable to this controller also?
- Mani
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2025-03-18 5:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 6:30 [PATCH v4 0/8] pci: qcom: Add QCS8300 PCIe support Ziyue Zhang
2025-03-10 6:30 ` [PATCH v4 1/8] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Document the QCS8300 QMP PCIe PHY Gen4 x2 Ziyue Zhang
2025-03-10 6:30 ` [PATCH v4 2/8] phy: qcom-qmp-pcie: add dual lane PHY support for QCS8300 Ziyue Zhang
2025-03-10 6:30 ` [PATCH v4 3/8] dt-bindings: PCI: qcom,pcie-sa8775p: document qcs8300 Ziyue Zhang
2025-03-18 5:41 ` Manivannan Sadhasivam
2025-03-10 6:30 ` [PATCH v4 4/8] PCI: qcom: Add QCS8300 PCIe support Ziyue Zhang
2025-03-18 5:38 ` Manivannan Sadhasivam [this message]
2025-03-10 6:31 ` [PATCH v4 5/8] arm64: dts: qcom: qcs8300: enable pcie0 Ziyue Zhang
2025-03-18 5:40 ` Manivannan Sadhasivam
2025-03-10 6:31 ` [PATCH v4 6/8] arm64: dts: qcom: qcs8300: enable pcie0 interface Ziyue Zhang
2025-03-10 20:25 ` Dmitry Baryshkov
2025-03-18 5:42 ` Manivannan Sadhasivam
2025-03-10 6:31 ` [PATCH v4 7/8] arm64: dts: qcom: qcs8300: enable pcie1 Ziyue Zhang
2025-03-18 5:42 ` Manivannan Sadhasivam
2025-03-10 6:31 ` [PATCH v4 8/8] arm64: dts: qcom: qcs8300: enable pcie1 interface Ziyue Zhang
2025-03-10 14:36 ` [PATCH v4 0/8] pci: qcom: Add QCS8300 PCIe support Rob Herring (Arm)
2025-03-11 11:47 ` (subset) " Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250318053836.tievnd5ohzl7bmox@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=kishon@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_krichai@quicinc.com \
--cc=quic_qianyu@quicinc.com \
--cc=quic_ziyuzhan@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox