Re: [PATCH 1/7] dt-bindings: media: renesas,isp: Add ISP core function block

["Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>]

On 2025-03-18 08:29:17 +0100, Krzysztof Kozlowski wrote:
> On 17/03/2025 20:44, Niklas Söderlund wrote:
> >>> Ahh I see. But I would like to have names if possible.
> >>>
> >>> The driver is backward compatible with the old bindings, and going
> >>> forward we have better bindings with names. All users are updated in the
> >>> next commits in this series so the warnings will go way rather quickly.
> >>
> >> Note that the driver does not _have_ to obtain the "cs" clock by name,
> >> as it will always be the first clock anyway ("make dtbs_check" will
> >> sort-of enforce that).  So you can simplify the code by obtaining
> >> the first clock without specifying a name, and the second (optional)
> >> clock with a name.
> > 
> > I understand that, and for this fix this would be acceptable. I'm just 
> > trying to think a head, something I should have done when first writing 
> > these bindings...
> > 
> > I'm fearing a scenario where we will need to add a 3rd reg region or 
> > clock. I don't think we will need that for the compatible values we have 
> 
> Bindings should be complete, so add 3rd clock now.
> 
> If you need to add it later, what's the problem? The position or order
> is strictly fixed, so at 3rd place you will always have new foo-clock.

I agree, bindings should be complete. But it's hard to create complete 
bindings from incomplete documentation. There is no 3rd clock or memory 
region that can be added now, at lest not one in the documentation I 
have access too. I was only trying to make the point that I do want to 
add *-names properties now and not only depend on argument position.

Sorry if I have misunderstood you.

> 
> > here, but then I never though we get the documentation that now allows 
> > us to describe the second region...
> Best regards,
> Krzysztof

-- 
Kind Regards,
Niklas Söderlund