From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sergio Perez <sergio@pereznus.es>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
Tomasz Duszynski <tduszyns@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: iio: light: bh1750: Add reset-gpios property
Date: Wed, 19 Mar 2025 09:42:32 +0100 [thread overview]
Message-ID: <20250319-elated-illegal-griffin-4ff0aa@krzk-bin> (raw)
In-Reply-To: <20250318194624.7626-1-sergio@pereznus.es>
On Tue, Mar 18, 2025 at 08:45:54PM +0100, Sergio Perez wrote:
Your threading is completely broken.
Read my last message - I gave you clear instructions which you did not
follow. Why?
>
> + reset-gpios:
> + description: GPIO connected to the sensor's reset line (active low)
"Active low reset line". No point to say that GPIO is a "GPIO connected
to the...", because it cannot be anything else.
> + maxItems: 1
> +
> required:
> - compatible
> - reg
> @@ -39,6 +43,7 @@ examples:
> light-sensor@23 {
> compatible = "rohm,bh1750";
> reg = <0x23>;
> + reset-gpios = <&gpio2 17 0>;
1. Include header and use proper defines
2. And then you will see that it is not active low, like you claim in
description...
> };
> };
>
> --
> 2.43.0
>
prev parent reply other threads:[~2025-03-19 8:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 19:45 [PATCH v4 1/2] dt-bindings: iio: light: bh1750: Add reset-gpios property Sergio Perez
2025-03-19 8:42 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250319-elated-illegal-griffin-4ff0aa@krzk-bin \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sergio@pereznus.es \
--cc=tduszyns@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox