From: Francesco Dolcini <francesco@dolcini.it>
To: Rob Herring <robh@kernel.org>,
Quentin Schulz <quentin.schulz@cherry.de>,
Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <jdelvare@suse.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Farouk Bouabid <farouk.bouabid@cherry.de>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Francesco Dolcini <francesco@dolcini.it>
Subject: Re: [PATCH v2 1/2] dt-bindings: hwmon: amc6821: add PWM polarity
Date: Wed, 19 Mar 2025 11:12:28 +0100 [thread overview]
Message-ID: <20250319101228.GA17979@francesco-nb> (raw)
In-Reply-To: <20250226135806.GA47264@francesco-nb>
Hello Rob and all,
On Wed, Feb 26, 2025 at 02:58:06PM +0100, Francesco Dolcini wrote:
> On Wed, Feb 26, 2025 at 07:49:22AM -0600, Rob Herring wrote:
> > On Mon, Feb 24, 2025 at 07:08:00PM +0100, Francesco Dolcini wrote:
> > > From: Francesco Dolcini <francesco.dolcini@toradex.com>
> > >
> > > Add property to describe the PWM-Out pin polarity.
> >
> > Why doesn't the invert support in the pwm binding work for you? Yes, I
> > read the discussion, but don't remember the conclusion and you need to
> > justify it here.
>
> This chip is not a PWM controller, it is a FAN controller.
>
> The HW has a PWM pin output that is used to control the fan, but the
> device is not modelled as a PWM controller (correctly, given that is not
> such a device) and the OS does not control the PWM, the chip reads the
> temperature and decide the PWM duty cycle accordingly in an autonomous
> way.
Can you advise on how to move this forward? Is my explanation good
enough or some more clarification is needed? Should I send a v3
incorporating such a comment into the commit message? Anything else?
Thanks,
Francesco
next prev parent reply other threads:[~2025-03-19 10:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 18:07 [PATCH v2 0/2] hwmon: (amc6821) Add PWM polarity configuration with OF Francesco Dolcini
2025-02-24 18:08 ` [PATCH v2 1/2] dt-bindings: hwmon: amc6821: add PWM polarity Francesco Dolcini
2025-02-26 13:49 ` Rob Herring
2025-02-26 13:58 ` Francesco Dolcini
2025-03-19 10:12 ` Francesco Dolcini [this message]
2025-03-19 13:44 ` Guenter Roeck
2025-02-24 18:08 ` [PATCH v2 2/2] hwmon: (amc6821) Add PWM polarity configuration with OF Francesco Dolcini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250319101228.GA17979@francesco-nb \
--to=francesco@dolcini.it \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=farouk.bouabid@cherry.de \
--cc=francesco.dolcini@toradex.com \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=quentin.schulz@cherry.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox