Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
	 Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	andersson@kernel.org, lgirdwood@gmail.com, robh@kernel.org,
	 krzk+dt@kernel.org, conor+dt@kernel.org, konradybcio@kernel.org,
	perex@perex.cz,  tiwai@suse.com, dmitry.baryshkov@linaro.org,
	linux-sound@vger.kernel.org,  linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	 johan+linaro@kernel.org
Subject: Re: [PATCH 1/3] ASoC: dt-bindings: wcd93xx: add bindings for audio switch controlling hp
Date: Thu, 20 Mar 2025 10:31:25 +0100	[thread overview]
Message-ID: <20250320-feathered-super-walrus-8eeef8@krzk-bin> (raw)
In-Reply-To: <938cb09f-3fb1-4daf-802d-2d95222f30db@linaro.org>

On Wed, Mar 19, 2025 at 06:00:51PM +0000, Srinivas Kandagatla wrote:
> 
> 
> On 19/03/2025 16:03, Mark Brown wrote:
> > On Wed, Mar 19, 2025 at 03:59:23PM +0000, Srinivas Kandagatla wrote:
> > > On 19/03/2025 10:01, Dmitry Baryshkov wrote:
> > 
> > > > Is this regulator supplying the codec or some external component? In the
> > > > latter case it's likely that it should not be a part of WCD bindings.
> > 
> > > This is regulator powering a mux that is driven by gpio which is part of
> > > codec binding. So I would assume this will fall into the codec.
> > 
> > > Where would we fit this if not part of codec?
> > 
> > > Unless we mark this regulator as always on.
> > 
> > I would expect that the mux would appear in the DT and consume both the
> > GPIO and the regulator.
> Yes, its doable, so we would endup with a mux driver consuming regulator and
> gpio and move the gpio handling in codec to move to use mux control.
> 
> Let met try that and see how it looks like.

Looking at schematics this is clearly not a supply of a codec, but as
Dmitry said, separate switch. Actually two switches.

Best regards,
Krzysztof


  reply	other threads:[~2025-03-20  9:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-19  9:16 [PATCH 0/3] ASoC: wcd938x: enable t14s audio headset srinivas.kandagatla
2025-03-19  9:16 ` [PATCH 1/3] ASoC: dt-bindings: wcd93xx: add bindings for audio switch controlling hp srinivas.kandagatla
2025-03-19 10:01   ` Dmitry Baryshkov
2025-03-19 15:59     ` Srinivas Kandagatla
2025-03-19 16:03       ` Mark Brown
2025-03-19 18:00         ` Srinivas Kandagatla
2025-03-20  9:31           ` Krzysztof Kozlowski [this message]
2025-03-20 10:51             ` Srinivas Kandagatla
2025-03-19  9:16 ` [PATCH 2/3] ASoC: codecs: wcd938x: add support power on hp audio switch srinivas.kandagatla
2025-03-19  9:16 ` [PATCH 3/3] arm64: dts: qcom: x1e78100-t14s: Enable audio headset support srinivas.kandagatla
2025-03-20  9:29   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250320-feathered-super-walrus-8eeef8@krzk-bin \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=johan+linaro@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox