* [PATCH v3 0/3] leds: add new LED driver for TI LP5812
@ 2025-03-06 17:21 Nam Tran
2025-03-06 17:21 ` [PATCH v3 1/3] dt-bindings: leds: Add LP5812 LED driver Nam Tran
` (2 more replies)
0 siblings, 3 replies; 26+ messages in thread
From: Nam Tran @ 2025-03-06 17:21 UTC (permalink / raw)
To: pavel, lee, krzk+dt, robh, conor+dt; +Cc: devicetree, linux-leds, linux-kernel
From: Nam Tran <trannamatk@gmail.com>
To: Pavel Machek <pavel@kernel.org>, Lee Jones <lee@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
This patch series adds support for the Texas Instruments LP5812 LED driver.
Patch 1 adds the Device Tree (DT) bindings documentation.
Patch 2 adds the LP5812 device tree node for Raspberry Pi 4B.
Patch 3 introduces the core driver implementation.
This driver has been tested on Raspberry Pi 4 B using kernel version 6.14.0-rc5.
I kindly request feedback from the community to ensure that this driver adheres to the Linux LED subsystem standards.
Thank you for your consideration.
Best regards,
Nam
---
Changes in v3:
- Addressed review comments from v2.
- Split the patches properly (DTS separated).
- Updated DTS example based on reviewer feedback.
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH v3 1/3] dt-bindings: leds: Add LP5812 LED driver
2025-03-06 17:21 [PATCH v3 0/3] leds: add new LED driver for TI LP5812 Nam Tran
@ 2025-03-06 17:21 ` Nam Tran
2025-03-07 8:42 ` Krzysztof Kozlowski
2025-03-18 13:56 ` Nam Tran
2025-03-06 17:21 ` [PATCH v3 2/3] arm64: dts: Add LP5812 LED node for Raspberry Pi 4 Model B Nam Tran
2025-03-06 17:21 ` [PATCH v3 3/3] leds: add new LED driver for TI LP5812 Nam Tran
2 siblings, 2 replies; 26+ messages in thread
From: Nam Tran @ 2025-03-06 17:21 UTC (permalink / raw)
To: pavel, lee, krzk+dt, robh, conor+dt
Cc: devicetree, linux-leds, linux-kernel, Nam Tran
This documentation ensures proper integration of the LP5812
in Device Tree-based systems.
Signed-off-by: Nam Tran <trannamatk@gmail.com>
---
.../devicetree/bindings/leds/ti,lp5812.yaml | 50 +++++++++++++++++++
MAINTAINERS | 6 +++
2 files changed, 56 insertions(+)
create mode 100644 Documentation/devicetree/bindings/leds/ti,lp5812.yaml
diff --git a/Documentation/devicetree/bindings/leds/ti,lp5812.yaml b/Documentation/devicetree/bindings/leds/ti,lp5812.yaml
new file mode 100644
index 000000000000..9a203da4f272
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/ti,lp5812.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/ti,lp5812.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+$ref: /schemas/leds/common.yaml#
+
+title: Linux driver for LP5812 LED from Texas Instruments
+
+maintainers:
+ - Nam Tran <trannamatk@gmail.com>
+
+description: |
+ The LP5812 is an I2C LED Driver that can support LED matrix 4x3.
+ For more product information please see the link below:
+ https://www.ti.com/product/LP5812#tech-docs
+
+properties:
+ compatible:
+ const: ti,lp5812
+
+ reg:
+ maxItems: 1
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ led-controller@1b {
+ compatible = "ti,lp5812";
+ reg = <0x1b>;
+ };
+ };
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 8e0736dc2ee0..2bd9f5132cab 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -23506,6 +23506,12 @@ S: Maintained
F: Documentation/devicetree/bindings/leds/backlight/ti,lp8864.yaml
F: drivers/leds/leds-lp8864.c
+TEXAS INSTRUMENTS' LP5812 LED DRIVER
+M: Nam Tran <trannamatk@gmail.com>
+L: linux-leds@vger.kernel.org
+S: Maintained
+F: Documentation/devicetree/bindings/leds/ti,lp5812.yaml
+
TEXAS INSTRUMENTS' SYSTEM CONTROL INTERFACE (TISCI) PROTOCOL DRIVER
M: Nishanth Menon <nm@ti.com>
M: Tero Kristo <kristo@kernel.org>
base-commit: 48a5eed9ad584315c30ed35204510536235ce402
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH v3 2/3] arm64: dts: Add LP5812 LED node for Raspberry Pi 4 Model B
2025-03-06 17:21 [PATCH v3 0/3] leds: add new LED driver for TI LP5812 Nam Tran
2025-03-06 17:21 ` [PATCH v3 1/3] dt-bindings: leds: Add LP5812 LED driver Nam Tran
@ 2025-03-06 17:21 ` Nam Tran
2025-03-07 8:42 ` Krzysztof Kozlowski
2025-03-07 8:43 ` Krzysztof Kozlowski
2025-03-06 17:21 ` [PATCH v3 3/3] leds: add new LED driver for TI LP5812 Nam Tran
2 siblings, 2 replies; 26+ messages in thread
From: Nam Tran @ 2025-03-06 17:21 UTC (permalink / raw)
To: pavel, lee, krzk+dt, robh, conor+dt
Cc: devicetree, linux-leds, linux-kernel, Nam Tran
Add the LP5812 LED driver node to the Device Tree for Raspberry Pi 4 B.
This enables the LED connected to the LP5812 to be controlled via I2C.
Signed-off-by: Nam Tran <trannamatk@gmail.com>
---
arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
index 353bb50ce542..85441746d94b 100644
--- a/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
+++ b/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
@@ -270,3 +270,13 @@ &vec {
&wifi_pwrseq {
reset-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>;
};
+
+&i2c1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ led-controller@1b {
+ compatible = "ti,lp5812";
+ reg = <0x1b>;
+ };
+};
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH v3 3/3] leds: add new LED driver for TI LP5812
2025-03-06 17:21 [PATCH v3 0/3] leds: add new LED driver for TI LP5812 Nam Tran
2025-03-06 17:21 ` [PATCH v3 1/3] dt-bindings: leds: Add LP5812 LED driver Nam Tran
2025-03-06 17:21 ` [PATCH v3 2/3] arm64: dts: Add LP5812 LED node for Raspberry Pi 4 Model B Nam Tran
@ 2025-03-06 17:21 ` Nam Tran
2025-03-06 18:53 ` Christophe JAILLET
` (5 more replies)
2 siblings, 6 replies; 26+ messages in thread
From: Nam Tran @ 2025-03-06 17:21 UTC (permalink / raw)
To: pavel, lee, krzk+dt, robh, conor+dt
Cc: devicetree, linux-leds, linux-kernel, Nam Tran
The chip can drive LED matrix 4x3.
This driver enables LED control via I2C.
The driver is implemented in two parts:
- Core driver logic in leds-lp5812.c
- Common support functions in leds-lp5812-common.c
Signed-off-by: Nam Tran <trannamatk@gmail.com>
---
MAINTAINERS | 6 +
drivers/leds/Kconfig | 29 +
drivers/leds/Makefile | 2 +
drivers/leds/leds-lp5812-common.c | 1023 ++++++++++++++
drivers/leds/leds-lp5812-common.h | 323 +++++
drivers/leds/leds-lp5812-regs.h | 96 ++
drivers/leds/leds-lp5812.c | 2190 +++++++++++++++++++++++++++++
7 files changed, 3669 insertions(+)
create mode 100644 drivers/leds/leds-lp5812-common.c
create mode 100644 drivers/leds/leds-lp5812-common.h
create mode 100644 drivers/leds/leds-lp5812-regs.h
create mode 100644 drivers/leds/leds-lp5812.c
diff --git a/MAINTAINERS b/MAINTAINERS
index 2bd9f5132cab..773c7ad6a7b6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -23511,6 +23511,12 @@ M: Nam Tran <trannamatk@gmail.com>
L: linux-leds@vger.kernel.org
S: Maintained
F: Documentation/devicetree/bindings/leds/ti,lp5812.yaml
+F: drivers/leds/Kconfig
+F: drivers/leds/Makefile
+F: drivers/leds/leds-lp5812-common.c
+F: drivers/leds/leds-lp5812-common.h
+F: drivers/leds/leds-lp5812-regs.h
+F: drivers/leds/leds-lp5812.c
TEXAS INSTRUMENTS' SYSTEM CONTROL INTERFACE (TISCI) PROTOCOL DRIVER
M: Nishanth Menon <nm@ti.com>
diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 2b27d043921c..7af5ebf190a9 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -483,6 +483,35 @@ config LEDS_LP5569
Driver provides direct control via LED class and interface for
programming the engines.
+config LEDS_LP5812
+ tristate "Enable LP5812 support LED matrix 4x3"
+ depends on LEDS_CLASS && I2C
+ depends on LEDS_CLASS_MULTICOLOR
+ help
+ If you say Y here you get support for TI LP5812 LED driver.
+
+ The LP5812 is an I2C-based RGB LED driver that supports a 4x3 LED matrix.
+ It provides independent brightness control and color mixing for each LED.
+ This driver integrates with the Linux LED framework and LED multicolor class.
+
+ To compile this driver as a module, choose M here: the
+ module will be called leds-lp5812.
+
+ If unsure, say N.
+
+config LEDS_LP5812_COMMON
+ tristate "Common driver for TI LP5812"
+ depends on LEDS_CLASS
+ depends on LEDS_CLASS_MULTICOLOR
+ depends on I2C
+ help
+ If you say Y here you get support common operation for TI LP5812 LED driver.
+
+ To compile this driver as a module, choose M here: the
+ module will be called leds-lp5812-common.
+
+ If unsure, say N.
+
config LEDS_LP8501
tristate "LED Support for TI LP8501 LED driver chip"
depends on LEDS_CLASS && I2C
diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile
index 6ad52e219ec6..d3daae2d808c 100644
--- a/drivers/leds/Makefile
+++ b/drivers/leds/Makefile
@@ -54,6 +54,8 @@ obj-$(CONFIG_LEDS_LP5523) += leds-lp5523.o
obj-$(CONFIG_LEDS_LP5562) += leds-lp5562.o
obj-$(CONFIG_LEDS_LP5569) += leds-lp5569.o
obj-$(CONFIG_LEDS_LP55XX_COMMON) += leds-lp55xx-common.o
+obj-$(CONFIG_LEDS_LP5812) += leds-lp5812.o
+obj-$(CONFIG_LEDS_LP5812_COMMON) += leds-lp5812-common.o
obj-$(CONFIG_LEDS_LP8501) += leds-lp8501.o
obj-$(CONFIG_LEDS_LP8788) += leds-lp8788.o
obj-$(CONFIG_LEDS_LP8860) += leds-lp8860.o
diff --git a/drivers/leds/leds-lp5812-common.c b/drivers/leds/leds-lp5812-common.c
new file mode 100644
index 000000000000..01157233507f
--- /dev/null
+++ b/drivers/leds/leds-lp5812-common.c
@@ -0,0 +1,1023 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * LP5812 Common Driver
+ *
+ * Copyright (C) 2025 Texas Instruments
+ *
+ * Author: Jared Zhou <jared-zhou@ti.com>
+ */
+
+#include "leds-lp5812-common.h"
+
+/*
+ * Function: lp5812_write
+ * Params:
+ * Return: 0 if success
+ */
+int lp5812_write(struct lp5812_chip *chip, u16 reg, u8 val)
+{
+ int ret;
+ u8 extracted_bits; /* save 9th and 8th bit of reg address */
+ struct i2c_msg msg;
+ u8 buf[2] = {(u8)(reg & 0xFF), val};
+
+ extracted_bits = (reg >> 8) & 0x03;
+ msg.addr = (chip->i2c_cl->addr << 2) | extracted_bits;
+ msg.flags = 0;
+ msg.len = sizeof(buf);
+ msg.buf = buf;
+
+ ret = i2c_transfer(chip->i2c_cl->adapter, &msg, 1);
+ if (ret != 1) {
+ dev_err(chip->dev, "i2c write error, register 0x%02X, ret=%d\n", reg, ret);
+ ret = ret < 0 ? ret : -EIO;
+ } else {
+ ret = 0;
+ }
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(lp5812_write);
+
+int lp5812_read(struct lp5812_chip *chip, u16 reg, u8 *val)
+{
+ int ret;
+ u8 ret_val; /* lp5812_chip return value */
+ u8 extracted_bits; /* save 9th and 8th bit of reg address */
+ u8 converted_reg; /* extracted 8bit from reg */
+ struct i2c_msg msgs[2];
+
+ extracted_bits = (reg >> 8) & 0x03;
+ converted_reg = (u8)(reg & 0xFF);
+
+ msgs[0].addr = (chip->i2c_cl->addr << 2) | extracted_bits;
+ msgs[0].flags = 0;
+ msgs[0].len = 1;
+ msgs[0].buf = &converted_reg;
+
+ msgs[1].addr = (chip->i2c_cl->addr << 2) | extracted_bits;
+ msgs[1].flags = I2C_M_RD;
+ msgs[1].len = 1;
+ msgs[1].buf = &ret_val;
+
+ ret = i2c_transfer(chip->i2c_cl->adapter, msgs, 2);
+ if (ret != 2) {
+ dev_err(chip->dev, "Read register 0x%02X error, ret=%d\n", reg, ret);
+ *val = 0;
+ ret = ret < 0 ? ret : -EIO;
+ } else {
+ *val = ret_val;
+ ret = 0;
+ }
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(lp5812_read);
+
+int lp5812_update_bit(struct lp5812_chip *chip, u16 reg, u8 mask, u8 val)
+{
+ int ret;
+ u8 tmp;
+
+ ret = lp5812_read(chip, reg, &tmp);
+ if (ret)
+ return ret;
+
+ tmp &= ~mask;
+ tmp |= val & mask;
+
+ return lp5812_write(chip, reg, tmp);
+}
+
+/*
+ * Function: lp5812_read_tsd_config_status
+ * Description: read tsd config status register
+ * Param: chip --> struct lp5812_chip itself
+ * reg_val
+ * Return: 0 if success
+ */
+int lp5812_read_tsd_config_status(struct lp5812_chip *chip, u8 *reg_val)
+{
+ int ret = 0;
+
+ if (!reg_val)
+ return -1;
+
+ ret = lp5812_read(chip, chip->regs->tsd_config_status_reg, reg_val);
+
+ return ret;
+}
+
+/*
+ * Function: lp5812_update_regs_config
+ * Description: update reg config register
+ * Param: chip --> struct lp5812_chip itself
+ * Return: 0 if success
+ */
+int lp5812_update_regs_config(struct lp5812_chip *chip)
+{
+ int ret;
+ u8 reg_val; /* save register value */
+
+ /* Send update command to update config setting */
+ ret = lp5812_write(chip, chip->regs->update_cmd_reg, UPDATE_CMD_VAL);
+ if (ret)
+ return ret;
+ /* check if the configuration is proper */
+ ret = lp5812_read_tsd_config_status(chip, ®_val);
+ if (ret == 0)
+ return (int)(reg_val & 0x01);
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(lp5812_update_regs_config);
+
+/*
+ * Function: lp5812_read_lod_status
+ * Description: read lod status register
+ * Param: chip --> struct lp5812_chip itself
+ * led_number --> int
+ * val -> u8 *
+ * Return: 0 if success
+ */
+int lp5812_read_lod_status(struct lp5812_chip *chip, int led_number, u8 *val)
+{
+ int ret = 0;
+ u16 reg = 0;
+ u8 reg_val = 0;
+
+ if (!val)
+ return -1;
+
+ if (led_number < 0x8)
+ reg = LOD_STAT_1_REG;
+ else
+ reg = LOD_STAT_2_REG;
+
+ ret = lp5812_read(chip, reg, ®_val);
+ if (ret)
+ return ret;
+
+ *val = (reg_val & (1 << (led_number % 8))) ? 1 : 0;
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(lp5812_read_lod_status);
+
+/*
+ * Function: lp5812_read_lsd_status
+ * Description: read lsd status register
+ * Param: chip --> struct lp5812_chip itself
+ * led_number --> int
+ * val -> u8 *
+ * Return: 0 if success
+ */
+int lp5812_read_lsd_status(struct lp5812_chip *chip, int led_number, u8 *val)
+{
+ int ret = 0;
+ u16 reg = 0;
+ u8 reg_val = 0;
+
+ if (!val)
+ return -1;
+
+ if (led_number < 0x8)
+ reg = LSD_STAT_1_REG;
+ else
+ reg = LSD_STAT_2_REG;
+
+ ret = lp5812_read(chip, reg, ®_val);
+ if (ret)
+ return ret;
+
+ *val = (reg_val & (1 << (led_number % 8))) ? 1 : 0;
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(lp5812_read_lsd_status);
+
+/*
+ * Function: lp5812_read_auto_pwm_value
+ * Description: read pwm value in autonomous mode
+ * Param: chip --> struct lp5812_chip itself
+ * led_number --> int
+ * val -> u8 *
+ * Return: 0 if success
+ */
+int lp5812_read_auto_pwm_value(struct lp5812_chip *chip, int led_number,
+ u8 *val)
+{
+ int ret = 0;
+ u16 reg = 0;
+ u8 reg_val = 0;
+
+ reg = AUTO_PWM_BASE_ADDR + led_number;
+
+ ret = lp5812_read(chip, reg, ®_val);
+ if (ret)
+ return ret;
+
+ *val = reg_val;
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(lp5812_read_auto_pwm_value);
+
+/*
+ * Function: lp5812_read_aep_status
+ * Description: read autonomous engine pattern status
+ * Param: chip --> struct lp5812_chip itself
+ * led_number --> int
+ * val -> u8 *
+ * Return: 0 if success
+ */
+int lp5812_read_aep_status(struct lp5812_chip *chip, int led_number, u8 *val)
+{
+ int ret = 0;
+ u16 reg;
+ u8 reg_val;
+
+ switch (led_number / 2) {
+ case 0:
+ reg = AEP_STATUS_0_REG; // LED_0 and LED_1
+ break;
+ case 1:
+ reg = AEP_STATUS_1_REG; // LED_2 and LED_3
+ break;
+ case 2:
+ reg = AEP_STATUS_2_REG; // LED_A0 and LED_A1
+ break;
+ case 3:
+ reg = AEP_STATUS_3_REG; // LED_A2 and LED_B0
+ break;
+ case 4:
+ reg = AEP_STATUS_4_REG; // LED_B1 and LED_B2
+ break;
+ case 5:
+ reg = AEP_STATUS_5_REG; // LED_C0 and LED_C1
+ break;
+ case 6:
+ reg = AEP_STATUS_6_REG; // LED_C2 and LED_D0
+ break;
+ case 7:
+ reg = AEP_STATUS_7_REG; // LED_D1 and LED_D2
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ ret = lp5812_read(chip, reg, ®_val);
+ if (ret)
+ return ret;
+
+ *val = (led_number % 2) ? ((reg_val >> 3) & 0x07) : (reg_val & 0x07);
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(lp5812_read_aep_status);
+
+int lp5812_enable_disable(struct lp5812_chip *chip, int enable)
+{
+ return lp5812_write(chip, chip->regs->enable_reg, (u8)enable);
+}
+EXPORT_SYMBOL_GPL(lp5812_enable_disable);
+
+int lp5812_reset(struct lp5812_chip *chip)
+{
+ return lp5812_write(chip, chip->regs->reset_reg, RESET_REG_VAL);
+}
+EXPORT_SYMBOL_GPL(lp5812_reset);
+
+int lp5812_fault_clear(struct lp5812_chip *chip, u8 value)
+{
+ u8 reg_val;
+
+ if (value == 0)
+ reg_val = LOD_CLEAR_VAL;
+ else if (value == 1)
+ reg_val = LSD_CLEAR_VAL;
+ else if (value == 2)
+ reg_val = TSD_CLEAR_VAL;
+ else if (value == 3)
+ reg_val = FAULT_CLEAR_ALL;
+ else
+ return -EINVAL;
+
+ return lp5812_write(chip, chip->regs->fault_clear_reg, reg_val);
+}
+EXPORT_SYMBOL_GPL(lp5812_fault_clear);
+
+void lp5812_dump_regs(struct lp5812_chip *chip, u16 from_reg, u16 to_reg)
+{
+ u16 reg_addr;
+ u8 reg_val;
+
+ for (reg_addr = from_reg; reg_addr <= to_reg; reg_addr++)
+ lp5812_read(chip, reg_addr, ®_val);
+}
+
+int lp5812_device_command(struct lp5812_chip *chip, enum device_command command)
+{
+ switch (command) {
+ case UPDATE:
+ return lp5812_write(chip, chip->regs->update_cmd_reg,
+ UPDATE_CMD_VAL);
+ case START:
+ return lp5812_write(chip, chip->regs->start_cmd_reg,
+ START_CMD_VAL);
+ case STOP:
+ return lp5812_write(chip, chip->regs->stop_cmd_reg,
+ STOP_CMD_VAL);
+ case PAUSE:
+ return lp5812_write(chip, chip->regs->pause_cmd_reg,
+ PAUSE_CMD_VAL);
+ case CONTINUE:
+ return lp5812_write(chip, chip->regs->continue_cmd_reg,
+ CONTINUE_CMD_VAL);
+ default:
+ return -EINVAL;
+ }
+}
+EXPORT_SYMBOL_GPL(lp5812_device_command);
+
+/*
+ * Function: lp5812_set_pwm_dimming_scale
+ * Description: set led as pwm Linear or exponential dimming scale
+ * Param: chip --> struct lp5812_chip itself
+ * led_number
+ * scale: enum type (LINEAR or EXPONENTIAL)
+ * Return: 0 if success
+ */
+int lp5812_set_pwm_dimming_scale(struct lp5812_chip *chip, int led_number,
+ enum pwm_dimming_scale scale)
+{
+ int ret = 0;
+ u16 reg;
+ u8 reg_val;
+
+ if (led_number <= 7)
+ reg = (u16)DEV_CONFIG5;
+ else
+ reg = (u16)DEV_CONFIG6;
+
+ ret = lp5812_read(chip, reg, ®_val);
+ if (ret != 0)
+ return ret;
+ if (scale == LINEAR) {
+ reg_val &= ~(1 << (led_number % 8));
+ ret = lp5812_write(chip, reg, reg_val);
+ if (ret != 0)
+ return ret;
+ } else {
+ reg_val |= (1 << (led_number % 8));
+ ret = lp5812_write(chip, reg, reg_val);
+ if (ret != 0)
+ return ret;
+ }
+
+ ret = lp5812_update_regs_config(chip);
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(lp5812_set_pwm_dimming_scale);
+
+/*
+ * Function: lp5812_get_pwm_dimming_scale
+ * Description: get lp5812 led pwm dimming scale
+ * Param: chip --> struct lp5812_chip itself
+ * led_number
+ * scale: enum type (LINEAR or EXPONENTIAL)
+ * Return: 0 if success
+ */
+int lp5812_get_pwm_dimming_scale(struct lp5812_chip *chip,
+ int led_number, enum pwm_dimming_scale *scale)
+{
+ int ret = 0;
+ u16 reg;
+ u8 reg_val;
+
+ if (led_number < 0x8)
+ reg = DEV_CONFIG5;
+ else
+ reg = DEV_CONFIG6;
+
+ ret = lp5812_read(chip, reg, ®_val);
+ if (ret)
+ return ret;
+
+ *scale = (reg_val & (1 << (led_number % 8))) ? EXPONENTIAL : LINEAR;
+
+ return 0;
+}
+EXPORT_SYMBOL_GPL(lp5812_get_pwm_dimming_scale);
+
+/*
+ * Function: lp5812_set_phase_align
+ * Description: set phase align for led (forward, middle, backward)
+ * Param: chip --> struct lp5812_chip itself
+ * led_number
+ * phase_align_val: 0,1,2,3
+ * Return: 0 if success
+ */
+int lp5812_set_phase_align(struct lp5812_chip *chip, int led_number,
+ int phase_align_val)
+{
+ int ret;
+ int bit_pos;
+ u16 reg;
+ u8 reg_val;
+
+ reg = DEV_CONFIG7 + (led_number / 4);
+ bit_pos = (led_number % 4) * 2;
+
+ ret = lp5812_read(chip, reg, ®_val);
+ if (ret)
+ return ret;
+ reg_val |= (phase_align_val << bit_pos);
+ ret = lp5812_write(chip, reg, reg_val);
+ if (ret != 0)
+ return ret;
+ ret = lp5812_update_regs_config(chip);
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(lp5812_set_phase_align);
+
+/*
+ * Function: lp5812_get_phase_align
+ * Description: get phase align of led
+ * Param: chip --> struct lp5812_chip itself
+ * led_number
+ * *phase_align_val: Return 0,1,2,3
+ * Return: 0 if success
+ */
+int lp5812_get_phase_align(struct lp5812_chip *chip, int led_number,
+ int *phase_align_val)
+{
+ int ret;
+ int bit_pos;
+ u16 reg;
+ u8 reg_val;
+
+ reg = DEV_CONFIG7 + (led_number / 4);
+ bit_pos = (led_number % 4) * 2;
+
+ ret = lp5812_read(chip, reg, ®_val);
+ if (ret)
+ return ret;
+
+ *phase_align_val = (reg_val >> bit_pos) & 0x03;
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(lp5812_get_phase_align);
+
+/*
+ * Function: lp5812_get_led_mode
+ * Description: get lp5812 led mode
+ * Param: chip --> struct lp5812_chip itself
+ * led_number
+ * mode: enum type (MANUAL or AUTONOMOUS)
+ * Return: 0 if success
+ */
+int lp5812_get_led_mode(struct lp5812_chip *chip,
+ int led_number, enum control_mode *mode)
+{
+ int ret = 0;
+ u16 reg;
+ u8 reg_val;
+
+ if (led_number < 0x8)
+ reg = DEV_CONFIG3;
+ else
+ reg = DEV_CONFIG4;
+
+ ret = lp5812_read(chip, reg, ®_val);
+ if (ret)
+ return ret;
+
+ *mode = (reg_val & (1 << (led_number % 8))) ? AUTONOMOUS : MANUAL;
+
+ return 0;
+}
+EXPORT_SYMBOL_GPL(lp5812_get_led_mode);
+
+/*
+ * Function: lp5812_set_led_mode
+ * Description: set lp5812 as manual or autonomous mode
+ * Param: chip --> struct lp5812_chip itself
+ * led_number
+ * mode: enum type (MANUAL or AUTONOMOUS)
+ * Return: 0 if success
+ */
+int lp5812_set_led_mode(struct lp5812_chip *chip, int led_number,
+ enum control_mode mode)
+{
+ int ret = 0;
+ u16 reg;
+ u8 reg_val;
+
+ if (led_number <= 7)
+ reg = (u16)DEV_CONFIG3;
+ else
+ reg = (u16)DEV_CONFIG4;
+ ret = lp5812_read(chip, reg, ®_val);
+ if (ret != 0)
+ return ret;
+ if (mode == MANUAL) {
+ reg_val &= ~(1 << (led_number % 8));
+ ret = lp5812_write(chip, reg, reg_val);
+ if (ret != 0)
+ return ret;
+ } else {
+ reg_val |= (1 << (led_number % 8));
+ ret = lp5812_write(chip, reg, reg_val);
+ if (ret != 0)
+ return ret;
+ }
+
+ ret = lp5812_update_regs_config(chip);
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(lp5812_set_led_mode);
+
+/*
+ * Function: lp5812_manual_dc_pwm_control
+ * Description: manual control for analog or pwm dimming type
+ * Param: chip --> struct lp5812_chip itself
+ * led_number --> led_number need to control (0,1,2,3)
+ * val --> 0 -> 255
+ * dimming_type --> enum(ANALOG, PWM)
+ * Return: 0 if success
+ */
+int lp5812_manual_dc_pwm_control(struct lp5812_chip *chip,
+ int led_number, u8 val, enum dimming_type dimming_type)
+{
+ int ret;
+ u16 led_base_reg;
+
+ if (dimming_type == ANALOG)
+ led_base_reg = (u16)MANUAL_DC_LED_0_REG;
+ else
+ led_base_reg = (u16)MANUAL_PWM_LED_0_REG;
+ ret = lp5812_write(chip, led_base_reg + led_number, val);
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(lp5812_manual_dc_pwm_control);
+
+int lp5812_manual_dc_pwm_read(struct lp5812_chip *chip,
+ int led_number, u8 *val, enum dimming_type dimming_type)
+{
+ int ret;
+ u16 led_base_reg;
+
+ if (dimming_type == ANALOG)
+ led_base_reg = (u16)MANUAL_DC_LED_0_REG;
+ else
+ led_base_reg = (u16)MANUAL_PWM_LED_0_REG;
+ ret = lp5812_read(chip, led_base_reg + led_number, val);
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(lp5812_manual_dc_pwm_read);
+
+int lp5812_autonomous_dc_pwm_control(struct lp5812_chip *chip,
+ int led_number, u8 val, enum dimming_type dimming_type)
+{
+ int ret;
+ u16 led_base_reg;
+
+ led_base_reg = (u16)AUTO_DC_LED_0_REG;
+ ret = lp5812_write(chip, led_base_reg + led_number, val);
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(lp5812_autonomous_dc_pwm_control);
+
+int lp5812_autonomous_dc_pwm_read(struct lp5812_chip *chip,
+ int led_number, u8 *val, enum dimming_type dimming_type)
+{
+ int ret;
+ u16 led_base_reg;
+
+ led_base_reg = (u16)AUTO_DC_LED_0_REG;
+ ret = lp5812_read(chip, led_base_reg + led_number, val);
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(lp5812_autonomous_dc_pwm_read);
+
+int lp5812_disable_all_leds(struct lp5812_chip *chip)
+{
+ int ret = 0;
+
+ ret = lp5812_write(chip, (u16)LED_ENABLE_1_REG, 0x00);
+ if (ret != 0)
+ return ret;
+ ret = lp5812_write(chip, (u16)LED_ENABLE_2_REG, 0x00);
+ if (ret != 0)
+ return ret;
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(lp5812_disable_all_leds);
+
+int lp5812_get_drive_mode_scan_order(struct lp5812_chip *chip)
+{
+ u8 val;
+ int ret = 0;
+
+ /* get led mode */
+ ret = lp5812_read(chip, (u16)DEV_CONFIG1, &val);
+ if (ret != 0)
+ return ret;
+ chip->u_drive_mode.drive_mode_val = val;
+
+ /* get scan order */
+ ret = lp5812_read(chip, (u16)DEV_CONFIG2, &val);
+ if (ret != 0)
+ return ret;
+ chip->u_scan_order.scan_order_val = val;
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(lp5812_get_drive_mode_scan_order);
+
+int lp5812_set_drive_mode_scan_order(struct lp5812_chip *chip)
+{
+ u8 val;
+ int ret = 0;
+
+ /* Set led mode */
+ val = chip->u_drive_mode.drive_mode_val;
+ ret = lp5812_write(chip, (u16)DEV_CONFIG1, val);
+ if (ret != 0)
+ return ret;
+
+ /* Setup scan order */
+ val = chip->u_scan_order.scan_order_val;
+ ret = lp5812_write(chip, (u16)DEV_CONFIG2, val);
+ if (ret != 0)
+ return ret;
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(lp5812_set_drive_mode_scan_order);
+
+int lp5812_initialize(struct lp5812_chip *chip)
+{
+ int ret = 0;
+
+ /* wait for 1 ms */
+ usleep_range(1000, 1100);
+
+ /* enable the lp5812 */
+ ret = lp5812_enable_disable(chip, 1);
+ if (ret != 0) {
+ dev_err(chip->dev, "lp5812_enable_disable failed\n");
+ return ret;
+ }
+ ret = lp5812_set_drive_mode_scan_order(chip);
+ if (ret != 0) {
+ dev_err(chip->dev, "lp5812_set_drive_mode_scan_order failed\n");
+ return ret;
+ }
+
+ /* Set lsd_threshold = 3h to avoid incorrect LSD detection */
+ ret = lp5812_write(chip, (u16)DEV_CONFIG12, 0x0B);
+ if (ret != 0) {
+ dev_err(chip->dev, "write 0x0B to DEV_CONFIG12 failed\n");
+ return ret;
+ }
+
+ /* Send update command to complete configuration settings */
+ ret = lp5812_update_regs_config(chip);
+ if (ret != 0) {
+ dev_err(chip->dev, "lp5812_update_regs_config failed\n");
+ return ret;
+ }
+
+ /* Enable LED_A0 for testing */
+ ret = lp5812_write(chip, (u16)LED_ENABLE_1_REG, 0x20);
+ if (ret != 0) {
+ dev_err(chip->dev, "write 0x10 to LED_ENABLE_1_REG failed\n");
+ return ret;
+ }
+ /* set max DC current for LED_A0 */
+ ret = lp5812_write(chip, (u16)0x35, 0x80);
+ if (ret != 0)
+ dev_err(chip->dev, "set max DC current for LED_A0 failed\n");
+
+ /* set 100% pwm cycle for LED_A0 */
+ ret = lp5812_write(chip, (u16)0x45, 0x80);
+ if (ret != 0)
+ dev_err(chip->dev, "set 100 percent pwm cycle for LED_A0 failed\n");
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(lp5812_initialize);
+
+int led_set_autonomous_animation_config(struct lp5812_led *led)
+{
+ int ret;
+ u16 reg;
+ struct lp5812_chip *chip = led->priv;
+
+ /* Set start/end pause */
+ reg = led->anim_base_addr + AUTO_PAUSE;
+ ret = lp5812_write(chip, reg, led->start_stop_pause_time.time_val);
+ if (ret)
+ return ret;
+
+ /* Set led playback and AEU selection */
+ reg = led->anim_base_addr + AUTO_PLAYBACK;
+ ret = lp5812_write(chip, reg, led->led_playback.led_playback_val);
+ if (ret)
+ return ret;
+
+ return 0;
+}
+EXPORT_SYMBOL_GPL(led_set_autonomous_animation_config);
+
+int led_get_autonomous_animation_config(struct lp5812_led *led)
+{
+ int ret;
+ u16 reg;
+ struct lp5812_chip *chip = led->priv;
+
+ /* Get start/end pause value */
+ reg = led->anim_base_addr + AUTO_PAUSE;
+ ret = lp5812_read(chip, reg, &led->start_stop_pause_time.time_val);
+ if (ret)
+ return ret;
+
+ /* Get led playback and AEU selection values */
+ reg = led->anim_base_addr + AUTO_PLAYBACK;
+ ret = lp5812_read(chip, reg, &led->led_playback.led_playback_val);
+ if (ret)
+ return ret;
+
+ return 0;
+}
+EXPORT_SYMBOL_GPL(led_get_autonomous_animation_config);
+
+static u16 get_aeu_pwm_register(struct anim_engine_unit *aeu,
+ enum pwm_slope_time_num pwm_num)
+{
+ u16 reg;
+ struct lp5812_led *led = aeu->led;
+
+ switch (pwm_num) {
+ case PWM1:
+ if (aeu->aeu_number == 1)
+ reg = led->anim_base_addr + AEU1_PWM_1;
+ else if (aeu->aeu_number == 2)
+ reg = led->anim_base_addr + AEU2_PWM_1;
+ else
+ reg = led->anim_base_addr + AEU3_PWM_1;
+ break;
+ case PWM2:
+ if (aeu->aeu_number == 1)
+ reg = led->anim_base_addr + AEU1_PWM_2;
+ else if (aeu->aeu_number == 2)
+ reg = led->anim_base_addr + AEU2_PWM_2;
+ else
+ reg = led->anim_base_addr + AEU3_PWM_2;
+ break;
+ case PWM3:
+ if (aeu->aeu_number == 1)
+ reg = led->anim_base_addr + AEU1_PWM_3;
+ else if (aeu->aeu_number == 2)
+ reg = led->anim_base_addr + AEU2_PWM_3;
+ else
+ reg = led->anim_base_addr + AEU3_PWM_3;
+ break;
+ case PWM4:
+ if (aeu->aeu_number == 1)
+ reg = led->anim_base_addr + AEU1_PWM_4;
+ else if (aeu->aeu_number == 2)
+ reg = led->anim_base_addr + AEU2_PWM_4;
+ else
+ reg = led->anim_base_addr + AEU3_PWM_4;
+ break;
+ case PWM5:
+ if (aeu->aeu_number == 1)
+ reg = led->anim_base_addr + AEU1_PWM_5;
+ else if (aeu->aeu_number == 2)
+ reg = led->anim_base_addr + AEU2_PWM_5;
+ else
+ reg = led->anim_base_addr + AEU3_PWM_5;
+ break;
+ default:
+ reg = led->anim_base_addr;
+ break;
+ }
+
+ return reg;
+}
+
+static u16 get_aeu_slope_time_register(struct anim_engine_unit *aeu,
+ enum pwm_slope_time_num slope_time_num)
+{
+ u16 reg;
+ struct lp5812_led *led = aeu->led;
+
+ switch (slope_time_num) {
+ case SLOPE_T1:
+ case SLOPE_T2:
+ if (aeu->aeu_number == 1)
+ reg = led->anim_base_addr + AEU1_T12;
+ else if (aeu->aeu_number == 2)
+ reg = led->anim_base_addr + AEU2_T12;
+ else
+ reg = led->anim_base_addr + AEU3_T12;
+ break;
+ case SLOPE_T3:
+ case SLOPE_T4:
+ if (aeu->aeu_number == 1)
+ reg = led->anim_base_addr + AEU1_T34;
+ else if (aeu->aeu_number == 2)
+ reg = led->anim_base_addr + AEU2_T34;
+ else
+ reg = led->anim_base_addr + AEU3_T34;
+ break;
+ default:
+ reg = led->anim_base_addr;
+ break;
+ }
+
+ return reg;
+}
+
+static u16 get_aeu_playback_time_register(struct anim_engine_unit *aeu)
+{
+ u16 reg;
+ struct lp5812_led *led = aeu->led;
+
+ if (aeu->aeu_number == 1)
+ reg = led->anim_base_addr + AEU1_PLAYBACK;
+ else if (aeu->aeu_number == 2)
+ reg = led->anim_base_addr + AEU2_PLAYBACK;
+ else
+ reg = led->anim_base_addr + AEU3_PLAYBACK;
+
+ return reg;
+}
+
+/* Function: led_aeu_pwm_set_val
+ * Description: set led AEU pwm value
+ * Params: aeu -> struct anim_engine_unit itself
+ * val: 0-255
+ * pwm_num: enum(PWM1 ... PWM5)
+ * Return 0 if success
+ */
+int led_aeu_pwm_set_val(struct anim_engine_unit *aeu, u8 val,
+ enum pwm_slope_time_num pwm_num)
+{
+ int ret;
+ u16 reg;
+ struct lp5812_led *led = aeu->led;
+ struct lp5812_chip *chip = led->priv;
+
+ reg = get_aeu_pwm_register(aeu, pwm_num);
+ ret = lp5812_write(chip, reg, val);
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(led_aeu_pwm_set_val);
+
+/* Function: led_aeu_pwm_get_val
+ * Description: get led AEU pwm value
+ * Params: aeu -> struct anim_engine_unit itself
+ * val: return back 0-255
+ * pwm_num: enum(PWM1 ... PWM5)
+ * Return 0 if success
+ */
+int led_aeu_pwm_get_val(struct anim_engine_unit *aeu, u8 *val,
+ enum pwm_slope_time_num pwm_num)
+{
+ int ret;
+ u16 reg;
+ struct lp5812_led *led = aeu->led;
+ struct lp5812_chip *chip = led->priv;
+
+ reg = get_aeu_pwm_register(aeu, pwm_num);
+ ret = lp5812_read(chip, reg, val);
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(led_aeu_pwm_get_val);
+
+/* Function: led_aeu_slope_time_set_val
+ * Description: set led AEU slope time value
+ * Params: aeu -> struct anim_engine_unit itself
+ * val: 0 -> 15
+ * slope_time_num: enum(SLOPE_T1 ... SLOPE_T4)
+ * Return 0 if success
+ */
+int led_aeu_slope_time_set_val(struct anim_engine_unit *aeu, u8 val,
+ enum pwm_slope_time_num slope_time_num)
+{
+ int ret;
+ u16 reg;
+ union time slope_time_val;
+ struct lp5812_led *led = aeu->led;
+ struct lp5812_chip *chip = led->priv;
+
+ reg = get_aeu_slope_time_register(aeu, slope_time_num);
+
+ /* get original value of slope time */
+ ret = lp5812_read(chip, reg, &slope_time_val.time_val);
+ if (ret != 0)
+ return ret;
+
+ /* Update new value for slope time*/
+ if (slope_time_num == SLOPE_T1 || slope_time_num == SLOPE_T3)
+ slope_time_val.s_time.first = val;
+ if (slope_time_num == SLOPE_T2 || slope_time_num == SLOPE_T4)
+ slope_time_val.s_time.second = val;
+
+ /* Save updated value to hardware */
+ ret = lp5812_write(chip, reg, slope_time_val.time_val);
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(led_aeu_slope_time_set_val);
+
+/* Function: led_aeu_slope_time_get_val
+ * Description: get led AEU slope time value
+ * Params: aeu -> struct anim_engine_unit itself
+ * val: return back 0 -> 15
+ * slope_time_num: enum(SLOPE_T1 ... SLOPE_T4)
+ * Return 0 if success
+ */
+int led_aeu_slope_time_get_val(struct anim_engine_unit *aeu, u8 *val,
+ enum pwm_slope_time_num slope_time_num)
+{
+ int ret = 0;
+ u16 reg;
+ union time slope_time_val;
+ struct lp5812_led *led = aeu->led;
+ struct lp5812_chip *chip = led->priv;
+
+ reg = get_aeu_slope_time_register(aeu, slope_time_num);
+ /* get slope time value */
+ ret = lp5812_read(chip, reg, &slope_time_val.time_val);
+ if (ret != 0)
+ return ret;
+
+ if (slope_time_num == SLOPE_T1 || slope_time_num == SLOPE_T3)
+ *val = slope_time_val.s_time.first;
+
+ if (slope_time_num == SLOPE_T2 || slope_time_num == SLOPE_T4)
+ *val = slope_time_val.s_time.second;
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(led_aeu_slope_time_get_val);
+
+/* Function: led_aeu_playback_time_set_val
+ * Description: set aeu playback time value
+ * Params: aeu -> struct anim_engine_unit itself
+ * val: 0 -> 3
+ * Return 0 if success
+ */
+int led_aeu_playback_time_set_val(struct anim_engine_unit *aeu, u8 val)
+{
+ int ret;
+ u16 reg;
+ struct lp5812_led *led = aeu->led;
+ struct lp5812_chip *chip = led->priv;
+
+ reg = get_aeu_playback_time_register(aeu);
+ ret = lp5812_write(chip, reg, val);
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(led_aeu_playback_time_set_val);
+
+/* Function: led_aeu_playback_time_get_val
+ * Description: get aeu playback time value
+ * Params: aeu -> struct anim_engine_unit itself
+ * val: return back 0 -> 3
+ * Return 0 if success
+ */
+int led_aeu_playback_time_get_val(struct anim_engine_unit *aeu, u8 *val)
+{
+ int ret;
+ u16 reg;
+ struct lp5812_led *led = aeu->led;
+ struct lp5812_chip *chip = led->priv;
+
+ reg = get_aeu_playback_time_register(aeu);
+ ret = lp5812_read(chip, reg, val);
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(led_aeu_playback_time_get_val);
+
+MODULE_DESCRIPTION("Texas Instruments LP5812 Common Driver");
+MODULE_AUTHOR("Jared Zhou");
+MODULE_LICENSE("GPL");
diff --git a/drivers/leds/leds-lp5812-common.h b/drivers/leds/leds-lp5812-common.h
new file mode 100644
index 000000000000..cc9bba706d09
--- /dev/null
+++ b/drivers/leds/leds-lp5812-common.h
@@ -0,0 +1,323 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * LP5812 Common Driver Header
+ *
+ * Copyright (C) 2025 Texas Instruments
+ *
+ * Author: Jared Zhou <jared-zhou@ti.com>
+ */
+
+#ifndef _LEDS_LP5812_COMMON_H_
+#define _LEDS_LP5812_COMMON_H_
+
+#include <linux/kernel.h>
+#include <linux/i2c.h>
+#include <linux/sysfs.h>
+#include <linux/mutex.h>
+#include <linux/types.h>
+#include <linux/leds.h>
+#include <linux/delay.h>
+
+#include "leds-lp5812-regs.h"
+
+#define LED0 "led_0"
+#define LED1 "led_1"
+#define LED2 "led_2"
+#define LED3 "led_3"
+#define LED_A0 "led_A0"
+#define LED_A1 "led_A1"
+#define LED_A2 "led_A2"
+#define LED_B0 "led_B0"
+#define LED_B1 "led_B1"
+#define LED_B2 "led_B2"
+#define LED_C0 "led_C0"
+#define LED_C1 "led_C1"
+#define LED_C2 "led_C2"
+#define LED_D0 "led_D0"
+#define LED_D1 "led_D1"
+#define LED_D2 "led_D2"
+
+/* Below define time for (start/stop/slope time) */
+#define TIME0 "no time"
+#define TIME1 "0.09s"
+#define TIME2 "0.18s"
+#define TIME3 "0.36s"
+#define TIME4 "0.54s"
+#define TIME5 "0.80s"
+#define TIME6 "1.07s"
+#define TIME7 "1.52s"
+#define TIME8 "2.06s"
+#define TIME9 "2.50s"
+#define TIME10 "3.04s"
+#define TIME11 "4.02s"
+#define TIME12 "5.01s"
+#define TIME13 "5.99s"
+#define TIME14 "7.06s"
+#define TIME15 "8.05s"
+/* End define time for (start/stop/slope time) */
+
+#define AEU1 "AEU1"
+#define AEU2 "AEU2"
+#define AEU3 "AEU3"
+
+#define MAX_LEDS 16
+#define MAX_TIME 16
+#define MAX_AEU 3
+
+#define LP5812_DEV_ATTR_RW(name) \
+ DEVICE_ATTR_RW(name)
+#define LP5812_DEV_ATTR_RO(name) \
+ DEVICE_ATTR_RO(name)
+#define LP5812_DEV_ATTR_WO(name) \
+ DEVICE_ATTR_WO(name)
+
+#define LP5812_KOBJ_ATTR(_name, _mode, _show, _store) \
+ struct kobj_attribute kobj_attr_##_name = __ATTR(_name, _mode, _show, _store)
+#define LP5812_KOBJ_ATTR_RW(name, show, store) \
+ LP5812_KOBJ_ATTR(name, 0644, show, store)
+#define LP5812_KOBJ_ATTR_RO(name, show) \
+ LP5812_KOBJ_ATTR(name, 0444, show, NULL)
+#define LP5812_KOBJ_ATTR_WO(name, store) \
+ LP5812_KOBJ_ATTR(name, 0200, NULL, store)
+
+enum pwm_slope_time_num {
+ PWM1 = 1,
+ PWM2,
+ PWM3,
+ PWM4,
+ PWM5,
+ SLOPE_T1,
+ SLOPE_T2,
+ SLOPE_T3,
+ SLOPE_T4
+};
+
+enum dimming_type {
+ ANALOG,
+ PWM
+};
+
+enum pwm_dimming_scale {
+ LINEAR = 0,
+ EXPONENTIAL
+};
+
+enum control_mode {
+ MANUAL = 0,
+ AUTONOMOUS
+};
+
+enum device_command {
+ NONE,
+ UPDATE,
+ START,
+ STOP,
+ PAUSE,
+ CONTINUE
+};
+
+enum animation_addr {
+ AUTO_PAUSE = 0,
+ AUTO_PLAYBACK,
+ AEU1_PWM_1,
+ AEU1_PWM_2,
+ AEU1_PWM_3,
+ AEU1_PWM_4,
+ AEU1_PWM_5,
+ AEU1_T12,
+ AEU1_T34,
+ AEU1_PLAYBACK,
+ AEU2_PWM_1,
+ AEU2_PWM_2,
+ AEU2_PWM_3,
+ AEU2_PWM_4,
+ AEU2_PWM_5,
+ AEU2_T12,
+ AEU2_T34,
+ AEU2_PLAYBACK,
+ AEU3_PWM_1,
+ AEU3_PWM_2,
+ AEU3_PWM_3,
+ AEU3_PWM_4,
+ AEU3_PWM_5,
+ AEU3_T12,
+ AEU3_T34,
+ AEU3_PLAYBACK
+};
+
+enum drive_mode {
+ DIRECT_MODE = 0,
+ TCM_1_SCAN,
+ TCM_2_SCAN,
+ TCM_3_SCAN,
+ TCM_4_SCAN,
+ MIX_1_SCAN,
+ MIX_2_SCAN,
+ MIX_3_SCAN
+};
+
+enum aeu_select {
+ ONLY_AEU1,
+ AEU1_AEU2,
+ AEU1_AEU2_AEU3
+};
+
+union time {
+ struct {
+ u8 first:4;
+ u8 second:4;
+ } __packed s_time;
+ u8 time_val;
+}; /* type for start/stop pause time and slope time */
+
+union led_playback {
+ struct {
+ u8 led_playback_time:4;
+ u8 aeu_selection:2;
+ u8 reserved:2;
+ } __packed s_led_playback;
+ u8 led_playback_val;
+};
+
+union scan_order {
+ struct {
+ u8 scan_order_0:2;
+ u8 scan_order_1:2;
+ u8 scan_order_2:2;
+ u8 scan_order_3:2;
+ } __packed s_scan_order;
+ u8 scan_order_val;
+};
+
+union drive_mode_info {
+ struct {
+ u8 mix_sel_led_0:1;
+ u8 mix_sel_led_1:1;
+ u8 mix_sel_led_2:1;
+ u8 mix_sel_led_3:1;
+ u8 led_mode:3;
+ u8 pwm_fre:1;
+ } __packed s_drive_mode;
+ u8 drive_mode_val;
+};
+
+struct drive_mode_led_map {
+ const char *drive_mode;
+ const char **led_arr;
+};
+
+struct lp5812_specific_regs {
+ u16 enable_reg;
+ u16 reset_reg;
+ u16 update_cmd_reg;
+ u16 start_cmd_reg;
+ u16 stop_cmd_reg;
+ u16 pause_cmd_reg;
+ u16 continue_cmd_reg;
+ u16 fault_clear_reg;
+ u16 tsd_config_status_reg;
+};
+
+struct anim_engine_unit {
+ struct kobject kobj;
+ struct lp5812_led *led;
+ struct attribute_group attr_group;
+ const char *aeu_name;
+ int aeu_number; /* start from 1 */
+
+ /* To know led using this AEU or not*/
+ int enabled;
+};
+
+struct lp5812_led {
+ struct kobject kobj;
+ struct lp5812_chip *priv;
+ struct attribute_group attr_group;
+ int enable;
+ enum control_mode mode;
+ enum dimming_type dimming_type;
+ u8 lod_lsd;
+ u8 auto_pwm;
+ u8 aep_status;
+ u16 anim_base_addr;
+ int led_number; /* start from 0 */
+ int is_sysfs_created;
+ const char *led_name;
+
+ union led_playback led_playback;
+ union time start_stop_pause_time;
+
+ int total_aeu;
+ struct anim_engine_unit aeu[MAX_AEU];
+};
+
+struct lp5812_chip {
+ struct i2c_client *i2c_cl;
+ struct mutex lock; /* Protects access to device registers */
+ struct device *dev;
+ struct attribute_group attr_group;
+ const struct lp5812_specific_regs *regs;
+ const struct drive_mode_led_map *chip_leds_map;
+ enum device_command command;
+ int total_leds;
+ union scan_order u_scan_order;
+ union drive_mode_info u_drive_mode;
+
+ struct lp5812_led leds[MAX_LEDS]; /* MAX 16 LEDs */
+};
+
+int lp5812_write(struct lp5812_chip *chip, u16 reg, u8 val);
+int lp5812_read(struct lp5812_chip *chip, u16 reg, u8 *val);
+int lp5812_update_bit(struct lp5812_chip *chip, u16 reg, u8 mask, u8 val);
+
+int lp5812_read_tsd_config_status(struct lp5812_chip *chip, u8 *reg_val);
+int lp5812_read_lod_status(struct lp5812_chip *chip, int led_number, u8 *val);
+int lp5812_read_lsd_status(struct lp5812_chip *chip, int led_number, u8 *val);
+int lp5812_read_auto_pwm_value(struct lp5812_chip *chip, int led_number, u8 *val);
+int lp5812_read_aep_status(struct lp5812_chip *chip, int led_number, u8 *val);
+int lp5812_update_regs_config(struct lp5812_chip *chip);
+int lp5812_enable_disable(struct lp5812_chip *chip, int enable);
+int lp5812_reset(struct lp5812_chip *chip);
+int lp5812_fault_clear(struct lp5812_chip *chip, u8 value);
+int lp5812_device_command(struct lp5812_chip *chip, enum device_command command);
+void lp5812_dump_regs(struct lp5812_chip *chip, u16 from_reg, u16 to_reg);
+int lp5812_set_led_mode(struct lp5812_chip *chip, int led_number,
+ enum control_mode mode);
+int lp5812_get_led_mode(struct lp5812_chip *chip,
+ int led_number, enum control_mode *mode);
+int lp5812_set_pwm_dimming_scale(struct lp5812_chip *chip, int led_number,
+ enum pwm_dimming_scale scale);
+int lp5812_get_pwm_dimming_scale(struct lp5812_chip *chip,
+ int led_number, enum pwm_dimming_scale *scale);
+int lp5812_manual_dc_pwm_control(struct lp5812_chip *chip,
+ int led_number, u8 val, enum dimming_type dimming_type);
+int lp5812_manual_dc_pwm_read(struct lp5812_chip *chip,
+ int led_number, u8 *val, enum dimming_type dimming_type);
+int lp5812_autonomous_dc_pwm_control(struct lp5812_chip *chip,
+ int led_number, u8 val, enum dimming_type dimming_type);
+int lp5812_autonomous_dc_pwm_read(struct lp5812_chip *chip,
+ int led_number, u8 *val, enum dimming_type dimming_type);
+int lp5812_disable_all_leds(struct lp5812_chip *chip);
+int lp5812_set_drive_mode_scan_order(struct lp5812_chip *chip);
+int lp5812_get_drive_mode_scan_order(struct lp5812_chip *chip);
+int lp5812_get_phase_align(struct lp5812_chip *chip, int led_number,
+ int *phase_align_val);
+int lp5812_set_phase_align(struct lp5812_chip *chip, int led_number,
+ int phase_align_val);
+int lp5812_initialize(struct lp5812_chip *chip);
+
+int led_set_autonomous_animation_config(struct lp5812_led *led);
+int led_get_autonomous_animation_config(struct lp5812_led *led);
+
+int led_aeu_pwm_set_val(struct anim_engine_unit *aeu, u8 val,
+ enum pwm_slope_time_num pwm_num);
+int led_aeu_pwm_get_val(struct anim_engine_unit *aeu, u8 *val,
+ enum pwm_slope_time_num pwm_num);
+int led_aeu_slope_time_set_val(struct anim_engine_unit *aeu, u8 val,
+ enum pwm_slope_time_num slope_time_num);
+int led_aeu_slope_time_get_val(struct anim_engine_unit *aeu, u8 *val,
+ enum pwm_slope_time_num slope_time_num);
+int led_aeu_playback_time_set_val(struct anim_engine_unit *aeu, u8 val);
+int led_aeu_playback_time_get_val(struct anim_engine_unit *aeu, u8 *val);
+
+#endif /*_LEDS_LP5812_COMMON_H_*/
diff --git a/drivers/leds/leds-lp5812-regs.h b/drivers/leds/leds-lp5812-regs.h
new file mode 100644
index 000000000000..00aa073e8523
--- /dev/null
+++ b/drivers/leds/leds-lp5812-regs.h
@@ -0,0 +1,96 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * LP5812 Register Header
+ *
+ * Copyright (C) 2025 Texas Instruments
+ *
+ * Author: Jared Zhou <jared-zhou@ti.com>
+ */
+
+#ifndef _LEDS_LP5812_REGS_H_
+#define _LEDS_LP5812_REGS_H_
+
+#define CHIP_EN_REG 0x00
+
+#define DEV_CONFIG0 0x01
+#define DEV_CONFIG1 0x02
+#define DEV_CONFIG2 0x03
+#define DEV_CONFIG3 0x04
+#define DEV_CONFIG4 0x05
+#define DEV_CONFIG5 0x06
+#define DEV_CONFIG6 0x07
+#define DEV_CONFIG7 0x08
+#define DEV_CONFIG8 0x09
+#define DEV_CONFIG9 0x0A
+#define DEV_CONFIG10 0x0B
+#define DEV_CONFIG11 0x0c
+#define DEV_CONFIG12 0x0D
+
+#define CMD_UPDATE_REG 0x10
+#define CMD_START_REG 0x11
+#define CMD_STOP_REG 0x12
+#define CMD_PAUSE_REG 0x13
+#define CMD_CONTINUE_REG 0x14
+
+#define LED_ENABLE_1_REG 0x20
+#define LED_ENABLE_2_REG 0x21
+
+#define FAULT_CLEAR_REG 0x22
+#define RESET_REG 0x23
+
+#define MANUAL_DC_LED_0_REG 0x30
+#define MANUAL_PWM_LED_0_REG 0x40
+#define AUTO_DC_LED_0_REG 0x50
+
+/* value for register */
+#define UPDATE_CMD_VAL 0x55
+#define START_CMD_VAL 0xFF
+#define STOP_CMD_VAL 0xAA
+#define PAUSE_CMD_VAL 0x33
+#define CONTINUE_CMD_VAL 0xCC
+
+#define CHIP_ENABLE 0x01
+#define CHIP_DISABLE 0x00
+
+#define FAULT_CLEAR_ALL 0x07
+#define TSD_CLEAR_VAL 0x04
+#define LSD_CLEAR_VAL 0x02
+#define LOD_CLEAR_VAL 0x01
+#define RESET_REG_VAL 0x66
+
+#define LED0_AUTO_BASE_ADRR 0x80
+#define LED1_AUTO_BASE_ADRR 0x9A
+#define LED2_AUTO_BASE_ADRR 0xB4
+#define LED3_AUTO_BASE_ADRR 0xCE
+#define LED_A0_AUTO_BASE_ADRR 0xE8
+#define LED_A1_AUTO_BASE_ADRR 0x102
+#define LED_A2_AUTO_BASE_ADRR 0x11C
+#define LED_B0_AUTO_BASE_ADRR 0x136
+#define LED_B1_AUTO_BASE_ADRR 0x150
+#define LED_B2_AUTO_BASE_ADRR 0x16A
+#define LED_C0_AUTO_BASE_ADRR 0x184
+#define LED_C1_AUTO_BASE_ADRR 0x19E
+#define LED_C2_AUTO_BASE_ADRR 0x1B8
+#define LED_D0_AUTO_BASE_ADRR 0x1D2
+#define LED_D1_AUTO_BASE_ADRR 0x1EC
+#define LED_D2_AUTO_BASE_ADRR 0x206
+
+/* Flag Registers */
+#define TSD_CONFIG_STAT_REG 0x300
+#define LOD_STAT_1_REG 0x301
+#define LOD_STAT_2_REG 0x302
+#define LSD_STAT_1_REG 0x303
+#define LSD_STAT_2_REG 0x304
+
+#define AUTO_PWM_BASE_ADDR 0x305
+
+#define AEP_STATUS_0_REG 0x315
+#define AEP_STATUS_1_REG 0x316
+#define AEP_STATUS_2_REG 0x317
+#define AEP_STATUS_3_REG 0x318
+#define AEP_STATUS_4_REG 0x319
+#define AEP_STATUS_5_REG 0x31A
+#define AEP_STATUS_6_REG 0x31B
+#define AEP_STATUS_7_REG 0x31C
+
+#endif /*_LEDS_LP5812_REGS_H_ */
diff --git a/drivers/leds/leds-lp5812.c b/drivers/leds/leds-lp5812.c
new file mode 100644
index 000000000000..7b1753849d0c
--- /dev/null
+++ b/drivers/leds/leds-lp5812.c
@@ -0,0 +1,2190 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * LP5812 LED driver
+ *
+ * Copyright (C) 2025 Texas Instruments
+ *
+ * Author: Jared Zhou <jared-zhou@ti.com>
+ */
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/init.h>
+#include <linux/mod_devicetable.h>
+#include <linux/string.h>
+
+#include "leds-lp5812-common.h"
+
+#define to_lp5812_led(x) container_of(x, struct lp5812_led, kobj)
+#define to_anim_engine_unit(x) container_of(x, struct anim_engine_unit, kobj)
+
+static int lp5812_init_dev_config(struct lp5812_chip *chip,
+ const char *drive_mode, int rm_led_sysfs);
+
+static struct drive_mode_led_map chip_leds_map[] = {
+ {
+ "direct_mode",
+ (const char *[]){LED0, LED1, LED2, LED3, NULL},
+ },
+ {
+ "tcmscan:1:0", /* tcm 1 scan; scan order 0 out0 */
+ (const char *[]){LED_A0, LED_A1, LED_A2, NULL},
+ },
+ {
+ "tcmscan:1:1", /* tcm 1 scan; scan order 0 out1 */
+ (const char *[]){LED_B0, LED_B1, LED_B2, NULL},
+ },
+ {
+ "tcmscan:1:2", /* tcm 1 scan; scan order 0 out2 */
+ (const char *[]){LED_C0, LED_C1, LED_C2, NULL},
+ },
+ {
+ "tcmscan:1:3", /* tcm 1 scan; scan order 0 out3 */
+ (const char *[]){LED_D0, LED_D1, LED_D2, NULL},
+ },
+ { /* tcm 2 scan, scan order 0 out0; scan order 1 out1 */
+ "tcmscan:2:0:1",
+ (const char *[]){LED_A0, LED_A1, LED_A2, LED_B0, LED_B1, LED_B2,
+ NULL},
+ },
+ { /* tcm 2 scan, scan order 0 out0; scan order 1 out2 */
+ "tcmscan:2:0:2",
+ (const char *[]){LED_A0, LED_A1, LED_A2, LED_C0, LED_C1, LED_C2,
+ NULL},
+ },
+ { /* tcm 2 scan, scan order 0 out0; scan order 1 out3 */
+ "tcmscan:2:0:3",
+ (const char *[]){LED_A0, LED_A1, LED_A2, LED_D0, LED_D1, LED_D2,
+ NULL},
+ },
+ { /* tcm 2 scan, scan order 0 out1; scan order 1 out2 */
+ "tcmscan:2:1:2",
+ (const char *[]){LED_B0, LED_B1, LED_B2, LED_C0, LED_C1, LED_C2,
+ NULL},
+ },
+ { /* tcm 2 scan, scan order 0 out1; scan order 1 out3 */
+ "tcmscan:2:1:3",
+ (const char *[]){LED_B0, LED_B1, LED_B2, LED_D0, LED_D1, LED_D2,
+ NULL},
+ },
+ { /* tcm 2 scan, scan order 0 out2; scan order 1 out3 */
+ "tcmscan:2:2:3",
+ (const char *[]){LED_C0, LED_C1, LED_C2, LED_D0, LED_D1, LED_D2,
+ NULL},
+ },
+ { /* tcm 3 scan, scan order 0 out0; scan order 1 out1;
+ * scan order 2 out2
+ */
+ "tcmscan:3:0:1:2",
+ (const char *[]){LED_A0, LED_A1, LED_A2, LED_B0, LED_B1, LED_B2,
+ LED_C0, LED_C1, LED_C2, NULL},
+ },
+ { /* tcm 3 scan, scan order 0 out0; scan order 1 out1;
+ * scan order 2 out3
+ */
+ "tcmscan:3:0:1:3",
+ (const char *[]){LED_A0, LED_A1, LED_A2, LED_B0, LED_B1, LED_B2,
+ LED_D0, LED_D1, LED_D2, NULL},
+ },
+ { /* tcm 3 scan, scan order 0 out0; scan order 1 out2;
+ * scan order 2 out3
+ */
+ "tcmscan:3:0:2:3",
+ (const char *[]){LED_A0, LED_A1, LED_A2, LED_C0, LED_C1, LED_C2,
+ LED_D0, LED_D1, LED_D2, NULL},
+ },
+ { /* tcm 4 scan, scan order 0 out0; scan order 1 out1;
+ * scan order 2 out2; scan order 3 out3
+ */
+ "tcmscan:4:0:1:2:3",
+ (const char *[]){LED_A0, LED_A1, LED_A2, LED_B0, LED_B1, LED_B2,
+ LED_C0, LED_C1, LED_C2, LED_D0, LED_D1, LED_D2, NULL},
+ },
+ { /* mix 1 scan, direct connect out0; scan order 0 out1 */
+ "mixscan:1:0:1",
+ (const char *[]){LED0, LED_B0, LED_B1, NULL},
+ },
+ { /* mix 1 scan, direct connect out0; scan order 0 out2 */
+ "mixscan:1:0:2",
+ (const char *[]){LED0, LED_C0, LED_C2, NULL},
+ },
+ { /* mix 1 scan, direct connect out0; scan order 0 out3 */
+ "mixscan:1:0:3",
+ (const char *[]){LED0, LED_D1, LED_D2, NULL},
+ },
+ { /* mix 1 scan, direct connect out1; scan order 0 out0 */
+ "mixscan:1:1:0",
+ (const char *[]){LED1, LED_A1, LED_A2, NULL},
+ },
+ { /* mix 1 scan, direct connect out1; scan order 0 out2 */
+ "mixscan:1:1:2",
+ (const char *[]){LED1, LED_C0, LED_C1, NULL},
+ },
+ { /* mix 1 scan, direct connect out1; scan order 0 out3 */
+ "mixscan:1:1:3",
+ (const char *[]){LED1, LED_D0, LED_D2, NULL},
+ },
+ { /* mix 1 scan, direct connect out2; scan order 0 out0 */
+ "mixscan:1:2:0",
+ (const char *[]){LED2, LED_A0, LED_A2, NULL},
+ },
+ { /* mix 1 scan, direct connect out2; scan order 0 out1 */
+ "mixscan:1:2:1",
+ (const char *[]){LED2, LED_B1, LED_B2, NULL},
+ },
+ { /* mix 1 scan, direct connect out2; scan order 0 out3 */
+ "mixscan:1:2:3",
+ (const char *[]){LED2, LED_D0, LED_D1, NULL},
+ },
+ { /* mix 1 scan, direct connect out3; scan order 0 out0 */
+ "mixscan:1:3:0",
+ (const char *[]){LED3, LED_A0, LED_A1, NULL},
+ },
+ { /* mix 1 scan, direct connect out3; scan order 0 out1 */
+ "mixscan:1:3:1",
+ (const char *[]){LED3, LED_B0, LED_B2, NULL},
+ },
+ { /* mix 1 scan, direct connect out3; scan order 0 out2 */
+ "mixscan:1:3:2",
+ (const char *[]){LED3, LED_C1, LED_C2, NULL},
+ },
+ { /* mix 2 scan, direct connect out0; scan order 0 out1;
+ * scan order 1 out2
+ */
+ "mixscan:2:0:1:2",
+ (const char *[]){LED0, LED_B0, LED_B1, LED_C0, LED_C2, NULL},
+ },
+ { /* mix 2 scan, direct connect out0; scan order 0 out1;
+ * scan order 1 out3
+ */
+ "mixscan:2:0:1:3",
+ (const char *[]){LED0, LED_B0, LED_B1, LED_D1, LED_D2, NULL},
+ },
+ { /* mix 2 scan, direct connect out0; scan order 0 out2;
+ * scan order 1 out3
+ */
+ "mixscan:2:0:2:3",
+ (const char *[]){LED0, LED_C0, LED_C2, LED_D1, LED_D2, NULL},
+ },
+ { /* mix 2 scan, direct connect out1; scan order 0 out0;
+ * scan order 1 out2
+ */
+ "mixscan:2:1:0:2",
+ (const char *[]){LED1, LED_A1, LED_A2, LED_C0, LED_C1, NULL},
+ },
+ { /* mix 2 scan, direct connect out1; scan order 0 out0;
+ * scan order 1 out3
+ */
+ "mixscan:2:1:0:3",
+ (const char *[]){LED1, LED_A1, LED_A2, LED_D0, LED_D2, NULL},
+ },
+ { /* mix 2 scan, direct connect out1; scan order 0 out2;
+ * scan order 1 out3
+ */
+ "mixscan:2:1:2:3",
+ (const char *[]){LED1, LED_C0, LED_C1, LED_D0, LED_D2, NULL},
+ },
+ { /* mix 2 scan, direct connect out2; scan order 0 out0;
+ * scan order 1 out1
+ */
+ "mixscan:2:2:0:1",
+ (const char *[]){LED2, LED_A0, LED_A2, LED_B1, LED_B2, NULL},
+ },
+ { /* mix 2 scan, direct connect out2; scan order 0 out0;
+ * scan order 1 out3
+ */
+ "mixscan:2:2:0:3",
+ (const char *[]){LED2, LED_A0, LED_A2, LED_D0, LED_D1, NULL},
+ },
+ { /* mix 2 scan, direct connect out2; scan order 0 out1;
+ * scan order 1 out3
+ */
+ "mixscan:2:2:1:3",
+ (const char *[]){LED2, LED_B1, LED_B2, LED_D0, LED_D1, NULL},
+ },
+ { /* mix 2 scan, direct connect out3; scan order 0 out0;
+ * scan order 1 out1
+ */
+ "mixscan:2:3:0:1",
+ (const char *[]){LED3, LED_A0, LED_A1, LED_B0, LED_B2, NULL},
+ },
+ { /* mix 2 scan, direct connect out3; scan order 0 out0;
+ * scan order 1 out2
+ */
+ "mixscan:2:3:0:2",
+ (const char *[]){LED3, LED_A0, LED_A1, LED_C1, LED_C2, NULL},
+ },
+ { /* mix 2 scan, direct connect out3; scan order 0 out1;
+ * scan order 1 out2
+ */
+ "mixscan:2:3:1:2",
+ (const char *[]){LED3, LED_B0, LED_B2, LED_C1, LED_C2, NULL},
+ },
+ { /* mix 3 scan, direct connect out0; scan order 0 out1;
+ * scan order 1 out2; scan order 2 out3
+ */
+ "mixscan:3:0:1:2:3",
+ (const char *[]){LED0, LED_B0, LED_B1, LED_C0, LED_C2, LED_D1,
+ LED_D2, NULL},
+ },
+ { /* mix 3 scan, direct connect out1; scan order 0 out0;
+ * scan order 1 out2; scan order 2 out3
+ */
+ "mixscan:3:1:0:2:3",
+ (const char *[]){LED1, LED_A1, LED_A2, LED_C0, LED_C1, LED_D0,
+ LED_D2, NULL},
+ },
+ { /* mix 3 scan, direct connect out2; scan order 0 out0;
+ * scan order 1 out1; scan order 2 out3
+ */
+ "mixscan:3:2:0:1:3",
+ (const char *[]){LED2, LED_A0, LED_A2, LED_B1, LED_B2, LED_D0,
+ LED_D1, NULL},
+ },
+ { /* mix 3 scan, direct connect out3; scan order 0 out0;
+ * scan order 1 out1; scan order 2 out2
+ */
+ "mixscan:3:3:0:1:2",
+ (const char *[]){LED3, LED_A0, LED_A1, LED_B0, LED_B2, LED_C1,
+ LED_C2, NULL},
+ },
+};
+
+static const char *led_name_array[MAX_LEDS] = {
+ LED0, LED1, LED2, LED3, LED_A0, LED_A1, LED_A2, LED_B0, LED_B1,
+ LED_B2, LED_C0, LED_C1, LED_C2, LED_D0, LED_D1, LED_D2
+};
+
+static u16 anim_base_addr_array[MAX_LEDS] = {
+ LED0_AUTO_BASE_ADRR, LED1_AUTO_BASE_ADRR, LED2_AUTO_BASE_ADRR,
+ LED3_AUTO_BASE_ADRR, LED_A0_AUTO_BASE_ADRR, LED_A1_AUTO_BASE_ADRR,
+ LED_A2_AUTO_BASE_ADRR, LED_B0_AUTO_BASE_ADRR, LED_B1_AUTO_BASE_ADRR,
+ LED_B2_AUTO_BASE_ADRR, LED_C0_AUTO_BASE_ADRR, LED_C1_AUTO_BASE_ADRR,
+ LED_C2_AUTO_BASE_ADRR, LED_D0_AUTO_BASE_ADRR, LED_D1_AUTO_BASE_ADRR,
+ LED_D2_AUTO_BASE_ADRR
+};
+
+static const char *time_name_array[MAX_TIME] = {
+ TIME0, TIME1, TIME2, TIME3, TIME4, TIME5, TIME6, TIME7, TIME8,
+ TIME9, TIME10, TIME11, TIME12, TIME13, TIME14, TIME15
+};
+
+static const char *led_playback_time_arr[MAX_TIME] = {
+ "0 time", "1 time", "2 times", "3 times", "4 times", "5 times",
+ "6 times", "7 times", "8 times", "9 times", "10 times", "11 times",
+ "12 times", "13 times", "14 times", "infinite times"
+};
+
+static const char *aeu_name_array[MAX_AEU] = {AEU1, AEU2, AEU3};
+
+static const struct lp5812_specific_regs regs = {
+ .enable_reg = CHIP_EN_REG,
+ .reset_reg = RESET_REG,
+ .update_cmd_reg = CMD_UPDATE_REG,
+ .start_cmd_reg = CMD_START_REG,
+ .stop_cmd_reg = CMD_STOP_REG,
+ .pause_cmd_reg = CMD_PAUSE_REG,
+ .continue_cmd_reg = CMD_CONTINUE_REG,
+ .fault_clear_reg = FAULT_CLEAR_REG,
+ .tsd_config_status_reg = TSD_CONFIG_STAT_REG,
+};
+
+static void led_kobj_release(struct kobject *kobj)
+{
+ kfree(kobj);
+}
+
+static void aeu_kobj_release(struct kobject *kobj)
+{
+ kfree(kobj);
+}
+
+static const struct kobj_type led_ktype = {
+ .release = led_kobj_release,
+ .sysfs_ops = &kobj_sysfs_ops,
+};
+
+static const struct kobj_type aeu_ktype = {
+ .release = aeu_kobj_release,
+ .sysfs_ops = &kobj_sysfs_ops,
+};
+
+static int aeu_create_sysfs_group(struct anim_engine_unit *aeu)
+{
+ int ret = 0;
+
+ ret = kobject_add(&aeu->kobj, &aeu->led->kobj, "%s",
+ aeu->aeu_name);
+ if (ret)
+ return ret;
+ ret = sysfs_create_group(&aeu->kobj, &aeu->attr_group);
+ aeu->enabled = 1;
+
+ return ret;
+}
+
+static void aeu_remove_sysfs_group(struct anim_engine_unit *aeu)
+{
+ aeu->enabled = 0;
+ sysfs_remove_group(&aeu->kobj, &aeu->attr_group);
+ kobject_del(&aeu->kobj);
+}
+
+/* Function to remove multiple sysfs group of AEU in one led */
+static void aeu_remove_multi_sysfs_groups(struct lp5812_led *led)
+{
+ int i;
+
+ for (i = 0; i < led->total_aeu; i++) {
+ if (led->aeu[i].enabled)
+ aeu_remove_sysfs_group(&led->aeu[i]);
+ }
+}
+
+/*
+ * Function to create multi sysfs group for specific led. it will
+ * check the mode of led and AEU number selection to create
+ * corresponding AEU interfaces
+ */
+static int aeu_create_multi_sysfs_groups(struct lp5812_led *led)
+{
+ int i;
+ int aeu_select;
+ enum control_mode mode;
+ struct lp5812_chip *chip = led->priv;
+
+ if (lp5812_get_led_mode(chip, led->led_number, &mode))
+ return -EIO;
+ if (mode == AUTONOMOUS) {
+ if (led_get_autonomous_animation_config(led))
+ return -EIO;
+ aeu_select = led->led_playback.s_led_playback.aeu_selection;
+ if (aeu_select == 3)
+ aeu_select = 2;
+ for (i = 0; i < aeu_select + 1; i++)
+ aeu_create_sysfs_group(&led->aeu[i]);
+ }
+
+ return 0;
+}
+
+static int lp5812_create_sysfs_group(struct lp5812_led *led)
+{
+ int ret = 0;
+
+ ret = kobject_add(&led->kobj, &led->priv->dev->kobj, "%s",
+ led->led_name);
+ if (ret)
+ return ret;
+ ret = sysfs_create_group(&led->kobj, &led->attr_group);
+ if (ret)
+ return ret;
+ led->is_sysfs_created = 1;
+
+ return ret;
+}
+
+static void lp5812_remove_sysfs_group(struct lp5812_led *led)
+{
+ int i;
+
+ /* remove sysfs group of AEU */
+ for (i = 0; i < led->total_aeu; i++) {
+ if (led->aeu[i].enabled)
+ aeu_remove_sysfs_group(&led->aeu[i]);
+ }
+ led->is_sysfs_created = 0;
+ sysfs_remove_group(&led->kobj, &led->attr_group);
+ kobject_del(&led->kobj);
+}
+
+static ssize_t device_enable_store(struct device *dev,
+ struct device_attribute *attr,
+ const char *buf, size_t len)
+{
+ int enable;
+ int ret;
+ struct lp5812_chip *chip = i2c_get_clientdata(to_i2c_client(dev));
+
+ ret = kstrtoint(buf, 0, &enable);
+ if (ret)
+ return ret;
+
+ if (enable != 0 && enable != 1)
+ return -EINVAL; /* Invalid argument */
+
+ /* set to hardware */
+ mutex_lock(&chip->lock);
+ if (lp5812_enable_disable(chip, enable)) {
+ mutex_unlock(&chip->lock);
+ return -EIO;
+ }
+ mutex_unlock(&chip->lock);
+
+ return len;
+}
+
+static ssize_t device_enable_show(struct device *dev,
+ struct device_attribute *attr,
+ char *buf)
+{
+ u8 enable;
+ struct lp5812_chip *chip = i2c_get_clientdata(to_i2c_client(dev));
+
+ mutex_lock(&chip->lock);
+ if (lp5812_read(chip, chip->regs->enable_reg, &enable)) {
+ mutex_unlock(&chip->lock);
+ return -EIO;
+ }
+ mutex_unlock(&chip->lock);
+
+ return sprintf(buf, "%d\n", enable);
+}
+
+static ssize_t device_command_store(struct device *dev,
+ struct device_attribute *attr,
+ const char *buf, size_t len)
+{
+ struct lp5812_chip *chip = i2c_get_clientdata(to_i2c_client(dev));
+
+ mutex_lock(&chip->lock);
+ if (sysfs_streq(buf, "update")) {
+ lp5812_device_command(chip, UPDATE);
+ } else if (sysfs_streq(buf, "start")) {
+ lp5812_device_command(chip, START);
+ } else if (sysfs_streq(buf, "stop")) {
+ lp5812_device_command(chip, STOP);
+ } else if (sysfs_streq(buf, "pause")) {
+ lp5812_device_command(chip, PAUSE);
+ } else if (sysfs_streq(buf, "continue")) {
+ lp5812_device_command(chip, CONTINUE);
+ } else {
+ mutex_unlock(&chip->lock);
+ return -EINVAL;
+ }
+ mutex_unlock(&chip->lock);
+
+ return len;
+}
+
+static ssize_t device_reset_store(struct device *dev,
+ struct device_attribute *attr,
+ const char *buf, size_t len)
+{
+ int reset;
+ int ret;
+ struct lp5812_chip *chip = i2c_get_clientdata(to_i2c_client(dev));
+
+ ret = kstrtoint(buf, 0, &reset);
+ if (ret)
+ return ret;
+
+ if (reset != 1)
+ return -EINVAL; /* Invalid argument */
+
+ /* reset hardware */
+ mutex_lock(&chip->lock);
+ lp5812_reset(chip);
+ msleep(1000);
+ /* set back manual mode as default for all LEDs */
+ lp5812_write(chip, (u16)DEV_CONFIG3, 0x00);
+ lp5812_write(chip, (u16)DEV_CONFIG4, 0x00);
+ lp5812_update_regs_config(chip);
+ mutex_unlock(&chip->lock);
+
+ /* Update sysfs based on default mode when hardware reseted*/
+ ret = lp5812_init_dev_config(chip, "direct_mode", 1);
+ if (ret) {
+ dev_err(dev, "%s: lp5812_init_dev_config failed\n",
+ __func__);
+ return ret;
+ }
+
+ return len;
+}
+
+static ssize_t fault_clear_store(struct device *dev,
+ struct device_attribute *attr,
+ const char *buf, size_t len)
+{
+ int fault_clear;
+ int ret;
+ struct lp5812_chip *chip = i2c_get_clientdata(to_i2c_client(dev));
+
+ ret = kstrtoint(buf, 0, &fault_clear);
+ if (ret)
+ return ret;
+
+ if (fault_clear != 0 && fault_clear != 1 && fault_clear != 2 &&
+ fault_clear != 3) {
+ return -EINVAL;
+ }
+ mutex_lock(&chip->lock);
+ if (lp5812_fault_clear(chip, fault_clear)) {
+ mutex_unlock(&chip->lock);
+ return -EIO;
+ }
+ mutex_unlock(&chip->lock);
+
+ return len;
+}
+
+static void lp5812_create_sysfs_via_led_name(struct lp5812_chip *chip,
+ const char *led_name)
+{
+ int i;
+
+ for (i = 0; i < chip->total_leds; i++) {
+ if (sysfs_streq(led_name, chip->leds[i].led_name)) {
+ lp5812_create_sysfs_group(&chip->leds[i]);
+
+ /*
+ * create AEU interface if current led mode is
+ * autonomous
+ */
+ aeu_create_multi_sysfs_groups(&chip->leds[i]);
+ }
+ }
+}
+
+static void set_mix_sel_led(struct lp5812_chip *chip, int mix_sel_led)
+{
+ if (mix_sel_led == 0) {
+ chip->u_drive_mode.s_drive_mode.mix_sel_led_0 = 1;
+ chip->u_drive_mode.s_drive_mode.mix_sel_led_1 = 0;
+ chip->u_drive_mode.s_drive_mode.mix_sel_led_2 = 0;
+ chip->u_drive_mode.s_drive_mode.mix_sel_led_3 = 0;
+ }
+ if (mix_sel_led == 1) {
+ chip->u_drive_mode.s_drive_mode.mix_sel_led_0 = 0;
+ chip->u_drive_mode.s_drive_mode.mix_sel_led_1 = 1;
+ chip->u_drive_mode.s_drive_mode.mix_sel_led_2 = 0;
+ chip->u_drive_mode.s_drive_mode.mix_sel_led_3 = 0;
+ }
+ if (mix_sel_led == 2) {
+ chip->u_drive_mode.s_drive_mode.mix_sel_led_0 = 0;
+ chip->u_drive_mode.s_drive_mode.mix_sel_led_1 = 0;
+ chip->u_drive_mode.s_drive_mode.mix_sel_led_2 = 1;
+ chip->u_drive_mode.s_drive_mode.mix_sel_led_3 = 0;
+ }
+ if (mix_sel_led == 3) {
+ chip->u_drive_mode.s_drive_mode.mix_sel_led_0 = 0;
+ chip->u_drive_mode.s_drive_mode.mix_sel_led_1 = 0;
+ chip->u_drive_mode.s_drive_mode.mix_sel_led_2 = 0;
+ chip->u_drive_mode.s_drive_mode.mix_sel_led_3 = 1;
+ }
+}
+
+static void parse_drive_mode(struct lp5812_chip *chip, char *str)
+{
+ int ret;
+ char *sub_str;
+ int tcm_scan_num, mix_scan_num, mix_sel_led;
+ int scan_oder0, scan_oder1, scan_oder2, scan_oder3;
+
+ sub_str = strsep(&str, ":");
+ if (sysfs_streq(sub_str, "direct_mode")) {
+ chip->u_drive_mode.s_drive_mode.led_mode = 0;
+ chip->u_drive_mode.s_drive_mode.mix_sel_led_0 = 0;
+ chip->u_drive_mode.s_drive_mode.mix_sel_led_1 = 0;
+ chip->u_drive_mode.s_drive_mode.mix_sel_led_2 = 0;
+ chip->u_drive_mode.s_drive_mode.mix_sel_led_3 = 0;
+ }
+ if (sysfs_streq(sub_str, "tcmscan")) {
+ chip->u_drive_mode.s_drive_mode.mix_sel_led_0 = 0;
+ chip->u_drive_mode.s_drive_mode.mix_sel_led_1 = 0;
+ chip->u_drive_mode.s_drive_mode.mix_sel_led_2 = 0;
+ chip->u_drive_mode.s_drive_mode.mix_sel_led_3 = 0;
+
+ /* Get tcm scan number */
+ sub_str = strsep(&str, ":");
+ ret = kstrtoint(sub_str, 0, &tcm_scan_num);
+ if (ret)
+ return;
+ chip->u_drive_mode.s_drive_mode.led_mode = tcm_scan_num;
+ switch (tcm_scan_num) {
+ case TCM_1_SCAN:
+ /* Get scan_oder0 */
+ sub_str = strsep(&str, ":");
+ ret = kstrtoint(sub_str, 0, &scan_oder0);
+ if (ret)
+ return;
+ chip->u_scan_order.s_scan_order.scan_order_0 =
+ scan_oder0;
+ break;
+ case TCM_2_SCAN:
+ /* Get scan_order0 */
+ sub_str = strsep(&str, ":");
+ ret = kstrtoint(sub_str, 0, &scan_oder0);
+ if (ret)
+ return;
+ /* Get scan_order1 */
+ sub_str = strsep(&str, ":");
+ ret = kstrtoint(sub_str, 0, &scan_oder1);
+ if (ret)
+ return;
+ chip->u_scan_order.s_scan_order.scan_order_0 =
+ scan_oder0;
+ chip->u_scan_order.s_scan_order.scan_order_1 =
+ scan_oder1;
+ break;
+ case TCM_3_SCAN:
+ /* Get scan_order0 */
+ sub_str = strsep(&str, ":");
+ ret = kstrtoint(sub_str, 0, &scan_oder0);
+ if (ret)
+ return;
+ /* Get scan_order1 */
+ sub_str = strsep(&str, ":");
+ ret = kstrtoint(sub_str, 0, &scan_oder1);
+ if (ret)
+ return;
+ /* Get scan_order2 */
+ sub_str = strsep(&str, ":");
+ ret = kstrtoint(sub_str, 0, &scan_oder2);
+ if (ret)
+ return;
+ chip->u_scan_order.s_scan_order.scan_order_0 =
+ scan_oder0;
+ chip->u_scan_order.s_scan_order.scan_order_1 =
+ scan_oder1;
+ chip->u_scan_order.s_scan_order.scan_order_2 =
+ scan_oder2;
+ break;
+ case TCM_4_SCAN:
+ /* Get scan_order0 */
+ sub_str = strsep(&str, ":");
+ ret = kstrtoint(sub_str, 0, &scan_oder0);
+ if (ret)
+ return;
+ /* Get scan_order1 */
+ sub_str = strsep(&str, ":");
+ ret = kstrtoint(sub_str, 0, &scan_oder1);
+ if (ret)
+ return;
+ /* Get scan_order2 */
+ sub_str = strsep(&str, ":");
+ ret = kstrtoint(sub_str, 0, &scan_oder2);
+ if (ret)
+ return;
+ /* Get scan_order3 */
+ sub_str = strsep(&str, ":");
+ ret = kstrtoint(sub_str, 0, &scan_oder3);
+ if (ret)
+ return;
+ chip->u_scan_order.s_scan_order.scan_order_0 =
+ scan_oder0;
+ chip->u_scan_order.s_scan_order.scan_order_1 =
+ scan_oder1;
+ chip->u_scan_order.s_scan_order.scan_order_2 =
+ scan_oder2;
+ chip->u_scan_order.s_scan_order.scan_order_3 =
+ scan_oder3;
+ break;
+ default:
+ break;
+ }
+ }
+ if (sysfs_streq(sub_str, "mixscan")) {
+ /* Get mix scan number */
+ sub_str = strsep(&str, ":");
+ ret = kstrtoint(sub_str, 0, &mix_scan_num);
+ if (ret)
+ return;
+ chip->u_drive_mode.s_drive_mode.led_mode = mix_scan_num + 4;
+ /* Get mix_sel_led */
+ sub_str = strsep(&str, ":");
+ ret = kstrtoint(sub_str, 0, &mix_sel_led);
+ if (ret)
+ return;
+ set_mix_sel_led(chip, mix_sel_led);
+ if (mix_scan_num == 1) {
+ /* Get scan_order0 */
+ sub_str = strsep(&str, ":");
+ ret = kstrtoint(sub_str, 0, &scan_oder0);
+ if (ret)
+ return;
+ chip->u_scan_order.s_scan_order.scan_order_0 =
+ scan_oder0;
+ }
+ if (mix_scan_num == 2) {
+ /* Get scan_order0 */
+ sub_str = strsep(&str, ":");
+ ret = kstrtoint(sub_str, 0, &scan_oder0);
+ if (ret)
+ return;
+ /* Get scan_order1 */
+ sub_str = strsep(&str, ":");
+ ret = kstrtoint(sub_str, 0, &scan_oder1);
+ if (ret)
+ return;
+ chip->u_scan_order.s_scan_order.scan_order_0 =
+ scan_oder0;
+ chip->u_scan_order.s_scan_order.scan_order_1 =
+ scan_oder1;
+ }
+ if (mix_scan_num == 3) {
+ /* Get scan_order0 */
+ sub_str = strsep(&str, ":");
+ ret = kstrtoint(sub_str, 0, &scan_oder0);
+ if (ret)
+ return;
+ /* Get scan_order1 */
+ sub_str = strsep(&str, ":");
+ ret = kstrtoint(sub_str, 0, &scan_oder1);
+ if (ret)
+ return;
+ /* Get scan_order2 */
+ sub_str = strsep(&str, ":");
+ ret = kstrtoint(sub_str, 0, &scan_oder2);
+ if (ret)
+ return;
+ chip->u_scan_order.s_scan_order.scan_order_0 =
+ scan_oder0;
+ chip->u_scan_order.s_scan_order.scan_order_1 =
+ scan_oder1;
+ chip->u_scan_order.s_scan_order.scan_order_2 =
+ scan_oder2;
+ }
+ }
+}
+
+static void leds_remove_existed_sysfs(struct lp5812_chip *chip)
+{
+ int i;
+
+ for (i = 0; i < chip->total_leds; i++) {
+ if (chip->leds[i].is_sysfs_created)
+ lp5812_remove_sysfs_group(&chip->leds[i]);
+ }
+}
+
+/*
+ * Function to init scan order and drive mode and create sysfs
+ * for led.
+ * Params: chip -> lp5812 struct itself
+ * drive_mode -> for EX: tcmscan:2:1:2
+ * rm_led_sysfs -> 1 to remove, 0 -> else
+ */
+static int lp5812_init_dev_config(struct lp5812_chip *chip,
+ const char *drive_mode, int rm_led_sysfs)
+{
+ int i;
+ int num_drive_mode;
+ int is_valid_arg = 0;
+ char *str;
+ const char **led_ptr;
+
+ str = kmalloc(strlen(drive_mode) + 1, GFP_KERNEL);
+ if (!str)
+ return -ENOMEM;
+ strscpy(str, drive_mode, strlen(drive_mode) + 1);
+
+ num_drive_mode = ARRAY_SIZE(chip_leds_map);
+ for (i = 0; i < num_drive_mode; ++i) {
+ if (sysfs_streq(str, chip_leds_map[i].drive_mode)) {
+ if (rm_led_sysfs)
+ leds_remove_existed_sysfs(chip);
+ parse_drive_mode(chip, str);
+ led_ptr = chip_leds_map[i].led_arr;
+ while (*led_ptr) {
+ lp5812_create_sysfs_via_led_name(chip,
+ *led_ptr);
+ ++led_ptr;
+ }
+ is_valid_arg = 1;
+ break;
+ }
+ }
+ kfree(str);
+ if (!is_valid_arg)
+ return -EINVAL;
+
+ return 0;
+}
+
+static ssize_t dev_config_store(struct device *dev,
+ struct device_attribute *attr,
+ const char *buf, size_t len)
+{
+ int ret;
+ struct lp5812_chip *chip = i2c_get_clientdata(to_i2c_client(dev));
+
+ mutex_lock(&chip->lock);
+ ret = lp5812_init_dev_config(chip, buf, 1);
+ if (ret) {
+ dev_err(chip->dev, "%s: lp5812_init_dev_config failed\n",
+ __func__);
+ goto out;
+ }
+
+ /* set drive mode and scan order to hardware */
+ ret = lp5812_set_drive_mode_scan_order(chip);
+ if (ret) {
+ ret = -EIO;
+ goto out;
+ }
+ ret = lp5812_update_regs_config(chip);
+ if (ret) {
+ ret = -EIO;
+ goto out;
+ }
+
+ /* disable all LEDs that were previously enabled */
+ ret = lp5812_disable_all_leds(chip);
+ if (ret) {
+ ret = -EIO;
+ goto out;
+ }
+ mutex_unlock(&chip->lock);
+
+ return len;
+out:
+ mutex_unlock(&chip->lock);
+ return ret;
+}
+
+static char *parse_dev_config_info(struct lp5812_chip *chip)
+{
+ char *tmp;
+ int order_0, order_1, order_2, order_3;
+ char *scan_order_0 = " scan_order_0: ";
+ char *scan_order_1 = " scan_order_1: ";
+ char *scan_order_2 = " scan_order_2: ";
+ char *scan_order_3 = " scan_order_3: ";
+
+ tmp = kmalloc(128, GFP_KERNEL);
+ if (!tmp)
+ return NULL;
+
+ order_0 = chip->u_scan_order.s_scan_order.scan_order_0;
+ order_1 = chip->u_scan_order.s_scan_order.scan_order_1;
+ order_2 = chip->u_scan_order.s_scan_order.scan_order_2;
+ order_3 = chip->u_scan_order.s_scan_order.scan_order_3;
+
+ switch (chip->u_drive_mode.s_drive_mode.led_mode) {
+ case DIRECT_MODE:
+ sprintf(tmp, "%s", "Mode: direct mode;");
+ break;
+ case TCM_1_SCAN:
+ sprintf(tmp, "%s%s%d%s", "Mode: tcm 1 scan;", scan_order_0,
+ order_0, ";");
+ break;
+ case TCM_2_SCAN:
+ sprintf(tmp, "%s%s%d%s%s%d%s", "Mode: tcm 2 scan;",
+ scan_order_0, order_0, ";", scan_order_1, order_1, ";");
+ break;
+ case TCM_3_SCAN:
+ sprintf(tmp, "%s%s%d%s%s%d%s%s%d%s", "Mode: tcm 3 scan;",
+ scan_order_0, order_0, ";", scan_order_1, order_1,
+ ";", scan_order_2, order_2, ";");
+ break;
+ case TCM_4_SCAN:
+ sprintf(tmp, "%s%s%d%s%s%d%s%s%d%s%s%d%s", "Mode: tcm 4 scan;",
+ scan_order_0, order_0, ";", scan_order_1, order_1, ";",
+ scan_order_2, order_2, ";", scan_order_3, order_3, ";");
+ break;
+ case MIX_1_SCAN:
+ sprintf(tmp, "%s%s%d%s", "Mode: mix 1 scan;", scan_order_0,
+ order_0, ";");
+ break;
+ case MIX_2_SCAN:
+ sprintf(tmp, "%s%s%d%s%s%d%s", "Mode: mix 2 scan;",
+ scan_order_0, order_0, ";", scan_order_1, order_1, ";");
+ break;
+ case MIX_3_SCAN:
+ sprintf(tmp, "%s%s%d%s%s%d%s%s%d%s", "Mode: mix 3 scan;",
+ scan_order_0, order_0, ";", scan_order_1, order_1,
+ ";", scan_order_2, order_2, ";");
+ break;
+ }
+
+ if (chip->u_drive_mode.s_drive_mode.mix_sel_led_0)
+ strcat(tmp, " Direct output: OUT0;");
+ else if (chip->u_drive_mode.s_drive_mode.mix_sel_led_1)
+ strcat(tmp, " Direct output: OUT1;");
+ else if (chip->u_drive_mode.s_drive_mode.mix_sel_led_2)
+ strcat(tmp, " Direct output: OUT2;");
+ else if (chip->u_drive_mode.s_drive_mode.mix_sel_led_3)
+ strcat(tmp, " Direct output: OUT3;");
+ else
+ strcat(tmp, " Direct output: None;");
+ return tmp;
+}
+
+static ssize_t dev_config_show(struct device *dev,
+ struct device_attribute *attr,
+ char *buf)
+{
+ int i;
+ int num_drive_mode;
+ char *mode_info;
+ char *total_str;
+ size_t total_length;
+ char *const_str = "\nPlease select below valid drive mode:\n";
+ char *const_ex_str = "For Ex: echo tcmscan:1:0 > dev_config\n";
+ int ret = 0;
+ struct lp5812_chip *chip = i2c_get_clientdata(to_i2c_client(dev));
+
+ /* get drive mode and scan order */
+ mutex_lock(&chip->lock);
+ ret = lp5812_get_drive_mode_scan_order(chip);
+ mutex_unlock(&chip->lock);
+ if (ret)
+ return -EIO;
+
+ mode_info = parse_dev_config_info(chip);
+ if (!mode_info)
+ return -ENOMEM;
+
+ num_drive_mode = ARRAY_SIZE(chip_leds_map);
+ total_length = strlen(mode_info) + strlen(const_str) +
+ strlen(const_ex_str) + 1;
+ for (i = 0; i < num_drive_mode; ++i) {
+ total_length += strlen(chip_leds_map[i].drive_mode) +
+ strlen("\n");
+ }
+
+ total_str = kmalloc(total_length, GFP_KERNEL);
+ if (!total_str)
+ return -ENOMEM;
+
+ sprintf(total_str, "%s%s%s", mode_info, const_str, const_ex_str);
+ for (i = 0; i < num_drive_mode; ++i) {
+ strcat(total_str, chip_leds_map[i].drive_mode);
+ strcat(total_str, "\n");
+ }
+
+ ret = sprintf(buf, "%s", total_str);
+ kfree(mode_info);
+ kfree(total_str);
+
+ return ret;
+}
+
+static ssize_t tsd_config_status_show(struct device *dev,
+ struct device_attribute *attr,
+ char *buf)
+{
+ int ret;
+ u8 reg_val;
+ int tsd_stat;
+ int config_stat;
+ struct lp5812_chip *chip = i2c_get_clientdata(to_i2c_client(dev));
+
+ mutex_lock(&chip->lock);
+ ret = lp5812_read(chip, (u16)TSD_CONFIG_STAT_REG, ®_val);
+ mutex_unlock(&chip->lock);
+ if (ret)
+ return -EIO;
+ tsd_stat = (reg_val >> 1) & 0x01;
+ config_stat = reg_val & 0x01;
+
+ return sprintf(buf, "%d %d\n", tsd_stat, config_stat);
+}
+
+static LP5812_DEV_ATTR_RW(device_enable);
+static LP5812_DEV_ATTR_RW(dev_config);
+static LP5812_DEV_ATTR_WO(device_command);
+static LP5812_DEV_ATTR_WO(device_reset);
+static LP5812_DEV_ATTR_WO(fault_clear);
+static LP5812_DEV_ATTR_RO(tsd_config_status);
+
+static struct attribute *lp5812_chip_attributes[] = {
+ &dev_attr_device_enable.attr,
+ &dev_attr_device_command.attr,
+ &dev_attr_device_reset.attr,
+ &dev_attr_fault_clear.attr,
+ &dev_attr_dev_config.attr,
+ &dev_attr_tsd_config_status.attr,
+ NULL,
+};
+
+static ssize_t led_enable_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ u8 val = 0;
+ u16 reg = 0;
+ u8 reg_val = 0;
+ int ret = 0;
+ struct lp5812_led *led = to_lp5812_led(kobj);
+ struct lp5812_chip *chip = led->priv;
+
+ if (led->led_number < 0x8)
+ reg = LED_ENABLE_1_REG;
+ else
+ reg = LED_ENABLE_2_REG;
+
+ mutex_lock(&chip->lock);
+ ret = lp5812_read(chip, reg, ®_val);
+ mutex_unlock(&chip->lock);
+ if (ret)
+ return -EIO;
+
+ val = (reg_val & (1 << (led->led_number % 8))) ? 1 : 0;
+ return sprintf(buf, "%d\n", val);
+}
+
+static ssize_t led_enable_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf, size_t count)
+{
+ int val = 0;
+ u16 reg = 0;
+ u8 reg_val = 0;
+ int ret = 0;
+ struct lp5812_led *led = to_lp5812_led(kobj);
+ struct lp5812_chip *chip = led->priv;
+
+ ret = kstrtoint(buf, 0, &val);
+ if (ret)
+ return -EINVAL;
+
+ if (val != 0 && val != 1)
+ return -EINVAL;
+
+ if (led->led_number < 0x8)
+ reg = LED_ENABLE_1_REG;
+ else
+ reg = LED_ENABLE_2_REG;
+
+ mutex_lock(&chip->lock);
+ ret = lp5812_read(chip, reg, ®_val);
+ if (ret == 0) {
+ if (val == 0) {
+ ret = lp5812_write(chip, reg,
+ reg_val & (~(1 << (led->led_number % 8))));
+ } else {
+ ret = lp5812_write(chip, reg,
+ reg_val | (1 << (led->led_number % 8)));
+ }
+ }
+ mutex_unlock(&chip->lock);
+
+ if (ret)
+ return -EIO;
+
+ return count;
+}
+
+static ssize_t led_mode_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ int ret = 0;
+ enum control_mode mode;
+ struct lp5812_led *led = to_lp5812_led(kobj);
+ struct lp5812_chip *chip = led->priv;
+
+ mutex_lock(&chip->lock);
+ ret = lp5812_get_led_mode(chip, led->led_number, &mode);
+ mutex_unlock(&chip->lock);
+ if (ret)
+ return -EIO;
+
+ return sprintf(buf, "%s\n", AUTONOMOUS == mode ? "autonomous" : "manual");
+}
+
+static ssize_t led_mode_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf, size_t count)
+{
+ int val, ret;
+ struct lp5812_led *led = to_lp5812_led(kobj);
+ struct lp5812_chip *chip = led->priv;
+
+ if (sysfs_streq(buf, "manual")) {
+ /* Remove AEU sysfs interface for current led in manual mode */
+ aeu_remove_multi_sysfs_groups(led);
+ val = 0;
+ } else if (sysfs_streq(buf, "autonomous")) {
+ val = 1;
+ } else {
+ return -EINVAL;
+ }
+
+ mutex_lock(&chip->lock);
+ ret = lp5812_set_led_mode(chip, led->led_number,
+ val ? AUTONOMOUS : MANUAL);
+ if (ret) {
+ ret = -EIO;
+ goto out;
+ }
+
+ ret = aeu_create_multi_sysfs_groups(led);
+ if (ret) {
+ dev_err(chip->dev, "aeu_create_multi_sysfs_groups() failed\n");
+ goto out;
+ }
+
+ mutex_unlock(&chip->lock);
+ return count;
+out:
+ mutex_unlock(&chip->lock);
+ return ret;
+}
+
+static ssize_t led_manual_dc_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf, size_t count)
+{
+ int manual_dc;
+ int ret;
+ struct lp5812_led *led = to_lp5812_led(kobj);
+ struct lp5812_chip *chip = led->priv;
+
+ ret = kstrtoint(buf, 0, &manual_dc);
+ if (ret)
+ return ret;
+
+ if (manual_dc < 0 || manual_dc > 255)
+ return -EINVAL; /* Invalid argument */
+
+ /* set to hardware */
+ mutex_lock(&chip->lock);
+ if (lp5812_manual_dc_pwm_control(chip, led->led_number,
+ manual_dc, ANALOG)) {
+ mutex_unlock(&chip->lock);
+ return -EIO;
+ }
+ mutex_unlock(&chip->lock);
+
+ return count;
+}
+
+static ssize_t led_manual_dc_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ u8 val;
+ struct lp5812_led *led = to_lp5812_led(kobj);
+ struct lp5812_chip *chip = led->priv;
+
+ mutex_lock(&chip->lock);
+ if (lp5812_manual_dc_pwm_read(chip, led->led_number, &val, ANALOG)) {
+ mutex_unlock(&chip->lock);
+ return -EIO;
+ }
+ mutex_unlock(&chip->lock);
+ return sprintf(buf, "%d\n", val);
+}
+
+static ssize_t led_manual_pwm_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf, size_t count)
+{
+ int manual_pwm;
+ int ret;
+ struct lp5812_led *led = to_lp5812_led(kobj);
+ struct lp5812_chip *chip = led->priv;
+
+ ret = kstrtoint(buf, 0, &manual_pwm);
+ if (ret)
+ return ret;
+
+ if (manual_pwm < 0 || manual_pwm > 255)
+ return -EINVAL; /* Invalid argument */
+
+ /* set to hardware */
+ mutex_lock(&chip->lock);
+ if (lp5812_manual_dc_pwm_control(chip, led->led_number,
+ manual_pwm, PWM)) {
+ mutex_unlock(&chip->lock);
+ return -EIO;
+ }
+ mutex_unlock(&chip->lock);
+
+ return count;
+}
+
+static ssize_t led_manual_pwm_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ u8 val;
+ struct lp5812_led *led = to_lp5812_led(kobj);
+ struct lp5812_chip *chip = led->priv;
+
+ mutex_lock(&chip->lock);
+ if (lp5812_manual_dc_pwm_read(chip, led->led_number, &val, PWM)) {
+ mutex_unlock(&chip->lock);
+ return -EIO;
+ }
+ mutex_unlock(&chip->lock);
+ return sprintf(buf, "%d\n", val);
+}
+
+static ssize_t led_auto_dc_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf, size_t count)
+{
+ int auto_dc;
+ int ret;
+ struct lp5812_led *led = to_lp5812_led(kobj);
+ struct lp5812_chip *chip = led->priv;
+
+ ret = kstrtoint(buf, 0, &auto_dc);
+ if (ret)
+ return ret;
+
+ if (auto_dc < 0 || auto_dc > 255)
+ return -EINVAL; /* Invalid argument */
+
+ /* set to hardware */
+ mutex_lock(&chip->lock);
+ if (lp5812_autonomous_dc_pwm_control(chip, led->led_number,
+ auto_dc, ANALOG)) {
+ mutex_unlock(&chip->lock);
+ return -EIO;
+ }
+ mutex_unlock(&chip->lock);
+
+ return count;
+}
+
+static ssize_t led_auto_dc_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ u8 val;
+ struct lp5812_led *led = to_lp5812_led(kobj);
+ struct lp5812_chip *chip = led->priv;
+
+ mutex_lock(&chip->lock);
+ if (lp5812_autonomous_dc_pwm_read(chip, led->led_number,
+ &val, ANALOG)) {
+ mutex_unlock(&chip->lock);
+ return -EIO;
+ }
+ mutex_unlock(&chip->lock);
+ return sprintf(buf, "%d\n", val);
+}
+
+static int parse_autonomous_animation_config(struct lp5812_led *led,
+ const char *user_buf)
+{
+ int ret;
+ int i;
+ char *str;
+ char *sub_str;
+ int aeu_select, start_pause_time, stop_pause_time, led_playback_time;
+
+ str = kmalloc(strlen(user_buf) + 1, GFP_KERNEL);
+ if (!str)
+ return -ENOMEM;
+ strscpy(str, user_buf, strlen(user_buf) + 1);
+
+ /* parse aeu_select */
+ sub_str = strsep(&str, ":");
+ ret = kstrtoint(sub_str, 0, &aeu_select);
+ if (ret)
+ return ret;
+ if (aeu_select < 1 || aeu_select > 3)
+ return -EINVAL;
+
+ aeu_remove_multi_sysfs_groups(led);
+
+ for (i = 0; i < aeu_select; i++)
+ aeu_create_sysfs_group(&led->aeu[i]);
+ led->led_playback.s_led_playback.aeu_selection = aeu_select - 1;
+
+ /* parse start_pause_time */
+ sub_str = strsep(&str, ":");
+ if (sub_str) {
+ ret = kstrtoint(sub_str, 0, &start_pause_time);
+ if (ret)
+ return ret;
+ if (start_pause_time < 0 || start_pause_time > 15)
+ return -EINVAL;
+ led->start_stop_pause_time.s_time.second = start_pause_time;
+ } else {
+ led->start_stop_pause_time.s_time.second = 15;
+ }
+
+ /* parse stop_pause_time */
+ sub_str = strsep(&str, ":");
+ if (sub_str) {
+ ret = kstrtoint(sub_str, 0, &stop_pause_time);
+ if (ret)
+ return ret;
+ if (stop_pause_time < 0 || stop_pause_time > 15)
+ return -EINVAL;
+ led->start_stop_pause_time.s_time.first = stop_pause_time;
+ } else {
+ led->start_stop_pause_time.s_time.first = 15;
+ }
+
+ /* parse led_playback_time */
+ sub_str = strsep(&str, ":");
+ if (sub_str) {
+ ret = kstrtoint(sub_str, 0, &led_playback_time);
+ if (ret)
+ return ret;
+ if (led_playback_time < 0 || led_playback_time > 15)
+ return -EINVAL;
+ led->led_playback.s_led_playback.led_playback_time =
+ led_playback_time;
+ } else {
+ led->led_playback.s_led_playback.led_playback_time = 15;
+ }
+
+ return 0;
+}
+
+static ssize_t led_auto_animation_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf, size_t count)
+{
+ int ret;
+ enum control_mode led_mode;
+ struct lp5812_led *led = to_lp5812_led(kobj);
+ struct lp5812_chip *chip = led->priv;
+
+ mutex_lock(&chip->lock);
+ /* First check the mode of led is manual or autonomous */
+ ret = lp5812_get_led_mode(chip, led->led_number, &led_mode);
+ if (ret) {
+ ret = -EIO;
+ goto out;
+ }
+
+ if (led_mode == AUTONOMOUS) {
+ ret = parse_autonomous_animation_config(led, buf);
+ if (ret) {
+ dev_err(chip->dev, "parse_autonomous_animation_config failed\n");
+ goto out;
+ }
+ /* Write data to hardware */
+ ret = led_set_autonomous_animation_config(led);
+ if (ret) {
+ ret = -EIO;
+ goto out;
+ }
+ }
+ mutex_unlock(&chip->lock);
+ return count;
+
+out:
+ mutex_unlock(&chip->lock);
+ return ret;
+}
+
+static ssize_t led_auto_animation_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ int ret;
+ char tmp_str[256] = {};
+ char usage[128] = {};
+ char *aeu_select = "AEU Select: ";
+ char *start_pause_time = "Start pause time: ";
+ char *stop_pause_time = "; Stop pause time: ";
+ char *led_playback_time = "; LED Playback time: ";
+ int aeu_selection, playback_time, start_pause, stop_pause;
+ struct lp5812_led *led = to_lp5812_led(kobj);
+ struct lp5812_chip *chip = led->priv;
+
+ sprintf(usage, "%s%s",
+ "Command usage: echo (aeu number):(start pause time):",
+ "(stop pause time):(playback time) > autonomous_animation");
+
+ mutex_lock(&chip->lock);
+ ret = led_get_autonomous_animation_config(led);
+ if (ret) {
+ ret = -EIO;
+ goto out;
+ }
+
+ /* parse config and feedback to userspace */
+ aeu_selection = led->led_playback.s_led_playback.aeu_selection;
+ playback_time = led->led_playback.s_led_playback.led_playback_time;
+ start_pause = led->start_stop_pause_time.s_time.second;
+ stop_pause = led->start_stop_pause_time.s_time.first;
+ if (aeu_selection == ONLY_AEU1) {
+ sprintf(tmp_str, "%s%s%s%s%s%s%s%s\n", aeu_select,
+ "Only use AEU1; ", start_pause_time,
+ time_name_array[start_pause], stop_pause_time,
+ time_name_array[stop_pause], led_playback_time,
+ led_playback_time_arr[playback_time]);
+ } else if (aeu_selection == AEU1_AEU2) {
+ sprintf(tmp_str, "%s%s%s%s%s%s%s%s\n", aeu_select,
+ "Use AEU1 and AEU2; ", start_pause_time,
+ time_name_array[start_pause], stop_pause_time,
+ time_name_array[stop_pause], led_playback_time,
+ led_playback_time_arr[playback_time]);
+ } else {
+ sprintf(tmp_str, "%s%s%s%s%s%s%s%s\n", aeu_select,
+ "Use AEU1,AEU2 and AEU3; ", start_pause_time,
+ time_name_array[start_pause], stop_pause_time,
+ time_name_array[stop_pause], led_playback_time,
+ led_playback_time_arr[playback_time]);
+ }
+ strcat(tmp_str, usage);
+ mutex_unlock(&chip->lock);
+ return sprintf(buf, "%s\n", tmp_str);
+
+out:
+ mutex_unlock(&chip->lock);
+ return ret;
+}
+
+static ssize_t led_lod_lsd_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ int ret = 0;
+ u8 lsd_status, lod_status;
+ struct lp5812_led *led = to_lp5812_led(kobj);
+ struct lp5812_chip *chip = led->priv;
+
+ mutex_lock(&chip->lock);
+ ret = lp5812_read_lsd_status(chip, led->led_number, &lsd_status);
+ if (ret) {
+ mutex_unlock(&chip->lock);
+ return -EIO;
+ }
+
+ ret = lp5812_read_lod_status(chip, led->led_number, &lod_status);
+ if (ret) {
+ mutex_unlock(&chip->lock);
+ return -EIO;
+ }
+ mutex_unlock(&chip->lock);
+
+ return sprintf(buf, "%d %d\n", lod_status, lsd_status);
+}
+
+static ssize_t led_auto_pwm_val_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ int ret = 0;
+ u8 auto_pwm_val;
+ struct lp5812_led *led = to_lp5812_led(kobj);
+ struct lp5812_chip *chip = led->priv;
+
+ mutex_lock(&chip->lock);
+ ret = lp5812_read_auto_pwm_value(chip, led->led_number, &auto_pwm_val);
+ mutex_unlock(&chip->lock);
+ if (ret)
+ return -EIO;
+
+ return sprintf(buf, "%d\n", auto_pwm_val);
+}
+
+static ssize_t led_aep_status_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ int ret = 0;
+ u8 aep_status;
+ struct lp5812_led *led = to_lp5812_led(kobj);
+ struct lp5812_chip *chip = led->priv;
+
+ mutex_lock(&chip->lock);
+ ret = lp5812_read_aep_status(chip, led->led_number, &aep_status);
+ mutex_unlock(&chip->lock);
+ if (ret)
+ return -EIO;
+
+ return sprintf(buf, "%d\n", aep_status);
+}
+
+static ssize_t led_pwm_phase_align_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf, size_t count)
+{
+ int val, ret;
+ struct lp5812_led *led = to_lp5812_led(kobj);
+ struct lp5812_chip *chip = led->priv;
+
+ if (sysfs_streq(buf, "forward"))
+ val = 0;
+ else if (sysfs_streq(buf, "middle"))
+ val = 2;
+ else if (sysfs_streq(buf, "backward"))
+ val = 3;
+ else
+ return -EINVAL;
+ mutex_lock(&chip->lock);
+ ret = lp5812_set_phase_align(chip, led->led_number, val);
+ mutex_unlock(&chip->lock);
+ if (ret)
+ return -EIO;
+
+ return count;
+}
+
+static ssize_t led_pwm_phase_align_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ int val, ret;
+ char *str;
+ struct lp5812_led *led = to_lp5812_led(kobj);
+ struct lp5812_chip *chip = led->priv;
+
+ mutex_lock(&chip->lock);
+ ret = lp5812_get_phase_align(chip, led->led_number, &val);
+ mutex_unlock(&chip->lock);
+ if (ret)
+ return -EIO;
+ if (val == 0 || val == 1)
+ str = "forward";
+ else if (val == 2)
+ str = "middle";
+ else
+ str = "backward";
+
+ return sprintf(buf, "%s\n", str);
+}
+
+static ssize_t led_pwm_dimming_scale_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf, size_t count)
+{
+ int val, ret;
+ struct lp5812_led *led = to_lp5812_led(kobj);
+ struct lp5812_chip *chip = led->priv;
+
+ if (sysfs_streq(buf, "linear"))
+ val = 0;
+ else if (sysfs_streq(buf, "exponential"))
+ val = 1;
+ else
+ return -EINVAL;
+
+ mutex_lock(&chip->lock);
+ ret = lp5812_set_pwm_dimming_scale(chip, led->led_number,
+ val ? EXPONENTIAL : LINEAR);
+ mutex_unlock(&chip->lock);
+ if (ret)
+ return -EIO;
+
+ return count;
+}
+
+static ssize_t led_pwm_dimming_scale_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ int ret = 0;
+ enum pwm_dimming_scale scale;
+ struct lp5812_led *led = to_lp5812_led(kobj);
+ struct lp5812_chip *chip = led->priv;
+
+ mutex_lock(&chip->lock);
+ ret = lp5812_get_pwm_dimming_scale(chip, led->led_number, &scale);
+ mutex_unlock(&chip->lock);
+ if (ret)
+ return -EIO;
+
+ return sprintf(buf, "%s\n",
+ scale == EXPONENTIAL ? "exponential" : "linear");
+}
+
+static LP5812_KOBJ_ATTR_RW(enable, led_enable_show, led_enable_store);
+static LP5812_KOBJ_ATTR_RW(mode, led_mode_show, led_mode_store);
+static LP5812_KOBJ_ATTR_RW(manual_dc, led_manual_dc_show,
+ led_manual_dc_store);
+static LP5812_KOBJ_ATTR_RW(manual_pwm, led_manual_pwm_show,
+ led_manual_pwm_store);
+static LP5812_KOBJ_ATTR_RW(autonomous_dc, led_auto_dc_show,
+ led_auto_dc_store);
+static LP5812_KOBJ_ATTR_RW(autonomous_animation, led_auto_animation_show,
+ led_auto_animation_store);
+static LP5812_KOBJ_ATTR_RW(pwm_phase_align, led_pwm_phase_align_show,
+ led_pwm_phase_align_store);
+static LP5812_KOBJ_ATTR_RW(pwm_dimming_scale, led_pwm_dimming_scale_show,
+ led_pwm_dimming_scale_store);
+static LP5812_KOBJ_ATTR_RO(lod_lsd, led_lod_lsd_show);
+static LP5812_KOBJ_ATTR_RO(auto_pwm_val, led_auto_pwm_val_show);
+static LP5812_KOBJ_ATTR_RO(aep_status, led_aep_status_show);
+
+static struct attribute *led_kobj_attributes[] = {
+ &kobj_attr_enable.attr,
+ &kobj_attr_mode.attr,
+ &kobj_attr_manual_dc.attr,
+ &kobj_attr_manual_pwm.attr,
+ &kobj_attr_autonomous_dc.attr,
+ &kobj_attr_autonomous_animation.attr,
+ &kobj_attr_lod_lsd.attr,
+ &kobj_attr_auto_pwm_val.attr,
+ &kobj_attr_aep_status.attr,
+ &kobj_attr_pwm_phase_align.attr,
+ &kobj_attr_pwm_dimming_scale.attr,
+ NULL,
+};
+
+static ssize_t aeu_pwm1_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf, size_t count)
+{
+ int val = 0;
+ int ret = 0;
+ struct anim_engine_unit *aeu = to_anim_engine_unit(kobj);
+ struct lp5812_chip *chip = aeu->led->priv;
+
+ ret = kstrtoint(buf, 0, &val);
+ if (ret)
+ return -EINVAL;
+ if (val < 0 || val > 255)
+ return -EINVAL; /* Invalid argument */
+
+ mutex_lock(&chip->lock);
+ ret = led_aeu_pwm_set_val(aeu, val, PWM1);
+ if (ret != 0) {
+ mutex_unlock(&chip->lock);
+ return -EIO;
+ }
+ mutex_unlock(&chip->lock);
+
+ return count;
+}
+
+static ssize_t aeu_pwm1_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ int ret = 0;
+ u8 val = 0;
+ struct anim_engine_unit *aeu = to_anim_engine_unit(kobj);
+ struct lp5812_chip *chip = aeu->led->priv;
+
+ mutex_lock(&chip->lock);
+ ret = led_aeu_pwm_get_val(aeu, &val, PWM1);
+ mutex_unlock(&chip->lock);
+ if (ret)
+ return -EIO;
+
+ return sprintf(buf, "%d\n", val);
+}
+
+static ssize_t aeu_pwm2_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf, size_t count)
+{
+ int val = 0;
+ int ret = 0;
+ struct anim_engine_unit *aeu = to_anim_engine_unit(kobj);
+ struct lp5812_chip *chip = aeu->led->priv;
+
+ ret = kstrtoint(buf, 0, &val);
+ if (ret)
+ return -EINVAL;
+ if (val < 0 || val > 255)
+ return -EINVAL; /* Invalid argument */
+
+ mutex_lock(&chip->lock);
+ ret = led_aeu_pwm_set_val(aeu, val, PWM2);
+ if (ret != 0) {
+ mutex_unlock(&chip->lock);
+ return -EIO;
+ }
+ mutex_unlock(&chip->lock);
+
+ return count;
+}
+
+static ssize_t aeu_pwm2_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ int ret = 0;
+ u8 val = 0;
+ struct anim_engine_unit *aeu = to_anim_engine_unit(kobj);
+ struct lp5812_chip *chip = aeu->led->priv;
+
+ mutex_lock(&chip->lock);
+ ret = led_aeu_pwm_get_val(aeu, &val, PWM2);
+ mutex_unlock(&chip->lock);
+ if (ret)
+ return -EIO;
+
+ return sprintf(buf, "%d\n", val);
+}
+
+static ssize_t aeu_pwm3_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf, size_t count)
+{
+ int val = 0;
+ int ret = 0;
+ struct anim_engine_unit *aeu = to_anim_engine_unit(kobj);
+ struct lp5812_chip *chip = aeu->led->priv;
+
+ ret = kstrtoint(buf, 0, &val);
+ if (ret)
+ return -EINVAL;
+ if (val < 0 || val > 255)
+ return -EINVAL; /* Invalid argument */
+
+ mutex_lock(&chip->lock);
+ ret = led_aeu_pwm_set_val(aeu, val, PWM3);
+ if (ret != 0) {
+ mutex_unlock(&chip->lock);
+ return -EIO;
+ }
+ mutex_unlock(&chip->lock);
+
+ return count;
+}
+
+static ssize_t aeu_pwm3_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ int ret = 0;
+ u8 val = 0;
+ struct anim_engine_unit *aeu = to_anim_engine_unit(kobj);
+ struct lp5812_chip *chip = aeu->led->priv;
+
+ mutex_lock(&chip->lock);
+ ret = led_aeu_pwm_get_val(aeu, &val, PWM3);
+ mutex_unlock(&chip->lock);
+ if (ret)
+ return -EIO;
+
+ return sprintf(buf, "%d\n", val);
+}
+
+static ssize_t aeu_pwm4_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf, size_t count)
+{
+ int val = 0;
+ int ret = 0;
+ struct anim_engine_unit *aeu = to_anim_engine_unit(kobj);
+ struct lp5812_chip *chip = aeu->led->priv;
+
+ ret = kstrtoint(buf, 0, &val);
+ if (ret)
+ return -EINVAL;
+ if (val < 0 || val > 255)
+ return -EINVAL; /* Invalid argument */
+
+ mutex_lock(&chip->lock);
+ ret = led_aeu_pwm_set_val(aeu, val, PWM4);
+ if (ret != 0) {
+ mutex_unlock(&chip->lock);
+ return -EIO;
+ }
+ mutex_unlock(&chip->lock);
+
+ return count;
+}
+
+static ssize_t aeu_pwm4_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ int ret = 0;
+ u8 val = 0;
+ struct anim_engine_unit *aeu = to_anim_engine_unit(kobj);
+ struct lp5812_chip *chip = aeu->led->priv;
+
+ mutex_lock(&chip->lock);
+ ret = led_aeu_pwm_get_val(aeu, &val, PWM4);
+ mutex_unlock(&chip->lock);
+ if (ret)
+ return -EIO;
+
+ return sprintf(buf, "%d\n", val);
+}
+
+static ssize_t aeu_pwm5_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf, size_t count)
+{
+ int val = 0;
+ int ret = 0;
+ struct anim_engine_unit *aeu = to_anim_engine_unit(kobj);
+ struct lp5812_chip *chip = aeu->led->priv;
+
+ ret = kstrtoint(buf, 0, &val);
+ if (ret)
+ return -EINVAL;
+ if (val < 0 || val > 255)
+ return -EINVAL; /* Invalid argument */
+
+ mutex_lock(&chip->lock);
+ ret = led_aeu_pwm_set_val(aeu, val, PWM5);
+ if (ret != 0) {
+ mutex_unlock(&chip->lock);
+ return -EIO;
+ }
+ mutex_unlock(&chip->lock);
+
+ return count;
+}
+
+static ssize_t aeu_pwm5_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ int ret = 0;
+ u8 val = 0;
+ struct anim_engine_unit *aeu = to_anim_engine_unit(kobj);
+ struct lp5812_chip *chip = aeu->led->priv;
+
+ mutex_lock(&chip->lock);
+ ret = led_aeu_pwm_get_val(aeu, &val, PWM5);
+ mutex_unlock(&chip->lock);
+ if (ret)
+ return -EIO;
+
+ return sprintf(buf, "%d\n", val);
+}
+
+static ssize_t aeu_slope_time_t1_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf, size_t count)
+{
+ int val = 0;
+ int ret = 0;
+ struct anim_engine_unit *aeu = to_anim_engine_unit(kobj);
+ struct lp5812_chip *chip = aeu->led->priv;
+
+ ret = kstrtoint(buf, 0, &val);
+ if (ret)
+ return -EINVAL;
+
+ if (val < 0x00 || val > 0x0F)
+ return -EINVAL;
+
+ mutex_lock(&chip->lock);
+ ret = led_aeu_slope_time_set_val(aeu, val, SLOPE_T1);
+ if (ret != 0) {
+ mutex_unlock(&chip->lock);
+ return -EIO;
+ }
+ mutex_unlock(&chip->lock);
+
+ return count;
+}
+
+static ssize_t aeu_slope_time_t1_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ int ret = 0;
+ u8 val = 0;
+ struct anim_engine_unit *aeu = to_anim_engine_unit(kobj);
+ struct lp5812_chip *chip = aeu->led->priv;
+
+ mutex_lock(&chip->lock);
+ ret = led_aeu_slope_time_get_val(aeu, &val, SLOPE_T1);
+ mutex_unlock(&chip->lock);
+ if (ret)
+ return -EIO;
+
+ return sprintf(buf, "%d\n", val);
+}
+
+static ssize_t aeu_slope_time_t2_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf, size_t count)
+{
+ int val = 0;
+ int ret = 0;
+ struct anim_engine_unit *aeu = to_anim_engine_unit(kobj);
+ struct lp5812_chip *chip = aeu->led->priv;
+
+ ret = kstrtoint(buf, 0, &val);
+ if (ret)
+ return -EINVAL;
+
+ if (val < 0x00 || val > 0x0F)
+ return -EINVAL;
+
+ mutex_lock(&chip->lock);
+ ret = led_aeu_slope_time_set_val(aeu, val, SLOPE_T2);
+ if (ret != 0) {
+ mutex_unlock(&chip->lock);
+ return -EIO;
+ }
+ mutex_unlock(&chip->lock);
+
+ return count;
+}
+
+static ssize_t aeu_slope_time_t2_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ int ret = 0;
+ u8 val = 0;
+ struct anim_engine_unit *aeu = to_anim_engine_unit(kobj);
+ struct lp5812_chip *chip = aeu->led->priv;
+
+ mutex_lock(&chip->lock);
+ ret = led_aeu_slope_time_get_val(aeu, &val, SLOPE_T2);
+ mutex_unlock(&chip->lock);
+ if (ret)
+ return -EIO;
+
+ return sprintf(buf, "%d\n", val);
+}
+
+static ssize_t aeu_slope_time_t3_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf, size_t count)
+{
+ int val = 0;
+ int ret = 0;
+ struct anim_engine_unit *aeu = to_anim_engine_unit(kobj);
+ struct lp5812_chip *chip = aeu->led->priv;
+
+ ret = kstrtoint(buf, 0, &val);
+ if (ret)
+ return -EINVAL;
+
+ if (val < 0x00 || val > 0x0F)
+ return -EINVAL;
+
+ mutex_lock(&chip->lock);
+ ret = led_aeu_slope_time_set_val(aeu, val, SLOPE_T3);
+ if (ret != 0) {
+ mutex_unlock(&chip->lock);
+ return -EIO;
+ }
+ mutex_unlock(&chip->lock);
+
+ return count;
+}
+
+static ssize_t aeu_slope_time_t3_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ int ret = 0;
+ u8 val = 0;
+ struct anim_engine_unit *aeu = to_anim_engine_unit(kobj);
+ struct lp5812_chip *chip = aeu->led->priv;
+
+ mutex_lock(&chip->lock);
+ ret = led_aeu_slope_time_get_val(aeu, &val, SLOPE_T3);
+ mutex_unlock(&chip->lock);
+ if (ret)
+ return -EIO;
+
+ return sprintf(buf, "%d\n", val);
+}
+
+static ssize_t aeu_slope_time_t4_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf, size_t count)
+{
+ int val = 0;
+ int ret = 0;
+ struct anim_engine_unit *aeu = to_anim_engine_unit(kobj);
+ struct lp5812_chip *chip = aeu->led->priv;
+
+ ret = kstrtoint(buf, 0, &val);
+ if (ret)
+ return -EINVAL;
+
+ if (val < 0x00 || val > 0x0F)
+ return -EINVAL;
+
+ mutex_lock(&chip->lock);
+ ret = led_aeu_slope_time_set_val(aeu, val, SLOPE_T4);
+ if (ret != 0) {
+ mutex_unlock(&chip->lock);
+ return -EIO;
+ }
+ mutex_unlock(&chip->lock);
+
+ return count;
+}
+
+static ssize_t aeu_slope_time_t4_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ int ret = 0;
+ u8 val = 0;
+ struct anim_engine_unit *aeu = to_anim_engine_unit(kobj);
+ struct lp5812_chip *chip = aeu->led->priv;
+
+ mutex_lock(&chip->lock);
+ ret = led_aeu_slope_time_get_val(aeu, &val, SLOPE_T4);
+ mutex_unlock(&chip->lock);
+ if (ret)
+ return -EIO;
+
+ return sprintf(buf, "%d\n", val);
+}
+
+static ssize_t aeu_playback_time_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf, size_t count)
+{
+ int val = 0;
+ int ret = 0;
+ struct anim_engine_unit *aeu = to_anim_engine_unit(kobj);
+ struct lp5812_chip *chip = aeu->led->priv;
+
+ ret = kstrtoint(buf, 0, &val);
+ if (ret)
+ return -EINVAL;
+
+ if (val < 0 || val > 3)
+ return -EINVAL;
+
+ mutex_lock(&chip->lock);
+ ret = led_aeu_playback_time_set_val(aeu, val);
+ if (ret != 0) {
+ mutex_unlock(&chip->lock);
+ return -EIO;
+ }
+ mutex_unlock(&chip->lock);
+
+ return count;
+}
+
+static ssize_t aeu_playback_time_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ int ret = 0;
+ u8 val = 0;
+ struct anim_engine_unit *aeu = to_anim_engine_unit(kobj);
+ struct lp5812_chip *chip = aeu->led->priv;
+
+ mutex_lock(&chip->lock);
+ ret = led_aeu_playback_time_get_val(aeu, &val);
+ if (ret != 0) {
+ mutex_unlock(&chip->lock);
+ return -EIO;
+ }
+ mutex_unlock(&chip->lock);
+
+ return sprintf(buf, "%d\n", val);
+}
+
+static LP5812_KOBJ_ATTR_RW(pwm1, aeu_pwm1_show, aeu_pwm1_store);
+static LP5812_KOBJ_ATTR_RW(pwm2, aeu_pwm2_show, aeu_pwm2_store);
+static LP5812_KOBJ_ATTR_RW(pwm3, aeu_pwm3_show, aeu_pwm3_store);
+static LP5812_KOBJ_ATTR_RW(pwm4, aeu_pwm4_show, aeu_pwm4_store);
+static LP5812_KOBJ_ATTR_RW(pwm5, aeu_pwm5_show, aeu_pwm5_store);
+static LP5812_KOBJ_ATTR_RW(slope_time_t1, aeu_slope_time_t1_show,
+ aeu_slope_time_t1_store);
+static LP5812_KOBJ_ATTR_RW(slope_time_t2, aeu_slope_time_t2_show,
+ aeu_slope_time_t2_store);
+static LP5812_KOBJ_ATTR_RW(slope_time_t3, aeu_slope_time_t3_show,
+ aeu_slope_time_t3_store);
+static LP5812_KOBJ_ATTR_RW(slope_time_t4, aeu_slope_time_t4_show,
+ aeu_slope_time_t4_store);
+static LP5812_KOBJ_ATTR_RW(playback_time, aeu_playback_time_show,
+ aeu_playback_time_store);
+
+static struct attribute *aeu_kobj_attributes[] = {
+ &kobj_attr_pwm1.attr,
+ &kobj_attr_pwm2.attr,
+ &kobj_attr_pwm3.attr,
+ &kobj_attr_pwm4.attr,
+ &kobj_attr_pwm5.attr,
+ &kobj_attr_slope_time_t1.attr,
+ &kobj_attr_slope_time_t2.attr,
+ &kobj_attr_slope_time_t3.attr,
+ &kobj_attr_slope_time_t4.attr,
+ &kobj_attr_playback_time.attr,
+ NULL,
+};
+
+static void aeu_init_properties(struct lp5812_led *led)
+{
+ int i;
+
+ for (i = 0; i < MAX_AEU; i++) {
+ led->aeu[i].aeu_name = aeu_name_array[i];
+ led->aeu[i].aeu_number = i + 1;
+ led->aeu[i].led = led;
+ led->aeu[i].enabled = 0;
+ led->aeu[i].attr_group.attrs = aeu_kobj_attributes;
+ kobject_init(&led->aeu[i].kobj, &aeu_ktype);
+ }
+}
+
+static int lp5812_probe(struct i2c_client *client)
+{
+ struct lp5812_chip *chip;
+ int i;
+ int ret;
+ u8 val;
+
+ chip = devm_kzalloc(&client->dev, sizeof(struct lp5812_chip),
+ GFP_KERNEL);
+ if (!chip)
+ return -ENOMEM;
+ mutex_init(&chip->lock);
+ chip->i2c_cl = client;
+ chip->dev = &client->dev;
+ chip->regs = ®s;
+ chip->command = NONE;
+ chip->total_leds = MAX_LEDS;
+ chip->attr_group.name = "lp5812_chip_setup";
+ chip->attr_group.attrs = lp5812_chip_attributes;
+ chip->chip_leds_map = chip_leds_map;
+ chip->u_drive_mode.drive_mode_val = 0x10;
+ chip->u_scan_order.scan_order_val = 0x00;
+
+ /* initialize property for each led */
+ for (i = 0; i < MAX_LEDS; i++) {
+ chip->leds[i].led_name = led_name_array[i];
+ chip->leds[i].led_number = i;
+ chip->leds[i].anim_base_addr = anim_base_addr_array[i];
+ chip->leds[i].enable = 0; /* LED disable as default */
+ chip->leds[i].mode = MANUAL; /* manual mode as default */
+ chip->leds[i].priv = chip;
+ chip->leds[i].total_aeu = MAX_AEU;
+ chip->leds[i].led_playback.led_playback_val = 0;
+ chip->leds[i].start_stop_pause_time.time_val = 0;
+ /* sysfs for this led not be created */
+ chip->leds[i].is_sysfs_created = 0;
+ chip->leds[i].attr_group.attrs = led_kobj_attributes;
+ kobject_init(&chip->leds[i].kobj, &led_ktype);
+
+ /* init animation engine unit properties */
+ aeu_init_properties(&chip->leds[i]);
+
+ /* set autonomous animation config as default for all LEDs */
+ led_set_autonomous_animation_config(&chip->leds[i]);
+ }
+
+ i2c_set_clientdata(client, chip);
+
+ ret = sysfs_create_group(&chip->dev->kobj, &chip->attr_group);
+ if (ret) {
+ dev_err(chip->dev, "sysfs_create_group failed\n");
+ return ret;
+ }
+
+ ret = lp5812_init_dev_config(chip, "tcmscan:4:0:1:2:3", 0);
+ if (ret) {
+ dev_err(chip->dev, "%s: lp5812_init_dev_config failed\n",
+ __func__);
+ return ret;
+ }
+ /* initialize lp5812 chip */
+ ret = lp5812_initialize(chip);
+
+ /* code to verify i2c read/write ok or not */
+ lp5812_read(chip, (u16)DEV_CONFIG2, &val);
+
+ lp5812_write(chip, (u16)LED_A1_AUTO_BASE_ADRR, 0x14);
+ lp5812_read(chip, (u16)LED_A1_AUTO_BASE_ADRR, &val);
+ /* End code to verify i2c read/write*/
+
+ return 0;
+}
+
+static void lp5812_remove(struct i2c_client *client)
+{
+ struct lp5812_chip *chip = i2c_get_clientdata(client);
+
+ mutex_destroy(&chip->lock);
+ leds_remove_existed_sysfs(chip);
+ sysfs_remove_group(&chip->dev->kobj, &chip->attr_group);
+
+ /* Disable all Leds */
+ lp5812_disable_all_leds(chip);
+
+ /* Disable lp5812 device */
+ lp5812_enable_disable(chip, 0);
+}
+
+static const struct i2c_device_id lp5812_id[] = {
+ { "lp5812", 0 },
+ { }
+};
+
+MODULE_DEVICE_TABLE(i2c, lp5812_id);
+
+#ifdef CONFIG_OF
+static const struct of_device_id of_lp5812_match[] = {
+ { .compatible = "ti,lp5812", },
+ {/* NULL */},
+};
+
+MODULE_DEVICE_TABLE(of, of_lp5812_match);
+#endif
+
+static struct i2c_driver lp5812_driver = {
+ .driver = {
+ .name = "lp5812",
+ .of_match_table = of_match_ptr(of_lp5812_match),
+ },
+ .probe = lp5812_probe,
+ .remove = lp5812_remove,
+ .id_table = lp5812_id,
+};
+
+module_i2c_driver(lp5812_driver);
+
+MODULE_DESCRIPTION("Texas Instruments LP5812 LED Driver");
+MODULE_AUTHOR("Jared Zhou");
+MODULE_LICENSE("GPL");
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH v3 3/3] leds: add new LED driver for TI LP5812
2025-03-06 17:21 ` [PATCH v3 3/3] leds: add new LED driver for TI LP5812 Nam Tran
@ 2025-03-06 18:53 ` Christophe JAILLET
2025-03-07 8:52 ` Krzysztof Kozlowski
` (4 subsequent siblings)
5 siblings, 0 replies; 26+ messages in thread
From: Christophe JAILLET @ 2025-03-06 18:53 UTC (permalink / raw)
To: trannamatk
Cc: conor+dt, devicetree, krzk+dt, lee, linux-kernel, linux-leds,
pavel, robh
Le 06/03/2025 à 18:21, Nam Tran a écrit :
> The chip can drive LED matrix 4x3.
> This driver enables LED control via I2C.
>
> The driver is implemented in two parts:
> - Core driver logic in leds-lp5812.c
> - Common support functions in leds-lp5812-common.c
>
> Signed-off-by: Nam Tran <trannamatk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
A few comments/nitpicks.
Some of them can be applied in several places, I've not spotted all of
them, but you get the idea.
Hoping, this will help to clean the code and help other reviewers.
> +
> +static ssize_t led_mode_store(struct kobject *kobj,
> + struct kobj_attribute *attr, const char *buf, size_t count)
> +{
> + int val, ret;
> + struct lp5812_led *led = to_lp5812_led(kobj);
> + struct lp5812_chip *chip = led->priv;
> +
> + if (sysfs_streq(buf, "manual")) {
> + /* Remove AEU sysfs interface for current led in manual mode */
> + aeu_remove_multi_sysfs_groups(led);
> + val = 0;
Maybe use AUTONOMOUS or MANUAL directly.
> + } else if (sysfs_streq(buf, "autonomous")) {
> + val = 1;
> + } else {
> + return -EINVAL;
> + }
> +
> + mutex_lock(&chip->lock);
> + ret = lp5812_set_led_mode(chip, led->led_number,
> + val ? AUTONOMOUS : MANUAL);
> + if (ret) {
> + ret = -EIO;
> + goto out;
> + }
> +
> + ret = aeu_create_multi_sysfs_groups(led);
> + if (ret) {
> + dev_err(chip->dev, "aeu_create_multi_sysfs_groups() failed\n");
> + goto out;
> + }
> +
> + mutex_unlock(&chip->lock);
> + return count;
> +out:
> + mutex_unlock(&chip->lock);
> + return ret;
> +}
...
> +static ssize_t led_manual_pwm_store(struct kobject *kobj,
> + struct kobj_attribute *attr, const char *buf, size_t count)
> +{
> + int manual_pwm;
> + int ret;
> + struct lp5812_led *led = to_lp5812_led(kobj);
> + struct lp5812_chip *chip = led->priv;
> +
> + ret = kstrtoint(buf, 0, &manual_pwm);
> + if (ret)
> + return ret;
> +
> + if (manual_pwm < 0 || manual_pwm > 255)
> + return -EINVAL; /* Invalid argument */
Useless comment (here and in several other places)
> +
> + /* set to hardware */
> + mutex_lock(&chip->lock);
> + if (lp5812_manual_dc_pwm_control(chip, led->led_number,
> + manual_pwm, PWM)) {
> + mutex_unlock(&chip->lock);
> + return -EIO;
> + }
> + mutex_unlock(&chip->lock);
> +
> + return count;
> +}
...
> +static ssize_t led_auto_dc_store(struct kobject *kobj,
> + struct kobj_attribute *attr, const char *buf, size_t count)
> +{
> + int auto_dc;
> + int ret;
> + struct lp5812_led *led = to_lp5812_led(kobj);
> + struct lp5812_chip *chip = led->priv;
> +
> + ret = kstrtoint(buf, 0, &auto_dc);
> + if (ret)
> + return ret;
> +
> + if (auto_dc < 0 || auto_dc > 255)
> + return -EINVAL; /* Invalid argument */
Useless comment
> +
> + /* set to hardware */
> + mutex_lock(&chip->lock);
> + if (lp5812_autonomous_dc_pwm_control(chip, led->led_number,
> + auto_dc, ANALOG)) {
> + mutex_unlock(&chip->lock);
> + return -EIO;
> + }
> + mutex_unlock(&chip->lock);
> +
> + return count;
> +}
...
> +static int parse_autonomous_animation_config(struct lp5812_led *led,
> + const char *user_buf)
> +{
> + int ret;
> + int i;
> + char *str;
> + char *sub_str;
> + int aeu_select, start_pause_time, stop_pause_time, led_playback_time;
> +
> + str = kmalloc(strlen(user_buf) + 1, GFP_KERNEL);
kstrdup()?
> + if (!str)
> + return -ENOMEM;
> + strscpy(str, user_buf, strlen(user_buf) + 1);
> +
> + /* parse aeu_select */
> + sub_str = strsep(&str, ":");
> + ret = kstrtoint(sub_str, 0, &aeu_select);
> + if (ret)
> + return ret;
> + if (aeu_select < 1 || aeu_select > 3)
> + return -EINVAL;
> +
> + aeu_remove_multi_sysfs_groups(led);
> +
> + for (i = 0; i < aeu_select; i++)
> + aeu_create_sysfs_group(&led->aeu[i]);
> + led->led_playback.s_led_playback.aeu_selection = aeu_select - 1;
> +
> + /* parse start_pause_time */
> + sub_str = strsep(&str, ":");
> + if (sub_str) {
> + ret = kstrtoint(sub_str, 0, &start_pause_time);
> + if (ret)
> + return ret;
> + if (start_pause_time < 0 || start_pause_time > 15)
> + return -EINVAL;
> + led->start_stop_pause_time.s_time.second = start_pause_time;
> + } else {
> + led->start_stop_pause_time.s_time.second = 15;
> + }
> +
> + /* parse stop_pause_time */
> + sub_str = strsep(&str, ":");
> + if (sub_str) {
> + ret = kstrtoint(sub_str, 0, &stop_pause_time);
> + if (ret)
> + return ret;
> + if (stop_pause_time < 0 || stop_pause_time > 15)
> + return -EINVAL;
> + led->start_stop_pause_time.s_time.first = stop_pause_time;
> + } else {
> + led->start_stop_pause_time.s_time.first = 15;
> + }
> +
> + /* parse led_playback_time */
> + sub_str = strsep(&str, ":");
> + if (sub_str) {
> + ret = kstrtoint(sub_str, 0, &led_playback_time);
> + if (ret)
> + return ret;
> + if (led_playback_time < 0 || led_playback_time > 15)
> + return -EINVAL;
> + led->led_playback.s_led_playback.led_playback_time =
> + led_playback_time;
> + } else {
> + led->led_playback.s_led_playback.led_playback_time = 15;
> + }
> +
> + return 0;
> +}
...
> +static ssize_t led_auto_animation_show(struct kobject *kobj,
> + struct kobj_attribute *attr, char *buf)
> +{
> + int ret;
> + char tmp_str[256] = {};
> + char usage[128] = {};
> + char *aeu_select = "AEU Select: ";
> + char *start_pause_time = "Start pause time: ";
> + char *stop_pause_time = "; Stop pause time: ";
> + char *led_playback_time = "; LED Playback time: ";
> + int aeu_selection, playback_time, start_pause, stop_pause;
> + struct lp5812_led *led = to_lp5812_led(kobj);
> + struct lp5812_chip *chip = led->priv;
> +
> + sprintf(usage, "%s%s",
> + "Command usage: echo (aeu number):(start pause time):",
> + "(stop pause time):(playback time) > autonomous_animation");
> +
> + mutex_lock(&chip->lock);
> + ret = led_get_autonomous_animation_config(led);
> + if (ret) {
> + ret = -EIO;
> + goto out;
> + }
> +
> + /* parse config and feedback to userspace */
> + aeu_selection = led->led_playback.s_led_playback.aeu_selection;
> + playback_time = led->led_playback.s_led_playback.led_playback_time;
> + start_pause = led->start_stop_pause_time.s_time.second;
> + stop_pause = led->start_stop_pause_time.s_time.first;
> + if (aeu_selection == ONLY_AEU1) {
> + sprintf(tmp_str, "%s%s%s%s%s%s%s%s\n", aeu_select,
Maybe add a least 1 tab for all this parameters, to improve readability?
> + "Only use AEU1; ", start_pause_time,
> + time_name_array[start_pause], stop_pause_time,
> + time_name_array[stop_pause], led_playback_time,
> + led_playback_time_arr[playback_time]);
> + } else if (aeu_selection == AEU1_AEU2) {
> + sprintf(tmp_str, "%s%s%s%s%s%s%s%s\n", aeu_select,
> + "Use AEU1 and AEU2; ", start_pause_time,
> + time_name_array[start_pause], stop_pause_time,
> + time_name_array[stop_pause], led_playback_time,
> + led_playback_time_arr[playback_time]);
> + } else {
> + sprintf(tmp_str, "%s%s%s%s%s%s%s%s\n", aeu_select,
> + "Use AEU1,AEU2 and AEU3; ", start_pause_time,
> + time_name_array[start_pause], stop_pause_time,
> + time_name_array[stop_pause], led_playback_time,
> + led_playback_time_arr[playback_time]);
> + }
> + strcat(tmp_str, usage);
> + mutex_unlock(&chip->lock);
> + return sprintf(buf, "%s\n", tmp_str);
> +
> +out:
> + mutex_unlock(&chip->lock);
> + return ret;
> +}
...
> +static ssize_t led_pwm_dimming_scale_store(struct kobject *kobj,
> + struct kobj_attribute *attr, const char *buf, size_t count)
> +{
> + int val, ret;
> + struct lp5812_led *led = to_lp5812_led(kobj);
> + struct lp5812_chip *chip = led->priv;
> +
> + if (sysfs_streq(buf, "linear"))
> + val = 0;
Maybe use directly LINEAR or EXPONENTIAL to simplify the code?
> + else if (sysfs_streq(buf, "exponential"))
> + val = 1;
> + else
> + return -EINVAL;
> +
> + mutex_lock(&chip->lock);
> + ret = lp5812_set_pwm_dimming_scale(chip, led->led_number,
> + val ? EXPONENTIAL : LINEAR);
> + mutex_unlock(&chip->lock);
> + if (ret)
> + return -EIO;
> +
> + return count;
> +}
...
> +static struct attribute *led_kobj_attributes[] = {
> + &kobj_attr_enable.attr,
> + &kobj_attr_mode.attr,
> + &kobj_attr_manual_dc.attr,
> + &kobj_attr_manual_pwm.attr,
> + &kobj_attr_autonomous_dc.attr,
> + &kobj_attr_autonomous_animation.attr,
> + &kobj_attr_lod_lsd.attr,
> + &kobj_attr_auto_pwm_val.attr,
> + &kobj_attr_aep_status.attr,
> + &kobj_attr_pwm_phase_align.attr,
> + &kobj_attr_pwm_dimming_scale.attr,
> + NULL,
Nitpick: unneeded comma after a terminator
> +};
...
> +static ssize_t aeu_pwm4_store(struct kobject *kobj,
> + struct kobj_attribute *attr, const char *buf, size_t count)
> +{
> + int val = 0;
> + int ret = 0;
> + struct anim_engine_unit *aeu = to_anim_engine_unit(kobj);
> + struct lp5812_chip *chip = aeu->led->priv;
> +
> + ret = kstrtoint(buf, 0, &val);
> + if (ret)
> + return -EINVAL;
> + if (val < 0 || val > 255)
> + return -EINVAL; /* Invalid argument */
This comment is not really useful.
> +
> + mutex_lock(&chip->lock);
> + ret = led_aeu_pwm_set_val(aeu, val, PWM4);
> + if (ret != 0) {
> + mutex_unlock(&chip->lock);
> + return -EIO;
> + }
> + mutex_unlock(&chip->lock);
> +
> + return count;
> +}
> +
> +static ssize_t aeu_pwm4_show(struct kobject *kobj,
> + struct kobj_attribute *attr, char *buf)
> +{
> + int ret = 0;
> + u8 val = 0;
> + struct anim_engine_unit *aeu = to_anim_engine_unit(kobj);
> + struct lp5812_chip *chip = aeu->led->priv;
> +
> + mutex_lock(&chip->lock);
> + ret = led_aeu_pwm_get_val(aeu, &val, PWM4);
> + mutex_unlock(&chip->lock);
> + if (ret)
> + return -EIO;
> +
> + return sprintf(buf, "%d\n", val);
> +
Maybe the core of aeu_pwm|14]_store() and aeu_pwm[14]_show() could be
implemented only once, with an additional parameter for PWx?
}
...
> +static ssize_t aeu_playback_time_show(struct kobject *kobj,
> + struct kobj_attribute *attr, char *buf)
> +{
> + int ret = 0;
> + u8 val = 0;
> + struct anim_engine_unit *aeu = to_anim_engine_unit(kobj);
> + struct lp5812_chip *chip = aeu->led->priv;
> +
> + mutex_lock(&chip->lock);
> + ret = led_aeu_playback_time_get_val(aeu, &val);
> + if (ret != 0) {
> + mutex_unlock(&chip->lock);
> + return -EIO;
> + }
> + mutex_unlock(&chip->lock);
> +
> + return sprintf(buf, "%d\n", val);
sysfs_emit? (here and in mayne places)
> +}
> +
> +static LP5812_KOBJ_ATTR_RW(pwm1, aeu_pwm1_show, aeu_pwm1_store);
> +static LP5812_KOBJ_ATTR_RW(pwm2, aeu_pwm2_show, aeu_pwm2_store);
> +static LP5812_KOBJ_ATTR_RW(pwm3, aeu_pwm3_show, aeu_pwm3_store);
> +static LP5812_KOBJ_ATTR_RW(pwm4, aeu_pwm4_show, aeu_pwm4_store);
> +static LP5812_KOBJ_ATTR_RW(pwm5, aeu_pwm5_show, aeu_pwm5_store);
> +static LP5812_KOBJ_ATTR_RW(slope_time_t1, aeu_slope_time_t1_show,
> + aeu_slope_time_t1_store);
> +static LP5812_KOBJ_ATTR_RW(slope_time_t2, aeu_slope_time_t2_show,
> + aeu_slope_time_t2_store);
> +static LP5812_KOBJ_ATTR_RW(slope_time_t3, aeu_slope_time_t3_show,
> + aeu_slope_time_t3_store);
> +static LP5812_KOBJ_ATTR_RW(slope_time_t4, aeu_slope_time_t4_show,
> + aeu_slope_time_t4_store);
> +static LP5812_KOBJ_ATTR_RW(playback_time, aeu_playback_time_show,
> + aeu_playback_time_store);
> +
> +static struct attribute *aeu_kobj_attributes[] = {
> + &kobj_attr_pwm1.attr,
> + &kobj_attr_pwm2.attr,
> + &kobj_attr_pwm3.attr,
> + &kobj_attr_pwm4.attr,
> + &kobj_attr_pwm5.attr,
> + &kobj_attr_slope_time_t1.attr,
> + &kobj_attr_slope_time_t2.attr,
> + &kobj_attr_slope_time_t3.attr,
> + &kobj_attr_slope_time_t4.attr,
> + &kobj_attr_playback_time.attr,
> + NULL,
Nitpick: unneeded comma after a terminator
> +};
> +
> +static void aeu_init_properties(struct lp5812_led *led)
> +{
> + int i;
> +
> + for (i = 0; i < MAX_AEU; i++) {
> + led->aeu[i].aeu_name = aeu_name_array[i];
> + led->aeu[i].aeu_number = i + 1;
> + led->aeu[i].led = led;
> + led->aeu[i].enabled = 0;
> + led->aeu[i].attr_group.attrs = aeu_kobj_attributes;
> + kobject_init(&led->aeu[i].kobj, &aeu_ktype);
> + }
> +}
> +
> +static int lp5812_probe(struct i2c_client *client)
> +{
> + struct lp5812_chip *chip;
> + int i;
> + int ret;
> + u8 val;
> +
> + chip = devm_kzalloc(&client->dev, sizeof(struct lp5812_chip),
> + GFP_KERNEL);
> + if (!chip)
> + return -ENOMEM;
> + mutex_init(&chip->lock);
> + chip->i2c_cl = client;
> + chip->dev = &client->dev;
> + chip->regs = ®s;
> + chip->command = NONE;
> + chip->total_leds = MAX_LEDS;
> + chip->attr_group.name = "lp5812_chip_setup";
> + chip->attr_group.attrs = lp5812_chip_attributes;
> + chip->chip_leds_map = chip_leds_map;
> + chip->u_drive_mode.drive_mode_val = 0x10;
> + chip->u_scan_order.scan_order_val = 0x00;
> +
> + /* initialize property for each led */
> + for (i = 0; i < MAX_LEDS; i++) {
> + chip->leds[i].led_name = led_name_array[i];
> + chip->leds[i].led_number = i;
> + chip->leds[i].anim_base_addr = anim_base_addr_array[i];
> + chip->leds[i].enable = 0; /* LED disable as default */
> + chip->leds[i].mode = MANUAL; /* manual mode as default */
> + chip->leds[i].priv = chip;
> + chip->leds[i].total_aeu = MAX_AEU;
> + chip->leds[i].led_playback.led_playback_val = 0;
> + chip->leds[i].start_stop_pause_time.time_val = 0;
> + /* sysfs for this led not be created */
> + chip->leds[i].is_sysfs_created = 0;
> + chip->leds[i].attr_group.attrs = led_kobj_attributes;
> + kobject_init(&chip->leds[i].kobj, &led_ktype);
> +
> + /* init animation engine unit properties */
> + aeu_init_properties(&chip->leds[i]);
> +
> + /* set autonomous animation config as default for all LEDs */
> + led_set_autonomous_animation_config(&chip->leds[i]);
> + }
> +
> + i2c_set_clientdata(client, chip);
> +
> + ret = sysfs_create_group(&chip->dev->kobj, &chip->attr_group);
> + if (ret) {
> + dev_err(chip->dev, "sysfs_create_group failed\n");
Maybe return dev_err_probe?
> + return ret;
> + }
> +
> + ret = lp5812_init_dev_config(chip, "tcmscan:4:0:1:2:3", 0);
> + if (ret) {
> + dev_err(chip->dev, "%s: lp5812_init_dev_config failed\n",
> + __func__);
Maybe return dev_err_probe?
> + return ret;
> + }
> + /* initialize lp5812 chip */
Nitpick: this comment is not really useful, IMHO, the line just after
should be enough
> + ret = lp5812_initialize(chip);
Missing error handling?
> +
> + /* code to verify i2c read/write ok or not */
> + lp5812_read(chip, (u16)DEV_CONFIG2, &val);
> +
> + lp5812_write(chip, (u16)LED_A1_AUTO_BASE_ADRR, 0x14);
> + lp5812_read(chip, (u16)LED_A1_AUTO_BASE_ADRR, &val);
> + /* End code to verify i2c read/write*/
> +
> + return 0;
> +}
> +
> +static void lp5812_remove(struct i2c_client *client)
> +{
> + struct lp5812_chip *chip = i2c_get_clientdata(client);
> +
> + mutex_destroy(&chip->lock);
> + leds_remove_existed_sysfs(chip);
> + sysfs_remove_group(&chip->dev->kobj, &chip->attr_group);
> +
> + /* Disable all Leds */
Nitpick: this comment is not really useful, IMHI, the line just after
should be enough
> + lp5812_disable_all_leds(chip);
> +
> + /* Disable lp5812 device */
> + lp5812_enable_disable(chip, 0);
> +}
> +
> +static const struct i2c_device_id lp5812_id[] = {
> + { "lp5812", 0 },
Nitpick: unneeded explicit 0
> + { }
> +};
> +
> +MODULE_DEVICE_TABLE(i2c, lp5812_id);
> +
> +#ifdef CONFIG_OF
> +static const struct of_device_id of_lp5812_match[] = {
> + { .compatible = "ti,lp5812", },
> + {/* NULL */},
Nitpick: unneeded comma after a terminator
> +};
> +
> +MODULE_DEVICE_TABLE(of, of_lp5812_match);
> +#endif
> +
> +static struct i2c_driver lp5812_driver = {
> + .driver = {
> + .name = "lp5812",
> + .of_match_table = of_match_ptr(of_lp5812_match),
> + },
> + .probe = lp5812_probe,
> + .remove = lp5812_remove,
> + .id_table = lp5812_id,
> +};
> +
> +module_i2c_driver(lp5812_driver);
> +
> +MODULE_DESCRIPTION("Texas Instruments LP5812 LED Driver");
> +MODULE_AUTHOR("Jared Zhou");
> +MODULE_LICENSE("GPL");
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: leds: Add LP5812 LED driver
2025-03-06 17:21 ` [PATCH v3 1/3] dt-bindings: leds: Add LP5812 LED driver Nam Tran
@ 2025-03-07 8:42 ` Krzysztof Kozlowski
2025-03-18 13:56 ` Nam Tran
1 sibling, 0 replies; 26+ messages in thread
From: Krzysztof Kozlowski @ 2025-03-07 8:42 UTC (permalink / raw)
To: Nam Tran
Cc: pavel, lee, krzk+dt, robh, conor+dt, devicetree, linux-leds,
linux-kernel
On Fri, Mar 07, 2025 at 12:21:24AM +0700, Nam Tran wrote:
> This documentation ensures proper integration of the LP5812
> in Device Tree-based systems.
No changelog, no improvements in commit msg. You got comment at v1 to
which you did not respond. Then you send v2 and I asked the same.
Please respond to the comment at v1 so acknowledge that you udnerstood
it.
Your commit msg is totally redundant - you just said what Devicetree
binding is. I asked to change it: describe the hardware instead.
>
> Signed-off-by: Nam Tran <trannamatk@gmail.com>
> ---
> .../devicetree/bindings/leds/ti,lp5812.yaml | 50 +++++++++++++++++++
> MAINTAINERS | 6 +++
> 2 files changed, 56 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/ti,lp5812.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/ti,lp5812.yaml b/Documentation/devicetree/bindings/leds/ti,lp5812.yaml
> new file mode 100644
> index 000000000000..9a203da4f272
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/ti,lp5812.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/ti,lp5812.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +$ref: /schemas/leds/common.yaml#
> +
> +title: Linux driver for LP5812 LED from Texas Instruments
Nothing improved.
> +
> +maintainers:
> + - Nam Tran <trannamatk@gmail.com>
> +
> +description: |
> + The LP5812 is an I2C LED Driver that can support LED matrix 4x3.
> + For more product information please see the link below:
> + https://www.ti.com/product/LP5812#tech-docs
> +
> +properties:
> + compatible:
> + const: ti,lp5812
> +
> + reg:
> + maxItems: 1
This improved... but:
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
What are these?
> +
> +required:
> + - compatible
> + - reg
> +
Nothing improved here.
You keep ignoring comments, not responding to them. This is not how you
are supposed to work with reviewers.
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + led-controller@1b {
> + compatible = "ti,lp5812";
> + reg = <0x1b>;
> + };
> + };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8e0736dc2ee0..2bd9f5132cab 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -23506,6 +23506,12 @@ S: Maintained
> F: Documentation/devicetree/bindings/leds/backlight/ti,lp8864.yaml
> F: drivers/leds/leds-lp8864.c
>
> +TEXAS INSTRUMENTS' LP5812 LED DRIVER
Nothing improved.
NAK
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v3 2/3] arm64: dts: Add LP5812 LED node for Raspberry Pi 4 Model B
2025-03-06 17:21 ` [PATCH v3 2/3] arm64: dts: Add LP5812 LED node for Raspberry Pi 4 Model B Nam Tran
@ 2025-03-07 8:42 ` Krzysztof Kozlowski
2025-03-07 8:43 ` Krzysztof Kozlowski
1 sibling, 0 replies; 26+ messages in thread
From: Krzysztof Kozlowski @ 2025-03-07 8:42 UTC (permalink / raw)
To: Nam Tran
Cc: pavel, lee, krzk+dt, robh, conor+dt, devicetree, linux-leds,
linux-kernel
On Fri, Mar 07, 2025 at 12:21:25AM +0700, Nam Tran wrote:
> Add the LP5812 LED driver node to the Device Tree for Raspberry Pi 4 B.
> This enables the LED connected to the LP5812 to be controlled via I2C.
>
> Signed-off-by: Nam Tran <trannamatk@gmail.com>
> ---
> arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
> index 353bb50ce542..85441746d94b 100644
> --- a/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
> +++ b/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
> @@ -270,3 +270,13 @@ &vec {
> &wifi_pwrseq {
> reset-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>;
> };
> +
> +&i2c1 {
Follow ordering of nodes explained in DTS coding style.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v3 2/3] arm64: dts: Add LP5812 LED node for Raspberry Pi 4 Model B
2025-03-06 17:21 ` [PATCH v3 2/3] arm64: dts: Add LP5812 LED node for Raspberry Pi 4 Model B Nam Tran
2025-03-07 8:42 ` Krzysztof Kozlowski
@ 2025-03-07 8:43 ` Krzysztof Kozlowski
1 sibling, 0 replies; 26+ messages in thread
From: Krzysztof Kozlowski @ 2025-03-07 8:43 UTC (permalink / raw)
To: Nam Tran
Cc: pavel, lee, krzk+dt, robh, conor+dt, devicetree, linux-leds,
linux-kernel
On Fri, Mar 07, 2025 at 12:21:25AM +0700, Nam Tran wrote:
> Add the LP5812 LED driver node to the Device Tree for Raspberry Pi 4 B.
> This enables the LED connected to the LP5812 to be controlled via I2C.
>
> Signed-off-by: Nam Tran <trannamatk@gmail.com>
> ---
> arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
One more: DTS is *never* in the middle of patchset. It is always at the
end.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v3 3/3] leds: add new LED driver for TI LP5812
2025-03-06 17:21 ` [PATCH v3 3/3] leds: add new LED driver for TI LP5812 Nam Tran
2025-03-06 18:53 ` Christophe JAILLET
@ 2025-03-07 8:52 ` Krzysztof Kozlowski
2025-03-24 4:44 ` Nam Tran
2025-03-10 1:21 ` kernel test robot
` (3 subsequent siblings)
5 siblings, 1 reply; 26+ messages in thread
From: Krzysztof Kozlowski @ 2025-03-07 8:52 UTC (permalink / raw)
To: Nam Tran
Cc: pavel, lee, krzk+dt, robh, conor+dt, devicetree, linux-leds,
linux-kernel
On Fri, Mar 07, 2025 at 12:21:26AM +0700, Nam Tran wrote:
> The chip can drive LED matrix 4x3.
> This driver enables LED control via I2C.
You still did not respond to comments from v1. I don't see it being
addressed.
>
> The driver is implemented in two parts:
> - Core driver logic in leds-lp5812.c
> - Common support functions in leds-lp5812-common.c
Why do you make two modules? This looks really unneccessary. Just
compile them into one module.
>
> Signed-off-by: Nam Tran <trannamatk@gmail.com>
> ---
> MAINTAINERS | 6 +
> drivers/leds/Kconfig | 29 +
> drivers/leds/Makefile | 2 +
> drivers/leds/leds-lp5812-common.c | 1023 ++++++++++++++
> drivers/leds/leds-lp5812-common.h | 323 +++++
> drivers/leds/leds-lp5812-regs.h | 96 ++
> drivers/leds/leds-lp5812.c | 2190 +++++++++++++++++++++++++++++
> 7 files changed, 3669 insertions(+)
> create mode 100644 drivers/leds/leds-lp5812-common.c
> create mode 100644 drivers/leds/leds-lp5812-common.h
> create mode 100644 drivers/leds/leds-lp5812-regs.h
> create mode 100644 drivers/leds/leds-lp5812.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2bd9f5132cab..773c7ad6a7b6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -23511,6 +23511,12 @@ M: Nam Tran <trannamatk@gmail.com>
> L: linux-leds@vger.kernel.org
> S: Maintained
> F: Documentation/devicetree/bindings/leds/ti,lp5812.yaml
> +F: drivers/leds/Kconfig
> +F: drivers/leds/Makefile
> +F: drivers/leds/leds-lp5812-common.c
> +F: drivers/leds/leds-lp5812-common.h
> +F: drivers/leds/leds-lp5812-regs.h
> +F: drivers/leds/leds-lp5812.c
>
> TEXAS INSTRUMENTS' SYSTEM CONTROL INTERFACE (TISCI) PROTOCOL DRIVER
> M: Nishanth Menon <nm@ti.com>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index 2b27d043921c..7af5ebf190a9 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -483,6 +483,35 @@ config LEDS_LP5569
> Driver provides direct control via LED class and interface for
> programming the engines.
>
> +config LEDS_LP5812
> + tristate "Enable LP5812 support LED matrix 4x3"
> + depends on LEDS_CLASS && I2C
> + depends on LEDS_CLASS_MULTICOLOR
> + help
> + If you say Y here you get support for TI LP5812 LED driver.
> +
> + The LP5812 is an I2C-based RGB LED driver that supports a 4x3 LED matrix.
> + It provides independent brightness control and color mixing for each LED.
> + This driver integrates with the Linux LED framework and LED multicolor class.
> +
> + To compile this driver as a module, choose M here: the
> + module will be called leds-lp5812.
> +
> + If unsure, say N.
> +
> +config LEDS_LP5812_COMMON
> + tristate "Common driver for TI LP5812"
> + depends on LEDS_CLASS
> + depends on LEDS_CLASS_MULTICOLOR
> + depends on I2C
> + help
> + If you say Y here you get support common operation for TI LP5812 LED driver.
> +
> + To compile this driver as a module, choose M here: the
> + module will be called leds-lp5812-common.
> +
> + If unsure, say N.
> +
> config LEDS_LP8501
> tristate "LED Support for TI LP8501 LED driver chip"
> depends on LEDS_CLASS && I2C
> diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile
> index 6ad52e219ec6..d3daae2d808c 100644
> --- a/drivers/leds/Makefile
> +++ b/drivers/leds/Makefile
> @@ -54,6 +54,8 @@ obj-$(CONFIG_LEDS_LP5523) += leds-lp5523.o
> obj-$(CONFIG_LEDS_LP5562) += leds-lp5562.o
> obj-$(CONFIG_LEDS_LP5569) += leds-lp5569.o
> obj-$(CONFIG_LEDS_LP55XX_COMMON) += leds-lp55xx-common.o
> +obj-$(CONFIG_LEDS_LP5812) += leds-lp5812.o
> +obj-$(CONFIG_LEDS_LP5812_COMMON) += leds-lp5812-common.o
> obj-$(CONFIG_LEDS_LP8501) += leds-lp8501.o
> obj-$(CONFIG_LEDS_LP8788) += leds-lp8788.o
> obj-$(CONFIG_LEDS_LP8860) += leds-lp8860.o
> diff --git a/drivers/leds/leds-lp5812-common.c b/drivers/leds/leds-lp5812-common.c
> new file mode 100644
> index 000000000000..01157233507f
> --- /dev/null
> +++ b/drivers/leds/leds-lp5812-common.c
> @@ -0,0 +1,1023 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * LP5812 Common Driver
> + *
> + * Copyright (C) 2025 Texas Instruments
> + *
> + * Author: Jared Zhou <jared-zhou@ti.com>
> + */
> +
> +#include "leds-lp5812-common.h"
> +
> +/*
> + * Function: lp5812_write
> + * Params:
> + * Return: 0 if success
No, use proper kerneldoc
> + */
> +int lp5812_write(struct lp5812_chip *chip, u16 reg, u8 val)
> +{
> + int ret;
> + u8 extracted_bits; /* save 9th and 8th bit of reg address */
> + struct i2c_msg msg;
> + u8 buf[2] = {(u8)(reg & 0xFF), val};
> +
> + extracted_bits = (reg >> 8) & 0x03;
> + msg.addr = (chip->i2c_cl->addr << 2) | extracted_bits;
> + msg.flags = 0;
> + msg.len = sizeof(buf);
> + msg.buf = buf;
> +
> + ret = i2c_transfer(chip->i2c_cl->adapter, &msg, 1);
> + if (ret != 1) {
> + dev_err(chip->dev, "i2c write error, register 0x%02X, ret=%d\n", reg, ret);
> + ret = ret < 0 ? ret : -EIO;
> + } else {
> + ret = 0;
> + }
> +
> + return ret;
> +}
> +EXPORT_SYMBOL_GPL(lp5812_write);
> +
Missing kerneldoc. Every exported symbol must have kerneldoc.
> +int lp5812_read(struct lp5812_chip *chip, u16 reg, u8 *val)
> +{
> + int ret;
> + u8 ret_val; /* lp5812_chip return value */
> + u8 extracted_bits; /* save 9th and 8th bit of reg address */
> + u8 converted_reg; /* extracted 8bit from reg */
> + struct i2c_msg msgs[2];
> +
> + extracted_bits = (reg >> 8) & 0x03;
> + converted_reg = (u8)(reg & 0xFF);
> +
> + msgs[0].addr = (chip->i2c_cl->addr << 2) | extracted_bits;
> + msgs[0].flags = 0;
> + msgs[0].len = 1;
> + msgs[0].buf = &converted_reg;
> +
> + msgs[1].addr = (chip->i2c_cl->addr << 2) | extracted_bits;
> + msgs[1].flags = I2C_M_RD;
> + msgs[1].len = 1;
> + msgs[1].buf = &ret_val;
> +
> + ret = i2c_transfer(chip->i2c_cl->adapter, msgs, 2);
> + if (ret != 2) {
> + dev_err(chip->dev, "Read register 0x%02X error, ret=%d\n", reg, ret);
> + *val = 0;
> + ret = ret < 0 ? ret : -EIO;
> + } else {
> + *val = ret_val;
> + ret = 0;
> + }
> +
> + return ret;
> +}
> +EXPORT_SYMBOL_GPL(lp5812_read);
> +
> +int lp5812_update_bit(struct lp5812_chip *chip, u16 reg, u8 mask, u8 val)
Why this is not static?
> +{
> + int ret;
> + u8 tmp;
> +
> + ret = lp5812_read(chip, reg, &tmp);
> + if (ret)
> + return ret;
> +
> + tmp &= ~mask;
> + tmp |= val & mask;
> +
> + return lp5812_write(chip, reg, tmp);
> +}
> +
> +/*
> + * Function: lp5812_read_tsd_config_status
> + * Description: read tsd config status register
> + * Param: chip --> struct lp5812_chip itself
> + * reg_val
> + * Return: 0 if success
> + */
> +int lp5812_read_tsd_config_status(struct lp5812_chip *chip, u8 *reg_val)
Why this is not static?
> +{
> + int ret = 0;
> +
> + if (!reg_val)
> + return -1;
> +
> + ret = lp5812_read(chip, chip->regs->tsd_config_status_reg, reg_val);
> +
> + return ret;
> +}
> +
> +/*
> + * Function: lp5812_update_regs_config
Missing kerneldoc
> + * Description: update reg config register
> + * Param: chip --> struct lp5812_chip itself
> + * Return: 0 if success
> + */
> +int lp5812_update_regs_config(struct lp5812_chip *chip)
> +{
> + int ret;
> + u8 reg_val; /* save register value */
> +
...
> +static struct drive_mode_led_map chip_leds_map[] = {
> + {
> + "direct_mode",
> + (const char *[]){LED0, LED1, LED2, LED3, NULL},
Drop the cast.
> + },
> + {
> + "tcmscan:1:0", /* tcm 1 scan; scan order 0 out0 */
> + (const char *[]){LED_A0, LED_A1, LED_A2, NULL},
> + },
> + {
> + "tcmscan:1:1", /* tcm 1 scan; scan order 0 out1 */
> + (const char *[]){LED_B0, LED_B1, LED_B2, NULL},
> + },
> + {
> + "tcmscan:1:2", /* tcm 1 scan; scan order 0 out2 */
> + (const char *[]){LED_C0, LED_C1, LED_C2, NULL},
> + },
> + {
> + "tcmscan:1:3", /* tcm 1 scan; scan order 0 out3 */
> + (const char *[]){LED_D0, LED_D1, LED_D2, NULL},
What is all this here?
How LED controller with so little properties have so complicated driver?
> + },
> + { /* tcm 2 scan, scan order 0 out0; scan order 1 out1 */
> + "tcmscan:2:0:1",
> + (const char *[]){LED_A0, LED_A1, LED_A2, LED_B0, LED_B1, LED_B2,
> + NULL},
> + },
> + { /* tcm 2 scan, scan order 0 out0; scan order 1 out2 */
> + "tcmscan:2:0:2",
> + (const char *[]){LED_A0, LED_A1, LED_A2, LED_C0, LED_C1, LED_C2,
> + NULL},
> +static void led_kobj_release(struct kobject *kobj)
> +{
> + kfree(kobj);
> +}
> +
> +static void aeu_kobj_release(struct kobject *kobj)
> +{
> + kfree(kobj);
> +}
What is all this? Why do you create your own kobjects?
> +
> +static const struct kobj_type led_ktype = {
> + .release = led_kobj_release,
> + .sysfs_ops = &kobj_sysfs_ops,
> +};
> +
> +static const struct kobj_type aeu_ktype = {
> + .release = aeu_kobj_release,
> + .sysfs_ops = &kobj_sysfs_ops,
> +};
> +static ssize_t device_reset_store(struct device *dev,
> + struct device_attribute *attr,
> + const char *buf, size_t len)
NAK.
Sorry, you just cannot create whatever interfaces you want. You must use
standard LED interfaces for normal LED operations. None of these sysfs
are needed for device control.
Respond to this comment that you understood it (you ignored all previous
comments).
> +{
> + int reset;
> + int ret;
> + struct lp5812_chip *chip = i2c_get_clientdata(to_i2c_client(dev));
> +
> + ret = kstrtoint(buf, 0, &reset);
> + if (ret)
> + return ret;
> +
> + if (reset != 1)
> + return -EINVAL; /* Invalid argument */
> +
> + /* reset hardware */
> + mutex_lock(&chip->lock);
> + lp5812_reset(chip);
> + msleep(1000);
> + /* set back manual mode as default for all LEDs */
> + lp5812_write(chip, (u16)DEV_CONFIG3, 0x00);
> + lp5812_write(chip, (u16)DEV_CONFIG4, 0x00);
> + lp5812_update_regs_config(chip);
> + mutex_unlock(&chip->lock);
> +
> + /* Update sysfs based on default mode when hardware reseted*/
> + ret = lp5812_init_dev_config(chip, "direct_mode", 1);
> + if (ret) {
> + dev_err(dev, "%s: lp5812_init_dev_config failed\n",
> + __func__);
> + return ret;
> + }
> +
> + return len;
> +}
...
> +static LP5812_KOBJ_ATTR_RW(pwm1, aeu_pwm1_show, aeu_pwm1_store);
> +static LP5812_KOBJ_ATTR_RW(pwm2, aeu_pwm2_show, aeu_pwm2_store);
> +static LP5812_KOBJ_ATTR_RW(pwm3, aeu_pwm3_show, aeu_pwm3_store);
> +static LP5812_KOBJ_ATTR_RW(pwm4, aeu_pwm4_show, aeu_pwm4_store);
> +static LP5812_KOBJ_ATTR_RW(pwm5, aeu_pwm5_show, aeu_pwm5_store);
> +static LP5812_KOBJ_ATTR_RW(slope_time_t1, aeu_slope_time_t1_show,
> + aeu_slope_time_t1_store);
> +static LP5812_KOBJ_ATTR_RW(slope_time_t2, aeu_slope_time_t2_show,
> + aeu_slope_time_t2_store);
> +static LP5812_KOBJ_ATTR_RW(slope_time_t3, aeu_slope_time_t3_show,
> + aeu_slope_time_t3_store);
> +static LP5812_KOBJ_ATTR_RW(slope_time_t4, aeu_slope_time_t4_show,
> + aeu_slope_time_t4_store);
> +static LP5812_KOBJ_ATTR_RW(playback_time, aeu_playback_time_show,
> + aeu_playback_time_store);
What is all this?
...
> +static int lp5812_probe(struct i2c_client *client)
> +{
> + struct lp5812_chip *chip;
> + int i;
> + int ret;
> + u8 val;
> +
> + chip = devm_kzalloc(&client->dev, sizeof(struct lp5812_chip),
> + GFP_KERNEL);
> + if (!chip)
> + return -ENOMEM;
> + mutex_init(&chip->lock);
> + chip->i2c_cl = client;
> + chip->dev = &client->dev;
> + chip->regs = ®s;
> + chip->command = NONE;
> + chip->total_leds = MAX_LEDS;
> + chip->attr_group.name = "lp5812_chip_setup";
> + chip->attr_group.attrs = lp5812_chip_attributes;
> + chip->chip_leds_map = chip_leds_map;
> + chip->u_drive_mode.drive_mode_val = 0x10;
> + chip->u_scan_order.scan_order_val = 0x00;
> +
> + /* initialize property for each led */
> + for (i = 0; i < MAX_LEDS; i++) {
> + chip->leds[i].led_name = led_name_array[i];
> + chip->leds[i].led_number = i;
> + chip->leds[i].anim_base_addr = anim_base_addr_array[i];
> + chip->leds[i].enable = 0; /* LED disable as default */
> + chip->leds[i].mode = MANUAL; /* manual mode as default */
> + chip->leds[i].priv = chip;
> + chip->leds[i].total_aeu = MAX_AEU;
> + chip->leds[i].led_playback.led_playback_val = 0;
> + chip->leds[i].start_stop_pause_time.time_val = 0;
> + /* sysfs for this led not be created */
> + chip->leds[i].is_sysfs_created = 0;
> + chip->leds[i].attr_group.attrs = led_kobj_attributes;
> + kobject_init(&chip->leds[i].kobj, &led_ktype);
> +
> + /* init animation engine unit properties */
> + aeu_init_properties(&chip->leds[i]);
> +
> + /* set autonomous animation config as default for all LEDs */
> + led_set_autonomous_animation_config(&chip->leds[i]);
> + }
> +
> + i2c_set_clientdata(client, chip);
> +
> + ret = sysfs_create_group(&chip->dev->kobj, &chip->attr_group);
You need sysfs ABI documentation.
> + if (ret) {
> + dev_err(chip->dev, "sysfs_create_group failed\n");
> + return ret;
> + }
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v3 3/3] leds: add new LED driver for TI LP5812
2025-03-06 17:21 ` [PATCH v3 3/3] leds: add new LED driver for TI LP5812 Nam Tran
2025-03-06 18:53 ` Christophe JAILLET
2025-03-07 8:52 ` Krzysztof Kozlowski
@ 2025-03-10 1:21 ` kernel test robot
2025-03-11 11:20 ` kernel test robot
` (2 subsequent siblings)
5 siblings, 0 replies; 26+ messages in thread
From: kernel test robot @ 2025-03-10 1:21 UTC (permalink / raw)
To: Nam Tran, pavel, lee, krzk+dt, robh, conor+dt
Cc: llvm, oe-kbuild-all, devicetree, linux-leds, linux-kernel,
Nam Tran
Hi Nam,
kernel test robot noticed the following build errors:
[auto build test ERROR on lee-leds/for-leds-next]
[also build test ERROR on robh/for-next linus/master v6.14-rc5 next-20250307]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Nam-Tran/dt-bindings-leds-Add-LP5812-LED-driver/20250307-012604
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git for-leds-next
patch link: https://lore.kernel.org/r/20250306172126.24667-4-trannamatk%40gmail.com
patch subject: [PATCH v3 3/3] leds: add new LED driver for TI LP5812
config: x86_64-randconfig-005-20250310 (https://download.01.org/0day-ci/archive/20250310/202503100925.eZz1D0kw-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250310/202503100925.eZz1D0kw-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503100925.eZz1D0kw-lkp@intel.com/
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> ERROR: modpost: "led_set_autonomous_animation_config" [drivers/leds/leds-lp5812.ko] undefined!
>> ERROR: modpost: "lp5812_initialize" [drivers/leds/leds-lp5812.ko] undefined!
ERROR: modpost: "lp5812_read" [drivers/leds/leds-lp5812.ko] undefined!
>> ERROR: modpost: "lp5812_write" [drivers/leds/leds-lp5812.ko] undefined!
ERROR: modpost: "lp5812_disable_all_leds" [drivers/leds/leds-lp5812.ko] undefined!
ERROR: modpost: "lp5812_enable_disable" [drivers/leds/leds-lp5812.ko] undefined!
>> ERROR: modpost: "lp5812_device_command" [drivers/leds/leds-lp5812.ko] undefined!
>> ERROR: modpost: "lp5812_reset" [drivers/leds/leds-lp5812.ko] undefined!
>> ERROR: modpost: "lp5812_update_regs_config" [drivers/leds/leds-lp5812.ko] undefined!
>> ERROR: modpost: "lp5812_fault_clear" [drivers/leds/leds-lp5812.ko] undefined!
WARNING: modpost: suppressed 23 unresolved symbol warnings because there were too many)
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v3 3/3] leds: add new LED driver for TI LP5812
2025-03-06 17:21 ` [PATCH v3 3/3] leds: add new LED driver for TI LP5812 Nam Tran
` (2 preceding siblings ...)
2025-03-10 1:21 ` kernel test robot
@ 2025-03-11 11:20 ` kernel test robot
2025-03-18 13:35 ` Nam Tran
2025-03-25 19:15 ` Markus Elfring
5 siblings, 0 replies; 26+ messages in thread
From: kernel test robot @ 2025-03-11 11:20 UTC (permalink / raw)
To: Nam Tran, pavel, lee, krzk+dt, robh, conor+dt
Cc: llvm, oe-kbuild-all, devicetree, linux-leds, linux-kernel,
Nam Tran
Hi Nam,
kernel test robot noticed the following build errors:
[auto build test ERROR on lee-leds/for-leds-next]
[also build test ERROR on robh/for-next linus/master v6.14-rc6 next-20250307]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Nam-Tran/dt-bindings-leds-Add-LP5812-LED-driver/20250307-012604
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git for-leds-next
patch link: https://lore.kernel.org/r/20250306172126.24667-4-trannamatk%40gmail.com
patch subject: [PATCH v3 3/3] leds: add new LED driver for TI LP5812
config: x86_64-randconfig-077-20250310 (https://download.01.org/0day-ci/archive/20250311/202503111910.ko7pwUem-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250311/202503111910.ko7pwUem-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503111910.ko7pwUem-lkp@intel.com/
All errors (new ones prefixed by >>, old ones prefixed by <<):
WARNING: modpost: missing MODULE_DESCRIPTION() in mm/kasan/kasan_test.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/slub_kunit.o
>> ERROR: modpost: "lp5812_disable_all_leds" [drivers/leds/leds-lp5812.ko] undefined!
>> ERROR: modpost: "lp5812_enable_disable" [drivers/leds/leds-lp5812.ko] undefined!
>> ERROR: modpost: "lp5812_set_pwm_dimming_scale" [drivers/leds/leds-lp5812.ko] undefined!
>> ERROR: modpost: "lp5812_get_pwm_dimming_scale" [drivers/leds/leds-lp5812.ko] undefined!
>> ERROR: modpost: "lp5812_read" [drivers/leds/leds-lp5812.ko] undefined!
>> ERROR: modpost: "lp5812_set_phase_align" [drivers/leds/leds-lp5812.ko] undefined!
>> ERROR: modpost: "lp5812_get_phase_align" [drivers/leds/leds-lp5812.ko] undefined!
>> ERROR: modpost: "lp5812_read_aep_status" [drivers/leds/leds-lp5812.ko] undefined!
>> ERROR: modpost: "lp5812_read_auto_pwm_value" [drivers/leds/leds-lp5812.ko] undefined!
>> ERROR: modpost: "lp5812_read_lsd_status" [drivers/leds/leds-lp5812.ko] undefined!
WARNING: modpost: suppressed 23 unresolved symbol warnings because there were too many)
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v3 3/3] leds: add new LED driver for TI LP5812
2025-03-06 17:21 ` [PATCH v3 3/3] leds: add new LED driver for TI LP5812 Nam Tran
` (3 preceding siblings ...)
2025-03-11 11:20 ` kernel test robot
@ 2025-03-18 13:35 ` Nam Tran
2025-03-18 18:54 ` Krzysztof Kozlowski
2025-03-20 15:50 ` Lee Jones
2025-03-25 19:15 ` Markus Elfring
5 siblings, 2 replies; 26+ messages in thread
From: Nam Tran @ 2025-03-18 13:35 UTC (permalink / raw)
To: krzk+dt; +Cc: pavel, lee, robh, conor+dt, devicetree, linux-leds, linux-kernel
From: Nam Tran <trannamatk@gmail.com>
To: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org> Pavel Machek <pavel@kernel.org>, Lee Jones <lee@kernel.org>, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
I sincerely apologize for not addressing all of your previous comments earlier. That was not my intention, and I truly appreciate the time and effort you have put into reviewing my patch. Below, I would like to properly address your concerns.
On Fri, Mar 07, 2025 at 12:21:26AM +0700, Nam Tran wrote:
> The chip can drive LED matrix 4x3.
> This driver enables LED control via I2C.
You still did not respond to comments from v1. I don't see it being addressed.
Nam: I am sorry. This is my mistake. I think that I just need to update source code based on your comments and submit a new patch. This is the first time I try to update a new thing to the Linux Kernel. I will give answer inline your message for tracing easily.
In previous comment you have a question
"Why none of the 10 existing drivers fit for your device?"
Nam: I have carefully reviewed the existing LED drivers in the kernel, but none of them fully support the advanced capabilities of the LP5812. Unlike basic LED controllers, the LP5812 has difference features and register
For more detail, please refer to this documentation https://www.ti.com/lit/ds/symlink/lp5812.pdf?ts=1741765622088&ref_url=https%253A%252F%252Fwww.ti.com%252Fproduct%252FLP5812
>
> The driver is implemented in two parts:
> - Core driver logic in leds-lp5812.c
> - Common support functions in leds-lp5812-common.c
Why do you make two modules? This looks really unneccessary. Just compile them into one module. No, use proper kerneldoc Missing kerneldoc. Every exported symbol must have kerneldoc. Why this is not static?
Nam: I will merge source code into a file only. Therefore, I don’t need to export symbols here.
> +{
> + int ret;
> + u8 tmp;
> +
> + ret = lp5812_read(chip, reg, &tmp);
> + if (ret)
> + return ret;
> +
> + tmp &= ~mask;
> + tmp |= val & mask;
> +
> + return lp5812_write(chip, reg, tmp);
> +}
> +
> +/*
> + * Function: lp5812_read_tsd_config_status
> + * Description: read tsd config status register
> + * Param: chip --> struct lp5812_chip itself
> + * reg_val
> + * Return: 0 if success
> + */
> +int lp5812_read_tsd_config_status(struct lp5812_chip *chip, u8 *reg_val)
Why this is not static?
Nam: I will change it to a static function.
> +{
> + int ret = 0;
> +
> + if (!reg_val)
> + return -1;
> +
> + ret = lp5812_read(chip, chip->regs->tsd_config_status_reg, reg_val);
> +
> + return ret;
> +}
> +
> +/*
> + * Function: lp5812_update_regs_config
Missing kerneldoc
Nam: If I merge leds-lp5812-common.c into leds-lp5812.c, the functions will no longer need to be exported, as they will only be used internally within a single compilation unit. As a result, kernel doc for these symbols will no longer be mandatory. Would you agree that this approach eliminates the need for separate kernel doc entries for these functions?
> + * Description: update reg config register
> + * Param: chip --> struct lp5812_chip itself
> + * Return: 0 if success
> + */
> +int lp5812_update_regs_config(struct lp5812_chip *chip)
> +{
> + int ret;
> + u8 reg_val; /* save register value */
> +
...
> +static struct drive_mode_led_map chip_leds_map[] = {
> + {
> + "direct_mode",
> + (const char *[]){LED0, LED1, LED2, LED3, NULL},
Drop the cast.
Nam: I will drop them.
> + },
> + {
> + "tcmscan:1:0", /* tcm 1 scan; scan order 0 out0 */
> + (const char *[]){LED_A0, LED_A1, LED_A2, NULL},
> + },
> + {
> + "tcmscan:1:1", /* tcm 1 scan; scan order 0 out1 */
> + (const char *[]){LED_B0, LED_B1, LED_B2, NULL},
> + },
> + {
> + "tcmscan:1:2", /* tcm 1 scan; scan order 0 out2 */
> + (const char *[]){LED_C0, LED_C1, LED_C2, NULL},
> + },
> + {
> + "tcmscan:1:3", /* tcm 1 scan; scan order 0 out3 */
> + (const char *[]){LED_D0, LED_D1, LED_D2, NULL},
What is all this here?
How LED controller with so little properties have so complicated driver?
Nam: This hardware has 7 modes. Each mode has many options. My idea is to create a driver that supports all capabilities of the hardware. Therefore, when the user updates the mode of hardware, it will create specific device files.
Refer: https://dev.ti.com/gallery/view/LED/LP581x/ver/0.16.0/
> + },
> + { /* tcm 2 scan, scan order 0 out0; scan order 1 out1 */
> + "tcmscan:2:0:1",
> + (const char *[]){LED_A0, LED_A1, LED_A2, LED_B0, LED_B1, LED_B2,
> + NULL},
> + },
> + { /* tcm 2 scan, scan order 0 out0; scan order 1 out2 */
> + "tcmscan:2:0:2",
> + (const char *[]){LED_A0, LED_A1, LED_A2, LED_C0, LED_C1, LED_C2,
> + NULL},
> +static void led_kobj_release(struct kobject *kobj)
> +{
> + kfree(kobj);
> +}
> +
> +static void aeu_kobj_release(struct kobject *kobj)
> +{
> + kfree(kobj);
> +}
What is all this? Why do you create your own kobjects?
Nam: Same as previous answer, I need to create kobjects to support many interfaces.
> +
> +static const struct kobj_type led_ktype = {
> + .release = led_kobj_release,
> + .sysfs_ops = &kobj_sysfs_ops,
> +};
> +
> +static const struct kobj_type aeu_ktype = {
> + .release = aeu_kobj_release,
> + .sysfs_ops = &kobj_sysfs_ops,
> +};
> +static ssize_t device_reset_store(struct device *dev,
> + struct device_attribute *attr,
> + const char *buf, size_t len)
NAK.
Sorry, you just cannot create whatever interfaces you want. You must use
standard LED interfaces for normal LED operations. None of these sysfs
are needed for device control.
Respond to this comment that you understood it (you ignored all previous
comments). …
Nam: based on LP5812 datasheet, it is not normal LED operations. It supports many modes, each mode we can control specific leds (user can enable/disable leds). Each led has normal mode, autonomous mode … That is why I want to create interfaces.
Based on your concern, I think that my driver may not be compatible with normal LED operations. Given that the LP5812 driver has advanced functionality beyond basic LED control, would it be acceptable to place the driver in a different location instead of drivers/led/? If so, could you suggest a more suitable location?
I am open to discussions on how best to integrate these features while maintaining compliance with kernel standards. Please let me know your thoughts on how we can refine the approach.
> +static LP5812_KOBJ_ATTR_RW(pwm1, aeu_pwm1_show, aeu_pwm1_store);
> +static LP5812_KOBJ_ATTR_RW(pwm2, aeu_pwm2_show, aeu_pwm2_store);
> +static LP5812_KOBJ_ATTR_RW(pwm3, aeu_pwm3_show, aeu_pwm3_store);
> +static LP5812_KOBJ_ATTR_RW(pwm4, aeu_pwm4_show, aeu_pwm4_store);
> +static LP5812_KOBJ_ATTR_RW(pwm5, aeu_pwm5_show, aeu_pwm5_store);
> +static LP5812_KOBJ_ATTR_RW(slope_time_t1, aeu_slope_time_t1_show,
> + aeu_slope_time_t1_store);
> +static LP5812_KOBJ_ATTR_RW(slope_time_t2, aeu_slope_time_t2_show,
> + aeu_slope_time_t2_store);
> +static LP5812_KOBJ_ATTR_RW(slope_time_t3, aeu_slope_time_t3_show,
> + aeu_slope_time_t3_store);
> +static LP5812_KOBJ_ATTR_RW(slope_time_t4, aeu_slope_time_t4_show,
> + aeu_slope_time_t4_store);
> +static LP5812_KOBJ_ATTR_RW(playback_time, aeu_playback_time_show,
> + aeu_playback_time_store);
What is all this?
Nam: In autonomous mode, we can blink leds with specific PWM, delay, slope …
Refer: chapter 7.3.4 from https://www.ti.com/lit/ds/symlink/lp5812.pdf?ts=1741765622088&ref_url=https%253A%252F%252Fwww.ti.com%252Fproduct%252FLP5812
> +static int lp5812_probe(struct i2c_client *client)
> +{
> + struct lp5812_chip *chip;
> + int i; > + aeu_init_properties(&chip->leds[i]);
> +
> + /* set autonomous animation config as default for all LEDs */
> + led_set_autonomous_animation_config(&chip->leds[i]);
> + }
> +
> + i2c_set_clientdata(client, chip);
> +
> + ret = sysfs_create_group(&chip->dev->kobj, &chip->attr_group);
You need sysfs ABI documentation.
Nam: I understand that since the driver creates a sysfs attribute group using sysfs_create_group(), corresponding sysfs ABI documentation is required.
I will add a new entry under Documentation/ABI/testing/ to document the exposed sysfs attributes for the LP5812 driver in the next patch.
Best regards,
Nam
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: leds: Add LP5812 LED driver
2025-03-06 17:21 ` [PATCH v3 1/3] dt-bindings: leds: Add LP5812 LED driver Nam Tran
2025-03-07 8:42 ` Krzysztof Kozlowski
@ 2025-03-18 13:56 ` Nam Tran
2025-03-18 18:59 ` Krzysztof Kozlowski
1 sibling, 1 reply; 26+ messages in thread
From: Nam Tran @ 2025-03-18 13:56 UTC (permalink / raw)
To: krzk+dt; +Cc: pavel, lee, robh, conor+dt, devicetree, linux-leds, linux-kernel
From: Nam Tran <trannamatk@gmail.com>
To: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org> Pavel Machek <pavel@kernel.org>, Lee Jones <lee@kernel.org>, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Sorry for being unprofessional. I will make sure to properly address your concerns.
On Fri, Mar 07, 2025 at 12:21:24AM +0700, Nam Tran wrote:
> This documentation ensures proper integration of the LP5812
> in Device Tree-based systems.
No changelog, no improvements in commit msg. You got comment at v1 to
which you did not respond. Then you send v2 and I asked the same.
Please respond to the comment at v1 so acknowledge that you understood it.
Your previous comment
Your commit msg is totally redundant - you just said what Devicetree binding is. I asked to change it: describe the hardware instead.
Nam: I apologize for not responding to your v1 feedback. I appreciate your patience and will ensure that I acknowledge all review comments moving forward.
I now understand your request regarding the commit message. Instead of providing a generic description of Device Tree bindings, I will update the commit message in the next patch to describe the LP5812 hardware itself.
>
> Signed-off-by: Nam Tran <trannamatk@gmail.com>
> ---
> .../devicetree/bindings/leds/ti,lp5812.yaml | 50 +++++++++++++++++++
> MAINTAINERS | 6 +++
> 2 files changed, 56 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/ti,lp5812.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/ti,lp5812.yaml b/Documentation/devicetree/bindings/leds/ti,lp5812.yaml
> new file mode 100644
> index 000000000000..9a203da4f272
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/ti,lp5812.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/ti,lp5812.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +$ref: /schemas/leds/common.yaml#
> +
> +title: Linux driver for LP5812 LED from Texas Instruments
Nothing improved.
Nam: Do you mean the title should focus on the LP5812 hardware itself? If so, I will update it accordingly to better describe the device.
> +
> +maintainers:
> + - Nam Tran <trannamatk@gmail.com>
> +
> +description: |
> + The LP5812 is an I2C LED Driver that can support LED matrix 4x3.
> + For more product information please see the link below:
> + https://www.ti.com/product/LP5812#tech-docs
> +
> +properties:
> + compatible:
> + const: ti,lp5812
> +
> + reg:
> + maxItems: 1
This improved... but:
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
What are these?
Nam: I included the #address-cells and #size-cells properties to resolve a warning encountered when running:
make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/leds/ti,lp5812.yaml
The specific warning was:
Documentation/devicetree/bindings/leds/ti,lp5812.example.dts:23.17-30: Warning (reg_format): /example-0/i2c/led-controller@1b:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
This warning suggests that the default values for #address-cells and #size-cells in the schema context are not aligned with the LP5812's expected usage. To explicitly define the correct values, I set these properties as mentioned.
This ensures that the binding schema validation passes without warnings. If you believe a different approach is more appropriate, I’m happy to adjust the binding accordingly.
> +
> +required:
> + - compatible
> + - reg
> +
Nothing improved here.
Your previous comment
No ref to LED common schema? No other properties? This is too incomplete
Nam: I have chosen not to reference common.yaml in the LP5812 binding because the LP5812 does not fully align with the standard LED properties defined in the common schema. Since the driver does not use standard properties like function, color, or max-brightness, I believe referencing the common schema would introduce unnecessary constraints.
Currently, I have included compatible and reg as required properties, as they are essential for describing the LP5812 device. Are there additional properties that should be marked as required? Or if you have specific improvements in mind, I would appreciate your guidance.
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + led-controller@1b {
> + compatible = "ti,lp5812";
> + reg = <0x1b>;
> + };
> + };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8e0736dc2ee0..2bd9f5132cab 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -23506,6 +23506,12 @@ S: Maintained
> F: Documentation/devicetree/bindings/leds/backlight/ti,lp8864.yaml
> F: drivers/leds/leds-lp8864.c
>
> +TEXAS INSTRUMENTS' LP5812 LED DRIVER
Nothing improved.
Your previous comment
5 is before 8, so this does not look sorted.
Nam: I have reviewed the sorting order in MAINTAINERS, and I believe the current placement of LP5812 is correct. Since "LB" comes before "LP" alphabetically, "TEXAS INSTRUMENTS' LB8864 LED DRIVER" is correctly listed before "TEXAS INSTRUMENTS' LP5812 LED BACKLIGHT DRIVER".
It seems there is a typo in the MAINTAINERS file, should it be LB8864 or LP8864?
Best regards,
Nam Tran
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v3 3/3] leds: add new LED driver for TI LP5812
2025-03-18 13:35 ` Nam Tran
@ 2025-03-18 18:54 ` Krzysztof Kozlowski
2025-03-24 4:39 ` Nam Tran
2025-03-20 15:50 ` Lee Jones
1 sibling, 1 reply; 26+ messages in thread
From: Krzysztof Kozlowski @ 2025-03-18 18:54 UTC (permalink / raw)
To: Nam Tran, krzk+dt
Cc: pavel, lee, robh, conor+dt, devicetree, linux-leds, linux-kernel
On 18/03/2025 14:35, Nam Tran wrote:
> From: Nam Tran <trannamatk@gmail.com>
> To: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org> Pavel Machek <pavel@kernel.org>, Lee Jones <lee@kernel.org>, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
>
> I sincerely apologize for not addressing all of your previous comments earlier. That was not my intention, and I truly appreciate the time and effort you have put into reviewing my patch. Below, I would like to properly address your concerns.
>
> On Fri, Mar 07, 2025 at 12:21:26AM +0700, Nam Tran wrote:
>> The chip can drive LED matrix 4x3.
>> This driver enables LED control via I2C.
>
> You still did not respond to comments from v1. I don't see it being addressed.
>
> Nam: I am sorry. This is my mistake. I think that I just need to update source code based on your comments and submit a new patch. This is the first time I try to update a new thing to the Linux Kernel. I will give answer inline your message for tracing easily.
>
> In previous comment you have a question
> "Why none of the 10 existing drivers fit for your device?"
>
> Nam: I have carefully reviewed the existing LED drivers in the kernel, but none of them fully support the advanced capabilities of the LP5812. Unlike basic LED controllers, the LP5812 has difference features and register
> For more detail, please refer to this documentation https://www.ti.com/lit/ds/symlink/lp5812.pdf?ts=1741765622088&ref_url=https%253A%252F%252Fwww.ti.com%252Fproduct%252FLP5812
So you read my question and decided to not give an answer. Great.
The burden of proving this is on you. Do not expect me to read this and
10 other datasheets for existing LP devices. Maybe they fit, maybe they
don't but based on style of this submission and style of the code I feel
you just want to push your patches instead of integrate.
That's not how it works.
>
>>
>> The driver is implemented in two parts:
>> - Core driver logic in leds-lp5812.c
>> - Common support functions in leds-lp5812-common.c
>
> Why do you make two modules? This looks really unneccessary. Just compile them into one module. No, use proper kerneldoc Missing kerneldoc. Every exported symbol must have kerneldoc. Why this is not static?
>
> Nam: I will merge source code into a file only. Therefore, I don’t need to export symbols here.
I cannot parse this. Use standard email quotes and replies. Like every
email client since 30 years.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: leds: Add LP5812 LED driver
2025-03-18 13:56 ` Nam Tran
@ 2025-03-18 18:59 ` Krzysztof Kozlowski
2025-03-31 15:31 ` Nam Tran
0 siblings, 1 reply; 26+ messages in thread
From: Krzysztof Kozlowski @ 2025-03-18 18:59 UTC (permalink / raw)
To: Nam Tran, krzk+dt
Cc: pavel, lee, robh, conor+dt, devicetree, linux-leds, linux-kernel
On 18/03/2025 14:56, Nam Tran wrote:
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/leds/ti,lp5812.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +$ref: /schemas/leds/common.yaml#
>> +
>> +title: Linux driver for LP5812 LED from Texas Instruments
>
> Nothing improved.
>
> Nam: Do you mean the title should focus on the LP5812 hardware itself? If so, I will update it accordingly to better describe the device.
No, I mean you should say what this device is, not what the driver is
for. Bindings are about hardware, not drivers.
>
>> +
>> +maintainers:
>> + - Nam Tran <trannamatk@gmail.com>
>> +
>> +description: |
>> + The LP5812 is an I2C LED Driver that can support LED matrix 4x3.
>> + For more product information please see the link below:
>> + https://www.ti.com/product/LP5812#tech-docs
>> +
>> +properties:
>> + compatible:
>> + const: ti,lp5812
>> +
>> + reg:
>> + maxItems: 1
>
>
> This improved... but:
>
>> +
>> + "#address-cells":
>> + const: 1
>> +
>> + "#size-cells":
>> + const: 0
>
> What are these?
>
> Nam: I included the #address-cells and #size-cells properties to resolve a warning encountered when running:
> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/leds/ti,lp5812.yaml
> The specific warning was:
> Documentation/devicetree/bindings/leds/ti,lp5812.example.dts:23.17-30: Warning (reg_format): /example-0/i2c/led-controller@1b:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
This makes no sense.
> This warning suggests that the default values for #address-cells and #size-cells in the schema context are not aligned with the LP5812's expected usage. To explicitly define the correct values, I set these properties as mentioned.
> This ensures that the binding schema validation passes without warnings. If you believe a different approach is more appropriate, I’m happy to adjust the binding accordingly.
I can barely parse your messages. They are neither properly quoting my
replies, nor wrapped according to email style. Use standard format,
expressed in countless guides bout netiquette and mailing lists.
You added properties to hide warning, instead of fixing the warning, but
these properties make nos sense here.
>
>> +
>> +required:
>> + - compatible
>> + - reg
>> +
>
> Nothing improved here.
> Your previous comment
> No ref to LED common schema? No other properties? This is too incomplete
>
> Nam: I have chosen not to reference common.yaml in the LP5812 binding because the LP5812 does not fully align with the standard LED properties defined in the common schema. Since the driver does
That's a no go.
> not use standard properties like function, color, or max-brightness, I believe referencing the common schema would introduce unnecessary constraints.
Driver? Please describe hardware, not driver.
> Currently, I have included compatible and reg as required properties, as they are essential for describing the LP5812 device. Are there additional properties that should be marked as required? Or if you have specific improvements in mind, I would appreciate your guidance.
Look at other bindings and do not re-invent.
>
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + i2c {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + led-controller@1b {
>> + compatible = "ti,lp5812";
>> + reg = <0x1b>;
>> + };
>> + };
>> +
>> +...
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 8e0736dc2ee0..2bd9f5132cab 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -23506,6 +23506,12 @@ S: Maintained
>> F: Documentation/devicetree/bindings/leds/backlight/ti,lp8864.yaml
>> F: drivers/leds/leds-lp8864.c
>>
>> +TEXAS INSTRUMENTS' LP5812 LED DRIVER
>
> Nothing improved.
> Your previous comment
> 5 is before 8, so this does not look sorted.
>
> Nam: I have reviewed the sorting order in MAINTAINERS, and I believe the current placement of LP5812 is correct. Since "LB" comes before "LP" alphabetically, "TEXAS INSTRUMENTS' LB8864 LED DRIVER" is correctly listed before "TEXAS INSTRUMENTS' LP5812 LED BACKLIGHT DRIVER".
Indeed, existing entry has typo, so code is fine. Is it such a big deal
to answer to reviewer to his comment?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v3 3/3] leds: add new LED driver for TI LP5812
2025-03-18 13:35 ` Nam Tran
2025-03-18 18:54 ` Krzysztof Kozlowski
@ 2025-03-20 15:50 ` Lee Jones
2025-03-24 4:34 ` Nam Tran
1 sibling, 1 reply; 26+ messages in thread
From: Lee Jones @ 2025-03-20 15:50 UTC (permalink / raw)
To: Nam Tran
Cc: krzk+dt, pavel, robh, conor+dt, devicetree, linux-leds,
linux-kernel
On Tue, 18 Mar 2025, Nam Tran wrote:
> From: Nam Tran <trannamatk@gmail.com>
> To: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org> Pavel Machek <pavel@kernel.org>, Lee Jones <lee@kernel.org>, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
>
> I sincerely apologize for not addressing all of your previous comments earlier. That was not my intention, and I truly appreciate the time and effort you have put into reviewing my patch. Below, I would like to properly address your concerns.
>
> On Fri, Mar 07, 2025 at 12:21:26AM +0700, Nam Tran wrote:
> > The chip can drive LED matrix 4x3.
> > This driver enables LED control via I2C.
>
> You still did not respond to comments from v1. I don't see it being addressed.
>
> Nam: I am sorry. This is my mistake. I think that I just need to update source code based on your comments and submit a new patch. This is the first time I try to update a new thing to the Linux Kernel. I will give answer inline your message for tracing easily.
For the record, I find this format pretty unreadable.
Please reply directly to the email you are responding to. This response
looks as though you're replying to the patch itself.
Configure your mailer to refrain from placing header information (To:
Cc: From: etc) in the body of the mail.
If your mailer conducts quoting correctly, there should be no need for
"Nam:" comments. For me it looks as though you authored both the review
comment and the response, since your mailer currently does not handle
quoting correctly.
It would help everyone out if you could configure your mailer correctly.
Maybe this document has additional hints for you particular mailer:
Documentation/process/email-clients.rst
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v3 3/3] leds: add new LED driver for TI LP5812
[not found] <0250320155012.GT3890718@google.com>
@ 2025-03-24 3:54 ` Nam Tran
0 siblings, 0 replies; 26+ messages in thread
From: Nam Tran @ 2025-03-24 3:54 UTC (permalink / raw)
To: lee; +Cc: pavel, krzk+dt, robh, conor+dt, devicetree, linux-leds,
linux-kernel
Thank you for your suggestion. I appreciate your guidance on proper email formatting.
I will ensure my future responses follow this standard.
Your feedback is very helpful for me to improve my contributions.
Best regards,
Nam Tran
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v3 3/3] leds: add new LED driver for TI LP5812
2025-03-20 15:50 ` Lee Jones
@ 2025-03-24 4:34 ` Nam Tran
0 siblings, 0 replies; 26+ messages in thread
From: Nam Tran @ 2025-03-24 4:34 UTC (permalink / raw)
To: lee; +Cc: pavel, krzk+dt, robh, conor+dt, devicetree, linux-leds,
linux-kernel
Thank you for your suggestion. I appreciate your guidance on proper email formatting.
I will ensure my future responses follow this standard.
Your feedback is very helpful for me to improve my contributions.
Best regards,
Nam Tran
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v3 3/3] leds: add new LED driver for TI LP5812
2025-03-18 18:54 ` Krzysztof Kozlowski
@ 2025-03-24 4:39 ` Nam Tran
0 siblings, 0 replies; 26+ messages in thread
From: Nam Tran @ 2025-03-24 4:39 UTC (permalink / raw)
To: krzk+dt; +Cc: pavel, lee, robh, conor+dt, devicetree, linux-leds, linux-kernel
On 18 Mar 2025 19:54:15, Krzysztof Kozlowski wrote:
>>
>> In previous comment you have a question
>> "Why none of the 10 existing drivers fit for your device?"
>>
>> Nam: I have carefully reviewed the existing LED drivers in the kernel, but none of them fully support the advanced capabilities of the LP5812. Unlike basic LED controllers, the LP5812 has difference features and register
>> For more detail, please refer to this documentation https://www.ti.com/lit/ds/symlink/lp5812.pdf?ts=1741765622088&ref_url=https%253A%252F%252Fwww.ti.com%252Fproduct%252FLP5812
>
>So you read my question and decided to not give an answer. Great.
I am sorry, this was my mistake. I thought I only needed to update the source code based on your comments and submit a new patch.
I will make sure to respond to your comments more promptly in the future.
>The burden of proving this is on you. Do not expect me to read this and
>10 other datasheets for existing LP devices. Maybe they fit, maybe they
>don't but based on style of this submission and style of the code I feel
>you just want to push your patches instead of integrate.
>
>That's not how it works.
I appreciate your feedback. I will provide a more detailed explanation rather than just linking the datasheet.
LP5812 is a new LED driver family. LP5812 has different registers for new features such as run mode, config AEU module...
These are not supported in the existing drivers, which are tailored for different device architectures or use cases.
The LP5812 uses a register map and control scheme that differs significantly from other LPxxxx LED drivers.
This required a custom implementation to manage device mode, select LEDs in each mode, configure autonomous AEU...
Integrating the LP5812 into an existing driver would introduce significant complexity,
as it would require modifications that could compromise the performance or maintainability of the existing codebase.
Developing a dedicated driver ensures clean, maintainable, and optimized code.
By creating a separate driver for the LP5812, we ensure that it can fully exploit its capabilities while maintaining compatibility with the Linux driver framework.
This approach also facilitates scalability for future revisions of this or similar devices.
>>
>>>
>>> The driver is implemented in two parts:
>>> - Core driver logic in leds-lp5812.c
>>> - Common support functions in leds-lp5812-common.c
>>
>> Why do you make two modules? This looks really unneccessary. Just compile them into one module. No, use proper kerneldoc Missing kerneldoc. Every exported symbol must have kerneldoc. Why this is not static?
>>
>> Nam: I will merge source code into a file only. Therefore, I don’t need to export symbols here.
>
> I cannot parse this. Use standard email quotes and replies. Like every
> email client since 30 years.
I apologize for the formatting issue in my previous response. I will ensure that my future responses follow standard email quoting for better readability.
For my remaining unreadable responses, I will correct them and reply to the corresponding emails.
Best regards,
Nam Tran
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v3 3/3] leds: add new LED driver for TI LP5812
2025-03-07 8:52 ` Krzysztof Kozlowski
@ 2025-03-24 4:44 ` Nam Tran
0 siblings, 0 replies; 26+ messages in thread
From: Nam Tran @ 2025-03-24 4:44 UTC (permalink / raw)
To: krzk+dt; +Cc: pavel, lee, robh, conor+dt, devicetree, linux-leds, linux-kernel
Below, I will properly address your remaining concerns in a better format.
On 7 Mar 2025 09:52:21, Krzysztof Kozlowski wrote:
>>
>> The driver is implemented in two parts:
>> - Core driver logic in leds-lp5812.c
>> - Common support functions in leds-lp5812-common.c
>
>Why do you make two modules? This looks really unneccessary. Just
>compile them into one module.
I will merge source code into a file only.
>> +#include "leds-lp5812-common.h"
>> +
>> +/*
>> + * Function: lp5812_write
>> + * Params:
>> + * Return: 0 if success
>
>No, use proper kerneldoc
>
>> + */
>> +int lp5812_write(struct lp5812_chip *chip, u16 reg, u8 val)
>> +{
>> + int ret;
>> + u8 extracted_bits; /* save 9th and 8th bit of reg address */
>> + struct i2c_msg msg;
>> + u8 buf[2] = {(u8)(reg & 0xFF), val};
>> +
>> + extracted_bits = (reg >> 8) & 0x03;
>> + msg.addr = (chip->i2c_cl->addr << 2) | extracted_bits;
>> + msg.flags = 0;
>> + msg.len = sizeof(buf);
>> + msg.buf = buf;
>> +
>> + ret = i2c_transfer(chip->i2c_cl->adapter, &msg, 1);
>> + if (ret != 1) {
>> + dev_err(chip->dev, "i2c write error, register 0x%02X, ret=%d\n", reg, ret);
>> + ret = ret < 0 ? ret : -EIO;
>> + } else {
>> + ret = 0;
>> + }
>> +
>> + return ret;
>> +}
>> +EXPORT_SYMBOL_GPL(lp5812_write);
>> +
>
>Missing kerneldoc. Every exported symbol must have kerneldoc.
If I merge leds-lp5812-common.c into leds-lp5812.c, the functions will no longer need to be exported, as they will only be used internally within a single compilation unit.
As a result, kernel doc for these symbols will no longer be mandatory.
Would you agree that this approach eliminates the need for separate kernel doc entries for these functions?
>> +int lp5812_read(struct lp5812_chip *chip, u16 reg, u8 *val)
>> +{
>> + int ret;
>> + u8 ret_val; /* lp5812_chip return value */
>> + u8 extracted_bits; /* save 9th and 8th bit of reg address */
>> + u8 converted_reg; /* extracted 8bit from reg */
>> + struct i2c_msg msgs[2];
>> +
>> + extracted_bits = (reg >> 8) & 0x03;
>> + converted_reg = (u8)(reg & 0xFF);
>> +
>> + msgs[0].addr = (chip->i2c_cl->addr << 2) | extracted_bits;
>> + msgs[0].flags = 0;
>> + msgs[0].len = 1;
>> + msgs[0].buf = &converted_reg;
>> +
>> + msgs[1].addr = (chip->i2c_cl->addr << 2) | extracted_bits;
>> + msgs[1].flags = I2C_M_RD;
>> + msgs[1].len = 1;
>> + msgs[1].buf = &ret_val;
>> +
>> + ret = i2c_transfer(chip->i2c_cl->adapter, msgs, 2);
>> + if (ret != 2) {
>> + dev_err(chip->dev, "Read register 0x%02X error, ret=%d\n", reg, ret);
>> + *val = 0;
>> + ret = ret < 0 ? ret : -EIO;
>> + } else {
>> + *val = ret_val;
>> + ret = 0;
>> + }
>> +
>> + return ret;
>> +}
>> +EXPORT_SYMBOL_GPL(lp5812_read);
>> +
>> +int lp5812_update_bit(struct lp5812_chip *chip, u16 reg, u8 mask, u8 val)
>
>Why this is not static?
I will change it to a static function.
>> +{
>> + int ret;
>> + u8 tmp;
>> +
>> + ret = lp5812_read(chip, reg, &tmp);
>> + if (ret)
>> + return ret;
>> +
>> + tmp &= ~mask;
>> + tmp |= val & mask;
>> +
>> + return lp5812_write(chip, reg, tmp);
>> +}
>> +
>> +/*
>> + * Function: lp5812_read_tsd_config_status
>> + * Description: read tsd config status register
>> + * Param: chip --> struct lp5812_chip itself
>> + * reg_val
>> + * Return: 0 if success
>> + */
>> +int lp5812_read_tsd_config_status(struct lp5812_chip *chip, u8 *reg_val)
>
>Why this is not static?
I will change it to a static function.
>> +{
>> + int ret = 0;
>> +
>> + if (!reg_val)
>> + return -1;
>> +
>> + ret = lp5812_read(chip, chip->regs->tsd_config_status_reg, reg_val);
>> +
>> + return ret;
>> +}
>> +
>> +/*
>> + * Function: lp5812_update_regs_config
>
>Missing kerneldoc
As mentioned above, I won't use EXPORT_SYMBOL_GPL for this function.
>> + * Description: update reg config register
>> + * Param: chip --> struct lp5812_chip itself
>> + * Return: 0 if success
>> + */
>> +int lp5812_update_regs_config(struct lp5812_chip *chip)
>> +{
>> + int ret;
>> + u8 reg_val; /* save register value */
>> +
>
>...
As mentioned above, I won't use EXPORT_SYMBOL_GPL for this function.
>
>> +static struct drive_mode_led_map chip_leds_map[] = {
>> + {
>> + "direct_mode",
>> + (const char *[]){LED0, LED1, LED2, LED3, NULL},
>
>Drop the cast.
I will drop them.
>> + },
>> + {
>> + "tcmscan:1:0", /* tcm 1 scan; scan order 0 out0 */
>> + (const char *[]){LED_A0, LED_A1, LED_A2, NULL},
>> + },
>> + {
>> + "tcmscan:1:1", /* tcm 1 scan; scan order 0 out1 */
>> + (const char *[]){LED_B0, LED_B1, LED_B2, NULL},
>> + },
>> + {
>> + "tcmscan:1:2", /* tcm 1 scan; scan order 0 out2 */
>> + (const char *[]){LED_C0, LED_C1, LED_C2, NULL},
>> + },
>> + {
>> + "tcmscan:1:3", /* tcm 1 scan; scan order 0 out3 */
>> + (const char *[]){LED_D0, LED_D1, LED_D2, NULL},
>
>
>What is all this here?
>
>How LED controller with so little properties have so complicated driver?
This hardware has 3 main modes. Each mode has many options. My idea is to create a driver that supports all capabilities of the hardware.
Therefore, when the user updates the mode of hardware, it will create specific device files.
Refer: https://dev.ti.com/gallery/view/LED/LP581x/ver/0.16.0/
>> + },
>> + { /* tcm 2 scan, scan order 0 out0; scan order 1 out1 */
>> + "tcmscan:2:0:1",
>> + (const char *[]){LED_A0, LED_A1, LED_A2, LED_B0, LED_B1, LED_B2,
>> + NULL},
>> + },
>> + { /* tcm 2 scan, scan order 0 out0; scan order 1 out2 */
>> + "tcmscan:2:0:2",
>> + (const char *[]){LED_A0, LED_A1, LED_A2, LED_C0, LED_C1, LED_C2,
>> + NULL},
>
>
>> +static void led_kobj_release(struct kobject *kobj)
>> +{
>> + kfree(kobj);
>> +}
>> +
>> +static void aeu_kobj_release(struct kobject *kobj)
>> +{
>> + kfree(kobj);
>> +}
>
>What is all this? Why do you create your own kobjects?
Same as previous answer, I need to create kobjects to support many interfaces.
>> +
>> +static const struct kobj_type led_ktype = {
>> + .release = led_kobj_release,
>> + .sysfs_ops = &kobj_sysfs_ops,
>> +};
>> +
>> +static const struct kobj_type aeu_ktype = {
>> + .release = aeu_kobj_release,
>> + .sysfs_ops = &kobj_sysfs_ops,
>> +};
>
>
>> +static ssize_t device_reset_store(struct device *dev,
>> + struct device_attribute *attr,
>> + const char *buf, size_t len)
>
>NAK.
>
>Sorry, you just cannot create whatever interfaces you want. You must use
>standard LED interfaces for normal LED operations. None of these sysfs
>are needed for device control.
>
>Respond to this comment that you understood it (you ignored all previous
>comments).
Based on LP5812 datasheet, it is not normal LED operations. It supports many modes, each mode we can control specific leds (user can enable/disable leds). Each led has normal mode, autonomous mode,… That is why I want to create interfaces.
Based on your concern, I think that my driver may not be compatible with normal LED operations. Given that the LP5812 driver has advanced functionality beyond basic LED control, would it be acceptable to place the driver in a different location instead of drivers/led/? If so, could you suggest a more suitable location?
I am open to discussions on how best to integrate these features while maintaining compliance with kernel standards. Please let me know your thoughts on how we can refine the approach.
>> +static LP5812_KOBJ_ATTR_RW(pwm1, aeu_pwm1_show, aeu_pwm1_store);
>> +static LP5812_KOBJ_ATTR_RW(pwm2, aeu_pwm2_show, aeu_pwm2_store);
>> +static LP5812_KOBJ_ATTR_RW(pwm3, aeu_pwm3_show, aeu_pwm3_store);
>> +static LP5812_KOBJ_ATTR_RW(pwm4, aeu_pwm4_show, aeu_pwm4_store);
>> +static LP5812_KOBJ_ATTR_RW(pwm5, aeu_pwm5_show, aeu_pwm5_store);
>> +static LP5812_KOBJ_ATTR_RW(slope_time_t1, aeu_slope_time_t1_show,
>> + aeu_slope_time_t1_store);
>> +static LP5812_KOBJ_ATTR_RW(slope_time_t2, aeu_slope_time_t2_show,
>> + aeu_slope_time_t2_store);
>> +static LP5812_KOBJ_ATTR_RW(slope_time_t3, aeu_slope_time_t3_show,
>> + aeu_slope_time_t3_store);
>> +static LP5812_KOBJ_ATTR_RW(slope_time_t4, aeu_slope_time_t4_show,
>> + aeu_slope_time_t4_store);
>> +static LP5812_KOBJ_ATTR_RW(playback_time, aeu_playback_time_show,
>> + aeu_playback_time_store);
>
>
>What is all this?
In autonomous mode, we can blink leds with specific PWM, delay, slope …
Refer: chapter 7.3.4 from https://www.ti.com/lit/ds/symlink/lp5812.pdf?ts=1741765622088&ref_url=https%253A%252F%252Fwww.ti.com%252Fproduct%252FLP5812
>> +static int lp5812_probe(struct i2c_client *client)
>> +{
>> + struct lp5812_chip *chip;
>> + int i;
>> + int ret;
>> + u8 val;
>> +
>> + chip = devm_kzalloc(&client->dev, sizeof(struct lp5812_chip),
>> + GFP_KERNEL);
>> + if (!chip)
>> + return -ENOMEM;
>> + mutex_init(&chip->lock);
>> + chip->i2c_cl = client;
>> + chip->dev = &client->dev;
>> + chip->regs = ®s;
>> + chip->command = NONE;
>> + chip->total_leds = MAX_LEDS;
>> + chip->attr_group.name = "lp5812_chip_setup";
>> + chip->attr_group.attrs = lp5812_chip_attributes;
>> + chip->chip_leds_map = chip_leds_map;
>> + chip->u_drive_mode.drive_mode_val = 0x10;
>> + chip->u_scan_order.scan_order_val = 0x00;
>> +
>> + /* initialize property for each led */
>> + for (i = 0; i < MAX_LEDS; i++) {
>> + chip->leds[i].led_name = led_name_array[i];
>> + chip->leds[i].led_number = i;
>> + chip->leds[i].anim_base_addr = anim_base_addr_array[i];
>> + chip->leds[i].enable = 0; /* LED disable as default */
>> + chip->leds[i].mode = MANUAL; /* manual mode as default */
>> + chip->leds[i].priv = chip;
>> + chip->leds[i].total_aeu = MAX_AEU;
>> + chip->leds[i].led_playback.led_playback_val = 0;
>> + chip->leds[i].start_stop_pause_time.time_val = 0;
>> + /* sysfs for this led not be created */
>> + chip->leds[i].is_sysfs_created = 0;
>> + chip->leds[i].attr_group.attrs = led_kobj_attributes;
>> + kobject_init(&chip->leds[i].kobj, &led_ktype);
>> +
>> + /* init animation engine unit properties */
>> + aeu_init_properties(&chip->leds[i]);
>> +
>> + /* set autonomous animation config as default for all LEDs */
>> + led_set_autonomous_animation_config(&chip->leds[i]);
>> + }
>> +
>> + i2c_set_clientdata(client, chip);
>> +
>> + ret = sysfs_create_group(&chip->dev->kobj, &chip->attr_group);
>
>
>You need sysfs ABI documentation.
I will add a new entry under Documentation/ABI/testing/ to document the exposed sysfs attributes for the LP5812 driver in the next patch.
Best regards,
Nam Tran
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v3 3/3] leds: add new LED driver for TI LP5812
2025-03-06 17:21 ` [PATCH v3 3/3] leds: add new LED driver for TI LP5812 Nam Tran
` (4 preceding siblings ...)
2025-03-18 13:35 ` Nam Tran
@ 2025-03-25 19:15 ` Markus Elfring
2025-03-27 15:48 ` Nam Tran
5 siblings, 1 reply; 26+ messages in thread
From: Markus Elfring @ 2025-03-25 19:15 UTC (permalink / raw)
To: Nam Tran, linux-leds, devicetree
Cc: LKML, Conor Dooley, Krzysztof Kozlowski, Lee Jones, Pavel Machek,
Rob Herring
…
> +++ b/drivers/leds/leds-lp5812.c
> @@ -0,0 +1,2190 @@
…
> +static ssize_t device_enable_show(struct device *dev,
> + struct device_attribute *attr,
> + char *buf)
> +{
…
> + mutex_lock(&chip->lock);
> + if (lp5812_read(chip, chip->regs->enable_reg, &enable)) {
> + mutex_unlock(&chip->lock);
> + return -EIO;
> + }
> + mutex_unlock(&chip->lock);
> +
> + return sprintf(buf, "%d\n", enable);
> +}
…
Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&chip->lock);”?
https://elixir.bootlin.com/linux/v6.14-rc6/source/include/linux/mutex.h#L201
Regards,
Markus
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v3 3/3] leds: add new LED driver for TI LP5812
2025-03-25 19:15 ` Markus Elfring
@ 2025-03-27 15:48 ` Nam Tran
0 siblings, 0 replies; 26+ messages in thread
From: Nam Tran @ 2025-03-27 15:48 UTC (permalink / raw)
To: Markus.Elfring
Cc: pavel, lee, krzk+dt, robh, conor+dt, devicetree, linux-leds,
linux-kernel
> …
> > +++ b/drivers/leds/leds-lp5812.c
> > @@ -0,0 +1,2190 @@
> …
> > +static ssize_t device_enable_show(struct device *dev,
> > + struct device_attribute *attr,
> > + char *buf)
> > +{
> …
> > + mutex_lock(&chip->lock);
> > + if (lp5812_read(chip, chip->regs->enable_reg, &enable)) {
> > + mutex_unlock(&chip->lock);
> > + return -EIO;
> > + }
> > + mutex_unlock(&chip->lock);
> > +
> > + return sprintf(buf, "%d\n", enable);
> > +}
> …
>
> Under which circumstances would you become interested to apply a statement
> like “guard(mutex)(&chip->lock);”?
> https://elixir.bootlin.com/linux/v6.14-rc6/source/include/linux/mutex.h#L201
Thank you for your suggestion regarding the use of guard(mutex)(&chip->lock).
While we understand the impacts of this approach, we are currently not planning to change the source code in this version.
We will consider incorporating this improvement in the next TI LED version.
Best regards,
Nam Tran
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: leds: Add LP5812 LED driver
2025-03-18 18:59 ` Krzysztof Kozlowski
@ 2025-03-31 15:31 ` Nam Tran
2025-03-31 15:42 ` Krzysztof Kozlowski
0 siblings, 1 reply; 26+ messages in thread
From: Nam Tran @ 2025-03-31 15:31 UTC (permalink / raw)
To: krzk+dt; +Cc: pavel, lee, robh, conor+dt, devicetree, linux-leds, linux-kernel
On 18 Mar 2025 19:59:51, Krzysztof Kozlowski wrote:
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/leds/ti,lp5812.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +$ref: /schemas/leds/common.yaml#
>>> +
>>> +title: Linux driver for LP5812 LED from Texas Instruments
>>
>> Nothing improved.
>>
>> Nam: Do you mean the title should focus on the LP5812 hardware itself? If so, I will update it accordingly to better describe the device.
>
>No, I mean you should say what this device is, not what the driver is
>for. Bindings are about hardware, not drivers.
Thank you for the clarification.
I will change the title to “TI/National Semiconductor LP5812 LED Drivers”.
>>
>>> +
>>> +maintainers:
>>> + - Nam Tran <trannamatk@gmail.com>
>>> +
>>> +description: |
>>> + The LP5812 is an I2C LED Driver that can support LED matrix 4x3.
>>> + For more product information please see the link below:
>>> + https://www.ti.com/product/LP5812#tech-docs
>>> +
>>> +properties:
>>> + compatible:
>>> + const: ti,lp5812
>>> +
>>> + reg:
>>> + maxItems: 1
>>
>>
>> This improved... but:
>>
>>> +
>>> + "#address-cells":
>>> + const: 1
>>> +
>>> + "#size-cells":
>>> + const: 0
>>
>> What are these?
>>
>> Nam: I included the #address-cells and #size-cells properties to resolve a warning encountered when running:
>> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/leds/ti,lp5812.yaml
>> The specific warning was:
>> Documentation/devicetree/bindings/leds/ti,lp5812.example.dts:23.17-30: Warning (reg_format): /example-0/i2c/led-controller@1b:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
>
>This makes no sense.
>
>> This warning suggests that the default values for #address-cells and #size-cells in the schema context are not aligned with the LP5812's expected usage. To explicitly define the correct values, I set these properties as mentioned.
>> This ensures that the binding schema validation passes without warnings. If you believe a different approach is more appropriate, I’m happy to adjust the binding accordingly.
>
>I can barely parse your messages. They are neither properly quoting my
>replies, nor wrapped according to email style. Use standard format,
>expressed in countless guides bout netiquette and mailing lists.
>
>You added properties to hide warning, instead of fixing the warning, but
>these properties make nos sense here.
#address-cells is 1 because I only one cell to define address of a child node of LP5812
#size-cells is 0 because I don't need to define size of reg properly of child node.
Reg properly of child node is describe for address only.
>>
>>> +
>>> +required:
>>> + - compatible
>>> + - reg
>>> +
>>
>> Nothing improved here.
>> Your previous comment
>> No ref to LED common schema? No other properties? This is too incomplete
>>
>> Nam: I have chosen not to reference common.yaml in the LP5812 binding because the LP5812 does not fully align with the standard LED properties defined in the common schema. Since the driver does
>
>That's a no go.
>
>> not use standard properties like function, color, or max-brightness, I believe referencing the common schema would introduce unnecessary constraints.
>
>Driver? Please describe hardware, not driver.
>
>> Currently, I have included compatible and reg as required properties, as they are essential for describing the LP5812 device. Are there additional properties that should be marked as required? Or if you have specific improvements in mind, I would appreciate your guidance.
>
>Look at other bindings and do not re-invent.
I checked other bindings and I will update LP5812 yaml follow multi color led and describe LP5812 hardware in the yaml.
My new yaml will update as below
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
%YAML 1.2
---
$id: http://devicetree.org/schemas/leds/ti,lp5812.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
$ref: /schemas/leds/common.yaml#
title: TI/National Semiconductor LP5812 LED Drivers
maintainers:
- Nam Tran <trannamatk@gmail.com>
description: |
The LP5812 is an I2C LED Driver that can support LED matrix 4x3.
For more product information please see the link below:
https://www.ti.com/product/LP5812#tech-docs
properties:
compatible:
const: ti,lp5812
reg:
maxItems: 1
description:
I2C slave address
lp5812/12- 0x1b
"#address-cells":
const: 1
"#size-cells":
const: 0
patternProperties:
'^multi-led@[0-3]$':
type: object
$ref: leds-class-multicolor.yaml#
unevaluatedProperties: false
properties:
reg:
minItems: 1
maxItems: 12
'#address-cells':
const: 1
'#size-cells':
const: 0
patternProperties:
"^led@[0-9a-f]+$":
type: object
$ref: common.yaml#
unevaluatedProperties: false
properties:
reg:
maxItems: 1
required:
- reg
required:
- compatible
- reg
additionalProperties: false
examples:
- |
#include <dt-bindings/leds/common.h>
i2c {
#address-cells = <1>;
#size-cells = <0>;
led-controller@1b {
compatible = "ti,lp5812";
reg = <0x1b>;
#address-cells = <1>;
#size-cells = <0>;
multi-led@0 {
#address-cells = <1>;
#size-cells = <0>;
reg = <0x0>;
color = <LED_COLOR_ID_RGB>;
led@0 {
reg = <0x0>;
color = <LED_COLOR_ID_GREEN>;
};
led@1 {
reg = <0x1>;
color = <LED_COLOR_ID_RED>;
};
led@2 {
reg = <0x2>;
color = <LED_COLOR_ID_BLUE>;
};
};
multi-led@1 {
#address-cells = <1>;
#size-cells = <0>;
reg = <0x1>;
color = <LED_COLOR_ID_RGB>;
led@3 {
reg = <0x3>;
color = <LED_COLOR_ID_GREEN>;
};
led@4 {
reg = <0x4>;
color = <LED_COLOR_ID_RED>;
};
led@5 {
reg = <0x5>;
color = <LED_COLOR_ID_BLUE>;
};
};
multi-led@2 {
#address-cells = <1>;
#size-cells = <0>;
reg = <0x2>;
color = <LED_COLOR_ID_RGB>;
led@6 {
reg = <0x6>;
color = <LED_COLOR_ID_GREEN>;
};
led@7 {
reg = <0x7>;
color = <LED_COLOR_ID_RED>;
};
led@8 {
reg = <0x8>;
color = <LED_COLOR_ID_BLUE>;
};
};
multi-led@3 {
#address-cells = <1>;
#size-cells = <0>;
reg = <0x3>;
color = <LED_COLOR_ID_RGB>;
led@9 {
reg = <0x9>;
color = <LED_COLOR_ID_GREEN>;
};
led@a {
reg = <0xA>;
color = <LED_COLOR_ID_RED>;
};
led@b {
reg = <0xB>;
color = <LED_COLOR_ID_BLUE>;
};
};
};
};
...
>>
>>> +additionalProperties: false
>>> +
>>> +examples:
>>> + - |
>>> + i2c {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + led-controller@1b {
>>> + compatible = "ti,lp5812";
>>> + reg = <0x1b>;
>>> + };
>>> + };
>>> +
>>> +...
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 8e0736dc2ee0..2bd9f5132cab 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -23506,6 +23506,12 @@ S: Maintained
>>> F: Documentation/devicetree/bindings/leds/backlight/ti,lp8864.yaml
>>> F: drivers/leds/leds-lp8864.c
>>>
>>> +TEXAS INSTRUMENTS' LP5812 LED DRIVER
>>
>> Nothing improved.
>> Your previous comment
>> 5 is before 8, so this does not look sorted.
>>
>> Nam: I have reviewed the sorting order in MAINTAINERS, and I believe the current placement of LP5812 is correct. Since "LB" comes before "LP" alphabetically, "TEXAS INSTRUMENTS' LB8864 LED DRIVER" is correctly listed before "TEXAS INSTRUMENTS' LP5812 LED BACKLIGHT DRIVER".
>
>
>Indeed, existing entry has typo, so code is fine. Is it such a big deal
>to answer to reviewer to his comment?
Thank you for the clarification. I now understand that the existing entry contains a typo.
I will make sure to response to reviewer comments more promtly in the future.
Is it acceptable if I modify MAINTAINERS file to adjust LB8864 to LP8864?
Best regards,
Nam Tran
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: leds: Add LP5812 LED driver
2025-03-31 15:31 ` Nam Tran
@ 2025-03-31 15:42 ` Krzysztof Kozlowski
2025-04-01 14:29 ` Nam Tran
0 siblings, 1 reply; 26+ messages in thread
From: Krzysztof Kozlowski @ 2025-03-31 15:42 UTC (permalink / raw)
To: Nam Tran, krzk+dt
Cc: pavel, lee, robh, conor+dt, devicetree, linux-leds, linux-kernel
On 31/03/2025 17:31, Nam Tran wrote:
>>>
>>>> +
>>>> + "#address-cells":
>>>> + const: 1
>>>> +
>>>> + "#size-cells":
>>>> + const: 0
>>>
>>> What are these?
>>>
>>> Nam: I included the #address-cells and #size-cells properties to resolve a warning encountered when running:
>>> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/leds/ti,lp5812.yaml
>>> The specific warning was:
>>> Documentation/devicetree/bindings/leds/ti,lp5812.example.dts:23.17-30: Warning (reg_format): /example-0/i2c/led-controller@1b:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
>>
>> This makes no sense.
>>
>>> This warning suggests that the default values for #address-cells and #size-cells in the schema context are not aligned with the LP5812's expected usage. To explicitly define the correct values, I set these properties as mentioned.
>>> This ensures that the binding schema validation passes without warnings. If you believe a different approach is more appropriate, I’m happy to adjust the binding accordingly.
>>
>> I can barely parse your messages. They are neither properly quoting my
>> replies, nor wrapped according to email style. Use standard format,
>> expressed in countless guides bout netiquette and mailing lists.
>>
>> You added properties to hide warning, instead of fixing the warning, but
>> these properties make nos sense here.
>
> #address-cells is 1 because I only one cell to define address of a child node of LP5812
> #size-cells is 0 because I don't need to define size of reg properly of child node.
> Reg properly of child node is describe for address only.
Please do not explain me how DT works, we all know. You do not have
child node. If you disagree - point me to the line in schema having it.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: leds: Add LP5812 LED driver
2025-03-31 15:42 ` Krzysztof Kozlowski
@ 2025-04-01 14:29 ` Nam Tran
2025-04-01 15:04 ` Krzysztof Kozlowski
0 siblings, 1 reply; 26+ messages in thread
From: Nam Tran @ 2025-04-01 14:29 UTC (permalink / raw)
To: krzk+dt; +Cc: pavel, lee, robh, conor+dt, devicetree, linux-leds, linux-kernel
On Mon, 31 Mar 2025, Krzysztof Kozlowski wrote:
>Please do not explain me how DT works, we all know. You do not have
>child node. If you disagree - point me to the line in schema having it.
Thank you for your feedback.
I now understand that my schema does not define child nodes, so #address-cells and #size-cells should not be included.
I will update the schema accordingly as shown below.
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
%YAML 1.2
---
$id: http://devicetree.org/schemas/leds/ti,lp5812.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
title: TI/National Semiconductor LP5812 LED Driver
maintainers:
- Nam Tran <trannamatk@gmail.com>
description: |
The LP5812 is an I2C LED Driver that can support LED matrix 4x3.
For more product information please see the link below:
https://www.ti.com/product/LP5812#tech-docs
properties:
compatible:
const: ti,lp5812
reg:
maxItems: 1
description:
I2C slave address
lp5812/12- 0x1b
patternProperties:
"^led@[0-9a-b]$":
type: object
$ref: common.yaml#
unevaluatedProperties: false
properties:
reg:
minimum: 0
maximum: 0xb
chan-name:
$ref: /schemas/types.yaml#/definitions/string
description: LED channel name
required:
- reg
required:
- compatible
- reg
additionalProperties: false
examples:
- |
#include <dt-bindings/leds/common.h>
i2c {
#address-cells = <1>;
#size-cells = <0>;
led-controller@1b {
compatible = "ti,lp5812";
reg = <0x1b>;
led@0 {
reg = <0x0>;
chan-name = "a0";
};
led@1 {
reg = <0x1>;
chan-name = "a1";
};
led@2 {
reg = <0x2>;
chan-name = "a2";
};
led@3 {
reg = <0x3>;
chan-name = "b0";
};
led@4 {
reg = <0x4>;
chan-name = "b1";
};
led@5 {
reg = <0x5>;
chan-name = "b2";
};
led@6 {
reg = <0x6>;
chan-name = "c0";
};
led@7 {
reg = <0x7>;
chan-name = "c1";
};
led@8 {
reg = <0x8>;
chan-name = "c2";
};
led@9 {
reg = <0x9>;
chan-name = "d0";
};
led@a {
reg = <0xa>;
chan-name = "d1";
};
led@b {
reg = <0xb>;
chan-name = "d2";
};
};
};
...
Best regards,
Nam Tran
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: leds: Add LP5812 LED driver
2025-04-01 14:29 ` Nam Tran
@ 2025-04-01 15:04 ` Krzysztof Kozlowski
0 siblings, 0 replies; 26+ messages in thread
From: Krzysztof Kozlowski @ 2025-04-01 15:04 UTC (permalink / raw)
To: Nam Tran, krzk+dt
Cc: pavel, lee, robh, conor+dt, devicetree, linux-leds, linux-kernel
On 01/04/2025 16:29, Nam Tran wrote:
> On Mon, 31 Mar 2025, Krzysztof Kozlowski wrote:
>
>> Please do not explain me how DT works, we all know. You do not have
>> child node. If you disagree - point me to the line in schema having it.
>
> Thank you for your feedback.
> I now understand that my schema does not define child nodes, so #address-cells and #size-cells should not be included.
> I will update the schema accordingly as shown below.
This has... What are we talking here about? I commented only about that
patch.
You claimed:
>Nam: I included the #address-cells and #size-cells properties to
resolve a warning encountered when running:
which was obviously not true. You could not have such errors, because
you did not have children. You disagreed with me so you got response
like that.
If you decide to add children, then you will need address and size
cells, but that's a different patch.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 26+ messages in thread
end of thread, other threads:[~2025-04-01 15:04 UTC | newest]
Thread overview: 26+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-06 17:21 [PATCH v3 0/3] leds: add new LED driver for TI LP5812 Nam Tran
2025-03-06 17:21 ` [PATCH v3 1/3] dt-bindings: leds: Add LP5812 LED driver Nam Tran
2025-03-07 8:42 ` Krzysztof Kozlowski
2025-03-18 13:56 ` Nam Tran
2025-03-18 18:59 ` Krzysztof Kozlowski
2025-03-31 15:31 ` Nam Tran
2025-03-31 15:42 ` Krzysztof Kozlowski
2025-04-01 14:29 ` Nam Tran
2025-04-01 15:04 ` Krzysztof Kozlowski
2025-03-06 17:21 ` [PATCH v3 2/3] arm64: dts: Add LP5812 LED node for Raspberry Pi 4 Model B Nam Tran
2025-03-07 8:42 ` Krzysztof Kozlowski
2025-03-07 8:43 ` Krzysztof Kozlowski
2025-03-06 17:21 ` [PATCH v3 3/3] leds: add new LED driver for TI LP5812 Nam Tran
2025-03-06 18:53 ` Christophe JAILLET
2025-03-07 8:52 ` Krzysztof Kozlowski
2025-03-24 4:44 ` Nam Tran
2025-03-10 1:21 ` kernel test robot
2025-03-11 11:20 ` kernel test robot
2025-03-18 13:35 ` Nam Tran
2025-03-18 18:54 ` Krzysztof Kozlowski
2025-03-24 4:39 ` Nam Tran
2025-03-20 15:50 ` Lee Jones
2025-03-24 4:34 ` Nam Tran
2025-03-25 19:15 ` Markus Elfring
2025-03-27 15:48 ` Nam Tran
[not found] <0250320155012.GT3890718@google.com>
2025-03-24 3:54 ` Nam Tran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).