Re: [PATCH v6 1/3] dt-bindings: hwmon: Add Microchip emc2305 support

Rob Herring
2025-03-21T21:35:23Z

On Fri, Mar 21, 2025 at 04:33:06PM +0200, florin.leotescu@oss.nxp.com wrote:
> From: Florin Leotescu <florin.leotescu@nxp.com>
>
> Introduce yaml schema for Microchip emc2305 pwm fan controller.
>
> Signed-off-by: Florin Leotescu <florin.leotescu@nxp.com>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/hwmon/microchip,emc2305.yaml | 110 ++++++++++++++++++
> 1 file changed, 110 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml b/Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml
> new file mode 100644
> index 000000000000..79081c116274
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml
> @@ -0,0 +1,110 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/microchip,emc2305.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip EMC2305 SMBus compliant PWM fan controller
> +
> +maintainers:
> + - Michael Shych <michaelsh@nvidia.com>
> +
> +description:
> + Microchip EMC2301/2/3/5 pwm controller which supports
> + up to five programmable fan control circuits.

Fix wrapping to wrap at 80.

> +
> +properties:
> + compatible:
> + oneOf:
> + - enum:
> + - microchip,emc2305
> + - items:
> + - enum:
> + - microchip,emc2303
> + - microchip,emc2302
> + - microchip,emc2301
> + - const: microchip,emc2305
> +
> + reg:
> + maxItems: 1
> +
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 0
> +
> + '#pwm-cells':
> + const: 3
> + description: |
> + Number of cells in a PWM specifier.
> + - cell 0: The PWM frequency
> + - cell 1: The PWM polarity: 0 or PWM_POLARITY_INVERTED
> + - cell 2: The PWM output config:
> + - 0 (Open-Drain)
> + - 1 (Push-Pull)
> +
> +patternProperties:
> + '^fan@[0-4]$':
> + $ref: fan-common.yaml#
> + unevaluatedProperties: false
> + properties:
> + reg:
> + description:
> + The fan number used to determine the associated PWM channel.

maxItems: 1

With that,

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>