Re: [PATCH RESEND 1/7] dt-bindings: soc: spacemit: define spacemit,k1-ccu resets

Alex Elder
2025-03-22T14:27:35Z

On 3/21/25 5:25 PM, Yixun Lan wrote:
> hi Alex:
>
> On 10:18 Fri 21 Mar , Alex Elder wrote:
>> There are additional SpacemiT syscon CCUs whose registers control both
>> clocks and resets: RCPU, RCPU2, and APBC2. Unlike those defined
>> previously, these will initially support only resets. They do not
>> incorporate power domain functionality.
>>
>> Define the index values for resets associated with all SpacemiT K1
>> syscon nodes, including those with clocks already defined, as well as
>> the new ones (without clocks).
>>
>> Signed-off-by: Alex Elder <elder@riscstar.com>
>> ---
>> .../soc/spacemit/spacemit,k1-syscon.yaml | 13 +-
>> include/dt-bindings/clock/spacemit,k1-ccu.h | 134 ++++++++++++++++++
>> 2 files changed, 143 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml b/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml
>> index 07a6728e6f864..333c28e075b6c 100644
>> --- a/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml
>> +++ b/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml
>> @@ -19,6 +19,9 @@ properties:
>> - spacemit,k1-syscon-apbc
>> - spacemit,k1-syscon-apmu
>> - spacemit,k1-syscon-mpmu
>> + - spacemit,k1-syscon-rcpu
>> + - spacemit,k1-syscon-rcpu2
>> + - spacemit,k1-syscon-apbc2
>>
>> reg:
>> maxItems: 1

. . .

32
>> @@ -180,6 +184,60 @@
>> #define CLK_TSEN_BUS 98
>> #define CLK_IPC_AP2AUD_BUS 99
>>
>> +/* APBC resets */
>> +
> I'd also suggest to drop above blank line, keep style consistent
> with others in this file, some same below that I won't comment

OK, I'll fix the weird extra line and will drop these blank
lines as you suggest in v2. I'll post another version after
Sunday. I recognize the merge window means I can't expect
reviews during that time, but this code is waiting for the
clock code to get accepted anyway.

Thanks a lot.

-Alex

>> +#define RST_UART0 0
>> +#define RST_UART2 1
>> +#define RST_UART3 2
>> +#define RST_UART4 3
>> +#define RST_UART5 4

. . .