[PATCH v5 0/5] dt-bindings: net: Add network-class.yaml schema

[PATCH v5 0/5] dt-bindings: net: Add network-class.yaml schema

[David Heidelberg via B4 Relay]

The Devicetree Specification, Release v0.3 specifies in section 4.3.1
a "Network Class Binding". This covers MAC address and maximal frame
size properties. "local-mac-address" and "mac-address" with a fixed
"address-size" of 48 bits are already in the ethernet-controller.yaml
schema so move those over.

Keep "address-size" fixed to 48 bits as it's unclear if network protocols
using 64-bit mac addresses like ZigBee, 6LoWPAN and others are relevant for
this binding. This allows mac address array size validation for ethernet
and wireless lan devices.

"max-frame-size" in the Devicetree Specification is written to cover the
whole layer 2 ethernet frame but actual use for this property is the
payload size. Keep the description from ethernet-controller.yaml which
specifies the property as MTU.

Signed-off-by: Janne Grunau <j@jannau.net>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
Changes in v5:
- Incorrect DCO chain, missing SoB. (Krzysztof)
- Improved address-bits description. (Krzysztof)
- Link to v4: https://lore.kernel.org/r/20250319-dt-bindings-network-class-v4-0-2329336802b4@ixit.cz

Changes in v4:
- Changed the mailing list address (Rob)
- Copyied the whole description for the max-frame-size, including the
  MTU x max-frame-size contradiction. (Rob)
- Link to v3: https://lore.kernel.org/r/20250318-dt-bindings-network-class-v3-0-4d8d04ddfb61@ixit.cz

Changes in v3:
- Incorporated wireless-controller.yaml suggestion (Andrew)
- Link to v2: https://lore.kernel.org/r/20230203-dt-bindings-network-class-v2-0-499686795073@jannau.net

Changes in v2:
- Added "max-frame-size" with the description from ethernet-controller.yaml
- Restrict "address-size" to 48-bits
- Fix the mac-address array size to 6 bytes
- Drop duplicate default value from "max-frame-size" description
- Link to v1: https://lore.kernel.org/r/20230203-dt-bindings-network-class-v1-0-452e0375200d@jannau.net

---
David Heidelberg (2):
      dt-bindings: net: Add generic wireless controller
      dt-bindings: wireless: qcom,wcnss: Use wireless-controller.yaml

Janne Grunau (3):
      dt-bindings: net: Add network-class schema for mac-address properties
      dt-bindings: wireless: bcm4329-fmac: Use wireless-controller.yaml schema
      dt-bindings: wireless: silabs,wfx: Use wireless-controller.yaml

 .../bindings/net/ethernet-controller.yaml          | 25 +-----------
 .../devicetree/bindings/net/network-class.yaml     | 46 ++++++++++++++++++++++
 .../bindings/net/wireless/brcm,bcm4329-fmac.yaml   |  2 +-
 .../bindings/net/wireless/silabs,wfx.yaml          |  5 +--
 .../bindings/net/wireless/wireless-controller.yaml | 23 +++++++++++
 .../devicetree/bindings/soc/qcom/qcom,wcnss.yaml   |  5 ++-
 6 files changed, 76 insertions(+), 30 deletions(-)
---
base-commit: 882a18c2c14fc79adb30fe57a9758283aa20efaa
change-id: 20230203-dt-bindings-network-class-8367edd679d2

Best regards,
-- 
David Heidelberg <david@ixit.cz>

[PATCH v5 1/5] dt-bindings: net: Add network-class schema for mac-address properties

[David Heidelberg via B4 Relay]

From: Janne Grunau <j@jannau.net>

The ethernet-controller schema specifies "mac-address" and
"local-mac-address" but other network devices such as wireless network
adapters use mac addresses as well.
The Devicetree Specification, Release v0.3 specifies in section 4.3.1
a generic "Network Class Binding" with "address-bits", "mac-address",
"local-mac-address" and "max-frame-size". This schema specifies the
"address-bits" property and moves the remaining properties over from
the ethernet-controller.yaml schema.

The "max-frame-size" property is used to describe the maximal payload
size despite its name. Keep the description from ethernet-controller
specifying this property as MTU. The contradictory description in the
Devicetree Specification is ignored.

Signed-off-by: Janne Grunau <j@jannau.net>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 .../bindings/net/ethernet-controller.yaml          | 25 +-----------
 .../devicetree/bindings/net/network-class.yaml     | 46 ++++++++++++++++++++++
 2 files changed, 47 insertions(+), 24 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
index 45819b2358002bc75e876eddb4b2ca18017c04bd..c91b41b83d1dc1294e99ec72c7cdcc16550cb33e 100644
--- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml
+++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
@@ -16,30 +16,6 @@ properties:
   label:
     description: Human readable label on a port of a box.
 
-  local-mac-address:
-    description:
-      Specifies the MAC address that was assigned to the network device.
-    $ref: /schemas/types.yaml#/definitions/uint8-array
-    minItems: 6
-    maxItems: 6
-
-  mac-address:
-    description:
-      Specifies the MAC address that was last used by the boot
-      program; should be used in cases where the MAC address assigned
-      to the device by the boot program is different from the
-      local-mac-address property.
-    $ref: /schemas/types.yaml#/definitions/uint8-array
-    minItems: 6
-    maxItems: 6
-
-  max-frame-size:
-    $ref: /schemas/types.yaml#/definitions/uint32
-    description:
-      Maximum transfer unit (IEEE defined MTU), rather than the
-      maximum frame size (there\'s contradiction in the Devicetree
-      Specification).
-
   max-speed:
     $ref: /schemas/types.yaml#/definitions/uint32
     description:
@@ -262,6 +238,7 @@ dependencies:
   pcs-handle-names: [pcs-handle]
 
 allOf:
+  - $ref: /schemas/net/network-class.yaml#
   - if:
       properties:
         phy-mode:
diff --git a/Documentation/devicetree/bindings/net/network-class.yaml b/Documentation/devicetree/bindings/net/network-class.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..06461fb92eb8452cea685160b7a29ee9c0493f7e
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/network-class.yaml
@@ -0,0 +1,46 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/network-class.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Network Class Common Properties
+
+maintainers:
+  - Devicetree Specification Mailing List <devicetree-spec@vger.kernel.org>
+
+properties:
+  address-bits:
+    description:
+      Specifies number of address bits required to address the device
+      described by this node, e.g. size of the MAC address.
+    default: 48
+    const: 48
+
+  local-mac-address:
+    description:
+      Specifies MAC address that was assigned to the network device described by
+      the node containing this property.
+    $ref: /schemas/types.yaml#/definitions/uint8-array
+    minItems: 6
+    maxItems: 6
+
+  mac-address:
+    description:
+      Specifies the MAC address that was last used by the boot program. This
+      property should be used in cases where the MAC address assigned to the
+      device by the boot program is different from the
+      local-mac-address property. This property shall be used only if the value
+      differs from local-mac-address property value.
+    $ref: /schemas/types.yaml#/definitions/uint8-array
+    minItems: 6
+    maxItems: 6
+
+  max-frame-size:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Maximum transfer unit (IEEE defined MTU), rather than the
+      maximum frame size (there\'s contradiction in the Devicetree
+      Specification).
+
+additionalProperties: true

-- 
2.49.0

[PATCH v5 2/5] dt-bindings: net: Add generic wireless controller

[David Heidelberg via B4 Relay]

From: David Heidelberg <david@ixit.cz>

Wireless controllers share the common properties.

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 .../bindings/net/wireless/wireless-controller.yaml | 23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/wireless/wireless-controller.yaml b/Documentation/devicetree/bindings/net/wireless/wireless-controller.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..7379f6c1aa05c15a5bc7b34df6502cc174af9a90
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/wireless/wireless-controller.yaml
@@ -0,0 +1,23 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/wireless/wireless-controller.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Wireless Controller Common Properties
+
+maintainers:
+  - Lorenzo Bianconi <lorenzo@kernel.org>
+
+properties:
+  $nodename:
+    pattern: "^wifi(@.*)?$"
+
+allOf:
+  - $ref: ieee80211.yaml#
+  - $ref: /schemas/net/network-class.yaml#
+
+additionalProperties: true
+
+...
+

-- 
2.49.0

[PATCH v5 3/5] dt-bindings: wireless: bcm4329-fmac: Use wireless-controller.yaml schema

[David Heidelberg via B4 Relay]

From: Janne Grunau <j@jannau.net>

The wireless-controller schema specifies local-mac-address as
used in the bcm4329-fmac device nodes of Apple silicon devices
(arch/arm64/boot/dts/apple).

Fixes `make dtbs_check` for those devices.

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Janne Grunau <j@jannau.net>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
index a3607d55ef3671514cdf2c884cf5bd0ccaadb162..7c8100e59a6cd045837a2f602e367f3f79ced5ba 100644
--- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
@@ -16,7 +16,7 @@ description:
   binding.
 
 allOf:
-  - $ref: ieee80211.yaml#
+  - $ref: /schemas/net/wireless/wireless-controller.yaml#
 
 properties:
   compatible:

-- 
2.49.0

[PATCH v5 4/5] dt-bindings: wireless: silabs,wfx: Use wireless-controller.yaml

[David Heidelberg via B4 Relay]

From: Janne Grunau <j@jannau.net>

Instead listing local-mac-address and mac-address properties, reference
wireless-controller.yaml schema. The schema brings in constraints for the
property checked during `make dtbs_check`.

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Reviewed-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Signed-off-by: Janne Grunau <j@jannau.net>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 Documentation/devicetree/bindings/net/wireless/silabs,wfx.yaml | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/wireless/silabs,wfx.yaml b/Documentation/devicetree/bindings/net/wireless/silabs,wfx.yaml
index 84e5659e50ef3125b5063fbebcaf1d2b2bdb7398..6c0888ae4c4e172edf2a5f6249cb8aed5ed11681 100644
--- a/Documentation/devicetree/bindings/net/wireless/silabs,wfx.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/silabs,wfx.yaml
@@ -71,15 +71,12 @@ properties:
       "Platform Data Set" in Silabs jargon). Default depends of "compatible"
       string. For "silabs,wf200", the default is 'wf200.pds'.
 
-  local-mac-address: true
-
-  mac-address: true
-
 required:
   - compatible
   - reg
 
 allOf:
+  - $ref: /schemas/net/wireless/wireless-controller.yaml#
   - $ref: /schemas/spi/spi-peripheral-props.yaml#
 
 unevaluatedProperties: false

-- 
2.49.0

[PATCH v5 5/5] dt-bindings: wireless: qcom,wcnss: Use wireless-controller.yaml

[David Heidelberg via B4 Relay]

From: David Heidelberg <david@ixit.cz>

Reference wireless-controller.yaml schema, so we can use properties
as local-mac-address or mac-address.

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
index fd6db0ca98eb7e56d7399f55c408844d5e782805..4fcae6bedfffa845ad61c776ee0b70768e9a38a5 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
@@ -54,7 +54,7 @@ properties:
       - compatible
 
   wifi:
-    additionalProperties: false
+    unevaluatedProperties: false
     type: object
     properties:
       compatible:
@@ -88,6 +88,9 @@ properties:
       - qcom,smem-states
       - qcom,smem-state-names
 
+    allOf:
+      - $ref: /schemas/net/wireless/wireless-controller.yaml#
+
 required:
   - compatible
   - qcom,mmio

-- 
2.49.0

Re: [PATCH v5 1/5] dt-bindings: net: Add network-class schema for mac-address properties

[Rob Herring]

On Mon, Mar 24, 2025 at 12:41 PM David Heidelberg via B4 Relay
<devnull+david.ixit.cz@kernel.org> wrote:
>
> From: Janne Grunau <j@jannau.net>
>
> The ethernet-controller schema specifies "mac-address" and
> "local-mac-address" but other network devices such as wireless network
> adapters use mac addresses as well.
> The Devicetree Specification, Release v0.3 specifies in section 4.3.1
> a generic "Network Class Binding" with "address-bits", "mac-address",
> "local-mac-address" and "max-frame-size". This schema specifies the
> "address-bits" property and moves the remaining properties over from
> the ethernet-controller.yaml schema.
>
> The "max-frame-size" property is used to describe the maximal payload
> size despite its name. Keep the description from ethernet-controller
> specifying this property as MTU. The contradictory description in the
> Devicetree Specification is ignored.
>
> Signed-off-by: Janne Grunau <j@jannau.net>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  .../bindings/net/ethernet-controller.yaml          | 25 +-----------
>  .../devicetree/bindings/net/network-class.yaml     | 46 ++++++++++++++++++++++
>  2 files changed, 47 insertions(+), 24 deletions(-)

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH v5 0/5] dt-bindings: net: Add network-class.yaml schema

[Johannes Berg]

On Mon, 2025-03-24 at 18:41 +0100, David Heidelberg via B4 Relay wrote:
> The Devicetree Specification, Release v0.3 specifies in section 4.3.1
> a "Network Class Binding". This covers MAC address and maximal frame
> size properties. "local-mac-address" and "mac-address" with a fixed
> "address-size" of 48 bits are already in the ethernet-controller.yaml
> schema so move those over.
> 
> Keep "address-size" fixed to 48 bits as it's unclear if network protocols
> using 64-bit mac addresses like ZigBee, 6LoWPAN and others are relevant for
> this binding. This allows mac address array size validation for ethernet
> and wireless lan devices.
> 
> "max-frame-size" in the Devicetree Specification is written to cover the
> whole layer 2 ethernet frame but actual use for this property is the
> payload size. Keep the description from ethernet-controller.yaml which
> specifies the property as MTU.
> 

I have no idea what tree this should go through, and you CC'ed enough
people that I can't figure it out either ... I'll assume not wifi but DT
for now?

johannes

Re: [PATCH v5 0/5] dt-bindings: net: Add network-class.yaml schema

[Rob Herring]

On Tue, Mar 25, 2025 at 5:33 AM Johannes Berg <johannes@sipsolutions.net> wrote:
>
> On Mon, 2025-03-24 at 18:41 +0100, David Heidelberg via B4 Relay wrote:
> > The Devicetree Specification, Release v0.3 specifies in section 4.3.1
> > a "Network Class Binding". This covers MAC address and maximal frame
> > size properties. "local-mac-address" and "mac-address" with a fixed
> > "address-size" of 48 bits are already in the ethernet-controller.yaml
> > schema so move those over.
> >
> > Keep "address-size" fixed to 48 bits as it's unclear if network protocols
> > using 64-bit mac addresses like ZigBee, 6LoWPAN and others are relevant for
> > this binding. This allows mac address array size validation for ethernet
> > and wireless lan devices.
> >
> > "max-frame-size" in the Devicetree Specification is written to cover the
> > whole layer 2 ethernet frame but actual use for this property is the
> > payload size. Keep the description from ethernet-controller.yaml which
> > specifies the property as MTU.
> >
>
> I have no idea what tree this should go through, and you CC'ed enough
> people that I can't figure it out either ... I'll assume not wifi but DT
> for now?

Can you take it via wifi as the main target here is wifi bindings.

Rob

Re: [PATCH v5 0/5] dt-bindings: net: Add network-class.yaml schema

[Johannes Berg]

On Tue, 2025-03-25 at 08:02 -0500, Rob Herring wrote:
> > 
> > I have no idea what tree this should go through, and you CC'ed enough
> > people that I can't figure it out either ... I'll assume not wifi but DT
> > for now?
> 
> Can you take it via wifi as the main target here is wifi bindings.

I can do that, but I suppose it's 6.16 material at this point.

johannes

Re: [PATCH v5 0/5] dt-bindings: net: Add network-class.yaml schema

[David Heidelberg]

> I can do that, but I suppose it's 6.16 material at this point.

Hi Johannes. 

I assume you meant 6.15? 
This patchset should mainly clarify where these properties can be used and address incorrect warnings regarding device-tree verification. 

David

> johannes

Re: [PATCH v5 0/5] dt-bindings: net: Add network-class.yaml schema

[Johannes Berg]

On Wed, 2025-03-26 at 23:08 +0000, David Heidelberg wrote:
> > I can do that, but I suppose it's 6.16 material at this point.
> 
> Hi Johannes. 
> 
> I assume you meant 6.15? 

No. 6.15 merge window just opened.

> This patchset should mainly clarify where these properties can be used and address incorrect warnings regarding device-tree verification. 

I'm not really convinced that makes it a bugfix for the rc series
though?

johannes

Re: [PATCH v5 0/5] dt-bindings: net: Add network-class.yaml schema

[David Heidelberg]

Hi Johannes,

from the functionality standpoint this bindings do not change anything.

From validation point, if the `make dtbs_check` will pass as expected, it should yield only better results for integrators and developers. 

Thou if you want to postpone it for 6.16, I'll understand.

Thank you
David

On Wed, 2025-03-26 at 23:08 +0000, David Heidelberg wrote:
> > I can do that, but I suppose it's 6.16 material at this point.
> 
> Hi Johannes. 
> 
> I assume you meant 6.15? 

No. 6.15 merge window just opened.

> This patchset should mainly clarify where these properties can be used and address incorrect warnings regarding device-tree verification. 

I'm not really convinced that makes it a bugfix for the rc series
though?

johannes

Re: [PATCH v5 3/5] dt-bindings: wireless: bcm4329-fmac: Use wireless-controller.yaml schema

[Krzysztof Kozlowski]

On 24/03/2025 18:41, David Heidelberg via B4 Relay wrote:
> From: Janne Grunau <j@jannau.net>
> 
> The wireless-controller schema specifies local-mac-address as
> used in the bcm4329-fmac device nodes of Apple silicon devices
> (arch/arm64/boot/dts/apple).
> 
> Fixes `make dtbs_check` for those devices.
> 
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> Signed-off-by: Janne Grunau <j@jannau.net>
> Signed-off-by: David Heidelberg <david@ixit.cz>

This introduced several new dtbs_check warnings. Including on platforms
which were warnings free. It is nice to fix these warnings when you make
such changes.


Best regards,
Krzysztof

Re: [PATCH v5 3/5] dt-bindings: wireless: bcm4329-fmac: Use wireless-controller.yaml schema

[Krzysztof Kozlowski]

On 24/04/2025 10:20, Krzysztof Kozlowski wrote:
> On 24/03/2025 18:41, David Heidelberg via B4 Relay wrote:
>> From: Janne Grunau <j@jannau.net>
>>
>> The wireless-controller schema specifies local-mac-address as
>> used in the bcm4329-fmac device nodes of Apple silicon devices
>> (arch/arm64/boot/dts/apple).
>>
>> Fixes `make dtbs_check` for those devices.
>>
>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>> Signed-off-by: Janne Grunau <j@jannau.net>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
> 
> This introduced several new dtbs_check warnings. Including on platforms
> which were warnings free. It is nice to fix these warnings when you make
> such changes.


I will send the patches for them, except for Apple SoCs.

Best regards,
Krzysztof

Re: [PATCH v5 3/5] dt-bindings: wireless: bcm4329-fmac: Use wireless-controller.yaml schema

[Johannes Berg]

On Thu, 2025-04-24 at 10:28 +0200, Krzysztof Kozlowski wrote:
> On 24/04/2025 10:20, Krzysztof Kozlowski wrote:
> > On 24/03/2025 18:41, David Heidelberg via B4 Relay wrote:
> > > From: Janne Grunau <j@jannau.net>
> > > 
> > > The wireless-controller schema specifies local-mac-address as
> > > used in the bcm4329-fmac device nodes of Apple silicon devices
> > > (arch/arm64/boot/dts/apple).
> > > 
> > > Fixes `make dtbs_check` for those devices.
> > > 
> > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> > > Signed-off-by: Janne Grunau <j@jannau.net>
> > > Signed-off-by: David Heidelberg <david@ixit.cz>
> > 
> > This introduced several new dtbs_check warnings. Including on platforms
> > which were warnings free. It is nice to fix these warnings when you make
> > such changes.

Heh, especially since it said it should _fix_ things there.

> I will send the patches for them, except for Apple SoCs.

Thanks, I guess I'll hold the pull request for that. And I guess the
Apple ones are on David then.

Knew it was a mistake for me to ever do anything with DT stuff ;-)

johannes

Re: [PATCH v5 3/5] dt-bindings: wireless: bcm4329-fmac: Use wireless-controller.yaml schema

[Krzysztof Kozlowski]

On 24/04/2025 14:09, Johannes Berg wrote:
> On Thu, 2025-04-24 at 10:28 +0200, Krzysztof Kozlowski wrote:
>> On 24/04/2025 10:20, Krzysztof Kozlowski wrote:
>>> On 24/03/2025 18:41, David Heidelberg via B4 Relay wrote:
>>>> From: Janne Grunau <j@jannau.net>
>>>>
>>>> The wireless-controller schema specifies local-mac-address as
>>>> used in the bcm4329-fmac device nodes of Apple silicon devices
>>>> (arch/arm64/boot/dts/apple).
>>>>
>>>> Fixes `make dtbs_check` for those devices.
>>>>
>>>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>>>> Signed-off-by: Janne Grunau <j@jannau.net>
>>>> Signed-off-by: David Heidelberg <david@ixit.cz>
>>>
>>> This introduced several new dtbs_check warnings. Including on platforms
>>> which were warnings free. It is nice to fix these warnings when you make
>>> such changes.
> 
> Heh, especially since it said it should _fix_ things there.
> 
>> I will send the patches for them, except for Apple SoCs.
> 
> Thanks, I guess I'll hold the pull request for that. And I guess the
> Apple ones are on David then.
I think you can go ahead. I already referenced that commit from next in
my patches, so I hope that SHA will not change (don't rebase your tree):

https://lore.kernel.org/linux-devicetree/?q=f%3Akrzysztof+%22Align+wifi+node+name+with+bindings%22

Best regards,
Krzysztof

Re: [PATCH v5 3/5] dt-bindings: wireless: bcm4329-fmac: Use wireless-controller.yaml schema

[Johannes Berg]

On Thu, 2025-04-24 at 17:37 +0200, Krzysztof Kozlowski wrote:
> > 
> > Thanks, I guess I'll hold the pull request for that. And I guess the
> > Apple ones are on David then.
> I think you can go ahead. I already referenced that commit from next in
> my patches, so I hope that SHA will not change (don't rebase your tree):
> 
> https://lore.kernel.org/linux-devicetree/?q=f%3Akrzysztof+%22Align+wifi+node+name+with+bindings%22
> 

Hm. I thought this patchset broke it, and it is going through my tree.
Wouldn't it be much more complex for fixes on top of it to go through
another tree?

johannes

Re: [PATCH v5 3/5] dt-bindings: wireless: bcm4329-fmac: Use wireless-controller.yaml schema

[Rob Herring]

On Thu, Apr 24, 2025 at 10:42 AM Johannes Berg
<johannes@sipsolutions.net> wrote:
>
> On Thu, 2025-04-24 at 17:37 +0200, Krzysztof Kozlowski wrote:
> > >
> > > Thanks, I guess I'll hold the pull request for that. And I guess the
> > > Apple ones are on David then.
> > I think you can go ahead. I already referenced that commit from next in
> > my patches, so I hope that SHA will not change (don't rebase your tree):
> >
> > https://lore.kernel.org/linux-devicetree/?q=f%3Akrzysztof+%22Align+wifi+node+name+with+bindings%22
> >
>
> Hm. I thought this patchset broke it, and it is going through my tree.
> Wouldn't it be much more complex for fixes on top of it to go through
> another tree?

While it seems the reviews of the series caused more warnings for
Apple, in general, schemas creating warnings is not breaking things.
In a way, the whole point is to create warnings because if the .dts
files were perfect already we wouldn't need schemas. The main
requirement for schemas is only that they don't create warnings for
the examples. There's still too many for .dts files to worry about it
(and there's intermittent warnings from things getting merged via
different trees).

Rob

Re: [PATCH v5 3/5] dt-bindings: wireless: bcm4329-fmac: Use wireless-controller.yaml schema

[Johannes Berg]

On Thu, 2025-04-24 at 13:26 -0500, Rob Herring wrote:
> While it seems the reviews of the series caused more warnings for
> Apple, in general, schemas creating warnings is not breaking things.
> In a way, the whole point is to create warnings because if the .dts
> files were perfect already we wouldn't need schemas. The main
> requirement for schemas is only that they don't create warnings for
> the examples. There's still too many for .dts files to worry about it
> (and there's intermittent warnings from things getting merged via
> different trees).
> 

Oh, sure, but now if you want to apply the fixes you probably have to
wait for the broken patches in my tree to percolate all the way through
to Linus, then back to your tree, and then you can apply the fixes?

Seemed it'd be easier to send the fixes to me but it's all your call,
just let me know what you prefer.

johannes

Re: [PATCH v5 3/5] dt-bindings: wireless: bcm4329-fmac: Use wireless-controller.yaml schema

[Rob Herring]

On Thu, Apr 24, 2025 at 1:39 PM Johannes Berg <johannes@sipsolutions.net> wrote:
>
> On Thu, 2025-04-24 at 13:26 -0500, Rob Herring wrote:
> > While it seems the reviews of the series caused more warnings for
> > Apple, in general, schemas creating warnings is not breaking things.
> > In a way, the whole point is to create warnings because if the .dts
> > files were perfect already we wouldn't need schemas. The main
> > requirement for schemas is only that they don't create warnings for
> > the examples. There's still too many for .dts files to worry about it
> > (and there's intermittent warnings from things getting merged via
> > different trees).
> >
>
> Oh, sure, but now if you want to apply the fixes you probably have to
> wait for the broken patches in my tree to percolate all the way through
> to Linus, then back to your tree, and then you can apply the fixes?

No, I never take .dts changes. They all go via the individual platform
trees. It's a bit weird if Krzysztof refers to the commit that's not
in the linear history, but that shouldn't hold things up. The issues
exist with or without the schema change. They might even be backported
to stable while the schema change won't be.

Rob

Re: [PATCH v5 3/5] dt-bindings: wireless: bcm4329-fmac: Use wireless-controller.yaml schema

[Johannes Berg]

On Thu, 2025-04-24 at 14:04 -0500, Rob Herring wrote:
> On Thu, Apr 24, 2025 at 1:39 PM Johannes Berg <johannes@sipsolutions.net> wrote:
> > 
> > On Thu, 2025-04-24 at 13:26 -0500, Rob Herring wrote:
> > > While it seems the reviews of the series caused more warnings for
> > > Apple, in general, schemas creating warnings is not breaking things.
> > > In a way, the whole point is to create warnings because if the .dts
> > > files were perfect already we wouldn't need schemas. The main
> > > requirement for schemas is only that they don't create warnings for
> > > the examples. There's still too many for .dts files to worry about it
> > > (and there's intermittent warnings from things getting merged via
> > > different trees).
> > > 
> > 
> > Oh, sure, but now if you want to apply the fixes you probably have to
> > wait for the broken patches in my tree to percolate all the way through
> > to Linus, then back to your tree, and then you can apply the fixes?
> 
> No, I never take .dts changes. They all go via the individual platform
> trees. It's a bit weird if Krzysztof refers to the commit that's not
> in the linear history, but that shouldn't hold things up. The issues
> exist with or without the schema change. They might even be backported
> to stable while the schema change won't be.

Ah. OK, so never mind then. I'll assume whatever Krzysztof did will go
through some other tree and just go on with things :)

Thanks for the explanations!

johannes