From: Boris Brezillon <boris.brezillon@collabora.com>
To: Marek Vasut <marex@denx.de>
Cc: linux-arm-kernel@lists.infradead.org,
Conor Dooley <conor+dt@kernel.org>,
David Airlie <airlied@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Liviu Dudau <liviu.dudau@arm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Sebastian Reichel <sre@kernel.org>,
Shawn Guo <shawnguo@kernel.org>, Simona Vetter <simona@ffwll.ch>,
Steven Price <steven.price@arm.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
imx@lists.linux.dev
Subject: Re: [PATCH v2 4/9] drm/panthor: Implement optional reset
Date: Tue, 25 Mar 2025 08:43:49 +0100 [thread overview]
Message-ID: <20250325084349.344a0f11@collabora.com> (raw)
In-Reply-To: <c1de2afb-3559-4fbb-b13b-2373175b420b@denx.de>
On Tue, 25 Mar 2025 00:37:59 +0100
Marek Vasut <marex@denx.de> wrote:
> On 3/24/25 9:43 AM, Boris Brezillon wrote:
>
> [...]
>
> >> @@ -563,6 +585,7 @@ int panthor_device_suspend(struct device *dev)
> >>
> >> panthor_devfreq_suspend(ptdev);
> >>
> >> + reset_control_assert(ptdev->resets);
> >
> > Hm, that might be the cause of the fast reset issue (which is a fast
> > resume more than a fast reset BTW): if you re-assert the reset line on
> > runtime suspend, I guess this causes a full GPU reset, and the MCU ends
> > up in a state where it needs a slow reset (all data sections reset to
> > their initial state). Can you try to move the reset_control_[de]assert
> > to the unplug/init functions?
> Is it correct to assume , that if I remove all reset_control_assert()
> calls (and keep only the _deassert() calls), the slow resume problem
> should go away too ?
Yeah, dropping the _assert()s should do the trick.
next prev parent reply other threads:[~2025-03-25 7:43 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 20:05 [PATCH v2 0/9] arm64: dts: imx95: Add support for Mali G310 GPU Marek Vasut
2025-03-21 20:05 ` [PATCH v2 1/9] dt-bindings: reset: imx95-gpu-blk-ctrl: Document Freescale i.MX95 GPU reset Marek Vasut
2025-03-21 21:40 ` Rob Herring (Arm)
2025-03-21 20:05 ` [PATCH v2 2/9] reset: simple: Add support for " Marek Vasut
2025-03-21 20:05 ` [PATCH v2 3/9] dt-bindings: gpu: mali-valhall-csf: Document optional reset Marek Vasut
2025-04-03 12:53 ` Liviu Dudau
2025-03-21 20:05 ` [PATCH v2 4/9] drm/panthor: Implement " Marek Vasut
2025-03-24 8:43 ` Boris Brezillon
2025-03-24 19:05 ` Marek Vasut
2025-03-25 14:12 ` Philipp Zabel
2025-03-25 14:27 ` Marek Vasut
2025-03-25 15:00 ` Philipp Zabel
2025-03-24 23:37 ` Marek Vasut
2025-03-25 7:43 ` Boris Brezillon [this message]
2025-03-25 13:50 ` Marek Vasut
2025-03-25 14:35 ` Boris Brezillon
2025-03-25 14:37 ` Marek Vasut
2025-03-25 14:52 ` Boris Brezillon
2025-09-03 21:44 ` Marek Vasut
2025-09-04 6:22 ` Boris Brezillon
2025-09-04 6:36 ` Alexander Stein
2025-09-04 13:52 ` Marek Vasut
2025-09-04 14:39 ` Alexander Stein
2025-09-04 14:46 ` Marek Vasut
2025-09-04 13:49 ` Marek Vasut
2025-09-04 14:04 ` Boris Brezillon
2025-09-04 14:54 ` Marek Vasut
2025-09-04 15:20 ` Boris Brezillon
2025-09-04 15:29 ` Marek Vasut
2025-03-21 20:05 ` [PATCH v2 5/9] drm/panthor: Implement support for multiple power domains Marek Vasut
2025-03-26 15:07 ` Steven Price
2025-03-21 20:05 ` [PATCH v2 6/9] drm/panthor: Reset GPU after L2 cache power off Marek Vasut
2025-03-21 20:05 ` [PATCH v2 7/9] dt-bindings: gpu: mali-valhall-csf: Document i.MX95 support Marek Vasut
2025-03-24 16:31 ` Rob Herring (Arm)
2025-03-21 20:05 ` [PATCH v2 8/9] drm/panthor: Add " Marek Vasut
2025-03-21 20:05 ` [PATCH v2 9/9] arm64: dts: imx95: Describe Mali G310 GPU Marek Vasut
2025-03-24 7:02 ` Alexander Stein
2025-03-24 23:35 ` Marek Vasut
2025-03-25 7:00 ` Alexander Stein
2025-09-04 9:54 ` Peng Fan
2025-09-04 13:22 ` Marek Vasut
2025-09-09 0:52 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250325084349.344a0f11@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marex@denx.de \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=simona@ffwll.ch \
--cc=sre@kernel.org \
--cc=steven.price@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).