[PATCH RESEND] dt-bindings: trivial-devices: Document SPI measurement on LWE boards

[PATCH RESEND] dt-bindings: trivial-devices: Document SPI measurement on LWE boards

[Lukasz Majewski]

The measurement device on Liebherr's (LWE) boards is used to monitor
the overall state of the device. It does have SPI interface to
communicate with Linux host via spidev driver. Document the SPI DT
binding as trivial SPI device.

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index fadbd3c041c8..5d736a9792c2 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -161,6 +161,8 @@ properties:
           - jedec,spd5118
             # Linear Technology LTC2488
           - lineartechnology,ltc2488
+            # Liebherr on-board measurement SPI device
+          - lwe,btt
             # 5 Bit Programmable, Pulse-Width Modulator
           - maxim,ds1050
             # 10 kOhm digital potentiometer with I2C interface
-- 
2.39.5

Re: [PATCH RESEND] dt-bindings: trivial-devices: Document SPI measurement on LWE boards

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1424 bytes --]

On Wed, Mar 26, 2025 at 03:09:30PM +0100, Lukasz Majewski wrote:
> The measurement device on Liebherr's (LWE) boards is used to monitor
> the overall state of the device. It does have SPI interface to
> communicate with Linux host via spidev driver. Document the SPI DT
> binding as trivial SPI device.
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---

You should not do a resend with no explanation as to why. Additionally,
I would like to know why my review on the original patch was ignored:
https://lore.kernel.org/all/20250225-despair-rural-dc10216005f4@spud/#t

Cheers,
Conor.

>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index fadbd3c041c8..5d736a9792c2 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -161,6 +161,8 @@ properties:
>            - jedec,spd5118
>              # Linear Technology LTC2488
>            - lineartechnology,ltc2488
> +            # Liebherr on-board measurement SPI device
> +          - lwe,btt
>              # 5 Bit Programmable, Pulse-Width Modulator
>            - maxim,ds1050
>              # 10 kOhm digital potentiometer with I2C interface
> -- 
> 2.39.5
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[PATCH v2] dt-bindings: trivial-devices: Document SPI measurement on LWE boards

[Lukasz Majewski]

The measurement device on Liebherr's (LWE) boards is used to monitor
the overall state of the device. It does have SPI interface to
communicate with Linux host via spidev driver. Document the SPI DT
binding as trivial SPI device.

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
Changes for v2:
- Use already in-kernel available 'lwn' vendor prefix instead of introducing
  a new one
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 8da408107e55..1e37144e7017 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -161,6 +161,8 @@ properties:
           - jedec,spd5118
             # Linear Technology LTC2488
           - lineartechnology,ltc2488
+            # Liebherr on-board measurement SPI device
+          - lwn,btt
             # 5 Bit Programmable, Pulse-Width Modulator
           - maxim,ds1050
             # 10 kOhm digital potentiometer with I2C interface
-- 
2.39.5

Re: [PATCH v2] dt-bindings: trivial-devices: Document SPI measurement on LWE boards

[Fabio Estevam]

Hi  Lukasz,

On Wed, Mar 26, 2025 at 2:19 PM Lukasz Majewski <lukma@denx.de> wrote:
>
> The measurement device on Liebherr's (LWE) boards is used to monitor
> the overall state of the device. It does have SPI interface to
> communicate with Linux host via spidev driver. Document the SPI DT
> binding as trivial SPI device.

Can't you use lwn,bk4-spi instead?

Please check:
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/misc/lwn,bk4-spi.yaml?h=v6.14

Re: [PATCH v2] dt-bindings: trivial-devices: Document SPI measurement on LWE boards

[Lukasz Majewski]

[-- Attachment #1: Type: text/plain, Size: 887 bytes --]

Hi Fabio,

> Hi  Lukasz,
> 
> On Wed, Mar 26, 2025 at 2:19 PM Lukasz Majewski <lukma@denx.de> wrote:
> >
> > The measurement device on Liebherr's (LWE) boards is used to monitor
> > the overall state of the device. It does have SPI interface to
> > communicate with Linux host via spidev driver. Document the SPI DT
> > binding as trivial SPI device.  
> 
> Can't you use lwn,bk4-spi instead?

Conceptually, those are two different devices.

> 
> Please check:
> https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/misc/lwn,bk4-spi.yaml?h=v6.14




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH RESEND] dt-bindings: trivial-devices: Document SPI measurement on LWE boards

[Lukasz Majewski]

[-- Attachment #1: Type: text/plain, Size: 2359 bytes --]

Hi Conor,

> On Wed, Mar 26, 2025 at 03:09:30PM +0100, Lukasz Majewski wrote:
> > The measurement device on Liebherr's (LWE) boards is used to monitor
> > the overall state of the device. It does have SPI interface to
> > communicate with Linux host via spidev driver. Document the SPI DT
> > binding as trivial SPI device.
> > 
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > ---  
> 
> You should not do a resend with no explanation as to why.
> Additionally, I would like to know why my review on the original
> patch was ignored:
> https://lore.kernel.org/all/20250225-despair-rural-dc10216005f4@spud/#t
> 

I've made a mistake, as I've used the lwe prefix, which is the
different branch office for Liebherr.

As we discussed last time - it would be better to use the already
present 'lwn' vendor prefix as several other boards from this company
use it (display5, bk4, xea, btt3).

And this was apparent, after I've resent the patches. My mistake.

Regarding the comment - on xea, btt the binding would be used, as those
two boards (based on imx287) are using it.

Hence, single "trivial device" would be OK.

The v2 of this patch has the proper 'lwn,btt' binding.

> Cheers,
> Conor.
> 
> >  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml
> > b/Documentation/devicetree/bindings/trivial-devices.yaml index
> > fadbd3c041c8..5d736a9792c2 100644 ---
> > a/Documentation/devicetree/bindings/trivial-devices.yaml +++
> > b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -161,6
> > +161,8 @@ properties:
> >            - jedec,spd5118
> >              # Linear Technology LTC2488
> >            - lineartechnology,ltc2488
> > +            # Liebherr on-board measurement SPI device
> > +          - lwe,btt
> >              # 5 Bit Programmable, Pulse-Width Modulator
> >            - maxim,ds1050
> >              # 10 kOhm digital potentiometer with I2C interface
> > -- 
> > 2.39.5
> >   




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH RESEND] dt-bindings: trivial-devices: Document SPI measurement on LWE boards

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2666 bytes --]

On Wed, Mar 26, 2025 at 06:42:40PM +0100, Lukasz Majewski wrote:
> Hi Conor,
> 
> > On Wed, Mar 26, 2025 at 03:09:30PM +0100, Lukasz Majewski wrote:
> > > The measurement device on Liebherr's (LWE) boards is used to monitor
> > > the overall state of the device. It does have SPI interface to
> > > communicate with Linux host via spidev driver. Document the SPI DT
> > > binding as trivial SPI device.
> > > 
> > > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > > ---  
> > 
> > You should not do a resend with no explanation as to why.
> > Additionally, I would like to know why my review on the original
> > patch was ignored:
> > https://lore.kernel.org/all/20250225-despair-rural-dc10216005f4@spud/#t
> > 
> 
> I've made a mistake, as I've used the lwe prefix, which is the
> different branch office for Liebherr.
> 
> As we discussed last time - it would be better to use the already
> present 'lwn' vendor prefix as several other boards from this company
> use it (display5, bk4, xea, btt3).
> 
> And this was apparent, after I've resent the patches. My mistake.
> 
> Regarding the comment - on xea, btt the binding would be used, as those
> two boards (based on imx287) are using it.
> 
> Hence, single "trivial device" would be OK.
> 
> The v2 of this patch has the proper 'lwn,btt' binding.

I'm sorry, I don't understand how this excuses using the same binding
for different devices.

> 
> > Cheers,
> > Conor.
> > 
> > >  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml
> > > b/Documentation/devicetree/bindings/trivial-devices.yaml index
> > > fadbd3c041c8..5d736a9792c2 100644 ---
> > > a/Documentation/devicetree/bindings/trivial-devices.yaml +++
> > > b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -161,6
> > > +161,8 @@ properties:
> > >            - jedec,spd5118
> > >              # Linear Technology LTC2488
> > >            - lineartechnology,ltc2488
> > > +            # Liebherr on-board measurement SPI device
> > > +          - lwe,btt
> > >              # 5 Bit Programmable, Pulse-Width Modulator
> > >            - maxim,ds1050
> > >              # 10 kOhm digital potentiometer with I2C interface
> > > -- 
> > > 2.39.5
> > >   
> 
> 
> 
> 
> Best regards,
> 
> Lukasz Majewski
> 
> --
> 
> DENX Software Engineering GmbH,      Managing Director: Erika Unter
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2] dt-bindings: trivial-devices: Document SPI measurement on LWE boards

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]

On Wed, Mar 26, 2025 at 06:18:38PM +0100, Lukasz Majewski wrote:
> The measurement device on Liebherr's (LWE) boards is used to monitor
> the overall state of the device. It does have SPI interface to
> communicate with Linux host via spidev driver. Document the SPI DT
> binding as trivial SPI device.
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>

See comments on v1 and v1's resend. Should continue the conversation on
the latter, rather than splitting it here. Please also do not send
another version, where this is bundled with the spidev driver patch,
until that conversation has been resolved.

Cheers,
Conor.

> ---
> Changes for v2:
> - Use already in-kernel available 'lwn' vendor prefix instead of introducing
>   a new one
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 8da408107e55..1e37144e7017 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -161,6 +161,8 @@ properties:
>            - jedec,spd5118
>              # Linear Technology LTC2488
>            - lineartechnology,ltc2488
> +            # Liebherr on-board measurement SPI device
> +          - lwn,btt
>              # 5 Bit Programmable, Pulse-Width Modulator
>            - maxim,ds1050
>              # 10 kOhm digital potentiometer with I2C interface
> -- 
> 2.39.5
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH RESEND] dt-bindings: trivial-devices: Document SPI measurement on LWE boards

[Lukasz Majewski]

[-- Attachment #1: Type: text/plain, Size: 3696 bytes --]

Hi Conor,

> On Wed, Mar 26, 2025 at 06:42:40PM +0100, Lukasz Majewski wrote:
> > Hi Conor,
> >   
> > > On Wed, Mar 26, 2025 at 03:09:30PM +0100, Lukasz Majewski wrote:  
> > > > The measurement device on Liebherr's (LWE) boards is used to
> > > > monitor the overall state of the device. It does have SPI
> > > > interface to communicate with Linux host via spidev driver.
> > > > Document the SPI DT binding as trivial SPI device.
> > > > 
> > > > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > > > ---    
> > > 
> > > You should not do a resend with no explanation as to why.
> > > Additionally, I would like to know why my review on the original
> > > patch was ignored:
> > > https://lore.kernel.org/all/20250225-despair-rural-dc10216005f4@spud/#t
> > >   
> > 
> > I've made a mistake, as I've used the lwe prefix, which is the
> > different branch office for Liebherr.
> > 
> > As we discussed last time - it would be better to use the already
> > present 'lwn' vendor prefix as several other boards from this
> > company use it (display5, bk4, xea, btt3).
> > 
> > And this was apparent, after I've resent the patches. My mistake.
> > 
> > Regarding the comment - on xea, btt the binding would be used, as
> > those two boards (based on imx287) are using it.
> > 
> > Hence, single "trivial device" would be OK.
> > 
> > The v2 of this patch has the proper 'lwn,btt' binding.  
> 
> I'm sorry, I don't understand how this excuses using the same binding
> for different devices.

Ok, so maybe I will just explain how things are on those devices and we
can find some solution.

So we do have two devices - based on imx287: XEA (rev 1,2) and BTT (rev
0,1,2).

We do have a measurement device connected to SPI (on both above
devices). This device has a protocol, which is fully served in user
space (just the /dev/spidevX.Y is required for it).

Hence the 'lwn,btt' can be used for all those measurement devices.

As pointed out by Fabio, there is also 'lwn,bk4-spi' which is totally
different device, with different protocol used.


> 
> >   
> > > Cheers,
> > > Conor.
> > >   
> > > >  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > > 
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/trivial-devices.yaml
> > > > b/Documentation/devicetree/bindings/trivial-devices.yaml index
> > > > fadbd3c041c8..5d736a9792c2 100644 ---
> > > > a/Documentation/devicetree/bindings/trivial-devices.yaml +++
> > > > b/Documentation/devicetree/bindings/trivial-devices.yaml @@
> > > > -161,6 +161,8 @@ properties:
> > > >            - jedec,spd5118
> > > >              # Linear Technology LTC2488
> > > >            - lineartechnology,ltc2488
> > > > +            # Liebherr on-board measurement SPI device
> > > > +          - lwe,btt
> > > >              # 5 Bit Programmable, Pulse-Width Modulator
> > > >            - maxim,ds1050
> > > >              # 10 kOhm digital potentiometer with I2C interface
> > > > -- 
> > > > 2.39.5
> > > >     
> > 
> > 
> > 
> > 
> > Best regards,
> > 
> > Lukasz Majewski
> > 
> > --
> > 
> > DENX Software Engineering GmbH,      Managing Director: Erika Unter
> > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> > Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> > lukma@denx.de  
> 
> 




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH RESEND] dt-bindings: trivial-devices: Document SPI measurement on LWE boards

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2443 bytes --]

On Wed, Mar 26, 2025 at 10:27:02PM +0100, Lukasz Majewski wrote:
> Hi Conor,
> 
> > On Wed, Mar 26, 2025 at 06:42:40PM +0100, Lukasz Majewski wrote:
> > > Hi Conor,
> > >   
> > > > On Wed, Mar 26, 2025 at 03:09:30PM +0100, Lukasz Majewski wrote:  
> > > > > The measurement device on Liebherr's (LWE) boards is used to
> > > > > monitor the overall state of the device. It does have SPI
> > > > > interface to communicate with Linux host via spidev driver.
> > > > > Document the SPI DT binding as trivial SPI device.
> > > > > 
> > > > > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > > > > ---    
> > > > 
> > > > You should not do a resend with no explanation as to why.
> > > > Additionally, I would like to know why my review on the original
> > > > patch was ignored:
> > > > https://lore.kernel.org/all/20250225-despair-rural-dc10216005f4@spud/#t
> > > >   
> > > 
> > > I've made a mistake, as I've used the lwe prefix, which is the
> > > different branch office for Liebherr.
> > > 
> > > As we discussed last time - it would be better to use the already
> > > present 'lwn' vendor prefix as several other boards from this
> > > company use it (display5, bk4, xea, btt3).
> > > 
> > > And this was apparent, after I've resent the patches. My mistake.
> > > 
> > > Regarding the comment - on xea, btt the binding would be used, as
> > > those two boards (based on imx287) are using it.
> > > 
> > > Hence, single "trivial device" would be OK.
> > > 
> > > The v2 of this patch has the proper 'lwn,btt' binding.  
> > 
> > I'm sorry, I don't understand how this excuses using the same binding
> > for different devices.
> 
> Ok, so maybe I will just explain how things are on those devices and we
> can find some solution.
> 
> So we do have two devices - based on imx287: XEA (rev 1,2) and BTT (rev
> 0,1,2).
> 
> We do have a measurement device connected to SPI (on both above
> devices). This device has a protocol, which is fully served in user
> space (just the /dev/spidevX.Y is required for it).
> 
> Hence the 'lwn,btt' can be used for all those measurement devices.

You mentioned in the previous version of this that the devices used a
"similar approach", not the same approach. Now you're saying that it is
the same. Which is it?
If a kernel driver was handling this, rather than userspace via spidev,
would it have to differentiate between xea and btt devices?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]