From: Conor Dooley <conor@kernel.org>
To: Lukasz Majewski <lukma@denx.de>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
Noah Wang <noahwang.wang@outlook.com>,
Michal Simek <michal.simek@amd.com>,
Fabio Estevam <festevam@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] dt-bindings: trivial-devices: Document SPI measurement on LWE boards
Date: Wed, 26 Mar 2025 16:43:44 +0000 [thread overview]
Message-ID: <20250326-unluckily-consuming-948176031b08@spud> (raw)
In-Reply-To: <20250326140930.2587775-1-lukma@denx.de>
[-- Attachment #1: Type: text/plain, Size: 1424 bytes --]
On Wed, Mar 26, 2025 at 03:09:30PM +0100, Lukasz Majewski wrote:
> The measurement device on Liebherr's (LWE) boards is used to monitor
> the overall state of the device. It does have SPI interface to
> communicate with Linux host via spidev driver. Document the SPI DT
> binding as trivial SPI device.
>
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
You should not do a resend with no explanation as to why. Additionally,
I would like to know why my review on the original patch was ignored:
https://lore.kernel.org/all/20250225-despair-rural-dc10216005f4@spud/#t
Cheers,
Conor.
> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index fadbd3c041c8..5d736a9792c2 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -161,6 +161,8 @@ properties:
> - jedec,spd5118
> # Linear Technology LTC2488
> - lineartechnology,ltc2488
> + # Liebherr on-board measurement SPI device
> + - lwe,btt
> # 5 Bit Programmable, Pulse-Width Modulator
> - maxim,ds1050
> # 10 kOhm digital potentiometer with I2C interface
> --
> 2.39.5
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-03-26 16:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 14:09 [PATCH RESEND] dt-bindings: trivial-devices: Document SPI measurement on LWE boards Lukasz Majewski
2025-03-26 16:43 ` Conor Dooley [this message]
2025-03-26 17:42 ` Lukasz Majewski
2025-03-26 17:46 ` Conor Dooley
2025-03-26 21:27 ` Lukasz Majewski
2025-03-26 22:12 ` Conor Dooley
2025-03-26 17:18 ` [PATCH v2] " Lukasz Majewski
2025-03-26 17:30 ` Fabio Estevam
2025-03-26 17:38 ` Lukasz Majewski
2025-03-26 18:12 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250326-unluckily-consuming-948176031b08@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lukma@denx.de \
--cc=michal.simek@amd.com \
--cc=noahwang.wang@outlook.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox