From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E667D235C1E for ; Fri, 28 Mar 2025 13:31:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743168683; cv=none; b=fb/vrQOM3KKTUWRNn5Fh6yYQrgFdoG4S78ef2zPC+nS0dtnofOI/Df/QNQD0To1S49/ok8kgu6dHx4lCeCU6rMrmENMKi4nQLWM7K2aY7anW2cBu2CLSRKFJ5LVWSvMkF+UcV2icPZN1N2b9dZntIbOxmFWhJNQPQvg8FfI4IRo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743168683; c=relaxed/simple; bh=oM7nIChVy6AnX102peSIS6No2vZfRMNewLZjt/WfrE0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FG44hc8uNsd6Ly6clgZt7vIuZp+rLldkG6H8DCbHFWra7evUs5Iw1h0u700uBd9avvivBgNj/pDqxNGQhBkWEmTaTzKMyMkLOh8nKNLOxgiZvmfCFvZf5u3oQI5nPmbC5F5T2cQu/d3v5dE1hYFAtjig/PvA6dZG10BYNy+sAwI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=h/Dz7krH; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="h/Dz7krH" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5e6f4b3ebe5so4054711a12.0 for ; Fri, 28 Mar 2025 06:31:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743168670; x=1743773470; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=31t2yEGURbHN+dYzF9A6q02DZ3VBH6YOfFo8ts0pTFs=; b=h/Dz7krHtN0w9o/IOClhkmZijx7OtzSMyotcInOQrxRodXDX+Qz2ndUVAlGCBevzKK 3BZfFMMOvjVJff1X2bNSDFui2vy0AjqY7aa0D2/3GW10OT34B4Li+LcS9t8d29mzC6QL b5S0eRNeldL63/L+8Ui5WXARXi4KvIfr4Znlc5Uvp+JaP7t79hMWzsHvPKP2G4qn6O5/ DREiKF4FWVArUSTzB+K0wxm719HutQZU59Np6EpzhPlJfV8pjVD7XkwYseI+BzgxXpAp +xnygv8a/P6u6yb5WauppZ2MQJn7UC5KyMi9ci6hlMJz2+MK+sNyCWKu8BVvinEDQezk 0L2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743168670; x=1743773470; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=31t2yEGURbHN+dYzF9A6q02DZ3VBH6YOfFo8ts0pTFs=; b=BVYfPfdjWm+PHgLmvTy0QRKsPHp9yweX23jUuAPTIGsLPWlnROtbg15M5q3YiwZ01h h0hJb2uP2fTHC+x/9On0pTJuhJoT7fTfKISK4uSJVzqNsPVn5fmm8xVu4MzUR57xIaiM BNBGKVb2WX6KF+5FTGCfxWuB0PNt+CS3gM3ck5/g9L5izZsLodJHZwf+I23mUa9WqaVq qs9XrYRVFntlv6D9+g9PFq4yTFn6RWmU/1JRPtvU9lKFFRa/UBLWalLJa7BqGVTiuNuN D7ptP/hkS/xqb3WByOG4cm85fGbAtWgRcQptyLykABxuBGb0VBpWn+GZXURRyTF5Zh56 81HQ== X-Forwarded-Encrypted: i=1; AJvYcCW2xCfI1iTPq/dkAq2w4hooGs8vp2NpdQ9UHtLAQRvaf0wU+cGt6kT4821n8/wStMGJAUwNquekRmTu@vger.kernel.org X-Gm-Message-State: AOJu0YwDNEejPlck2cntrA/UjcpYOaeQXjri7bp/g8RKMJBRFC6KY++A Lac2sNH5A55YjctJXBSZCzah5kmziO9jy6djIgXwboBI/t5psHh9I4d0ER3yDac= X-Gm-Gg: ASbGncuhGwCvVgOibx6gh4/dFi47TK1OXVSKs5U6nrn/B5IQMGe3wnz1Dg62W64DeUQ +1QWnJxMIK9agCnM+cR2r5JWC8gfX1iosNMlpb60fAeBoNxda431sY69Od72rxuQ3SYGOSfmrbg 1yv+a8Hbh/ViPg/biKTrSHyUnTiWoMDT9OWXxNYSHLYCAnHNJ3Tu+qcQtX8TOk7UmwjxJ3lz0w7 2LQDOQX55ZmaePKkS6UN8fEBs1XADlHk6rOBzHbsv2r5dJi3xGaSujCEi9kQI9ONiqlao7T2ikJ gYnDGfVfN3ALjLL2/zq0SfxvFrkMyiyEtwSP4c/+VcPQtmzAnuur9KeWhdRDZTdChYDkjcx+vjR vXswZVtqhof6FWIUCjUqOUsOwM1EP X-Google-Smtp-Source: AGHT+IHYdNpE5Oaiy98m+ZWWJjpn0kB8pbikHk0ZcUltpSgeHSv0me+ylZHKLUVEOgvnZGzJh/notA== X-Received: by 2002:a05:6402:518d:b0:5e7:b02b:6430 with SMTP id 4fb4d7f45d1cf-5ed8f3fd122mr6775177a12.23.1743168670150; Fri, 28 Mar 2025 06:31:10 -0700 (PDT) Received: from puffmais.c.googlers.com (8.239.204.35.bc.googleusercontent.com. [35.204.239.8]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5edc17e01f7sm1355284a12.79.2025.03.28.06.31.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Mar 2025 06:31:09 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Mar 2025 13:29:16 +0000 Subject: [PATCH v2 30/32] rtc: s5m: replace regmap_update_bits with regmap_clear/set_bits Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20250328-s2mpg10-v2-30-b54dee33fb6b@linaro.org> References: <20250328-s2mpg10-v2-0-b54dee33fb6b@linaro.org> In-Reply-To: <20250328-s2mpg10-v2-0-b54dee33fb6b@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Rob Herring , Conor Dooley , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , Russell King , Catalin Marinas , Will Deacon , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The regmap_clear_bits() and regmap_set_bits() helper macros state the intention a bit more obviously. Use those. Signed-off-by: André Draszik --- drivers/rtc/rtc-s5m.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index e8e442c503064eb4e570af5bf7dcff6bfa7f4656..fb65a8e439d72d9070751c00f5826a403ac0b416 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -338,8 +338,8 @@ static int s5m8767_rtc_set_alarm_reg(struct s5m_rtc_info *info) /* On S2MPS13 the AUDR is not auto-cleared */ if (info->device_type == S2MPS13X) - regmap_update_bits(info->regmap, info->regs->udr_update, - S2MPS13_RTC_AUDR_MASK, 0); + regmap_clear_bits(info->regmap, info->regs->udr_update, + S2MPS13_RTC_AUDR_MASK); return ret; } @@ -351,10 +351,8 @@ static int s5m_rtc_read_time(struct device *dev, struct rtc_time *tm) int ret; if (info->regs->read_time_udr_mask) { - ret = regmap_update_bits(info->regmap, - info->regs->udr_update, - info->regs->read_time_udr_mask, - info->regs->read_time_udr_mask); + ret = regmap_set_bits(info->regmap, info->regs->udr_update, + info->regs->read_time_udr_mask); if (ret) { dev_err(dev, "Failed to prepare registers for time reading: %d\n", -- 2.49.0.472.ge94155a9ec-goog