From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2072.outbound.protection.outlook.com [40.107.236.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0803412B71; Fri, 28 Mar 2025 12:53:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.72 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743166432; cv=fail; b=on1sDmdF2euKVGpainX7QIRltK8pT3Zl3TbnPeTEfS/ur4ERgidm8yPRxRorzFnnpUTHJSKJsQRC4GfaVbGdOQ0v28e9q+iYNv7FnaOTFxcEjUwWSHIVVP/shy+NQsVK9Ltb/hkfvUl+Xu0b8Cf9qdUjYfSedQA+o6O0c/82Gps= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743166432; c=relaxed/simple; bh=lECJgvEx8o/zqRm0vQcxauU2S+7iU9bPggXja4naJlY=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=Bc6VjapODy7nbbV5QmQPVxcve1m06ARAeM8RCQvuLKYBFQ/S3bQdLSf+axK0+zvql9ia+27h9nm9Cd93h9f00+QyrbpLz60BfAA6mKLieabuvzDbsIQ9+Is7ch9E0hUMuIpBr2KG3XRdZU9BGfUBB333j4MQYlKPOHJ2RiT355w= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=TmioXojd; arc=fail smtp.client-ip=40.107.236.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="TmioXojd" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NehrQkrXrjxz4JSIwF4VM3InmZGAGs6osG/ZAWDg7ECDuPtndTWgeRbctdRAT2s8KIyyWzC9KnxwuG+XmPZv275k34RHSW8b/BBrWyUYLQQ/2bkZN540sCQA+c8+w5Pzv2c82WmhCTRHaFAkm61qqQdT9rIBxZ5dpiPwyHm2XyRrjbOC0j94nkvIPAWqNAx6jWOaE5io33vo5GUBRrQI19Y8Nr69BOVngP1cW9lzi1wfZsPKZFIwJuO2Mp04tKJSBuO2r41qoeVGh+qyKoKZK4PEfJkCnXoBPucCSG9E1xbHcZHasfpq3iX5TGWb38Uhmx0UPihcEhhaSfIiqtAENg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n63MBMO8ycvR7NnvzwMuiQGDIst8YBLAqb7bLqAnvdo=; b=YLjZQ4cPVrK16ChVtFKZEjEl61bZuWidSzy5WSsPmn71e6JfVfvJvY6j/pT+JMz3M1Ny2h5/CgDclNFaRZeol/t68C9rn1H8gzymHw3k4E16mvGr4GkIwwLuGAYanGKDNEsL8rv/Hg1vgmXRxfpTXkqCPtUyu/NvTsT3CnPIf0yQUT1z2ykm4EJMGSO3o+SFUNiXxeNf994oZp6iAFVYgYGpOzuqm5xpXLx7jhiKIgfD9L5S6r/uay/iS+RK0VjE7T4cbsgjhElsJA87KbVicKafai6HU/2Nbat/dvSbOoo6aDZzLqekck0N6U9mRPrANF5E9PHw6uACo4WM4za3Ew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n63MBMO8ycvR7NnvzwMuiQGDIst8YBLAqb7bLqAnvdo=; b=TmioXojdJ6QTAGEicpHBnx4d1fWWKGPB+kCoepZOAWDjm3fQOVVjH0HLL25JN9/0xN75W/HI5ODm8XJ0aQOQF1k4siOGNt83ZFlrik+uijwkCqz6BdTn09oevyfbeQHgIajoUCKmPxnbxta1/anGGpqGXAPmmjk2/+X3rhWEIEdvBeZa+5OVCyztOfWP+4j++wglYZYQf1H2w0zfWETPkI66QhX2CQb/9UUebKv2rYI7sC4nTq4Mg0gxkVdWC70F5QpwY02l9iA1LqfLYSRJ0ULNdXxrWqLPeRfSnxb4mcDb2hUsAV85BVMV2pukDixmUrkPAlUyS4N/60fRkbqRRw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH3PR12MB8659.namprd12.prod.outlook.com (2603:10b6:610:17c::13) by DM4PR12MB8572.namprd12.prod.outlook.com (2603:10b6:8:17d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.44; Fri, 28 Mar 2025 12:53:47 +0000 Received: from CH3PR12MB8659.namprd12.prod.outlook.com ([fe80::6eb6:7d37:7b4b:1732]) by CH3PR12MB8659.namprd12.prod.outlook.com ([fe80::6eb6:7d37:7b4b:1732%4]) with mapi id 15.20.8534.043; Fri, 28 Mar 2025 12:53:46 +0000 Date: Fri, 28 Mar 2025 09:53:45 -0300 From: Jason Gunthorpe To: Pratyush Yadav Cc: Changyuan Lyu , linux-kernel@vger.kernel.org, graf@amazon.com, akpm@linux-foundation.org, luto@kernel.org, anthony.yznaga@oracle.com, arnd@arndb.de, ashish.kalra@amd.com, benh@kernel.crashing.org, bp@alien8.de, catalin.marinas@arm.com, dave.hansen@linux.intel.com, dwmw2@infradead.org, ebiederm@xmission.com, mingo@redhat.com, jgowans@amazon.com, corbet@lwn.net, krzk@kernel.org, rppt@kernel.org, mark.rutland@arm.com, pbonzini@redhat.com, pasha.tatashin@soleen.com, hpa@zytor.com, peterz@infradead.org, robh+dt@kernel.org, robh@kernel.org, saravanak@google.com, skinsburskii@linux.microsoft.com, rostedt@goodmis.org, tglx@linutronix.de, thomas.lendacky@amd.com, usama.arif@bytedance.com, will@kernel.org, devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH v5 09/16] kexec: enable KHO support for memory preservation Message-ID: <20250328125345.GA10839@nvidia.com> References: <20250320015551.2157511-1-changyuanl@google.com> <20250320015551.2157511-10-changyuanl@google.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BN0PR08CA0009.namprd08.prod.outlook.com (2603:10b6:408:142::13) To CH3PR12MB8659.namprd12.prod.outlook.com (2603:10b6:610:17c::13) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB8659:EE_|DM4PR12MB8572:EE_ X-MS-Office365-Filtering-Correlation-Id: b6d0e49c-a993-4cbf-854f-08dd6df793fa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Kb2bA6A5Dw+MTnYJngrPqpXo5MF4f5K9b3tmhEBU/LA7a79lZPANR9KlCoIu?= =?us-ascii?Q?opWVNVA28bVH3iHl65YXaPnG2s81RSk7eKPckOr9cs+1LdBLkASsb49rSThy?= =?us-ascii?Q?V8uwjsWl5/yE+e0ZdF6TUQt+Or3+onQ8ir/ABsYBIW6brIawxAh2XL1YzFaJ?= =?us-ascii?Q?Yz/dnWcExq+oiQmXwvd9qpSykGCdGaNotO+tU5OPWqYEgukdfmM4re62pQra?= =?us-ascii?Q?R4A555Vjek/lLPt0QUB0xVK+ff6ixFHbp7L9BX503ZabRD0Y7ygS9UYJRwwG?= =?us-ascii?Q?AgmWjDEj89F3DhUUmwJ2DdFjsMRi8phV8QxhCuXNDilFNYoX2sRNCgIVKfKk?= =?us-ascii?Q?ieMy0A8l+FGGqcU528oULCqopHALMUvkX/d0m+Bv8KNiedFgWBRb9t+Jaotj?= =?us-ascii?Q?uop36HY+LJw3FRo8KmNCozr6qVS7EWelZJo6BdzQ3GDAk40pCSw7U8x9+oW0?= =?us-ascii?Q?OIyv9vN9XNnoPQmi9cft4E1tN6qVk/+DGl+P2rGgqJOkkgM6RLU/rxkxbs2M?= =?us-ascii?Q?suPrZzvflUuVrFeGFzICjSr3mLhljuZK9QgBXRdjbBXvkm/sR3+zBJW5dXXq?= =?us-ascii?Q?SwiPh5OYpw34PXr4Adbe0aLf1V9Cn8RbISAv5mojdGJ16Cv0BtTP0GWoZb0v?= =?us-ascii?Q?JHsTHqwgXZT1Vmnrlw4k/GICrKnf8uTS5YNKV7Bcdjx6OexQ4iTrpPU3RnFu?= =?us-ascii?Q?WuKYuOFZVy4jJ0ggV+yQsySyhmDB8W5TKHC9Pm3kZ5MKPr707kWIYZaiSeSn?= =?us-ascii?Q?ZuirPl0ljNINsRQuNR6dJPrTuswynMbXUC7cC2H3c217xBcrd0uI/5fzOYsC?= =?us-ascii?Q?tJgeB0V3D2wJ2fdVeecJLleAlGmtcKShMhThFCdHOAIEO/THuDTeQo3zzYcY?= =?us-ascii?Q?nWJpg2DTKc7EzB89oK7zE4+/ElUU8behZerluQnlnjn813qyNd5CqJsdG7lV?= =?us-ascii?Q?amvklm3Tk0y6pFP5fcUS37PM08EAYkFrMzmRTUmm1Dou7jOPzJxgN9a8760q?= =?us-ascii?Q?f+h48pJ423a5POpZOe/DaZNLESPXU0JaS2w0P8qq02IOyqhShsWKSgI1j7ar?= =?us-ascii?Q?y7zkqVrthS9Us+Lf5M/PzuCDdvoNiBIRNGBN/928b+4M2TA8DcOAnBHFfXc+?= =?us-ascii?Q?qTPPN9g8hbdVLvkLihAvvxEtT1BzIiZZbO7rhjDHgOznRFf46vzPin8kQ9h/?= =?us-ascii?Q?HZEolnoeGeBxg3fOigerVxZLEJDfutFtUItS17q3v+IGoADUkB+C1p2YmE1Z?= =?us-ascii?Q?A3IgQoWpcyFdaFr/ksQrimvmYZMDbLKdgPgsM9AAC9G/1O4urSYhpZmMpngD?= =?us-ascii?Q?GzJa9B9phk33t2oznFs3tS5SkGLGVf5kvXCeP43zxygGDoV+Wm0QB75Ksaem?= =?us-ascii?Q?VdsD5nh2bedvgCNIlb7D3H6euj2Q?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR12MB8659.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?v1Idz+p1dEQFiRwa2FG+EqKnkp6tmByMveMaGtDKbIGEtEEUv+kIjHUsrRTt?= =?us-ascii?Q?Db10P4iJzExr6LJpZ/1xUINCLV+7vHdeIDh9rMoyEXJ33GAoOfKr0QCUNtFq?= =?us-ascii?Q?xJMpv0ajYcOxxBHyHOo6L5KYENsUeMj0OiuO08vWy8m5YdjbwW2SmeDIWjwy?= =?us-ascii?Q?IWmMdiOASjBd6imvxlYxpYlF4ZHvbpLcs0lhkAMsPON0bJJ+mZqPyAWPHlco?= =?us-ascii?Q?ETtHwinFF6NF+382WkyJFxKnGnqWmV6MMiI8Z4jD061PGpTVdBLhg62NjjqT?= =?us-ascii?Q?FB7dvD0pB9Vj7PvUMhZOjNa4UTosagS7pjaiWj2Xef4qkamDUjSsdYiXhunu?= =?us-ascii?Q?4arqo8Wy/FMQBCiz+TgWpHVHN5voKV1x4rjiAxBPIOPCEDy9f5gQumVlkCEl?= =?us-ascii?Q?RwywtTrJnPPV2vFbEp1wk9fq74RUTvMYP7QkUvfITWnyY/O1qBAlsGZ+DEbv?= =?us-ascii?Q?melOUTG5A+2A1BbxBTtLk/WGh6n2na8viNMORJKI3I9+Jsr67+wZbMYy2L82?= =?us-ascii?Q?rAU9AUkIdeCWBe1qCpz7sZABniLarbR0MzKrsI5cG9iObS0Xrbh7+c77z0Oj?= =?us-ascii?Q?yWf71lQUeUdpenJDu1gC8rwY4Ss3IHzm3EmesggyDOVkACcZLjbCcqJWLbDU?= =?us-ascii?Q?cM/bgdMtmpEnDtKQ/yD1J/v2aLDrHMEwdsdkfz50CmHn0bLVZxDfyIh39E8J?= =?us-ascii?Q?B39LSGNTrI30AcAhOg4WWVfAig1AUtMWzhVAC8uNHba/TxalotChsRKAszpK?= =?us-ascii?Q?/rBTpDOE04HdWZ3bmOR//7QVaWH7j8w+spLG2b1WE0vAW/MOcbSoslQKvLs4?= =?us-ascii?Q?Tf3IJAKXDgR7IB1E5ZlRo7hjelhXycFiAq7C5SEbq9lW5Dhbbp2xnXK8I7eT?= =?us-ascii?Q?bmCsYVDZFjlIA41MQO1Ign9Gj/sG+iMXRtjr5IzxGf2dgaU0xNLVtzo1OIVM?= =?us-ascii?Q?LudBMrVYfSjjxjoLcRhAIxGV6ofPc53STCfJMQJqaYGNmerGKbM9P3uaZiIN?= =?us-ascii?Q?DivQy2q6l8qvKEjDl1f1KuWMEliCn16M1j8TIL/8EAFXz1K4QH6axSIzBVix?= =?us-ascii?Q?7rcmeHp6gIDOCi8v97BpDPRwnxREoZR58Ow+mMMBDkGj41U/9MW1d9I5cgyW?= =?us-ascii?Q?yPmWMfV1/CZL2YVq/fSphM4orhTLsL1Xw+LpabVt4+41S9Q28l9NdrnucrSG?= =?us-ascii?Q?K/LQGExPWhTpl68Uu7TJYH4l2sXEF7nxq3H0/mfONxwygzl8PPu0VoHuFWxg?= =?us-ascii?Q?KMgS0P5U6VODpmT9kwchlmhexBOwS4sdV96xFIakABUIWcPpsIWUd611DdpJ?= =?us-ascii?Q?erYxro/k5YhzdgO+rzcbih8iXJ4oKBVb0udCeKW2Ck1TqUBaxMLwsBU3hv7u?= =?us-ascii?Q?eb4TmFdoXSvtxE2S4cLAukbfJcs+4WpmpUMPU+MN8f5Qt/vCQAuhYVQNG7XC?= =?us-ascii?Q?L7MtbUAGcFDiXRYQpWwV8TwFbWjrKCfQrzE8IEdwi/Ohj54ir/0OY1TOJB3B?= =?us-ascii?Q?ypOCWJk3lTP/OpohPfQHCp94QfVPl9XQfUuqSQXFNT/5pE+gPtS2lqHqKLNp?= =?us-ascii?Q?tfCxNbqQOeMHLZWNl4HrbBDNwxD8o/g460TWLvkE?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6d0e49c-a993-4cbf-854f-08dd6df793fa X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8659.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2025 12:53:46.5784 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HcQbqeOc5Xme5p8rWKyecWNOUmSZpCbctRfO61FqSWwhZy9Zk629a8JW+2PB1bmi X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB8572 On Thu, Mar 27, 2025 at 05:28:40PM +0000, Pratyush Yadav wrote: > > Otherwise we are going to be spending months just polishing this one > > patch without any actual data on where the performance issues and hot > > spots actually are. > > The memblock_reserve side we can optimize later, I agree. But the memory > preservation format is ABI I think the agreement was that nothing is ABI at this point.. > and I think that is worth spending a little > more time on. And I don't think it should be that much more complex than > the current format. Maybe! Jason