* [PATCH v2] dt-bindings: gpio: pca95xx: add Toradex ecgpiol16
@ 2025-03-31 7:26 Francesco Dolcini
2025-03-31 15:49 ` Conor Dooley
2025-04-07 7:56 ` Bartosz Golaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Francesco Dolcini @ 2025-03-31 7:26 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: Emanuele Ghidoli, Krzysztof Kozlowski, linux-gpio, devicetree,
linux-kernel, Francesco Dolcini
From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
The Toradex ecgpiol16 is a 16-bit I2C I/O expander implemented using a
small MCU.
Its register interface and behavior are compatible with the PCAL6416.
Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
v2: compatible changed from embedded-controller-io16 to ecgpiol16
v1: https://lore.kernel.org/all/20250328122917.43273-1-francesco@dolcini.it/
---
Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
index 7b1eb08fa055..4d3f52f8d1b8 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
+++ b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
@@ -16,6 +16,9 @@ description: |+
properties:
compatible:
oneOf:
+ - items:
+ - const: toradex,ecgpiol16
+ - const: nxp,pcal6416
- items:
- const: diodes,pi4ioe5v6534q
- const: nxp,pcal6534
@@ -132,6 +135,7 @@ allOf:
- maxim,max7325
- maxim,max7326
- maxim,max7327
+ - toradex,ecgpiol16
then:
properties:
reset-gpios: false
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: gpio: pca95xx: add Toradex ecgpiol16
2025-03-31 7:26 [PATCH v2] dt-bindings: gpio: pca95xx: add Toradex ecgpiol16 Francesco Dolcini
@ 2025-03-31 15:49 ` Conor Dooley
2025-04-07 7:56 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2025-03-31 15:49 UTC (permalink / raw)
To: Francesco Dolcini
Cc: Linus Walleij, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Emanuele Ghidoli,
Krzysztof Kozlowski, linux-gpio, devicetree, linux-kernel,
Francesco Dolcini
[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]
On Mon, Mar 31, 2025 at 09:26:44AM +0200, Francesco Dolcini wrote:
> From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
>
> The Toradex ecgpiol16 is a 16-bit I2C I/O expander implemented using a
> small MCU.
> Its register interface and behavior are compatible with the PCAL6416.
>
> Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
> v2: compatible changed from embedded-controller-io16 to ecgpiol16
> v1: https://lore.kernel.org/all/20250328122917.43273-1-francesco@dolcini.it/
> ---
> Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
> index 7b1eb08fa055..4d3f52f8d1b8 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
> @@ -16,6 +16,9 @@ description: |+
> properties:
> compatible:
> oneOf:
> + - items:
> + - const: toradex,ecgpiol16
> + - const: nxp,pcal6416
> - items:
> - const: diodes,pi4ioe5v6534q
You could have made this into an enum, and added your new compatible
there. If there's a respin, can you do that please?
Acked-by: Conor Dooley <conor.dooley@microchip.com>
> - const: nxp,pcal6534
> @@ -132,6 +135,7 @@ allOf:
> - maxim,max7325
> - maxim,max7326
> - maxim,max7327
> + - toradex,ecgpiol16
> then:
> properties:
> reset-gpios: false
> --
> 2.39.5
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: gpio: pca95xx: add Toradex ecgpiol16
2025-03-31 7:26 [PATCH v2] dt-bindings: gpio: pca95xx: add Toradex ecgpiol16 Francesco Dolcini
2025-03-31 15:49 ` Conor Dooley
@ 2025-04-07 7:56 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2025-04-07 7:56 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Francesco Dolcini
Cc: Bartosz Golaszewski, Emanuele Ghidoli, Krzysztof Kozlowski,
linux-gpio, devicetree, linux-kernel, Francesco Dolcini
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
On Mon, 31 Mar 2025 09:26:44 +0200, Francesco Dolcini wrote:
> The Toradex ecgpiol16 is a 16-bit I2C I/O expander implemented using a
> small MCU.
> Its register interface and behavior are compatible with the PCAL6416.
>
>
Applied, thanks!
[1/1] dt-bindings: gpio: pca95xx: add Toradex ecgpiol16
commit: ac7d33f3899762b5d0c90a51a96ea11b6d7660ba
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-07 7:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-31 7:26 [PATCH v2] dt-bindings: gpio: pca95xx: add Toradex ecgpiol16 Francesco Dolcini
2025-03-31 15:49 ` Conor Dooley
2025-04-07 7:56 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).