Re: [PATCH 4/6] iio: adc: ti-adc128s052: Use devm_mutex_init()

[Jonathan Cameron <jic23@kernel.org>]

On Mon, 31 Mar 2025 11:03:30 +0300
Matti Vaittinen <mazziesaccount@gmail.com> wrote:

> Quoting Jonathan:
> "Whilst it doesn't bring huge advantage, now we have devm_mutex_init()
> it seems reasonable to use it and maybe catch a use after free for the
> lock"
> 
> Switch to use devm_mutex_init() while working on this file.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
> ---
>  drivers/iio/adc/ti-adc128s052.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ti-adc128s052.c b/drivers/iio/adc/ti-adc128s052.c
> index dd1e405bf172..90b23c68daea 100644
> --- a/drivers/iio/adc/ti-adc128s052.c
> +++ b/drivers/iio/adc/ti-adc128s052.c
> @@ -172,7 +172,7 @@ static int adc128_probe(struct spi_device *spi)
>  	if (ret)
>  		return ret;
>  
> -	mutex_init(&adc->lock);
> +	devm_mutex_init(&spi->dev, &adc->lock);
	ret = devm_mutex_init(&spi->dev, &adc->lock);
	if (ret)
		return ret;

>  
>  	return devm_iio_device_register(&spi->dev, indio_dev);
>  }