From: Lee Jones <lee@kernel.org>
To: Artur Weber <aweber.kernel@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Stanislav Jakubek <stano.jakubek@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v7 05/10] mfd: bcm590xx: Add support for multiple device types + BCM59054 compatible
Date: Fri, 4 Apr 2025 16:38:54 +0100 [thread overview]
Message-ID: <20250404153854.GG372032@google.com> (raw)
In-Reply-To: <20250316-bcm59054-v7-5-4281126be1b8@gmail.com>
On Sun, 16 Mar 2025, Artur Weber wrote:
> The BCM59054 is another chip from the BCM590xx line of PMUs, commonly
> used on devices with the BCM21664/BCM23550 chipsets.
>
> Prepare the BCM590xx driver for supporting other devices by adding the
> PMUID register values for supported chip types and store them in the
> MFD data struct as "pmu_id". (These will be checked against the actual
> PMUID register values in a later commit.)
>
> Then, add a DT compatible for the BCM59054, and provide the PMU ID as
> OF match data.
>
> Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
> ---
> Changes in v6:
> - Move PMUID value to MFD header
> - Use PMUID value as OF data/device type value
> - Add bcm59054 to I2C ID table
>
> Changes in v4:
> - Rewrite commit message description
> - Rename "device_type" member to "dev_type"
> - Drop awkward line break to fit function call
> - Add PMU ID/revision parsing function
>
> Changes in v3:
> - Fix compilation warning about device_type pointer cast type
> - Name the device types enum and use it as the type in the MFD struct
> ---
> drivers/mfd/bcm590xx.c | 12 +++++++++++-
> include/linux/mfd/bcm590xx.h | 7 +++++++
> 2 files changed, 18 insertions(+), 1 deletion(-)
Looks like the Regulator changes depend on this.
Let me know when they're ready to go.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2025-04-04 15:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-16 18:18 [PATCH v7 00/10] mfd: bcm590xx: Add support for BCM59054 Artur Weber
2025-03-16 18:18 ` [PATCH v7 01/10] dt-bindings: mfd: brcm,bcm59056: Convert to YAML Artur Weber
2025-03-16 18:18 ` [PATCH v7 02/10] dt-bindings: mfd: brcm,bcm59056: Add compatible for BCM59054 Artur Weber
2025-03-16 18:18 ` [PATCH v7 03/10] ARM: dts: Drop DTS for BCM59056 PMU Artur Weber
2025-03-16 18:18 ` [PATCH v7 04/10] mfd: bcm590xx: Drop unused "id" member of bcm590xx MFD struct Artur Weber
2025-04-04 15:37 ` (subset) " Lee Jones
2025-03-16 18:18 ` [PATCH v7 05/10] mfd: bcm590xx: Add support for multiple device types + BCM59054 compatible Artur Weber
2025-04-04 15:38 ` Lee Jones [this message]
2025-03-16 18:18 ` [PATCH v7 06/10] mfd: bcm590xx: Add PMU ID/revision parsing function Artur Weber
2025-04-01 12:50 ` Lee Jones
2025-03-16 18:18 ` [PATCH v7 07/10] regulator: bcm590xx: Use dev_err_probe for regulator register error Artur Weber
2025-03-16 18:18 ` [PATCH v7 08/10] regulator: bcm590xx: Store regulator descriptions in table Artur Weber
2025-03-16 18:18 ` [PATCH v7 09/10] regulator: bcm590xx: Rename BCM59056-specific data as such Artur Weber
2025-03-16 18:18 ` [PATCH v7 10/10] regulator: bcm590xx: Add support for BCM59054 regulators Artur Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250404153854.GG372032@google.com \
--to=lee@kernel.org \
--cc=aweber.kernel@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=stano.jakubek@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).