devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-mmc@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: mmc: arasan,sdhci: Add Renesas RZ/N1D
Date: Fri, 4 Apr 2025 11:05:47 -0500	[thread overview]
Message-ID: <20250404160547.GA1521768-robh@kernel.org> (raw)
In-Reply-To: <20250402093019.5639-2-wsa+renesas@sang-engineering.com>

On Wed, Apr 02, 2025 at 11:27:50AM +0200, Wolfram Sang wrote:
> This instance has a wakeup irq defined. It is currently not used by the
> driver.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> 
> Changes since v1:
> * dropped superfluous 'maxItems'
> * now checked also against 'dt_binding_check'
>   (Sorry, forgot this target in my scripts)
> 
>  .../devicetree/bindings/mmc/arasan,sdhci.yaml | 22 ++++++++++++++++++-
>  1 file changed, 21 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> index 9075add020bf..d4605bbc7a57 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> @@ -38,6 +38,15 @@ allOf:
>              - items:
>                  - const: clk_out_sd1
>                  - const: clk_in_sd1
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: renesas,rzn1-sdhci
> +    then:
> +      properties:
> +        interrupts:
> +          minItems: 2
>  
>  properties:
>    compatible:
> @@ -45,6 +54,10 @@ properties:
>        - const: arasan,sdhci-8.9a                # generic Arasan SDHCI 8.9a PHY
>        - const: arasan,sdhci-4.9a                # generic Arasan SDHCI 4.9a PHY
>        - const: arasan,sdhci-5.1                 # generic Arasan SDHCI 5.1 PHY
> +      - items:
> +          - const: renesas,r9a06g032-sdhci      # Renesas RZ/N1D SoC
> +          - const: renesas,rzn1-sdhci           # Renesas RZ/N1 family
> +          - const: arasan,sdhci-8.9a
>        - items:
>            - const: rockchip,rk3399-sdhci-5.1    # rk3399 eMMC PHY
>            - const: arasan,sdhci-5.1
> @@ -109,7 +122,14 @@ properties:
>        - const: gate
>  
>    interrupts:
> -    maxItems: 1
> +    minItems: 1
> +    maxItems: 2
> +
> +  interrupt-names:
> +    minItems: 1
> +    items:
> +      - const: int
> +      - const: wkup

The standardized name is 'wakeup'.

>  
>    phys:
>      maxItems: 1
> -- 
> 2.47.2
> 

  reply	other threads:[~2025-04-04 16:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-02  9:27 [PATCH v2] dt-bindings: mmc: arasan,sdhci: Add Renesas RZ/N1D Wolfram Sang
2025-04-04 16:05 ` Rob Herring [this message]
2025-04-05 17:30   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250404160547.GA1521768-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=krzk+dt@kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=ulf.hansson@linaro.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).