From: Andreas Kemnade <andreas@kemnade.info>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Sukrut Bellary <sbellary@baylibre.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Tero Kristo <kristo@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: clock: ti: Convert to yaml
Date: Sat, 5 Apr 2025 21:55:29 +0200 [thread overview]
Message-ID: <20250405215529.7f3f3253@akair> (raw)
In-Reply-To: <20250404-famous-rottweiler-of-perspective-e5dcbc@shite>
Am Fri, 4 Apr 2025 12:44:39 +0200
schrieb Krzysztof Kozlowski <krzk@kernel.org>:
> On Thu, Apr 03, 2025 at 06:44:57PM GMT, Sukrut Bellary wrote:
> > +properties:
> > + reg:
> > + maxItems: 1
>
> How reg is part of this? Every clock has reg, doesn't it? Otherwise how
> do you control it? Drop.
>
> > +
> > + ti,autoidle-shift:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + description:
> > + bit shift of the autoidle enable bit for the clock
> > + maximum: 31
> > + default: 0
> > +
> > + ti,invert-autoidle-bit:
> > + type: boolean
> > + description:
> > + autoidle is enabled by setting the bit to 0
>
> required:
> - ti,autoidle-shift
> - ti,invert-autoidle-bit - although this makes no sense, so probably
> old binding was not correct here
>
well, the more informal definition in the txt file can be read as: if
the clock supports autoidle, then ti,autoidle-shift is required. But
that does not
translate to the formal definition in the yaml file.
So we have nothing required here.
I am a bit wondering whether we should just drop the autoidle.txt. The
only thing worth there is the description.
Regards,
Andreas
next prev parent reply other threads:[~2025-04-05 19:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 1:44 [PATCH 0/4] dt-bindings: clock: ti: convert to yaml Sukrut Bellary
2025-04-04 1:44 ` [PATCH 1/4] dt-bindings: clock: ti: Convert " Sukrut Bellary
2025-04-04 10:44 ` Krzysztof Kozlowski
2025-04-05 19:55 ` Andreas Kemnade [this message]
2025-04-09 8:11 ` Sukrut Bellary
2025-04-09 7:46 ` Sukrut Bellary
2025-04-04 15:19 ` Rob Herring
2025-04-09 8:21 ` Sukrut Bellary
2025-04-04 1:44 ` [PATCH 2/4] " Sukrut Bellary
2025-04-04 5:51 ` kernel test robot
2025-04-04 10:46 ` Krzysztof Kozlowski
2025-04-09 8:23 ` Sukrut Bellary
2025-04-04 14:56 ` Rob Herring (Arm)
2025-04-09 8:35 ` Sukrut Bellary
2025-04-09 9:10 ` Andreas Kemnade
2025-04-10 17:49 ` Sukrut Bellary
2025-04-04 1:44 ` [PATCH 3/4] dt-bindings: clock: ti: Convert fixed-factor-clock " Sukrut Bellary
2025-04-04 19:40 ` Rob Herring
2025-04-09 8:38 ` Sukrut Bellary
2025-04-04 1:45 ` [PATCH 4/4] dt-bindings: clock: ti: add ti,autoidle.yaml reference Sukrut Bellary
2025-04-04 19:42 ` Rob Herring
2025-04-09 8:40 ` Sukrut Bellary
2025-04-05 19:49 ` Andreas Kemnade
2025-04-09 8:43 ` Sukrut Bellary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250405215529.7f3f3253@akair \
--to=andreas@kemnade.info \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sbellary@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).