From: Jonathan Cameron <jic23@kernel.org>
To: gyeyoung <gye976@gmail.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
lars@metafoo.de, gustavograzs@gmail.com,
javier.carrasco.cruz@gmail.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v1 4/5] iio: chemical: add support for winsen MHZ19B CO2 sensor
Date: Sun, 6 Apr 2025 12:21:51 +0100 [thread overview]
Message-ID: <20250406122151.1b2a6f8a@jic23-huawei> (raw)
In-Reply-To: <CAKbEznvnTzvv7GtdF0JNbsya0iW4fN3VFH9bEGNDrXWOfm3ELA@mail.gmail.com>
> > > +
> > > +static const struct iio_chan_spec mhz19b_channels[] = {
> > > + {
> > > + .type = IIO_CONCENTRATION,
> > > + .channel2 = IIO_MOD_CO2,
> > > + .modified = 1,
> > > + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
> >
> > I'm curious. We have a range control in your custom ABI, but no scale.
> > So what units is this in?
> >
> The unit is ppm. and as far as I understand, co2 input(processed) unit
> is percentage concentration.
> so In this device, the scale is a constant value (0.0001), regardless
> of the range.
> Is my understanding correct?
Yes.
next prev parent reply other threads:[~2025-04-06 11:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 5:32 [PATCH v1 0/5] add support for winsen MHZ19B CO2 sensor Gyeyoung Baek
2025-04-03 5:32 ` [PATCH v1 1/5] dt-bindings: add winsen to the vendor prefixes Gyeyoung Baek
2025-04-03 7:48 ` Krzysztof Kozlowski
2025-04-03 12:45 ` gyeyoung
2025-04-03 5:32 ` [PATCH v1 2/5] dt-bindings: add device tree support for winsen MHZ19B CO2 sensor Gyeyoung Baek
2025-04-03 7:48 ` Krzysztof Kozlowski
2025-04-03 5:32 ` [PATCH v1 3/5] ABI: iio: add new ABI doc for mhz19b Gyeyoung Baek
2025-04-03 7:51 ` Krzysztof Kozlowski
2025-04-03 14:09 ` gyeyoung
2025-04-04 11:33 ` Jonathan Cameron
2025-04-05 13:47 ` gyeyoung
2025-04-06 11:20 ` Jonathan Cameron
2025-04-06 11:26 ` Jonathan Cameron
2025-04-06 13:31 ` gyeyoung
2025-04-06 15:33 ` Jonathan Cameron
2025-04-07 2:10 ` gyeyoung
2025-04-07 18:52 ` Jonathan Cameron
2025-04-03 5:32 ` [PATCH v1 4/5] iio: chemical: add support for winsen MHZ19B CO2 sensor Gyeyoung Baek
2025-04-03 7:56 ` Krzysztof Kozlowski
2025-04-03 14:04 ` gyeyoung
2025-04-04 11:51 ` Jonathan Cameron
2025-04-05 14:45 ` gyeyoung
2025-04-06 11:21 ` Jonathan Cameron [this message]
2025-04-03 5:32 ` [PATCH v1 5/5] MAINTAINERS: Add WINSEN MHZ19B Gyeyoung Baek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250406122151.1b2a6f8a@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gustavograzs@gmail.com \
--cc=gye976@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).