From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5989C218AD2 for ; Mon, 7 Apr 2025 17:29:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744046945; cv=none; b=a+8ya3qgVLdGc5Aov0BfkwdH2A+s9sa0tzlzc8mjKRvkDJvc4YCbrmu+PrvdmTbP9tLXWD30IE8izu1zQu4iiRbo94AN1QHt5R42hUBUd8y60YEOWhNjHuAamZYjjq7kAG3yp6g/hI80ey2iGLlgvdaXH/lHNVmCgwIFDqk+oUQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744046945; c=relaxed/simple; bh=v1rM3bKaL5fazId1hGOHxWFqoP2Wtd1q2yFOeLRU448=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uJQSQy489zgdewEdIV/ChiBhnUdJ4zncSR8CSHR/Y2QF/dm6TC38586I22sUmmT2X4rZ7cxQP6aTJdt6utPFN9aKw5B6nS6SoWW4L858CgX2kz0tiO914p/EWvoK09kRE2/D97vLIgedEtQ77nqBKVyWmxziiZfTHwtfJ9h72Ck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ecl821oT; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ecl821oT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744046942; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=byI/z5EgcgD3KURSrPmsNqBUTi51FgnmC0aRsV45pBE=; b=Ecl821oTCH4EypZI0vsOFhzlSST021fIFTsTOhomGQu0ze87QMkCBf12Uw3MwcV+GU1lJM qxty8GBX1sT+rpy840iGBqRUJLOCpbQe8Ck2c6LAEDvmDHX7FB70OMefNkrGh57Ez4GQyD GD8nQEe5QGkeAVTqbtP7g0OjUQuQGIs= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-662-Eyyn3PRMMCWwXJxKennttQ-1; Mon, 07 Apr 2025 13:28:59 -0400 X-MC-Unique: Eyyn3PRMMCWwXJxKennttQ-1 X-Mimecast-MFC-AGG-ID: Eyyn3PRMMCWwXJxKennttQ_1744046937 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 68EE719560B0; Mon, 7 Apr 2025 17:28:56 +0000 (UTC) Received: from p16v.luc.cera.cz (unknown [10.44.32.4]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 891A2180B488; Mon, 7 Apr 2025 17:28:50 +0000 (UTC) From: Ivan Vecera To: netdev@vger.kernel.org Cc: Michal Schmidt , Vadim Fedorenko , Arkadiusz Kubalewski , Jiri Pirko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Prathosh Satish , Lee Jones , Kees Cook , Andy Shevchenko , Andrew Morton , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: [PATCH 02/28] mfd: zl3073x: Register itself as devlink device Date: Mon, 7 Apr 2025 19:28:29 +0200 Message-ID: <20250407172836.1009461-3-ivecera@redhat.com> In-Reply-To: <20250407172836.1009461-1-ivecera@redhat.com> References: <20250407172836.1009461-1-ivecera@redhat.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Use devlink_alloc() to alloc zl3073x_dev structure and register the device as a devlink device. Follow-up patches add support for devlink device info reporting and devlink flash interface will be later used for flashing firmware and configuration. Reviewed-by: Michal Schmidt Signed-off-by: Ivan Vecera --- drivers/mfd/Kconfig | 3 +++ drivers/mfd/zl3073x-core.c | 27 +++++++++++++++++++++++++-- 2 files changed, 28 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 30b36e3ee8f7f..a838d5dca4579 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -2424,11 +2424,13 @@ config MFD_UPBOARD_FPGA config MFD_ZL3073X_CORE tristate + select NET_DEVLINK select MFD_CORE config MFD_ZL3073X_I2C tristate "Microchip Azurite DPLL/PTP/SyncE with I2C" depends on I2C + depends on NET select MFD_ZL3073X_CORE select REGMAP_I2C help @@ -2441,6 +2443,7 @@ config MFD_ZL3073X_I2C config MFD_ZL3073X_SPI tristate "Microchip Azurite DPLL/PTP/SyncE with SPI" + depends on NET depends on SPI select MFD_ZL3073X_CORE select REGMAP_SPI diff --git a/drivers/mfd/zl3073x-core.c b/drivers/mfd/zl3073x-core.c index 67a9d5a0e2d8c..71454f683eab0 100644 --- a/drivers/mfd/zl3073x-core.c +++ b/drivers/mfd/zl3073x-core.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0-only #include +#include #include "zl3073x.h" /* @@ -44,24 +45,46 @@ const struct regmap_config *zl3073x_get_regmap_config(void) } EXPORT_SYMBOL_NS_GPL(zl3073x_get_regmap_config, "ZL3073X"); +static const struct devlink_ops zl3073x_devlink_ops = { +}; + +static void zl3073x_devlink_free(void *ptr) +{ + devlink_free(ptr); +} + struct zl3073x_dev *zl3073x_dev_alloc(struct device *dev) { - struct zl3073x_dev *zldev; + struct devlink *devlink; - return devm_kzalloc(dev, sizeof(*zldev), GFP_KERNEL); + devlink = devlink_alloc(&zl3073x_devlink_ops, + sizeof(struct zl3073x_dev), dev); + if (!devlink) + return NULL; + + if (devm_add_action_or_reset(dev, zl3073x_devlink_free, devlink)) + return NULL; + + return devlink_priv(devlink); } EXPORT_SYMBOL_NS_GPL(zl3073x_dev_alloc, "ZL3073X"); int zl3073x_dev_init(struct zl3073x_dev *zldev) { + struct devlink *devlink; + devm_mutex_init(zldev->dev, &zldev->lock); + devlink = priv_to_devlink(zldev); + devlink_register(devlink); + return 0; } EXPORT_SYMBOL_NS_GPL(zl3073x_dev_init, "ZL3073X"); void zl3073x_dev_exit(struct zl3073x_dev *zldev) { + devlink_unregister(priv_to_devlink(zldev)); } EXPORT_SYMBOL_NS_GPL(zl3073x_dev_exit, "ZL3073X"); -- 2.48.1