Re: [PATCH v2 1/1] dt-bindings: firmware: imx95-scmi: Allow linux,code for protocol@81

[Peng Fan <peng.fan@oss.nxp.com>]

+ SCMI maintainer, Sudeep and Cristian

On Wed, Apr 09, 2025 at 12:59:50PM +0200, Alexander Stein wrote:
>Hi,
>
>Am Montag, 4. November 2024, 09:56:21 CEST schrieb Alexander Stein:
>> BBM protocol supports a single power button, supported by driver
>> imx-sm-bbm-key.c. By default this is KEY_POWER, but can also be overwritten
>> using linux,code. Add a reference to this schema and add linux,code as a
>> supported property.
>> 
>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>
>Is there any other feedback or things to do here?

I see Rob already gave R-b.

Not sure this should go through Shawn's or Sudeep's tree.

Regards,
Peng

>
>Thanks
>Alexander
>
>> ---
>> Changes in v2:
>> * Added default value
>> 
>>  .../devicetree/bindings/firmware/nxp,imx95-scmi.yaml   | 10 ++++++++--
>>  1 file changed, 8 insertions(+), 2 deletions(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml
>> index 1a95010a546b1..c1b7140ee0098 100644
>> --- a/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml
>> +++ b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml
>> @@ -12,13 +12,19 @@ maintainers:
>>  
>>  properties:
>>    protocol@81:
>> -    $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node'
>> -    unevaluatedProperties: false
>> +    type: object
>> +    allOf:
>> +      - $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node'
>> +      - $ref: /schemas/input/input.yaml#
>> +    additionalProperties: false
>>  
>>      properties:
>>        reg:
>>          const: 0x81
>>  
>> +      linux,code:
>> +        default: 116  # KEY_POWER
>> +
>>    protocol@84:
>>      $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node'
>>      unevaluatedProperties: false
>> 
>
>
>-- 
>TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
>Amtsgericht München, HRB 105018
>Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
>http://www.tq-group.com/
>
>
>