From: Ivan Vecera <ivecera@redhat.com>
To: netdev@vger.kernel.org
Cc: Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
Jiri Pirko <jiri@resnulli.us>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Prathosh Satish <Prathosh.Satish@microchip.com>,
Lee Jones <lee@kernel.org>, Kees Cook <kees@kernel.org>,
Andy Shevchenko <andy@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Schmidt <mschmidt@redhat.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: [PATCH v2 04/14] mfd: zl3073x: Register itself as devlink device
Date: Wed, 9 Apr 2025 16:42:40 +0200 [thread overview]
Message-ID: <20250409144250.206590-5-ivecera@redhat.com> (raw)
In-Reply-To: <20250409144250.206590-1-ivecera@redhat.com>
Use devlink_alloc() to alloc zl3073x_dev structure and register
the device as a devlink device. Follow-up patches add support for
devlink device info reporting and devlink flash interface will
be later used for flashing firmware and configuration.
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
v1->v2:
- dependency on NET moved to MFD_ZL3073X_CORE in Kconfig
- devlink register managed way
---
drivers/mfd/Kconfig | 2 ++
drivers/mfd/zl3073x-core.c | 35 +++++++++++++++++++++++++++++++++--
2 files changed, 35 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 30b36e3ee8f7f..3c54b9e2b8003 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -2424,6 +2424,8 @@ config MFD_UPBOARD_FPGA
config MFD_ZL3073X_CORE
tristate
+ depends on NET
+ select NET_DEVLINK
select MFD_CORE
config MFD_ZL3073X_I2C
diff --git a/drivers/mfd/zl3073x-core.c b/drivers/mfd/zl3073x-core.c
index ccb6987d04a20..116c6dd9eebc7 100644
--- a/drivers/mfd/zl3073x-core.c
+++ b/drivers/mfd/zl3073x-core.c
@@ -8,6 +8,7 @@
#include <linux/mfd/zl3073x.h>
#include <linux/module.h>
#include <linux/regmap.h>
+#include <net/devlink.h>
#include "zl3073x.h"
/*
@@ -58,6 +59,14 @@ const struct regmap_config *zl3073x_get_regmap_config(void)
}
EXPORT_SYMBOL_NS_GPL(zl3073x_get_regmap_config, "ZL3073X");
+static const struct devlink_ops zl3073x_devlink_ops = {
+};
+
+static void zl3073x_devlink_free(void *ptr)
+{
+ devlink_free(ptr);
+}
+
/**
* zl3073x_devm_alloc - allocates zl3073x device structure
* @dev: pointer to device structure
@@ -68,12 +77,25 @@ EXPORT_SYMBOL_NS_GPL(zl3073x_get_regmap_config, "ZL3073X");
*/
struct zl3073x_dev *zl3073x_devm_alloc(struct device *dev)
{
- struct zl3073x_dev *zldev;
+ struct devlink *devlink;
+
+ devlink = devlink_alloc(&zl3073x_devlink_ops,
+ sizeof(struct zl3073x_dev), dev);
+ if (!devlink)
+ return NULL;
+
+ if (devm_add_action_or_reset(dev, zl3073x_devlink_free, devlink))
+ return NULL;
- return devm_kzalloc(dev, sizeof(*zldev), GFP_KERNEL);
+ return devlink_priv(devlink);
}
EXPORT_SYMBOL_NS_GPL(zl3073x_devm_alloc, "ZL3073X");
+static void zl3073x_devlink_unregister(void *ptr)
+{
+ devlink_unregister(ptr);
+}
+
/**
* zl3073x_dev_init - initialize zl3073x device
* @zldev: pointer to zl3073x device
@@ -84,6 +106,7 @@ EXPORT_SYMBOL_NS_GPL(zl3073x_devm_alloc, "ZL3073X");
*/
int zl3073x_dev_init(struct zl3073x_dev *zldev)
{
+ struct devlink *devlink;
int rc;
rc = devm_mutex_init(zldev->dev, &zldev->lock);
@@ -92,6 +115,14 @@ int zl3073x_dev_init(struct zl3073x_dev *zldev)
return rc;
}
+ devlink = priv_to_devlink(zldev);
+ devlink_register(devlink);
+
+ rc = devm_add_action_or_reset(zldev->dev, zl3073x_devlink_unregister,
+ devlink);
+ if (rc)
+ return rc;
+
return 0;
}
EXPORT_SYMBOL_NS_GPL(zl3073x_dev_init, "ZL3073X");
--
2.48.1
next prev parent reply other threads:[~2025-04-09 14:43 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 14:42 [PATCH v2 00/14] Add Microchip ZL3073x support (part 1) Ivan Vecera
2025-04-09 14:42 ` [PATCH v2 01/14] dt-bindings: dpll: Add device tree bindings for DPLL device and pin Ivan Vecera
2025-04-09 14:42 ` [PATCH v2 02/14] dt-bindings: dpll: Add support for Microchip Azurite chip family Ivan Vecera
2025-04-10 7:06 ` Krzysztof Kozlowski
2025-04-10 7:45 ` Ivan Vecera
2025-04-10 13:18 ` Conor Dooley
2025-04-10 13:35 ` Ivan Vecera
2025-04-10 17:07 ` Prathosh.Satish
2025-04-10 17:36 ` Ivan Vecera
2025-04-10 18:36 ` Prathosh.Satish
2025-04-10 17:36 ` Andrew Lunn
2025-04-10 18:33 ` Ivan Vecera
2025-04-10 21:12 ` Andrew Lunn
2025-04-11 9:56 ` Ivan Vecera
2025-04-14 17:19 ` Conor Dooley
2025-04-09 14:42 ` [PATCH v2 03/14] mfd: Add Microchip ZL3073x support Ivan Vecera
2025-04-09 15:43 ` Andy Shevchenko
2025-04-10 7:19 ` Krzysztof Kozlowski
2025-04-10 7:52 ` Ivan Vecera
2025-04-10 17:50 ` Andrew Lunn
2025-04-10 18:36 ` Ivan Vecera
2025-04-09 14:42 ` Ivan Vecera [this message]
2025-04-19 12:40 ` [PATCH v2 04/14] mfd: zl3073x: Register itself as devlink device kernel test robot
2025-04-19 14:03 ` kernel test robot
2025-04-09 14:42 ` [PATCH v2 05/14] mfd: zl3073x: Add register access helpers Ivan Vecera
2025-04-09 14:42 ` [PATCH v2 06/14] mfd: zl3073x: Add macros for device registers access Ivan Vecera
2025-04-10 7:17 ` Krzysztof Kozlowski
2025-04-10 8:20 ` Ivan Vecera
2025-04-10 17:53 ` Andy Shevchenko
2025-04-13 10:18 ` Ivan Vecera
2025-04-09 14:42 ` [PATCH v2 07/14] mfd: zl3073x: Add components versions register defs Ivan Vecera
2025-04-10 7:13 ` Krzysztof Kozlowski
2025-04-10 8:26 ` Ivan Vecera
2025-04-10 17:41 ` Andrew Lunn
2025-04-10 18:44 ` Ivan Vecera
2025-04-10 21:54 ` Andrew Lunn
2025-04-15 10:01 ` Ivan Vecera
2025-04-15 11:16 ` Andy Shevchenko
2025-04-15 12:57 ` Andrew Lunn
2025-04-15 14:20 ` Ivan Vecera
2025-04-10 17:50 ` Andy Shevchenko
2025-04-11 11:19 ` Ivan Vecera
2025-04-11 12:31 ` Andrew Lunn
2025-04-11 13:19 ` Ivan Vecera
2025-04-11 13:17 ` Ivan Vecera
2025-04-13 19:50 ` Andrew Lunn
2025-04-09 14:42 ` [PATCH v2 08/14] mfd: zl3073x: Implement devlink device info Ivan Vecera
2025-04-09 14:42 ` [PATCH v2 09/14] mfd: zl3073x: Add macro to wait for register value bits to be cleared Ivan Vecera
2025-04-09 14:42 ` [PATCH v2 10/14] mfd: zl3073x: Add functions to work with register mailboxes Ivan Vecera
2025-04-09 14:42 ` [PATCH v2 11/14] mfd: zl3073x: Add clock_id field Ivan Vecera
2025-04-09 14:42 ` [PATCH v2 12/14] lib: Allow modules to use strnchrnul Ivan Vecera
2025-04-09 14:42 ` [PATCH v2 13/14] mfd: zl3073x: Load mfg file into HW if it is present Ivan Vecera
2025-04-09 14:42 ` [PATCH v2 14/14] mfd: zl3073x: Fetch invariants during probe Ivan Vecera
2025-04-10 0:17 ` [PATCH v2 00/14] Add Microchip ZL3073x support (part 1) Jakub Kicinski
2025-04-10 9:18 ` Ivan Vecera
2025-04-10 17:26 ` Andrew Lunn
2025-04-10 22:57 ` Jakub Kicinski
2025-04-11 7:45 ` Ivan Vecera
2025-04-10 7:29 ` Lee Jones
2025-04-11 7:26 ` Lee Jones
2025-04-11 8:01 ` Ivan Vecera
2025-04-11 14:27 ` Michal Schmidt
2025-04-11 14:38 ` Michal Schmidt
2025-04-11 15:58 ` Rob Herring
2025-04-15 10:28 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250409144250.206590-5-ivecera@redhat.com \
--to=ivecera@redhat.com \
--cc=Prathosh.Satish@microchip.com \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=arkadiusz.kubalewski@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jiri@resnulli.us \
--cc=kees@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).