From: Alex Elder <elder@riscstar.com>
To: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org
Cc: p.zabel@pengutronix.de, dlan@gentoo.org, heylenay@4d2.org,
guodong@riscstar.com, paul.walmsley@sifive.com,
palmer@dabbelt.com, aou@eecs.berkeley.edu,
spacemit@lists.linux.dev, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 2/7] clk: spacemit: rename spacemit_ccu_data fields
Date: Wed, 9 Apr 2025 16:17:35 -0500 [thread overview]
Message-ID: <20250409211741.1171584-3-elder@riscstar.com> (raw)
In-Reply-To: <20250409211741.1171584-1-elder@riscstar.com>
Add "clk_" to the names of the fields in the spacemit_ccu_data structure
type. This prepares it for the addition of two similar fields dedicated
to resets.
Move the definition of this type closer to the top of the source file,
after constants are defined but before objects are defined.
Signed-off-by: Alex Elder <elder@riscstar.com>
---
drivers/clk/spacemit/ccu-k1.c | 34 +++++++++++++++++-----------------
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/clk/spacemit/ccu-k1.c b/drivers/clk/spacemit/ccu-k1.c
index 5804c2f854071..8a8d228b46c3f 100644
--- a/drivers/clk/spacemit/ccu-k1.c
+++ b/drivers/clk/spacemit/ccu-k1.c
@@ -129,6 +129,11 @@
#define APMU_EMAC0_CLK_RES_CTRL 0x3e4
#define APMU_EMAC1_CLK_RES_CTRL 0x3ec
+struct spacemit_ccu_data {
+ struct clk_hw **clk_hws;
+ size_t clk_num;
+};
+
/* APBS clocks start, APBS region contains and only contains all PLL clocks */
/* Frequency of pll{1,2} must not be updated at runtime */
@@ -933,11 +938,6 @@ CCU_GATE_DEFINE(emmc_bus_clk, CCU_PARENT_HW(pmua_aclk),
APMU_PMUA_EM_CLK_RES_CTRL, BIT(3), 0);
/* APMU clocks end */
-struct spacemit_ccu_data {
- struct clk_hw **hws;
- size_t num;
-};
-
static struct clk_hw *k1_ccu_pll_hws[] = {
[CLK_PLL1] = &pll1.common.hw,
[CLK_PLL2] = &pll2.common.hw,
@@ -977,8 +977,8 @@ static struct clk_hw *k1_ccu_pll_hws[] = {
};
static const struct spacemit_ccu_data k1_ccu_pll_data = {
- .hws = k1_ccu_pll_hws,
- .num = ARRAY_SIZE(k1_ccu_pll_hws),
+ .clk_hws = k1_ccu_pll_hws,
+ .clk_num = ARRAY_SIZE(k1_ccu_pll_hws),
};
static struct clk_hw *k1_ccu_mpmu_hws[] = {
@@ -1018,8 +1018,8 @@ static struct clk_hw *k1_ccu_mpmu_hws[] = {
};
static const struct spacemit_ccu_data k1_ccu_mpmu_data = {
- .hws = k1_ccu_mpmu_hws,
- .num = ARRAY_SIZE(k1_ccu_mpmu_hws),
+ .clk_hws = k1_ccu_mpmu_hws,
+ .clk_num = ARRAY_SIZE(k1_ccu_mpmu_hws),
};
static struct clk_hw *k1_ccu_apbc_hws[] = {
@@ -1126,8 +1126,8 @@ static struct clk_hw *k1_ccu_apbc_hws[] = {
};
static const struct spacemit_ccu_data k1_ccu_apbc_data = {
- .hws = k1_ccu_apbc_hws,
- .num = ARRAY_SIZE(k1_ccu_apbc_hws),
+ .clk_hws = k1_ccu_apbc_hws,
+ .clk_num = ARRAY_SIZE(k1_ccu_apbc_hws),
};
static struct clk_hw *k1_ccu_apmu_hws[] = {
@@ -1196,8 +1196,8 @@ static struct clk_hw *k1_ccu_apmu_hws[] = {
};
static const struct spacemit_ccu_data k1_ccu_apmu_data = {
- .hws = k1_ccu_apmu_hws,
- .num = ARRAY_SIZE(k1_ccu_apmu_hws),
+ .clk_hws = k1_ccu_apmu_hws,
+ .clk_num = ARRAY_SIZE(k1_ccu_apmu_hws),
};
static int spacemit_ccu_register(struct device *dev,
@@ -1207,13 +1207,13 @@ static int spacemit_ccu_register(struct device *dev,
struct clk_hw_onecell_data *clk_data;
int i, ret;
- clk_data = devm_kzalloc(dev, struct_size(clk_data, hws, data->num),
+ clk_data = devm_kzalloc(dev, struct_size(clk_data, hws, data->clk_num),
GFP_KERNEL);
if (!clk_data)
return -ENOMEM;
- for (i = 0; i < data->num; i++) {
- struct clk_hw *hw = data->hws[i];
+ for (i = 0; i < data->clk_num; i++) {
+ struct clk_hw *hw = data->clk_hws[i];
struct ccu_common *common;
const char *name;
@@ -1238,7 +1238,7 @@ static int spacemit_ccu_register(struct device *dev,
clk_data->hws[i] = hw;
}
- clk_data->num = data->num;
+ clk_data->num = data->clk_num;
ret = devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get, clk_data);
if (ret)
--
2.45.2
next prev parent reply other threads:[~2025-04-09 21:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 21:17 [PATCH v3 0/7] clk: spacemit: add K1 reset support Alex Elder
2025-04-09 21:17 ` [PATCH v3 1/7] dt-bindings: soc: spacemit: define spacemit,k1-ccu resets Alex Elder
2025-04-10 6:25 ` Krzysztof Kozlowski
2025-04-09 21:17 ` Alex Elder [this message]
2025-04-09 21:17 ` [PATCH v3 3/7] clk: spacemit: add reset controller support Alex Elder
2025-04-09 21:17 ` [PATCH v3 4/7] clk: spacemit: define existing syscon resets Alex Elder
2025-04-09 21:17 ` [PATCH v3 5/7] clk: spacemit: make clocks optional Alex Elder
2025-04-09 21:17 ` [PATCH v3 6/7] clk: spacemit: define new syscons with only resets Alex Elder
2025-04-09 21:17 ` [PATCH v3 7/7] riscv: dts: spacemit: add reset support for the K1 SoC Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250409211741.1171584-3-elder@riscstar.com \
--to=elder@riscstar.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=guodong@riscstar.com \
--cc=heylenay@4d2.org \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox