devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Guodong Xu <guodong@riscstar.com>
Cc: ukleinek@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, paul.walmsley@sifive.com,
	palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr,
	dlan@gentoo.org, p.zabel@pengutronix.de, drew@pdp7.com,
	inochiama@gmail.com, geert+renesas@glider.be, heylenay@4d2.org,
	tglx@linutronix.de, hal.feng@starfivetech.com,
	unicorn_wang@outlook.com, duje.mihanovic@skole.hr,
	elder@riscstar.com, linux-pwm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev
Subject: Re: [PATCH 3/9] dt-bindings: pwm: marvell,pxa: add support to spacemit K1
Date: Fri, 11 Apr 2025 17:43:00 +0100	[thread overview]
Message-ID: <20250411-spoiler-dispatch-8f709700a996@spud> (raw)
In-Reply-To: <20250411131423.3802611-4-guodong@riscstar.com>

[-- Attachment #1: Type: text/plain, Size: 992 bytes --]

On Fri, Apr 11, 2025 at 09:14:17PM +0800, Guodong Xu wrote:
> Add "spacemit,k1-pwm" as a compatible string to support the PWM
> controller on the SpacemiT K1 platform.
> 
> Signed-off-by: Guodong Xu <guodong@riscstar.com>
> ---
>  Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml
> index 9640d4b627c2..1e3cabf6a89a 100644
> --- a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml
> @@ -19,6 +19,7 @@ properties:
>        - marvell,pxa270-pwm
>        - marvell,pxa168-pwm
>        - marvell,pxa910-pwm
> +      - spacemit,k1-pwm

The driver doesn't appear to handle this differently to existing
compatibles, why is a fallback not used?

>  
>    reg:
>      # Length should be 0x10
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2025-04-11 16:43 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-11 13:14 [PATCH 0/9] pwm: Update PWM_PXA driver for SpacemiT K1 Guodong Xu
2025-04-11 13:14 ` [PATCH 1/9] dt-bindings: pwm: marvell,pxa: add optional property resets Guodong Xu
2025-04-11 16:44   ` Conor Dooley
2025-04-15  8:52     ` Philipp Zabel
2025-04-15  9:54       ` Guodong Xu
2025-04-15 10:12         ` Yixun Lan
2025-04-15 12:11           ` Alex Elder
2025-04-15 12:28             ` Yixun Lan
2025-04-16  5:18               ` Uwe Kleine-König
2025-04-16 11:33                 ` Alex Elder
2025-04-16 14:56                   ` Uwe Kleine-König
2025-04-11 13:14 ` [PATCH 2/9] pwm: pxa: add optional reset control Guodong Xu
2025-04-11 13:14 ` [PATCH 3/9] dt-bindings: pwm: marvell,pxa: add support to spacemit K1 Guodong Xu
2025-04-11 16:43   ` Conor Dooley [this message]
2025-04-12  4:00     ` Guodong Xu
2025-04-11 13:14 ` [PATCH 4/9] pwm: pxa: add support for " Guodong Xu
2025-04-11 13:14 ` [PATCH 5/9] riscv: dts: spacemit: add PWM support for K1 SoC Guodong Xu
2025-04-11 13:14 ` [PATCH 6/9] riscv: dts: spacemit: Add pinctrl configurations for PWM0-PWM19 Guodong Xu
2025-04-11 22:50   ` Inochi Amaoto
2025-04-14 16:42     ` Samuel Holland
2025-04-11 13:14 ` [PATCH 7/9] riscv: dts: spacemit: Add PWM14 backlight support for BPI-F3 Guodong Xu
2025-04-11 14:05   ` Yixun Lan
2025-04-11 14:23     ` Alex Elder
2025-04-11 14:45       ` Yixun Lan
2025-04-11 23:28       ` Inochi Amaoto
2025-04-12  4:22         ` Guodong Xu
2025-04-11 22:54   ` Inochi Amaoto
2025-04-14  5:58   ` Uwe Kleine-König
2025-04-14  8:03     ` Yixun Lan
2025-04-11 13:14 ` [PATCH 8/9] pwm: Kconfig: add depends on ARCH_SPACEMIT to PWM_PXA Guodong Xu
2025-04-11 13:14 ` [PATCH 9/9] riscv: defconfig: Enable PWM support for SpacemiT K1 SoC Guodong Xu
2025-04-11 22:52   ` Inochi Amaoto
2025-04-12  4:02     ` Guodong Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250411-spoiler-dispatch-8f709700a996@spud \
    --to=conor@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@gentoo.org \
    --cc=drew@pdp7.com \
    --cc=duje.mihanovic@skole.hr \
    --cc=elder@riscstar.com \
    --cc=geert+renesas@glider.be \
    --cc=guodong@riscstar.com \
    --cc=hal.feng@starfivetech.com \
    --cc=heylenay@4d2.org \
    --cc=inochiama@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=p.zabel@pengutronix.de \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh@kernel.org \
    --cc=spacemit@lists.linux.dev \
    --cc=tglx@linutronix.de \
    --cc=ukleinek@kernel.org \
    --cc=unicorn_wang@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).