From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D5E81D86FB; Fri, 11 Apr 2025 13:46:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744379206; cv=none; b=NqjOCWLqfMouToQbDmhDbU/GsQOYt+Beztm3OBjFgKReWlVy23SWJr+GqUHo89xEzPe46sxbtgymSHTiQ+ij5bAZ1Te4ZAlyEVhxVMTDxE7ngTPGCyGl5LtV1dz0m6SKS0ieDr6ekO8qumQ2peXvZ0e7mBzPUMa8c3gpO1zKyHE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744379206; c=relaxed/simple; bh=lfpofwq7AhcRnEO56wgTDW+zKFWju8+OfJKpaNYI9T0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u1xqnNHjp1wliYNJA0vn63NlxBliR0D4pXqPoTiHpbtuwlNFaq6hcxpc4ieGQThkvvwpuZ9M75Nb3YYP1WexZx807vAT/TKDkdGberN1rs2FTQr14z+JczgpleITcKp0X/3N82UaIoqv6xkjK0fnXOYiA2CY6EjL6TMM93sF28s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YGSplrp1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YGSplrp1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7652C4CEE2; Fri, 11 Apr 2025 13:46:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744379206; bh=lfpofwq7AhcRnEO56wgTDW+zKFWju8+OfJKpaNYI9T0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YGSplrp1HwBSG2RE7WPdi2jjo9tolZLXEJo86WNr+DMYcwi1SyAIrJDuTS/gq47jZ XAlVqJ1iCaF0+veS3PPAWdoLzBrusy2ioGIuVy3wc12EfuawG0NBDhnhQmEgIT0nFm NKVuho1JDHwdzex0lormI5ZE9w0Y4Kj1db2hijdEqFDKomv7/Rq6l5u5VVYNwif/uB fztfpBWH6c/2SaCvIoQeQqRYYrPBYua8U8A4zsk5kL6bQ38N8qNl2XOJdD0mJz+Enj 8e+pLoF2VRY+O7gv2n0On3XlC6KeM2WhPl3wclFi923af+yTBKyybraqVIVLDVjgiJ CvBv3tPswefvg== Date: Fri, 11 Apr 2025 08:46:44 -0500 From: Rob Herring To: Yuanfang Zhang Cc: Suzuki K Poulose , Mike Leach , James Clark , Krzysztof Kozlowski , Conor Dooley , Alexander Shishkin , kernel@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] dt-bindings: arm: Add device Trace Network On Chip definition Message-ID: <20250411134644.GA3059343-robh@kernel.org> References: <20250411-trace-noc-v3-0-1f19ddf7699b@quicinc.com> <20250411-trace-noc-v3-1-1f19ddf7699b@quicinc.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250411-trace-noc-v3-1-1f19ddf7699b@quicinc.com> On Fri, Apr 11, 2025 at 04:57:52PM +0800, Yuanfang Zhang wrote: > Add a new coresight-tnoc.yaml file to describe the bindings required to > define Trace Network On Chip (TNOC) in device trees. TNOC is an > integration hierarchy which is a hardware component that integrates the > functionalities of TPDA and funnels. It collects trace form subsystems > and transfers to coresight sink. > > Signed-off-by: Yuanfang Zhang > --- > .../bindings/arm/qcom,coresight-tnoc.yaml | 111 +++++++++++++++++++++ > 1 file changed, 111 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-tnoc.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-tnoc.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..709c1bc63db48c29bb2b33e7a795a5999768c5e7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tnoc.yaml > @@ -0,0 +1,111 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/qcom,coresight-tnoc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Trace Network On Chip - TNOC > + > +maintainers: > + - Yuanfang Zhang > + > +description: '>' is needed for paragraphs. > + The Trace Network On Chip (TNOC) is an integration hierarchy hardware > + component that integrates the functionalities of TPDA and funnels. > + > + It sits in the different subsystem of SOC and aggregates the trace and > + transports it to Aggregation TNOC or to coresight trace sink eventually. > + TNOC embeds bridges for all the interfaces APB, ATB, TPDA and NTS (Narrow > + Time Stamp). > + > + TNOC can take inputs from different trace sources i.e. ATB, TPDM. > + > +# Need a custom select here or 'arm,primecell' will match on lots of nodes > +select: > + properties: > + compatible: > + contains: > + enum: > + - qcom,coresight-tnoc > + required: > + - compatible > + > +properties: > + $nodename: > + pattern: "^tn(@[0-9a-f]+)$" > + > + compatible: > + items: > + - const: qcom,coresight-tnoc > + - const: arm,primecell > + > + reg: > + maxItems: 1 > + > + clock-names: > + items: > + - const: apb_pclk > + > + clocks: > + items: > + - description: APB register access clock > + > + in-ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + patternProperties: > + '^port(@[0-9a-f]{1,2})?$': > + description: Input connections from CoreSight Trace Bus > + $ref: /schemas/graph.yaml#/properties/port > + > + out-ports: > + $ref: /schemas/graph.yaml#/properties/ports > + additionalProperties: false > + > + properties: > + port: > + description: > + Output connection to CoreSight Trace Bus > + $ref: /schemas/graph.yaml#/properties/port > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - in-ports > + - out-ports > + > +additionalProperties: false > + > +examples: > + - | > + tn@109ab000 { > + compatible = "qcom,coresight-tnoc", "arm,primecell"; > + reg = <0x0 0x109ab000 0x0 0x4200>; > + > + clocks = <&aoss_qmp>; > + clock-names = "apb_pclk"; > + > + in-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + tn_ag_in_tpdm_gcc: endpoint { > + remote-endpoint = <&tpdm_gcc_out_tn_ag>; > + }; > + }; > + }; > + > + out-ports { > + port { > + tn_ag_out_funnel_in1: endpoint { > + remote-endpoint = <&funnel_in1_in_tn_ag>; > + }; > + }; > + }; > + }; > +... > > -- > 2.34.1 >