Re: [PATCH v2 1/9] dt-bindings: renesas,sh-msiof: Add MSIOF I2S Sound support

Kuninori Morimoto
2025-04-14T00:45:04Z

Hi Rob

> > Renesas MSIOF (Clock-Synchronized Serial Interface with FIFO) can work as
> > both SPI and I2S. MSIOF-I2S will use Audio Graph Card/Card2 driver which
> > uses Of-Graph in DT.
> >
> > MSIOF-SPI/I2S are using same DT compatible properties.
> > MSIOF-I2S uses Of-Graph for Audio-Graph-Card/Card2,
> > MSIOF-SPI doesn't use Of-Graph.
> >
> > Adds schema for MSIOF-I2S (= Sound).
> > Because MSIOF is no longer SPI specific device, remove spi specific schema
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
(snip)
> if:
> properties:
> $nodename:
> pattern: '^spi@'
> then:
> $ref: spi-controller.yaml#
>
> Or just always use 'spi' node name even if used for i2s.
(snip)
> > + "#address-cells":
> > + enum: [0, 1]
> > +
> > + "#size-cells":
> > + const: 0
> > +
>
> Then drop these.
(snip)
> > + # for MSIOF-I2S
> > + port:
> > + $ref: ../sound/audio-graph-port.yaml#/definitions/port-base
> > + unevaluatedProperties: false
> > + patternProperties:
> > + "^endpoint(@[0-9a-f]+)?":
> > + $ref: audio-graph-port.yaml#/definitions/endpoint-base
>
> The correct way is:
>
> port:
> $ref: audio-graph-port.yaml#
> unevaluatedProperties: false

Thanks. will fix in v3

Best regards
---
Kuninori Morimoto