Re: [PATCH v2 4/9] ASoC: renesas: rsnd: allow to use ADG only

Kuninori Morimoto
2025-04-15T01:20:36Z

Hi Mukesh

Thank you for reviewing

> > Audio clock generator (= ADG) can be used standalone, but current driver
> > will be error in such use case. Makes it as not error.
> will be error ?
> Makes it as not error ?
>
> I could not get exact problem here. seems you need to write properly.
> > And, current driver registers it as fixed rate clock, but actual clkout
> > was handled when SSI start works. Setup clkout setting when it was probed.
> > Otherwise it can't be used ADG only.
> >
> Same here, its not clearly explaining.
> > Because of this fixup, current rsnd_adg_get_clkout() function name will be
> > strange. Rename get -> init.
> >
> same here too. Please write in some verbose which says something.

Hmm.. indeed. I couldn't understand what I wanted to tell...
And I noticed that the code/patch itself is not wrong but strange.
I will update around here in v3

Thank you for your help !!

Best regards
---
Kuninori Morimoto