Re: [PATCH v5 01/14] dt-bindings: trigger-source: add generic GPIO trigger source

Linus Walleij
2025-04-16T07:44:11Z

Hi Jonathan,

thanks for your patch!

On Fri, Apr 11, 2025 at 5:56 PM Jonathan Santos
<Jonathan.Santos@analog.com> wrote:

> Inspired by pwn-trigger, create a new binding for using a GPIO
> pin as a trigger source.
>
> Signed-off-by: Jonathan Santos <Jonathan.Santos@analog.com>

Is this actually documenting the trigger sources I implemented for LED
here?
https://lore.kernel.org/all/20230926-gpio-led-trigger-dt-v2-0-e06e458b788e@linaro.org/

Then maybe put this in as Link:

I tried to figure out how to properly document it but I think it was part of
dtsschema and that may have confused me.

> +title: Generic trigger source using GPIO
> +
> +description: Remaps a GPIO pin as a trigger source.

Please write "GPIO line" instead of "GPIO pin".

The reason is that not all GPIOs are pins. Some are other stuff.

Yours,
Linus Walleij