From: Jonathan Cameron <jic23@kernel.org>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Laxman Dewangan <ldewangan@nvidia.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH v4 2/2] thermal: thermal-generic-adc: add temperature sensor channel
Date: Mon, 14 Apr 2025 19:35:38 +0100 [thread overview]
Message-ID: <20250414193538.5eb8e4a4@jic23-huawei> (raw)
In-Reply-To: <CAPVz0n16TbodhuTcqUufCk6=178ZTcc=2SLUjYHe5YsSJvettQ@mail.gmail.com>
> > > > > > +
> > > > > > + indio_dev->name = dev_name(dev);
> > > >
> > > > What does this end up as? The convention in IIO is to name after
> > > > a part number. If you have duplicates this isn't how you tell them
> > > > apart. So I'd kind of expect thermal-generic-temp or
> > > > something like that.
> > > >
> > >
> > > it is "generic-adc-thermal" with this name, it is not present anywhere in IIO.
> > >
>
> Then this is acceptable?
That string is fine. I'd still be tempted to hard code it here so the
value is obvious to anyone looking at the driver.
Thanks,
Jonathan
prev parent reply other threads:[~2025-04-14 18:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 7:56 [PATCH v4 0/2] thermal: thermal-generic-adc: add temp sensor function Svyatoslav Ryhel
2025-03-10 7:56 ` [PATCH v4 1/2] dt-bindings: thermal: generic-adc: Add optional io-channel-cells property Svyatoslav Ryhel
2025-03-11 8:20 ` Krzysztof Kozlowski
2025-03-11 8:30 ` Svyatoslav Ryhel
2025-03-10 7:56 ` [PATCH v4 2/2] thermal: thermal-generic-adc: add temperature sensor channel Svyatoslav Ryhel
2025-04-05 15:23 ` Svyatoslav Ryhel
2025-04-12 10:53 ` Jonathan Cameron
2025-04-12 11:06 ` Svyatoslav Ryhel
2025-04-13 9:28 ` Jonathan Cameron
2025-04-13 9:42 ` Svyatoslav Ryhel
2025-04-14 18:35 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250414193538.5eb8e4a4@jic23-huawei \
--to=jic23@kernel.org \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).