Re: [PATCH v2 3/5] dt-bindings: watchdog: separate out the IPQ5424 compatilble

[Rob Herring <robh@kernel.org>]

On Wed, Apr 16, 2025 at 01:59:20PM +0530, Kathiravan Thirumoorthy wrote:
> To retrieve the system restart reason code from IMEM, need to define the
> certain device specific data. To achieve that, decouple the IPQ5424
> compatible from the existing list and define along with 'qcom,kpss-wdt'.

You have missed the whole point of why there's both a specific 
compatible and a fallback. The specific one existed for a case like this 
where you need to start distinguishing the specific device. In short, 
this binding and dts changes are not needed at all, only the driver 
change is needed. Then you maintain forwards and backwards 
compatibility. 

> 
> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
> ---
> Changes in v2:
> 	- New patch
> ---
>  Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> index 49e2b807db0bc9d3edfc93ec41ad0df0b74ed032..e800f53381ef5626787eff1029bc94177e2635a4 100644
> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> @@ -20,7 +20,6 @@ properties:
>                - qcom,kpss-wdt-ipq4019
>                - qcom,apss-wdt-ipq5018
>                - qcom,apss-wdt-ipq5332
> -              - qcom,apss-wdt-ipq5424
>                - qcom,apss-wdt-ipq9574
>                - qcom,apss-wdt-msm8226
>                - qcom,apss-wdt-msm8974
> @@ -56,6 +55,8 @@ properties:
>                - qcom,kpss-wdt-msm8960
>            - const: qcom,kpss-timer
>            - const: qcom,msm-timer
> +      - items:
> +          - const: qcom,apss-wdt-ipq5424
>  
>    reg:
>      maxItems: 1
> @@ -93,7 +94,9 @@ allOf:
>        properties:
>          compatible:
>            contains:
> -            const: qcom,kpss-wdt
> +            enum:
> +              - qcom,apss-wdt-ipq5424
> +              - qcom,kpss-wdt
>      then:
>        properties:
>          clock-frequency: false
> 
> -- 
> 2.34.1
>